wangbo commented on a change in pull request #3729: URL: https://github.com/apache/incubator-doris/pull/3729#discussion_r435769378
########## File path: fe/src/main/java/org/apache/doris/load/loadv2/dpp/ColumnParser.java ########## @@ -0,0 +1,175 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license agreements. See the NOTICE file +// distributed with this work for additional information +// regarding copyright ownership. The ASF licenses this file +// to you under the Apache License, Version 2.0 (the +// "License"); you may not use this file except in compliance +// with the License. You may obtain a copy of the License at +// +// http://www.apache.org/licenses/LICENSE-2.0 +// +// Unless required by applicable law or agreed to in writing, +// software distributed under the License is distributed on an +// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +// KIND, either express or implied. See the License for the +// specific language governing permissions and limitations +// under the License. + +package org.apache.doris.load.loadv2.dpp; + +import org.apache.doris.common.UserException; +import org.joda.time.DateTime; + +import java.io.Serializable; +import java.util.Date; + +// Parser to validate value for different type +public abstract class ColumnParser implements Serializable { + public static ColumnParser create(String columnType) throws UserException { + if (columnType.equalsIgnoreCase("TINYINT")) { + return new TinyIntParser(); + } else if (columnType.equalsIgnoreCase("SMALLINT")) { + return new SmallIntParser(); + } else if (columnType.equalsIgnoreCase("INT")) { + return new IntParser(); + } else if (columnType.equalsIgnoreCase("BIGINT")) { + return new BigIntParser(); + } else if (columnType.equalsIgnoreCase("FLOAT")) { + return new FloatParser(); + } else if (columnType.equalsIgnoreCase("DOUBLE")) { + return new DoubleParser(); + } else if (columnType.equalsIgnoreCase("BOOLEAN")) { + return new BooleanParser(); + } else if (columnType.equalsIgnoreCase("DATE")) { + return new DateParser(); + } else if (columnType.equalsIgnoreCase("DATETIME")) { + return new DatetimeParser(); + } else if (columnType.equalsIgnoreCase("VARCHAR") + || columnType.equalsIgnoreCase("CHAR") + || columnType.equalsIgnoreCase("BITMAP") + || columnType.equalsIgnoreCase("HLL")) { + return new StringParser(); + } else { + throw new UserException("unsupported type:" + columnType); Review comment: maybe later support after first merged? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
