[GitHub] [incubator-doris] kangkaisen commented on a change in pull request #3775: Support read and write lock in table level to reduce lock competition

[GitBox]

kangkaisen commented on a change in pull request #3775:
URL: https://github.com/apache/incubator-doris/pull/3775#discussion_r435863730



##########
File path: fe/src/main/java/org/apache/doris/alter/Alter.java
##########
@@ -169,18 +169,19 @@ public void processAlterTable(AlterTableStmt stmt) throws 
UserException {
         // some operations will take long time to process, need to be done 
outside the databse lock
         boolean needProcessOutsideDatabaseLock = false;
         String tableName = dbTableName.getTbl();
-        db.writeLock();
-        try {
-            Table table = db.getTable(tableName);
-            if (table == null) {
-                ErrorReport.reportDdlException(ErrorCode.ERR_BAD_TABLE_ERROR, 
tableName);
-            }
 
-            if (table.getType() != TableType.OLAP) {
-                throw new DdlException("Do not support alter non-OLAP table[" 
+ tableName + "]");
-            }
-            OlapTable olapTable = (OlapTable) table;
+        Table table = db.getTable(tableName);

Review comment:
       Could use `getTableOrThrowException`




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org