[GitHub] [incubator-doris] morningman commented on a change in pull request #2064: Fix bug that tablet failed to be committed when no data is loaded

2019-10-24 Thread GitBox
morningman commented on a change in pull request #2064: Fix bug that tablet failed to be committed when no data is loaded URL: https://github.com/apache/incubator-doris/pull/2064#discussion_r338908150 ## File path: fe/src/main/java/org/apache/doris/catalog/Catalog.java ##

[GitHub] [incubator-doris] morningman commented on a change in pull request #2064: Fix bug that tablet failed to be committed when no data is loaded

2019-10-24 Thread GitBox
morningman commented on a change in pull request #2064: Fix bug that tablet failed to be committed when no data is loaded URL: https://github.com/apache/incubator-doris/pull/2064#discussion_r338908020 ## File path: fe/src/main/java/org/apache/doris/catalog/Catalog.java ##

[GitHub] [incubator-doris] imay commented on a change in pull request #2064: Fix bug that tablet failed to be committed when no data is loaded

2019-10-24 Thread GitBox
imay commented on a change in pull request #2064: Fix bug that tablet failed to be committed when no data is loaded URL: https://github.com/apache/incubator-doris/pull/2064#discussion_r338907685 ## File path: fe/src/main/java/org/apache/doris/catalog/Catalog.java ## @@ -29

[GitHub] [incubator-doris] kangkaisen opened a new pull request #2066: Update doc for FE metadata recover

2019-10-24 Thread GitBox
kangkaisen opened a new pull request #2066: Update doc for FE metadata recover URL: https://github.com/apache/incubator-doris/pull/2066 This is an automated message from the Apache Git Service. To respond to the message, plea

[incubator-doris] branch doc-meta created (now 412a205)

2019-10-24 Thread kangkaisen
This is an automated email from the ASF dual-hosted git repository. kangkaisen pushed a change to branch doc-meta in repository https://gitbox.apache.org/repos/asf/incubator-doris.git. at 412a205 Update doc for FE metadata recover This branch includes the following new commits: new

[incubator-doris] 01/01: Update doc for FE metadata recover

2019-10-24 Thread kangkaisen
This is an automated email from the ASF dual-hosted git repository. kangkaisen pushed a commit to branch doc-meta in repository https://gitbox.apache.org/repos/asf/incubator-doris.git commit 412a20528b685b13c5435bf7b3e82c9990392929 Author: kangkaisen AuthorDate: Fri Oct 25 12:09:38 2019 +0800

[GitHub] [incubator-doris] morningman opened a new issue #2065: Routine Load may takes too many FE memory

2019-10-24 Thread GitBox
morningman opened a new issue #2065: Routine Load may takes too many FE memory URL: https://github.com/apache/incubator-doris/issues/2065 **Describe the bug** When there are many routine load jobs and the config `max_running_txn_per_db` is low, some of routine load tasks may be accumu

[GitHub] [incubator-doris] morningman closed issue #2057: Create and drop repository using same repo name in lowercase and uppercase occurs error

2019-10-24 Thread GitBox
morningman closed issue #2057: Create and drop repository using same repo name in lowercase and uppercase occurs error URL: https://github.com/apache/incubator-doris/issues/2057 This is an automated message from the Apache

[GitHub] [incubator-doris] morningman opened a new issue #2063: Tablet failed to be committed when there is no data loaded for it.

2019-10-24 Thread GitBox
morningman opened a new issue #2063: Tablet failed to be committed when there is no data loaded for it. URL: https://github.com/apache/incubator-doris/issues/2063 **Describe the bug** When loading load to a table, if some of tablets does not receive any data in this job, they will fa

[GitHub] [incubator-doris] morningman opened a new pull request #2064: Fix bug that tablet failed to be committed when no data is loaded

2019-10-24 Thread GitBox
morningman opened a new pull request #2064: Fix bug that tablet failed to be committed when no data is loaded URL: https://github.com/apache/incubator-doris/pull/2064 ISSUE: #2063 This is an automated message from the Apache

[GitHub] [incubator-doris] kangkaisen commented on a change in pull request #2052: Optimize fe start logic

2019-10-24 Thread GitBox
kangkaisen commented on a change in pull request #2052: Optimize fe start logic URL: https://github.com/apache/incubator-doris/pull/2052#discussion_r338863696 ## File path: fe/src/main/java/org/apache/doris/catalog/Catalog.java ## @@ -2125,103 +2136,138 @@ private void setC

[GitHub] [incubator-doris] kangkaisen commented on issue #2052: Optimize fe start logic

2019-10-24 Thread GitBox
kangkaisen commented on issue #2052: Optimize fe start logic URL: https://github.com/apache/incubator-doris/pull/2052#issuecomment-546174085 > > @morningman Hi. This PR effect is big, please add more test if possible. > > It's OK, this CL does not change any meta date read/write forma

[GitHub] [incubator-doris] imay closed issue #2000: Replace NewStatus with Status

2019-10-24 Thread GitBox
imay closed issue #2000: Replace NewStatus with Status URL: https://github.com/apache/incubator-doris/issues/2000 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub a

[GitHub] [incubator-doris] imay removed a comment on issue #2000: Replace NewStatus with Status

2019-10-24 Thread GitBox
imay removed a comment on issue #2000: Replace NewStatus with Status URL: https://github.com/apache/incubator-doris/issues/2000#issuecomment-545956697 @Seaven This is an automated message from the Apache Git Service. To res

[GitHub] [incubator-doris] imay commented on issue #2000: Replace NewStatus with Status

2019-10-24 Thread GitBox
imay commented on issue #2000: Replace NewStatus with Status URL: https://github.com/apache/incubator-doris/issues/2000#issuecomment-545956697 @Seaven This is an automated message from the Apache Git Service. To respond to

[incubator-doris] branch master updated (78bf825 -> 189e08f)

2019-10-24 Thread zhaoc
This is an automated email from the ASF dual-hosted git repository. zhaoc pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/incubator-doris.git. from 78bf825 Optimize the convert of row block v2 to v1 #2011 (#2058) add 189e08f Replace NewStatus with St

[GitHub] [incubator-doris] imay merged pull request #2046: Changed replace NewStatus with Status

2019-10-24 Thread GitBox
imay merged pull request #2046: Changed replace NewStatus with Status URL: https://github.com/apache/incubator-doris/pull/2046 This is an automated message from the Apache Git Service. To respond to the message, please log on

[incubator-doris] branch master updated: Optimize the convert of row block v2 to v1 #2011 (#2058)

2019-10-24 Thread zhaoc
This is an automated email from the ASF dual-hosted git repository. zhaoc pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-doris.git The following commit(s) were added to refs/heads/master by this push: new 78bf825 Optimize the convert of row blo

[GitHub] [incubator-doris] imay merged pull request #2058: optimize the convert of row block v2 to v1 #2011

2019-10-24 Thread GitBox
imay merged pull request #2058: optimize the convert of row block v2 to v1 #2011 URL: https://github.com/apache/incubator-doris/pull/2058 This is an automated message from the Apache Git Service. To respond to the message, pl

[GitHub] [incubator-doris] gaodayue commented on a change in pull request #2055: add delete state of row block v2 for performance

2019-10-24 Thread GitBox
gaodayue commented on a change in pull request #2055: add delete state of row block v2 for performance URL: https://github.com/apache/incubator-doris/pull/2055#discussion_r338557950 ## File path: be/src/olap/rowset/segment_v2/segment_iterator.cpp ## @@ -169,12 +170,11 @@ S

[GitHub] [incubator-doris] gaodayue commented on a change in pull request #2055: add delete state of row block v2 for performance

2019-10-24 Thread GitBox
gaodayue commented on a change in pull request #2055: add delete state of row block v2 for performance URL: https://github.com/apache/incubator-doris/pull/2055#discussion_r338552951 ## File path: be/src/olap/rowset/segment_v2/column_reader.h ## @@ -170,6 +165,10 @@ class C

[GitHub] [incubator-doris] gaodayue commented on a change in pull request #2055: add delete state of row block v2 for performance

2019-10-24 Thread GitBox
gaodayue commented on a change in pull request #2055: add delete state of row block v2 for performance URL: https://github.com/apache/incubator-doris/pull/2055#discussion_r338564195 ## File path: be/src/olap/rowset/segment_v2/column_reader.h ## @@ -232,6 +244,9 @@ class Fi

[GitHub] [incubator-doris] gaodayue commented on a change in pull request #2055: add delete state of row block v2 for performance

2019-10-24 Thread GitBox
gaodayue commented on a change in pull request #2055: add delete state of row block v2 for performance URL: https://github.com/apache/incubator-doris/pull/2055#discussion_r338574147 ## File path: be/src/olap/generic_iterators.cpp ## @@ -139,6 +140,8 @@ class MergeIteratorC

[GitHub] [incubator-doris] gaodayue commented on a change in pull request #2055: add delete state of row block v2 for performance

2019-10-24 Thread GitBox
gaodayue commented on a change in pull request #2055: add delete state of row block v2 for performance URL: https://github.com/apache/incubator-doris/pull/2055#discussion_r338573230 ## File path: be/src/olap/rowset/segment_v2/segment_iterator.cpp ## @@ -52,13 +52,14 @@ Seg

[GitHub] [incubator-doris] gaodayue commented on a change in pull request #2055: add delete state of row block v2 for performance

2019-10-24 Thread GitBox
gaodayue commented on a change in pull request #2055: add delete state of row block v2 for performance URL: https://github.com/apache/incubator-doris/pull/2055#discussion_r338562908 ## File path: be/src/olap/rowset/segment_v2/column_reader.h ## @@ -91,41 +92,35 @@ class Co

[GitHub] [incubator-doris] morningman commented on a change in pull request #2052: Optimize fe start logic

2019-10-24 Thread GitBox
morningman commented on a change in pull request #2052: Optimize fe start logic URL: https://github.com/apache/incubator-doris/pull/2052#discussion_r338538988 ## File path: fe/src/main/java/org/apache/doris/catalog/Catalog.java ## @@ -2125,103 +2136,138 @@ private void setC

[GitHub] [incubator-doris] morningman commented on issue #2052: Optimize fe start logic

2019-10-24 Thread GitBox
morningman commented on issue #2052: Optimize fe start logic URL: https://github.com/apache/incubator-doris/pull/2052#issuecomment-545889232 > @morningman Hi. This PR effect is big, please add more test if possible. It's OK, this CL does not change any meta date read/write format and

[GitHub] [incubator-doris] morningman merged pull request #2060: Remove drop repository name toLowerCase

2019-10-24 Thread GitBox
morningman merged pull request #2060: Remove drop repository name toLowerCase URL: https://github.com/apache/incubator-doris/pull/2060 This is an automated message from the Apache Git Service. To respond to the message, pleas

[incubator-doris] branch master updated (0bcfdda -> 78a5a84)

2019-10-24 Thread morningman
This is an automated email from the ASF dual-hosted git repository. morningman pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/incubator-doris.git. from 0bcfdda Remove clear_alter_task (#2056) add 78a5a84 Remove drop repository name toLowerCase (#206

[GitHub] [incubator-doris] kangkaisen commented on issue #2052: Optimize fe start logic

2019-10-24 Thread GitBox
kangkaisen commented on issue #2052: Optimize fe start logic URL: https://github.com/apache/incubator-doris/pull/2052#issuecomment-545870517 @morningman Hi. This PR effect is big, please add more test if possible. This is an a

[GitHub] [incubator-doris] kangkaisen commented on a change in pull request #2052: Optimize fe start logic

2019-10-24 Thread GitBox
kangkaisen commented on a change in pull request #2052: Optimize fe start logic URL: https://github.com/apache/incubator-doris/pull/2052#discussion_r338507156 ## File path: fe/src/main/java/org/apache/doris/catalog/Catalog.java ## @@ -2125,103 +2136,138 @@ private void setC

[GitHub] [incubator-doris] kangkaisen commented on a change in pull request #2052: Optimize fe start logic

2019-10-24 Thread GitBox
kangkaisen commented on a change in pull request #2052: Optimize fe start logic URL: https://github.com/apache/incubator-doris/pull/2052#discussion_r338508079 ## File path: fe/src/main/java/org/apache/doris/catalog/Catalog.java ## @@ -2125,103 +2136,138 @@ private void setC

[incubator-doris] branch master updated (4848c94 -> 0bcfdda)

2019-10-24 Thread morningman
This is an automated email from the ASF dual-hosted git repository. morningman pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/incubator-doris.git. from 4848c94 Fix bug that unable to add bloom filter columns (#2054) add 0bcfdda Remove clear_alter_ta

[GitHub] [incubator-doris] morningman merged pull request #2056: Remove clear_alter_task

2019-10-24 Thread GitBox
morningman merged pull request #2056: Remove clear_alter_task URL: https://github.com/apache/incubator-doris/pull/2056 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitH

[GitHub] [incubator-doris] kangkaisen opened a new issue #2062: Segement V2: SegmentIterator support bitmap index

2019-10-24 Thread GitBox
kangkaisen opened a new issue #2062: Segement V2: SegmentIterator support bitmap index URL: https://github.com/apache/incubator-doris/issues/2062 For https://github.com/apache/incubator-doris/issues/1684 This work based on #2050 and https://github.com/apache/incubator-doris/issues/2

[GitHub] [incubator-doris] kangkaisen opened a new issue #2061: Segement V2: Add bitmap index reader

2019-10-24 Thread GitBox
kangkaisen opened a new issue #2061: Segement V2: Add bitmap index reader URL: https://github.com/apache/incubator-doris/issues/2061 For https://github.com/apache/incubator-doris/issues/1684 This work has done, but based on https://github.com/apache/incubator-doris/pull/2050. Afte

[GitHub] [incubator-doris] Youngwb opened a new pull request #2060: Remove drop repository name toLowerCase

2019-10-24 Thread GitBox
Youngwb opened a new pull request #2060: Remove drop repository name toLowerCase URL: https://github.com/apache/incubator-doris/pull/2060 fix bug #2057 Create and drop repository using same repo name in lowercase and uppercase occurs error --

[GitHub] [incubator-doris] jinyishu opened a new issue #2059: sql count 统计值为0时,结果返回 Empty set

2019-10-24 Thread GitBox
jinyishu opened a new issue #2059: sql count 统计值为0时,结果返回 Empty set URL: https://github.com/apache/incubator-doris/issues/2059 现象: mysql> select count(1) from test2 a inner join test b on a.did = b.did group by a.did; Empty set (1 min 27.16 sec) 期望:返回值为 0 ---

[GitHub] [incubator-doris] kangpinghuang opened a new pull request #2058: optimize the convert of row block v2 to v1 #2011

2019-10-24 Thread GitBox
kangpinghuang opened a new pull request #2058: optimize the convert of row block v2 to v1 #2011 URL: https://github.com/apache/incubator-doris/pull/2058 1. use MemPool exchange to avoid string copy 2. use batch convert to replace row by row --

[GitHub] [incubator-doris] kangpinghuang commented on issue #2055: add delete state of row block v2 for performance

2019-10-24 Thread GitBox
kangpinghuang commented on issue #2055: add delete state of row block v2 for performance URL: https://github.com/apache/incubator-doris/pull/2055#issuecomment-545818503 this improment will reduce my test query time cost by 200ms(total 1.2s). my test case: table: compreh_interest

[GitHub] [incubator-doris] Youngwb opened a new issue #2057: Create and drop repository using same repo name in lowercase and uppercase occurs error

2019-10-24 Thread GitBox
Youngwb opened a new issue #2057: Create and drop repository using same repo name in lowercase and uppercase occurs error URL: https://github.com/apache/incubator-doris/issues/2057 **Describe the bug** create repositories with name test and TEST, and drop repository TEST, but the test

[GitHub] [incubator-doris] kangpinghuang commented on issue #2055: add delete state of row block v2 for performance

2019-10-24 Thread GitBox
kangpinghuang commented on issue #2055: add delete state of row block v2 for performance URL: https://github.com/apache/incubator-doris/pull/2055#issuecomment-545789031 #2040 This is an automated message from the Apache Git S

[GitHub] [incubator-doris] chaoyli opened a new pull request #2056: Remove clear_alter_task

2019-10-24 Thread GitBox
chaoyli opened a new pull request #2056: Remove clear_alter_task URL: https://github.com/apache/incubator-doris/pull/2056 Alter task has been refactored and clear_alter_task is not necessary. This is an automated message from

[GitHub] [incubator-doris] Seaven commented on a change in pull request #2046: Changed replace NewStatus with Status

2019-10-24 Thread GitBox
Seaven commented on a change in pull request #2046: Changed replace NewStatus with Status URL: https://github.com/apache/incubator-doris/pull/2046#discussion_r338411868 ## File path: be/src/olap/utils.cpp ## @@ -1432,9 +1451,10 @@ OLAPStatus dir_walk(const string& root,

[GitHub] [incubator-doris] kangpinghuang opened a new pull request #2055: add delete state of row block v2 for performance

2019-10-24 Thread GitBox
kangpinghuang opened a new pull request #2055: add delete state of row block v2 for performance URL: https://github.com/apache/incubator-doris/pull/2055 1. BetaRowset do not set block_status of RowBlock corrently, which will incur more compute cost in reader. This patch will set block_stat