imay commented on a change in pull request #2064: Fix bug that tablet failed to 
be committed when no data is loaded
URL: https://github.com/apache/incubator-doris/pull/2064#discussion_r338907685
 
 

 ##########
 File path: fe/src/main/java/org/apache/doris/catalog/Catalog.java
 ##########
 @@ -2959,7 +2959,12 @@ public void addPartition(Database db, String tableName, 
AddPartitionClause addPa
 
                 // check partition name
                 if (olapTable.getPartition(partitionName) != null) {
-                    throw new DdlException("Partition " + partitionName + " 
already exists");
+                    if (singlePartitionDesc.isSetIfNotExists()) {
+                        LOG.info("add partition[{}] which already exists", 
partitionName);
 
 Review comment:
   Do we need this log?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org

Reply via email to