kangkaisen commented on a change in pull request #2052: Optimize fe start logic URL: https://github.com/apache/incubator-doris/pull/2052#discussion_r338863696
########## File path: fe/src/main/java/org/apache/doris/catalog/Catalog.java ########## @@ -2125,103 +2136,138 @@ private void setCanRead(boolean hasLog, boolean err) { } } else { - canRead = true; + canRead.set(true); + isReady.set(true); + } + } + + public void notifyNewFETypeTransfer(FrontendNodeType newType) { + try { + String msg = "notify new FE type transfer: " + newType; + LOG.warn(msg); + Util.stdoutWithTime(msg); + this.typeTransferQueue.put(newType); + } catch (InterruptedException e) { + LOG.error("failed to put new FE type: {}", newType, e); Review comment: > It almost never happen I see. > Perhaps I should exit the FE process. According to your optimization goal,I also think we should exit the FE process directly. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org