gaodayue commented on a change in pull request #2055: add delete state of row
block v2 for performance
URL: https://github.com/apache/incubator-doris/pull/2055#discussion_r338564195
##########
File path: be/src/olap/rowset/segment_v2/column_reader.h
##########
@@ -232,6 +244,9 @@ class FileColumnIterator : public ColumnIterator {
// current rowid
rowid_t _current_rowid = 0;
+
+ // page indexes those are DEL_PARTIAL_SATISFIED
+ std::unordered_set<uint32_t> _delete_partial_statisfied_pages;
Review comment:
`unordered_set` here seems to be overkill, isn't `std::vector<uint8_t>
_page_delete_status` simpler to deal with?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
