gaodayue commented on a change in pull request #2055: add delete state of row
block v2 for performance
URL: https://github.com/apache/incubator-doris/pull/2055#discussion_r338557950
##########
File path: be/src/olap/rowset/segment_v2/segment_iterator.cpp
##########
@@ -169,12 +170,11 @@ Status
SegmentIterator::_get_row_ranges_from_zone_map(RowRanges* zone_map_row_ra
continue;
}
Review comment:
I guess there is no ColumnReader for default column, so SegmentIterator
should be implemented fully based on ColumnIterator. It shouldn't be a friend
class of Segment.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
