[PATCH] D123884: [HLSL][clang][Driver] Support target profile command line option.

python3kgae updated this revision to Diff 423189. python3kgae edited reviewers, added: steven_wu, JonChesterfield, sscalpone, rnk, bogner, MaskRay, dexonsmith, nikic; removed: jdoerfert, sstefan1, baziotis. python3kgae edited subscribers, added: beanz; removed: mgorny, arphaman, kuter, jdoerfert,

[PATCH] D123884: [HLSL][clang][Driver] Support target profile command line option.

python3kgae updated this revision to Diff 423190. python3kgae added a comment. Fix format in Options.td. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123884/new/ https://reviews.llvm.org/D123884 Files: clang/include/clang/Basic/CodeGenOptions.h

[PATCH] D123887: [HLSL][clang][Driver] Fix test error for use SmallString::data instead SmallString::c_str.

python3kgae created this revision. python3kgae added a reviewer: wolfgangp. Herald added a project: All. python3kgae requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D123887 Fi

[PATCH] D122865: [HLSL][clang][Driver] Support target profile command line option.

python3kgae added a comment. Created new patch to fix the test fail at https://reviews.llvm.org/D123887 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122865/new/ https://reviews.llvm.org/D122865 ___ cfe-

[PATCH] D123887: [HLSL][clang][Driver] Fix test error for use SmallString::data instead SmallString::c_str.

python3kgae abandoned this revision. python3kgae added a comment. Thanks. Close this RP then. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123887/new/ https://reviews.llvm.org/D123887 ___ cfe-commits ma

[PATCH] D123907: [HLSL] Add shader attribute

python3kgae created this revision. python3kgae added reviewers: aaron.ballman, rnk, jdoerfert, MaskRay, rsmith. Herald added a subscriber: StephenFan. Herald added a project: All. python3kgae requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits.

[PATCH] D123907: [HLSL] Add shader attribute

python3kgae added inline comments. Comment at: clang/include/clang/Basic/Attr.td:3978 +"compute", "raygeneration", "intersection", +"anyhit", "closestHit", "miss", "callable", "mesh", +"amplificat

[PATCH] D123907: [HLSL] Add shader attribute

python3kgae updated this revision to Diff 423428. python3kgae added a comment. Add more detail to the doc. Update the attribute name according to the doc. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123907/new/ https://reviews.llvm.org/D123907 F

[PATCH] D123907: [HLSL] Add shader attribute

python3kgae updated this revision to Diff 423448. python3kgae added a comment. Fix doc. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123907/new/ https://reviews.llvm.org/D123907 Files: clang/include/clang/Basic/Attr.td clang/include/clang/Bas

[PATCH] D123907: [HLSL] Add shader attribute

python3kgae added inline comments. Comment at: clang/include/clang/Basic/AttrDocs.td:6389-6391 +Normally the shader type is set by shader target with the -T option like +-Tps_6_1. +When compiling to a library target like lib_6_3, the shader type attribute can aar

[PATCH] D123907: [HLSL] Add shader attribute

python3kgae added a comment. Thanks for the review. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123907/new/ https://reviews.llvm.org/D123907 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http

[PATCH] D123907: [HLSL] Add shader attribute

python3kgae added inline comments. Comment at: clang/include/clang/Basic/AttrDocs.td:6390 + ``[shader(string-literal)]`` +where the string literal is one of: . +Normally the shader type is set by shader target with the ``-T`` option like bogner wrote: > I'm gues

[PATCH] D123907: [HLSL] Add shader attribute

python3kgae updated this revision to Diff 424019. python3kgae added a comment. Fix doc again. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123907/new/ https://reviews.llvm.org/D123907 Files: clang/include/clang/Basic/Attr.td clang/include/cla

[PATCH] D123907: [HLSL] Add shader attribute

python3kgae updated this revision to Diff 424093. python3kgae added a comment. Add comment for test. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123907/new/ https://reviews.llvm.org/D123907 Files: clang/include/clang/Basic/Attr.td clang/incl

[PATCH] D123907: [HLSL] Add shader attribute

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGb02d88d5afb5: [HLSL] Add shader attribute (authored by python3kgae). Changed prior to commit: https://reviews.llvm.org/D123907?vs=424093&id=424104

[PATCH] D123907: [HLSL] Add shader attribute

python3kgae updated this revision to Diff 424105. python3kgae added a comment. Committed. Updated line number check for test. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123907/new/ https://reviews.llvm.org/D123907 Files: clang/include/clang/B

[PATCH] D123884: [HLSL][clang][Driver] Support target profile command line option.

python3kgae updated this revision to Diff 424810. python3kgae marked an inline comment as done. python3kgae added a comment. Herald added a subscriber: Anastasia. Use c_str instead of data to avoid test fail. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm

[PATCH] D123884: [HLSL][clang][Driver] Support target profile command line option.

python3kgae updated this revision to Diff 425315. python3kgae added a comment. Fix issues mentioned in comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123884/new/ https://reviews.llvm.org/D123884 Files: clang/include/clang/Basic/Diagnost

[PATCH] D123884: [HLSL][clang][Driver] Support target profile command line option.

python3kgae updated this revision to Diff 425322. python3kgae added a comment. Remove useless brackets. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123884/new/ https://reviews.llvm.org/D123884 Files: clang/include/clang/Basic/DiagnosticDriverK

[PATCH] D124593: [HLSL][clang] Add clang builtin for HLSL.

python3kgae created this revision. python3kgae added reviewers: anakryiko, ast, yonghong-song. Herald added a subscriber: Anastasia. Herald added a project: All. python3kgae requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. A directx specific

[PATCH] D124595: [HLSL] Add llvm intrinsic for HLSL.

python3kgae created this revision. python3kgae added reviewers: simoll, k-ishizaka, kaz7. Herald added subscribers: Anastasia, dexonsmith, hiraditya, mgorny. Herald added a project: All. python3kgae requested review of this revision. Herald added subscribers: llvm-commits, cfe-commits, jdoerfert. H

[PATCH] D124595: [HLSL] Add llvm intrinsic for HLSL.

python3kgae updated this revision to Diff 425697. python3kgae added a comment. Remove clang part change. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124595/new/ https://reviews.llvm.org/D124595 Files: clang/test/CodeGenHLSL/Builtins/sin_f32.hl

[PATCH] D124595: [HLSL] Add llvm intrinsic for HLSL.

python3kgae abandoned this revision. python3kgae added a comment. Change to different implementation. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124595/new/ https://reviews.llvm.org/D124595 ___ cfe-co

[PATCH] D124593: [HLSL][clang] Add clang builtin for HLSL.

python3kgae abandoned this revision. python3kgae added a comment. Change to different implementation. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124593/new/ https://reviews.llvm.org/D124593 ___ cfe-co

[PATCH] D123884: [HLSL][clang][Driver] Support validator version command line option.

python3kgae updated this revision to Diff 426191. python3kgae added a comment. NO change, fix UNKNOWN REVISION when arc land. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123884/new/ https://reviews.llvm.org/D123884 Files: clang/include/clang/B

[PATCH] D123884: [HLSL][clang][Driver] Support validator version command line option.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG73417c517644: [HLSL][clang][Driver] Support validator version command line option. (authored by python3kgae). Repository: rG LLVM Github Monorepo

[PATCH] D124751: Support -E option for HLSL.

python3kgae created this revision. python3kgae added reviewers: beanz, steven_wu, JonChesterfield, sscalpone, pow2clk, rnk, bogner, MaskRay, dexonsmith. Herald added subscribers: Anastasia, StephenFan. Herald added a project: All. python3kgae requested review of this revision. Herald added a proje

[PATCH] D124752: [HLSL] clang codeGen for HLSLShaderAttr.

python3kgae created this revision. python3kgae added reviewers: dblaikie, MaskRay, hoy, lebedev.ri. Herald added subscribers: Anastasia, StephenFan. Herald added a project: All. python3kgae requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Tr

[PATCH] D124753: [HLSL] Set main as default entry.

python3kgae created this revision. python3kgae added reviewers: beanz, steven_wu, JonChesterfield, sscalpone, pow2clk, rnk, bogner, MaskRay, dexonsmith. Herald added subscribers: Anastasia, StephenFan. Herald added a project: All. python3kgae requested review of this revision. Herald added a proje

[PATCH] D124790: [HLSL] Enable half type for hlsl.

python3kgae created this revision. python3kgae added reviewers: Anastasia, aaron.ballman, beanz, pow2clk. Herald added a subscriber: dexonsmith. Herald added a project: All. python3kgae requested review of this revision. Herald added subscribers: cfe-commits, MaskRay. Herald added a project: clang.

[PATCH] D124813: [HLSL] Add clang builtin for HLSL.

python3kgae created this revision. python3kgae added reviewers: anakryiko, ast, yonghong-song, beanz, pow2clk. Herald added a subscriber: Anastasia. Herald added a project: All. python3kgae requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Tw

[PATCH] D124790: [HLSL] Enable half type for hlsl.

python3kgae marked 3 inline comments as done. python3kgae added inline comments. Comment at: clang/lib/Basic/LangOptions.cpp:197 - // OpenCL has half keyword - Opts.Half = Opts.OpenCL; + // OpenCL and HLSL have half keyword + Opts.Half = Opts.OpenCL || Opts.HLSL; --

[PATCH] D124790: [HLSL] Enable half type for hlsl.

python3kgae marked 2 inline comments as done. python3kgae added inline comments. Comment at: clang/lib/Basic/LangOptions.cpp:197 - // OpenCL has half keyword - Opts.Half = Opts.OpenCL; + // OpenCL and HLSL have half keyword + Opts.Half = Opts.OpenCL || Opts.HLSL; --

[PATCH] D124790: [HLSL] Enable half type for hlsl.

python3kgae updated this revision to Diff 426854. python3kgae added a comment. Add option -fcgl which output clang codeGen result to avoid test dependent on build DirectX backend. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124790/new/ https://r

[PATCH] D124790: [HLSL] Enable half type for hlsl.

python3kgae added inline comments. Comment at: clang/lib/Basic/LangOptions.cpp:197 - // OpenCL has half keyword - Opts.Half = Opts.OpenCL; + // OpenCL and HLSL have half keyword + Opts.Half = Opts.OpenCL || Opts.HLSL; python3kgae wrote: > aaron.ballman wrot

[PATCH] D124983: [HLSL} add -fcgl option flag.

python3kgae created this revision. python3kgae added reviewers: amccarth, craig.topper, hans, rnk, stefan_reinalter, beanz, pow2clk. Herald added subscribers: Anastasia, StephenFan. Herald added a project: All. python3kgae requested review of this revision. Herald added subscribers: cfe-commits, M

[PATCH] D124983: [HLSL} add -fcgl option flag.

python3kgae marked 2 inline comments as done. python3kgae added inline comments. Comment at: clang/include/clang/Driver/Options.td:6765 "as_6_5, as_6_6, as_6_7">; +def fcgl : DXCFlag<"fcgl">, + HelpText<"Generate high-level code only. Without any dxil related passes.">

[PATCH] D125052: [HLSL] Enable vector types for hlsl.

python3kgae created this revision. python3kgae added reviewers: svenvh, asavonic, beanz, pow2clk. Herald added subscribers: Anastasia, mgorny. Herald added a project: All. python3kgae requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Vector t

[PATCH] D124983: [HLSL} add -fcgl option flag.

python3kgae updated this revision to Diff 427544. python3kgae marked 2 inline comments as done. python3kgae added a comment. Add emit_pristine_llvm to make fcgl easier to understand. Also change unit test to lib test. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://rev

[PATCH] D124983: [HLSL] add -fcgl option flag.

python3kgae updated this revision to Diff 427656. python3kgae added a comment. Remove HelpText for alias option. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124983/new/ https://reviews.llvm.org/D124983 Files: clang/include/clang/Driver/Options

[PATCH] D124983: [HLSL] add -fcgl option flag.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG3fa5eb4cfc06: [HLSL] add -fcgl option flag. (authored by python3kgae). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://re

[PATCH] D124790: [HLSL] Enable half type for hlsl.

python3kgae updated this revision to Diff 427711. python3kgae added a comment. Rebase for fcgl change. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124790/new/ https://reviews.llvm.org/D124790 Files: clang/include/clang/Driver/Options.td clan

[PATCH] D128845: [HLSL]Add -O and -Od option for dxc mode.

python3kgae updated this revision to Diff 444352. python3kgae marked an inline comment as done. python3kgae added a comment. Change default to O3 implement to HLSL driver and update test. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTI

[PATCH] D128462: [HLSL] add -I option for dxc mode.

python3kgae updated this revision to Diff 13. python3kgae marked 3 inline comments as done. python3kgae added a comment. Update test. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128462/new/ https://reviews.llvm.org/D128462 Files: clang/inc

[PATCH] D128462: [HLSL] add -I option for dxc mode.

python3kgae marked an inline comment as done. python3kgae added inline comments. Comment at: clang/include/clang/Driver/Options.td:6824 +class DXCJoinedOrSeparateConflict : Option<["--", "/", "-"], name, + KIND_JOINED_OR_SEPARATE>, Group, Flags<[DXCOption, NoXarchOption]>; --

[PATCH] D128462: [HLSL] add -I option for dxc mode.

python3kgae marked an inline comment as done. python3kgae added inline comments. Comment at: clang/include/clang/Driver/Options.td:6824 +class DXCJoinedOrSeparateConflict : Option<["--", "/", "-"], name, + KIND_JOINED_OR_SEPARATE>, Group, Flags<[DXCOption, NoXarchOption]>; --

[PATCH] D128462: [HLSL] add -I option for dxc mode.

python3kgae updated this revision to Diff 444803. python3kgae marked an inline comment as done. python3kgae added a comment. Add CLDXCOption flag and share option with CL mode. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128462/new/ https://revie

[PATCH] D128462: [HLSL] add -I option for dxc mode.

python3kgae marked an inline comment as done. python3kgae added inline comments. Comment at: clang/include/clang/Driver/Options.td:6318 + HelpText<"CL.EXE COMPATIBILITY OPTIONS">; + def cl_compile_Group : OptionGroup<"">, beanz wrote: > Do we need this group or

[PATCH] D128462: [HLSL] add -I option for dxc mode.

python3kgae updated this revision to Diff 444830. python3kgae marked an inline comment as done. python3kgae added a comment. Merge change from Chris. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128462/new/ https://reviews.llvm.org/D128462 Files:

[PATCH] D128462: [HLSL] add -I option for dxc mode.

python3kgae updated this revision to Diff 444834. python3kgae added a comment. Remove DXCJoinedOrSeparateConflict. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128462/new/ https://reviews.llvm.org/D128462 Files: clang/include/clang/Driver/Optio

[PATCH] D129883: [HLSL] Support cbuffer/tbuffer for hlsl.

python3kgae created this revision. python3kgae added reviewers: svenvh, asavonic, beanz, pow2clk, Anastasia, aaron.ballman. Herald added a subscriber: mgorny. Herald added a project: All. python3kgae requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-c

[PATCH] D129883: [HLSL] Support cbuffer/tbuffer for hlsl.

python3kgae updated this revision to Diff 445162. python3kgae added a comment. Code cleanup and add test for error case. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129883/new/ https://reviews.llvm.org/D129883 Files: clang/include/clang/AST/De

[PATCH] D129883: [HLSL] Support cbuffer/tbuffer for hlsl.

python3kgae marked 2 inline comments as done. python3kgae added inline comments. Comment at: clang/test/SemaHLSL/cbuffer_tbuffer.hlsl:1 +// RUN: %clang_cc1 -triple dxil-pc-shadermodel6.3-library -x hlsl -ast-dump -o - %s | FileCheck %s + beanz wrote: > This look

[PATCH] D125585: [HLSL][clang][Driver] Parse target profile early to update Driver::TargetTriple.

python3kgae added a comment. In D125585#3657734 , @vitalybuka wrote: > @python3kgae > 0fbafb5a1c4381ded4bc7f59a5a6091c229faed7 > is > fixing leaks in this tests. > > Note, the leak w

[PATCH] D130016: [HLSL] Add __builtin_hlsl_create_handle

python3kgae added inline comments. Comment at: clang/test/CodeGenHLSL/builtins/create_handle.hlsl:4 +void fn() { + (void)__builtin_hlsl_create_handle(0); +} What does the parameter 0 mean here? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D130033: [HLSL] Add resource binding attribute for HLSL.

python3kgae created this revision. python3kgae added reviewers: svenvh, asavonic, beanz, pow2clk, Anastasia, aaron.ballman. Herald added a project: All. python3kgae requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. The resource binding attri

[PATCH] D128462: [HLSL] add -I option for dxc mode.

python3kgae updated this revision to Diff 445967. python3kgae added a comment. Herald added subscribers: usaxena95, kadircet, arphaman. Herald added a project: clang-tools-extra. Fix test fail in clangd. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/

[PATCH] D130131: [HLSL] CodeGen hlsl cbuffer/tbuffer.

python3kgae created this revision. python3kgae added reviewers: aaron.ballman, Anastasia, kuhar, bogner, beanz, pow2clk. Herald added a project: All. python3kgae requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. cbuffer A { float a; flo

[PATCH] D128462: [HLSL] add -I option for dxc mode.

This revision was automatically updated to reflect the committed changes. Closed by commit rGa73a84c44753: [HLSL] add -I option for dxc mode. (authored by python3kgae). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128462/new/ https://reviews.llvm.o

[PATCH] D130207: [HLSL] Move DXIL validation version out of ModuleFlags

python3kgae created this revision. python3kgae added reviewers: Anastasia, kuhar, bogner, beanz, pow2clk. Herald added a subscriber: hiraditya. Herald added a project: All. python3kgae requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: llvm-commits, cfe

[PATCH] D128845: [HLSL]Add -O and -Od option for dxc mode.

python3kgae updated this revision to Diff 446310. python3kgae added a comment. Use CLDXCOption for opt level. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128845/new/ https://reviews.llvm.org/D128845 Files: clang/include/clang/Basic/TargetOptio

[PATCH] D124790: [HLSL] Enable half type for hlsl.

python3kgae updated this revision to Diff 428153. python3kgae added a comment. Add Sema test. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124790/new/ https://reviews.llvm.org/D124790 Files: clang/include/clang/Driver/Options.td clang/lib/Bas

[PATCH] D124751: [HLSL] Support -E option for HLSL.

python3kgae updated this revision to Diff 428209. python3kgae added a comment. Rebase to main for fix merge conflict. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124751/new/ https://reviews.llvm.org/D124751 Files: clang/include/clang/Basic/Dia

[PATCH] D125338: [HLSL] add -D option for dxc mode.

python3kgae created this revision. python3kgae added reviewers: amccarth, craig.topper, hans, rnk, stefan_reinalter, beanz, pow2clk, aaron.ballman. Herald added subscribers: Anastasia, StephenFan. Herald added a project: All. python3kgae requested review of this revision. Herald added subscribers:

[PATCH] D125338: [HLSL] add -D option for dxc mode.

python3kgae updated this revision to Diff 428698. python3kgae added a comment. Add check for macro. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125338/new/ https://reviews.llvm.org/D125338 Files: clang/include/clang/Driver/Options.td clang/l

[PATCH] D125338: [HLSL] add -D option for dxc mode.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG4dae38ebfba0: [HLSL] add -D option for dxc mode. (authored by python3kgae). Changed prior to commit: https://reviews.llvm.org/D125338?vs=428698&id

[PATCH] D125338: [HLSL] add -D option for dxc mode.

python3kgae added a comment. In D125338#3507063 , @thakis wrote: > Looks like this breaks tests on Mac: http://45.33.8.238/macm1/35103/step_7.txt > > Please take a look and revert for now if it takes a while to fix. I'll revert it. Thanks. Repository:

[PATCH] D125414: Revert "[HLSL] add -D option for dxc mode."

python3kgae created this revision. Herald added a subscriber: Anastasia. Herald added a project: All. python3kgae requested review of this revision. Herald added subscribers: cfe-commits, MaskRay. Herald added a project: clang. This reverts commit 4dae38ebfba0d8583e52c3ded8f62f5f9fa77fda

[PATCH] D125414: Revert "[HLSL] add -D option for dxc mode."

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG6055837f6d29: Revert "[HLSL] add -D option for dxc mode." (authore

[PATCH] D125585: [HLSL][clang][Driver] Parse target profile early to update Driver::TargetTriple.

python3kgae created this revision. python3kgae added reviewers: thakis, beanz, pow2clk. Herald added a subscriber: Anastasia. Herald added a project: All. python3kgae requested review of this revision. Herald added subscribers: cfe-commits, MaskRay. Herald added a project: clang. This is to avoid

[PATCH] D124751: [HLSL] Support -E option for HLSL.

python3kgae added a comment. In D124751#3513283 , @MaskRay wrote: > Is there a specification or reference implementation stating that -E is used? > >> Option<["--", "/", "-"], "E", > > Do you need the prefix `--`? You may define something like `CLFlag`. I

[PATCH] D125655: [HLSL] add -P option for dxc mode.

python3kgae created this revision. python3kgae added reviewers: amccarth, craig.topper, hans, rnk, stefan_reinalter, beanz, pow2clk. Herald added subscribers: Anastasia, StephenFan. Herald added a project: All. python3kgae requested review of this revision. Herald added subscribers: cfe-commits, M

[PATCH] D125585: [HLSL][clang][Driver] Parse target profile early to update Driver::TargetTriple.

python3kgae updated this revision to Diff 430211. python3kgae added a comment. Use llvm::Optional. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125585/new/ https://reviews.llvm.org/D125585 Files: clang/lib/Driver/Driver.cpp clang/lib/Driver/T

[PATCH] D124751: [HLSL] Support -E option for HLSL.

python3kgae added a comment. In D124751#3529652 , @MaskRay wrote: > In D124751#3513513 , @python3kgae > wrote: > >> In D124751#3513283 , @MaskRay >> wrote: >> >>> Is the

[PATCH] D124752: [HLSL] clang codeGen for HLSLShaderAttr.

python3kgae added inline comments. Comment at: clang/lib/AST/Mangle.cpp:138 + // HLSL shader entry function never need to be mangled. + if (getASTContext().getLangOpts().HLSL && D->hasAttr()) Anastasia wrote: > Does HLSL shader entry inherits the same behavio

[PATCH] D111109: AddGlobalAnnotations for function with or without function body.

python3kgae created this revision. python3kgae added a reviewer: clang. python3kgae added a project: clang. python3kgae requested review of this revision. Herald added a subscriber: cfe-commits. When AnnotateAttr is on a function, AddGlobalAnnotations is only called in CodeGenModule::EmitGlobalFu

[PATCH] D133668: [HLSL] Use _BitInt(16) for int16_t to avoid promote to int.

python3kgae updated this revision to Diff 468617. python3kgae added a comment. Switch back to short and disable integer promote for hlsl. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133668/new/ https://reviews.llvm.org/D133668 Files: clang/lib

[PATCH] D133668: [HLSL] Disable int16_t to avoid promote to int for HLSL.

python3kgae added a comment. In D133668#3847999 , @rjmccall wrote: > If you have `char`, would you want it to promote? Because turning `char` to > `_BitInt(8)` is breaking with C on other grounds (like aliasing), for better > or worse. So if you just

[PATCH] D133983: [HLSL] Add SV_DispatchThreadID

python3kgae updated this revision to Diff 468700. python3kgae added a comment. Check sret parameter exist. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133983/new/ https://reviews.llvm.org/D133983 Files: clang/include/clang/Basic/Attr.td clan

[PATCH] D133983: [HLSL] Add SV_DispatchThreadID

python3kgae updated this revision to Diff 468706. python3kgae added a comment. More check on the ir. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133983/new/ https://reviews.llvm.org/D133983 Files: clang/include/clang/Basic/Attr.td clang/incl

[PATCH] D133668: [HLSL] Disable int16_t to avoid promote to int for HLSL.

python3kgae updated this revision to Diff 468731. python3kgae marked an inline comment as done. python3kgae added a comment. Update comment and fix tests. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133668/new/ https://reviews.llvm.org/D133668 F

[PATCH] D133983: [HLSL] Add SV_DispatchThreadID

This revision was automatically updated to reflect the committed changes. Closed by commit rG14ae5d2b745f: [HLSL] Add SV_DispatchThreadID (authored by python3kgae). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133983/new/ https://reviews.llvm.org/D

[PATCH] D135429: [HLSL] [DirectX backend] Move generateGlobalCtorDtorCalls into DirectX backend.

python3kgae added a comment. gentle ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135429/new/ https://reviews.llvm.org/D135429 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.l

[PATCH] D133668: [HLSL] Disable integer promotion to avoid int16_t being promoted to int for HLSL.

python3kgae updated this revision to Diff 468993. python3kgae marked an inline comment as done. python3kgae added a comment. Herald added a subscriber: steakhal. Herald added a reviewer: NoQ. Move isPromotableIntegerType to ASTContext so it can access LangOpts. Repository: rG LLVM Github Monor

[PATCH] D135060: [HLSL] Add groupshare address space.

python3kgae updated this revision to Diff 469048. python3kgae added a comment. Update comments and add more test cases. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135060/new/ https://reviews.llvm.org/D135060 Files: clang/include/clang/Basic/A

[PATCH] D135060: [HLSL] Add groupshare address space.

python3kgae marked 3 inline comments as done. python3kgae added inline comments. Comment at: clang/test/ParserHLSL/group_shared_202x.hlsl:5-6 + +// expected-error@+1 {{return type cannot be qualified with address space}} +auto l = []() -> groupshared void {}; +// expected-error@+

[PATCH] D135721: [HLSL] Added HLSL this as a reference

python3kgae added inline comments. Comment at: clang/lib/Sema/HLSLExternalSemaSource.cpp:179 +AST, SourceLocation(), +Constructor->getThisType().getTypePtr()->getPointeeType(), true); +This->setValueKind(ExprValueKind::VK_LValue); gracejenning

[PATCH] D136134: [NFC] [DirectX backend] move ResourceClass into llvm.

python3kgae updated this revision to Diff 469074. python3kgae added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136134/new/ https://reviews.llvm.org/D136134 Files: clang/include/clang/Basic/HLSLRuntime.h clang/lib/CodeGen/C

[PATCH] D135060: [HLSL] Add groupshare address space.

This revision was automatically updated to reflect the committed changes. python3kgae marked an inline comment as done. Closed by commit rG7e04c0ad6325: [HLSL] Add groupshare address space. (authored by python3kgae). Changed prior to commit: https://reviews.llvm.org/D135060?vs=469048&id=469259#

[PATCH] D136134: [NFC] [DirectX backend] move ResourceClass into llvm.

python3kgae marked an inline comment as done. python3kgae added inline comments. Comment at: clang/lib/Sema/HLSLExternalSemaSource.cpp:20 #include "clang/Sema/Sema.h" +#include "llvm/Frontend/HLSL/HLSLResource.h" beanz wrote: > You need to add FrontendHLSL to

[PATCH] D136134: [NFC] [DirectX backend] move ResourceClass into llvm.

python3kgae marked an inline comment as done. python3kgae added inline comments. Comment at: clang/lib/Sema/HLSLExternalSemaSource.cpp:20 #include "clang/Sema/Sema.h" +#include "llvm/Frontend/HLSL/HLSLResource.h" python3kgae wrote: > beanz wrote: > > You need

[PATCH] D136134: [NFC] [DirectX backend] move ResourceClass into llvm.

python3kgae updated this revision to Diff 469302. python3kgae marked an inline comment as done. python3kgae added a comment. Add FrontendHLSL to Sema link Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136134/new/ https://reviews.llvm.org/D136134 F

[PATCH] D136134: [NFC] [DirectX backend] move ResourceClass into llvm.

python3kgae added inline comments. Comment at: clang/lib/Sema/HLSLExternalSemaSource.cpp:20 #include "clang/Sema/Sema.h" +#include "llvm/Frontend/HLSL/HLSLResource.h" beanz wrote: > python3kgae wrote: > > python3kgae wrote: > > > beanz wrote: > > > > You need

[PATCH] D133668: [HLSL] Disable integer promotion to avoid int16_t being promoted to int for HLSL.

python3kgae updated this revision to Diff 469334. python3kgae added a comment. Update test. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133668/new/ https://reviews.llvm.org/D133668 Files: clang/include/clang/AST/ASTContext.h clang/include/cl

[PATCH] D136134: [NFC] [DirectX backend] move ResourceClass into llvm.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGa7183a158d68: [NFC] [DirectX backend] move ResourceClass into llvm. (authored by python3kgae). Changed prior to commit: https://reviews.llvm.org/D

[PATCH] D133668: [HLSL] Disable integer promotion to avoid int16_t being promoted to int for HLSL.

python3kgae updated this revision to Diff 469373. python3kgae added a comment. Fix clang-format. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133668/new/ https://reviews.llvm.org/D133668 Files: clang/include/clang/AST/ASTContext.h clang/inclu

[PATCH] D133668: [HLSL] Disable integer promotion to avoid int16_t being promoted to int for HLSL.

This revision was automatically updated to reflect the committed changes. Closed by commit rG464926ef4484: [HLSL] Disable integer promotion to avoid int16_t being promoted to int for… (authored by python3kgae). Changed prior to commit: https://reviews.llvm.org/D133668?vs=469373&id=469387#toc R

[PATCH] D136482: [HLSL] support unbounded global resource array.

python3kgae created this revision. python3kgae added reviewers: pow2clk, beanz, bogner. Herald added a subscriber: Anastasia. Herald added a project: All. python3kgae requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. unbounded resource array

[PATCH] D136743: [HLSL] support ConstantBuffer

python3kgae created this revision. python3kgae added reviewers: pow2clk, beanz, bogner. Herald added a subscriber: Anastasia. Herald added a project: All. python3kgae requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Support ConstantBuffer by

[PATCH] D136743: [HLSL] support ConstantBuffer

python3kgae updated this revision to Diff 470870. python3kgae edited the summary of this revision. python3kgae added a comment. Fix windows test fail caused by dead ptr. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136743/new/ https://reviews.llvm

<    1   2   3   4   5   >