python3kgae marked an inline comment as done.
python3kgae added inline comments.
================
Comment at: clang/include/clang/Driver/Options.td:6824
+class DXCJoinedOrSeparateConflict<string name> : Option<["--", "/", "-"], name,
+ KIND_JOINED_OR_SEPARATE>, Group<dxc_Group>, Flags<[DXCOption,
NoXarchOption]>;
----------------
pow2clk wrote:
> I'm not sure why this has the suffix "Conflict" In addition, you can't
> currently specify the "I" option with "--" in DXC.
The conflict happened with clang-cl which use same prefix ("/", "-") as dxc.
def _SLASH_I : CLJoinedOrSeparate<"I">,
HelpText<"Add directory to include search path">, MetaVarName<"<dir>">,
Alias<I>;
================
Comment at: clang/include/clang/Driver/Options.td:6851
Group<dxc_Group>, Flags<[DXCOption, NoXarchOption]>, Alias<D>;
+def dxc_I : DXCJoinedOrSeparateConflict<"I">,
+ HelpText<"Add directory to include search path">,
----------------
beanz wrote:
> beanz wrote:
> > This option has the same behavior between DXC and clang, is there a reason
> > we need to define a new option value instead of reusing the existing one?
> As a note, the `I_Group` only has the `-I` flag, so we probably can just make
> `I_Group` valid for DXC.
clang -I is CC1Option,CC1AsOption,FlangOption,FC1Option. We need one for dxc
mode with prefix "/", "-". But it conflict with _SLASH_I for clang-cl.
So have to add dxc_I.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D128462/new/
https://reviews.llvm.org/D128462
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
