python3kgae added a comment. In D125585#3657734 <https://reviews.llvm.org/D125585#3657734>, @vitalybuka wrote:
> @python3kgae > 0fbafb5a1c4381ded4bc7f59a5a6091c229faed7 > <https://reviews.llvm.org/rG0fbafb5a1c4381ded4bc7f59a5a6091c229faed7> is > fixing leaks in this tests. > > Note, the leak was missed because of unrelated issues in gtest and lsan setup > which we fixed recently. > > I incorrectly blamed the leak on D122865 <https://reviews.llvm.org/D122865>, > but in fact it was D125585 <https://reviews.llvm.org/D125585>. I see that > before this patch we have one Driver, one Compilation and both deleted > correctly. Leaks are obvious, after this patch we don't delete Compilation. > > I fixed the leak, but I had to remove shared driver. My concern is that maybe > shared driver is important use-case. If it's so, would you like to take a > look, and find how to avoid a leak with shared driver? Hi Vitaly, Thanks for fixing the leak. Shared driver is not important use-case. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125585/new/ https://reviews.llvm.org/D125585 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
