[PATCH] D58880: [WIP] [clangd] Type hierarchy subtypes

nridge updated this revision to Diff 204201. nridge added a comment. Rebase, add lit test, and post for review Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58880/new/ https://reviews.llvm.org/D58880 Files: clang-tools-extra/clangd/ClangdServer.

[PATCH] D58880: [clangd] Type hierarchy subtypes

nridge updated this revision to Diff 204208. nridge added a comment. Get disabled tests passing Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58880/new/ https://reviews.llvm.org/D58880 Files: clang-tools-extra/clangd/ClangdServer.cpp clang-too

[PATCH] D62839: [clangd] Index API and implementations for relations

nridge marked an inline comment as done. nridge added inline comments. Comment at: clang-tools-extra/clangd/index/Index.h:77 +struct RelationsRequest { + SymbolID Subject; + index::SymbolRole Predicate; kadircet wrote: > sorry for missing it in previous iterati

[PATCH] D62839: [clangd] Index API and implementations for relations

nridge added inline comments. Comment at: clang-tools-extra/clangd/index/dex/Dex.cpp:244 llvm::function_ref Callback) const { trace::Span Tracer("Dex lookup"); for (const auto &ID : Req.IDs) { kadircet wrote: > could you revert these chang

[PATCH] D62839: [clangd] Index API and implementations for relations

nridge updated this revision to Diff 204691. nridge marked 7 inline comments as done. nridge added a comment. Address latest review comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62839/new/ https://reviews.llvm.org/D62839 Files: clang-to

[PATCH] D58880: [clangd] Type hierarchy subtypes

nridge updated this revision to Diff 204696. nridge marked 13 inline comments as done. nridge added a comment. Address review comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58880/new/ https://reviews.llvm.org/D58880 Files: clang-tools-ex

[PATCH] D58880: [clangd] Type hierarchy subtypes

nridge added inline comments. Comment at: clang-tools-extra/clangd/XRefs.cpp:1061 + End.character = CD.End.column(); + // TODO: How to get entire range like in declToTypeHierarchyItem()? + THI.range = {Start, End}; kadircet wrote: > a few different approaches

[PATCH] D63316: [clangd] Include the diagnostics's code when comparing diagnostics

nridge created this revision. nridge added a reviewer: kadircet. Herald added subscribers: cfe-commits, arphaman, jkorous, MaskRay, ilya-biryukov. Herald added a project: clang. This fixes https://github.com/clangd/clangd/issues/60 Repository: rG LLVM Github Monorepo https://reviews.llvm.org

[PATCH] D62839: [clangd] Index API and implementations for relations

This revision was automatically updated to reflect the committed changes. Closed by commit rL363481: [clangd] Index API and implementations for relations (authored by nridge, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit: https://

[PATCH] D62839: [clangd] Index API and implementations for relations

nridge added a comment. Thanks for fixing that! Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62839/new/ https://reviews.llvm.org/D62839 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/c

[PATCH] D63331: [clangd] WIP/RFC: Prototype for semantic highlighting proposal

nridge added a comment. In D63331#1543441 , @hokein wrote: > To avoid multiple people working on the same feature, I think the plan is > that @jvikstrom will pick up the current stuff, and continue > working/improving it. Sounds good! I'm excited to se

[PATCH] D58880: [clangd] Type hierarchy subtypes

This revision was automatically updated to reflect the committed changes. Closed by commit rL363506: [clangd] Type hierarchy subtypes (authored by nridge, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm.org/D58

[PATCH] D58880: [clangd] Type hierarchy subtypes

nridge added inline comments. Comment at: clang-tools-extra/clangd/XRefs.cpp:1052 + PathRef TUPath) { + // TODO: Pass in ClangdServer::WorkspaceRoot as a HintPath. + StringRef HintPath; kadircet wrote: > this part looks a little messed

[PATCH] D58880: [clangd] Type hierarchy subtypes

nridge updated this revision to Diff 204937. nridge marked 5 inline comments as done. nridge added a comment. Address remaining review comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58880/new/ https://reviews.llvm.org/D58880 Files: clang

[PATCH] D63316: [clangd] Include the diagnostics's code when comparing diagnostics

nridge updated this revision to Diff 204939. nridge added a comment. Revise fix and add test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63316/new/ https://reviews.llvm.org/D63316 Files: clang-tools-extra/clangd/Protocol.h clang-tools-extra/

[PATCH] D63316: [clangd] Include the diagnostics's code when comparing diagnostics

nridge marked an inline comment as done. nridge added a comment. The fix actually broke another lit test, because in that test the client was not sending the diagnostic's code back in the `codeAction` request, resulting in a mismatch with the new comparison function. I think a real client could

[PATCH] D63316: [clangd] Include the diagnostics's code when comparing diagnostics

nridge updated this revision to Diff 205694. nridge added a comment. Add requested test case Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63316/new/ https://reviews.llvm.org/D63316 Files: clang-tools-extra/clangd/Protocol.h clang-tools-extra/

[PATCH] D63316: [clangd] Include the diagnostics's code when comparing diagnostics

This revision was automatically updated to reflect the committed changes. Closed by commit rL363889: [clangd] Include the diagnostics's code when comparing diagnostics (authored by nridge, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to comm

[PATCH] D64307: [clangd] Add a missing early return in getTypeHierarchy()

This revision was automatically updated to reflect the committed changes. Closed by commit rL365849: [clangd] Add a missing early return in getTypeHierarchy() (authored by nridge, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit: htt

[PATCH] D64308: [clangd] Implement typeHierarchy/resolve for subtypes

This revision was automatically updated to reflect the committed changes. nridge marked 3 inline comments as done. Closed by commit rL365867: [clangd] Implement typeHierarchy/resolve for subtypes (authored by nridge, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-com

[PATCH] D64613: [clangd] Type hierarchy: don't resolve parents if the client only asked for children

nridge created this revision. nridge added a reviewer: sammccall. Herald added subscribers: cfe-commits, kadircet, arphaman, jkorous, MaskRay, ilya-biryukov. Herald added a project: clang. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D64613 Files: clang-tools-extra/clangd/XR

[PATCH] D64308: [clangd] Implement typeHierarchy/resolve for subtypes

nridge marked an inline comment as done. nridge added inline comments. Comment at: clang-tools-extra/clangd/test/type-hierarchy.test:1 # RUN: clangd -lit-test < %s | FileCheck -strict-whitespace %s {"jsonrpc":"2.0","id":0,"method":"initialize","params":{"processId":123,"rootPa

[PATCH] D64613: [clangd] Type hierarchy: don't resolve parents if the client only asked for children

nridge added a comment. This is an issue I noticed while writing the unit test for D64308 . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64613/new/ https://reviews.llvm.org/D64613 __

[PATCH] D64614: [clangd] Mark type hierarchy as a supported feature in the docs

nridge created this revision. nridge added a reviewer: sammccall. Herald added subscribers: cfe-commits, kadircet, arphaman, jkorous, MaskRay, ilya-biryukov. Herald added a project: clang. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D64614 Files: clang-tools-extra/docs/clan

[PATCH] D64614: [clangd] Mark type hierarchy as a supported feature in the docs

nridge marked an inline comment as done. nridge added inline comments. Comment at: clang-tools-extra/docs/clangd/Features.rst:264 +-++--+ -| Type hierarchy | No | No | +| Type hierarchy

[PATCH] D64308: [clangd] Implement typeHierarchy/resolve for subtypes

nridge reopened this revision. nridge marked an inline comment as done. nridge added a comment. This revision is now accepted and ready to land. This was backed out due to a Windows test failure. Seems to be related to the hint path having a different format on Windows. I guess I should not hard-

[PATCH] D64308: [clangd] Implement typeHierarchy/resolve for subtypes

nridge updated this revision to Diff 209666. nridge added a comment. Fix Windows test failure Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64308/new/ https://reviews.llvm.org/D64308 Files: clang-tools-extra/clangd/ClangdLSPServer.cpp clang-to

[PATCH] D64308: [clangd] Implement typeHierarchy/resolve for subtypes

This revision was automatically updated to reflect the committed changes. Closed by commit rL365986: [clangd] Implement typeHierarchy/resolve for subtypes (authored by nridge, committed by ). Changed prior to commit: https://reviews.llvm.org/D64308?vs=209666&id=209669#toc Repository: rL LLVM

[PATCH] D64614: [clangd] Mark type hierarchy as a supported feature in the docs

This revision was automatically updated to reflect the committed changes. Closed by commit rL365987: [clangd] Mark type hierarchy as a supported feature in the docs (authored by nridge, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit:

[PATCH] D64614: [clangd] Mark type hierarchy as a supported feature in the docs

nridge marked an inline comment as done. nridge added inline comments. Comment at: clang-tools-extra/docs/clangd/Features.rst:264 +-++--+ -| Type hierarchy | No | No | +| Type hierarchy

[PATCH] D64614: [clangd] Mark type hierarchy as a supported feature in the docs

nridge marked an inline comment as done. nridge added inline comments. Comment at: clang-tools-extra/docs/clangd/Features.rst:264 +-++--+ -| Type hierarchy | No | No | +| Type hierarchy

[PATCH] D64613: [clangd] Type hierarchy: don't resolve parents if the client only asked for children

nridge updated this revision to Diff 209677. nridge added a comment. Address review comment Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64613/new/ https://reviews.llvm.org/D64613 Files: clang-tools-extra/clangd/XRefs.cpp clang-tools-extra/cl

[PATCH] D64613: [clangd] Type hierarchy: don't resolve parents if the client only asked for children

nridge marked 2 inline comments as done. nridge added inline comments. Comment at: clang-tools-extra/clangd/XRefs.cpp:1238 Optional Result = - getTypeAncestors(*CXXRD, AST.getASTContext(), RPSet); + getTypeAncestors(*CXXRD, AST.getASTContext(), RPSet, ResolveParents)

[PATCH] D64613: [clangd] Type hierarchy: don't resolve parents if the client only asked for children

nridge marked an inline comment as done. nridge added a comment. (Changed reviewer to Kadir as he reviewed the previous version.) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64613/new/ https://reviews.llvm.org/D64613 __

[PATCH] D64613: [clangd] Type hierarchy: don't resolve parents if the client only asked for children

This revision was automatically updated to reflect the committed changes. Closed by commit rL366338: [clangd] Type hierarchy: don't resolve parents if the client only asked for… (authored by nridge, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed pri

[PATCH] D64922: [clangd] Added option to enable semantic highlighting via an experimental capability

nridge added a comment. I believe this is not necessary. You can add text document capabilities in the vscode client extension like this: class SemanticHighlightingFeature implements vscodelc.StaticFeature { fillClientCapabilities(capabilities: vscodelc.ClientCapabilities): void { co

[PATCH] D65373: [clangd] Update features table in the docs with links to LSP extension proposals

nridge created this revision. nridge added a reviewer: sammccall. Herald added subscribers: cfe-commits, kadircet, arphaman, jkorous, MaskRay, ilya-biryukov. Herald added a project: clang. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D65373 Files: clang-tools-extra/docs/clan

[PATCH] D65373: [clangd] Update features table in the docs with links to LSP extension proposals

nridge marked an inline comment as done. nridge added inline comments. Comment at: clang-tools-extra/docs/clangd/Features.rst:266 +-++--+ -| Organize Includes | No | No | +| Organize Includes

[PATCH] D65625: [clangd] Allow the client to specify multiple compilation databases in the 'initialize' request

nridge created this revision. nridge added a reviewer: ilya-biryukov. Herald added subscribers: cfe-commits, kadircet, arphaman, jkorous, MaskRay. Herald added a project: clang. This is useful for multi-project setups where each project has its own compilation database, and particularly in cases w

[PATCH] D65625: [clangd] Allow the client to specify multiple compilation databases in the 'initialize' request

nridge added a comment. As background, some discussion of this took place on the mailing list a few months ago: http://lists.llvm.org/pipermail/clangd-dev/2019-January/000232.html Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65625/new/ https://re

[PATCH] D65625: [clangd] Allow the client to specify multiple compilation databases in the 'initialize' request

nridge added a comment. Thanks for having a look! I filed an issue so some folks who don't necessarily have an LLVM Phabricator account can weigh in, let's continue the discussion there. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST AC

[PATCH] D65637: [clangd] [WIP] Semantic highlighting prototype for the vscode extension.

nridge added a comment. Do you plan to support text decorations other than color, e.g. bold / underline / italic? Are users going to be able to tweak the color (and other decoration options) for specific highlightings in the VSCode Settings? Repository: rG LLVM Github Monorepo CHANGES SINC

[PATCH] D65373: [clangd] Update features table in the docs with links to LSP extension proposals

nridge added a comment. Review ping :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65373/new/ https://reviews.llvm.org/D65373 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llv

[PATCH] D65373: [clangd] Update features table in the docs with links to LSP extension proposals

nridge updated this revision to Diff 215815. nridge added a comment. Address review comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65373/new/ https://reviews.llvm.org/D65373 Files: clang-tools-extra/docs/clangd/Features.rst Index: clang

[PATCH] D65373: [clangd] Update features table in the docs with links to LSP extension proposals

nridge marked 2 inline comments as done. nridge added inline comments. Comment at: clang-tools-extra/docs/clangd/Features.rst:260 +-++--+ -| Syntax and Semantic Coloring| No | No | +| Syntax and Semant

[PATCH] D65373: [clangd] Update features table in the docs with links to LSP extension proposals

This revision was automatically updated to reflect the committed changes. Closed by commit rL369229: [clangd] Update features table in the docs with links to LSP extension proposals (authored by nridge, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed

[PATCH] D64307: [clangd] Add a missing early return in getTypeHierarchy()

nridge created this revision. nridge added a reviewer: sammccall. Herald added subscribers: cfe-commits, kadircet, arphaman, jkorous, MaskRay, ilya-biryukov. Herald added a project: clang. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D64307 Files: clang-tools-extra/clangd/XR

[PATCH] D64308: [clangd] Implement typeHierarchy/resolve for subtypes

nridge created this revision. nridge added a reviewer: sammccall. Herald added subscribers: cfe-commits, kadircet, arphaman, jkorous, MaskRay, ilya-biryukov. Herald added a project: clang. This allows the client to resolve subtypes one level at a time. For supertypes, this is not necessary, beca

[PATCH] D64308: [clangd] Implement typeHierarchy/resolve for subtypes

nridge added a comment. This was an oversight on my part: I forgot that, when we didn't implement typeHierarchy/resolve, it was only supertypes that didn't need it; subtypes do. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64308/new/ https://revi

[PATCH] D64257: [clangd] Added highlighting for class and enum types

nridge added a comment. @jvikstrom out of curiosity, are you testing these patches against a client-side implementation of semantic highlighting? If so, which one? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64257/new/ https://reviews.llvm.org/D

[PATCH] D60953: [clangd] Respect clang-tidy suppression comments

nridge added a comment. Friendly review ping. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60953/new/ https://reviews.llvm.org/D60953 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://li

[PATCH] D61841: [clangd] Respect WarningsAsErrors configuration for clang-tidy

nridge created this revision. nridge added a reviewer: ilya-biryukov. Herald added subscribers: cfe-commits, kadircet, arphaman, jkorous, MaskRay. Herald added a project: clang. This completes the fix for https://bugs.llvm.org/show_bug.cgi?id=41218. Repository: rG LLVM Github Monorepo https:/

[PATCH] D61842: [WIP] [Not ready for review] Semantic highlighting

nridge created this revision. Herald added subscribers: cfe-commits, kadircet, arphaman, mgrang, jkorous, javed.absar, mgorny. Herald added a project: clang. nridge planned changes to this revision. Done: - Basic plumbing - Encoding of semantic highlighting tokens into the protocol format - Comp

[PATCH] D61842: [clangd] [WIP] [Not ready for review] Semantic highlighting

nridge updated this revision to Diff 199202. nridge added a comment. Add [clangd] to title Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61842/new/ https://reviews.llvm.org/D61842 Files: clang-tools-extra/clangd/CMakeLists.txt clang-tools-extr

[PATCH] D60953: [clangd] Respect clang-tidy suppression comments

nridge updated this revision to Diff 199551. nridge marked 9 inline comments as done. nridge added a comment. Address review comments, except for the derived class one, about which I have a question Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D609

[PATCH] D60953: [clangd] Respect clang-tidy suppression comments

nridge added inline comments. Comment at: clang-tools-extra/clangd/ClangdUnit.cpp:243 +// future). +class ClangdDiagnosticConsumer : public StoreDiags { +public: sammccall wrote: > Thanks, this is much cleaner. > > I think we don't need the subclass at all thoug

[PATCH] D61841: [clangd] Respect WarningsAsErrors configuration for clang-tidy

nridge updated this revision to Diff 199552. nridge marked 2 inline comments as done. nridge added a comment. Address review comment Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61841/new/ https://reviews.llvm.org/D61841 Files: clang-tools-extr

[PATCH] D61841: [clangd] Respect WarningsAsErrors configuration for clang-tidy

nridge added inline comments. Comment at: clang-tools-extra/clangd/ClangdUnit.cpp:346 + std::string CheckName = CTContext->getCheckName(Info.getID()); + if (!CheckName.empty() && WarningAsErrorFilter->contains(CheckName)) { +Level = DiagnosticsEngine::Error; ---

[PATCH] D60953: [clangd] Respect clang-tidy suppression comments

nridge updated this revision to Diff 199954. nridge marked 5 inline comments as done. nridge added a comment. Address latest review comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60953/new/ https://reviews.llvm.org/D60953 Files: clang-to

[PATCH] D61841: [clangd] Respect WarningsAsErrors configuration for clang-tidy

nridge updated this revision to Diff 199956. nridge added a comment. Update as per changes to dependent patch D60953 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61841/new/ https://reviews.llvm.org/D61841 Files:

[PATCH] D61841: [clangd] Respect WarningsAsErrors configuration for clang-tidy

nridge edited reviewers, added: sammccall; removed: ilya-biryukov. nridge added a subscriber: sammccall. nridge added a comment. Herald added a subscriber: ilya-biryukov. Changing reviewer to @sammccall as the updates to the patch are closely related to the discussion in D60953

[PATCH] D60953: [clangd] Respect clang-tidy suppression comments

nridge added a comment. Could someone merge this and D61841 now that they're approved? Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60953/new/ https://reviews.llvm.org/D60953 __

[PATCH] D60953: [clangd] Respect clang-tidy suppression comments

nridge added a comment. Thank you MaskRay! Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60953/new/ https://reviews.llvm.org/D60953 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bi

[PATCH] D59407: [clangd] Add RelationSlab

nridge updated this revision to Diff 200735. nridge added a comment. Herald added a subscriber: mgrang. Implemented discussed design approach ("Add a RelationSlab storing (subject, predicate, object) triples, intended for sparse relations") Repository: rG LLVM Github Monorepo CHANGES SINCE L

[PATCH] D59407: [clangd] Add RelationSlab

nridge updated this revision to Diff 201427. nridge marked 19 inline comments as done. nridge added a comment. Address review comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59407/new/ https://reviews.llvm.org/D59407 Files: clang-tools-ex

[PATCH] D59407: [clangd] Add RelationSlab

nridge added inline comments. Comment at: clang-tools-extra/clangd/index/Relation.cpp:19 +llvm::iterator_range +RelationSlab::lookup(const SymbolID &Subject, + index::SymbolRole Predicate) const { kadircet wrote: > I would suggest adding anoth

[PATCH] D62459: [clangd] Serialization support for RelationSlab

nridge created this revision. nridge added a reviewer: kadircet. Herald added subscribers: cfe-commits, arphaman, jkorous, MaskRay, ilya-biryukov. Herald added a project: clang. This builds on D59407 to provide YAML and RIFF serialization support. Repository:

[PATCH] D62471: [clangd] SymbolCollector support for relations

nridge created this revision. nridge added a reviewer: kadircet. Herald added subscribers: cfe-commits, arphaman, jkorous, MaskRay, ilya-biryukov. Herald added a project: clang. The only relation currently collected is RelationBaseOf, because this is all we need for type hierarchy subtypes. Addit

[PATCH] D62459: [clangd] Serialization support for RelationSlab

nridge marked an inline comment as done. nridge added inline comments. Comment at: clang-tools-extra/clangd/index/Serialization.h:81 +// Used for serializing SymbolRole as used in Relation. +enum class RelationKind : uint8_t { ChildOf = 1, BaseOf }; +llvm::Expected symbolRoleToRe

[PATCH] D56314: [clangd] Don't store completion info if the symbol is not used for code completion.

nridge added a comment. Might we want to keep some of this information for `workspace/symbol`? I mean, surely not "documentation", but perhaps "signature" and "return type"? For example, when cquery responds to `workspace/symbol`, it puts into `SymbolInformation.name` a "detailed name"

[PATCH] D67536: [WIP] [clangd] Add support for an inactive regions notification

nridge created this revision. nridge added reviewers: sammccall, ilya-biryukov, hokein. Herald added subscribers: cfe-commits, kadircet, arphaman, jkorous, MaskRay. Herald added a project: clang. nridge added a comment. This patch adds server-side support for greying out code in inactive preproce

[PATCH] D67536: [WIP] [clangd] Add support for an inactive regions notification

nridge added a comment. This patch adds server-side support for greying out code in inactive preprocessor branches (issue #132 ). I didn't write test yet. I wanted to post the patch for feedback first, to see if the general approach is ok. Reposit

[PATCH] D67537: [WIP] [clangd] Client-side support for inactive regions

nridge created this revision. Herald added subscribers: cfe-commits, kadircet, arphaman, jkorous, MaskRay, ilya-biryukov. Herald added a project: clang. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D67537 Files: clang-tools-extra/clangd/clients/clangd-vscode/src/extension.ts

[PATCH] D67537: [WIP] [clangd] Client-side support for inactive regions

nridge added a comment. This is not for review yet, I'm just posting it to illustrate the client side of D67536 . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67537/new/ https://reviews.llvm.org/D67537

[PATCH] D67536: [WIP] [clangd] Add support for an inactive regions notification

nridge added a comment. For reference, I also posted a proof-of-concept client impl in D67537 , which I used to test/validate this patch. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67536/new/ https://reviews.llv

[PATCH] D67536: [WIP] [clangd] Add support for an inactive regions notification

nridge planned changes to this revision. nridge added a comment. Ok, I can try formulating this as part of / an extension to semantic highlighting. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67536/new/ https://reviews.llvm.org/D67536 ___

[PATCH] D67358: [clangd] Implement semantic selections.

nridge added a comment. Which LSP feature is this related to? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67358/new/ https://reviews.llvm.org/D67358 ___ cfe-commits mailing list cfe-commits@lists.llv

[PATCH] D67901: [clangd] Improve semantic highlighting in dependent contexts (fixes #154)

nridge created this revision. nridge added a reviewer: hokein. Herald added subscribers: cfe-commits, usaxena95, kadircet, arphaman, jkorous, MaskRay, ilya-biryukov. Herald added a project: clang. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D67901 Files: clang-tools-extra/c

[PATCH] D67901: [clangd] Improve semantic highlighting in dependent contexts (fixes #154)

nridge marked an inline comment as done. nridge added inline comments. Comment at: clang-tools-extra/clangd/SemanticHighlighting.cpp:181 + addToken(E->getMemberLoc(), E->getQualifier() + ? HighlightingKind::StaticField +

[PATCH] D67901: [clangd] Improve semantic highlighting in dependent contexts (fixes #154)

nridge updated this revision to Diff 221583. nridge added a comment. Updated to use a new "dependent type" highlighting Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67901/new/ https://reviews.llvm.org/D67901 Files: clang-tools-extra/clangd/Sema

[PATCH] D67901: [clangd] Improve semantic highlighting in dependent contexts (fixes #154)

nridge marked 2 inline comments as done. nridge added inline comments. Comment at: clang-tools-extra/clangd/SemanticHighlighting.cpp:181 + addToken(E->getMemberLoc(), E->getQualifier() + ? HighlightingKind::StaticField +

[PATCH] D67901: [clangd] Improve semantic highlighting in dependent contexts (fixes #154)

nridge updated this revision to Diff 222333. nridge added a comment. Address review comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67901/new/ https://reviews.llvm.org/D67901 Files: clang-tools-extra/clangd/SemanticHighlighting.cpp clan

[PATCH] D67901: [clangd] Improve semantic highlighting in dependent contexts (fixes #154)

nridge added a comment. I do feel strongly that types and non-types should be highlighted differently, so the updated patch adds two new dependent highlightings, one for types and one for variables/functions. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.ll

[PATCH] D67536: [WIP] [clangd] Add support for an inactive regions notification

nridge updated this revision to Diff 222336. nridge added a comment. Herald added subscribers: usaxena95, mgrang. Reformulate as an extension to semantic highlighting Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67536/new/ https://reviews.llvm.org

[PATCH] D67537: [WIP] [clangd] Client-side support for inactive regions

nridge updated this revision to Diff 222337. nridge added a comment. Herald added a subscriber: usaxena95. Update to reflect changes to server side in D67536 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67537/new/

[PATCH] D67536: [WIP] [clangd] Add support for an inactive regions notification

nridge added a comment. The updated patch formulates this as a new semantic highlighting kind. The tokens created for inactive regions are one per line, with the character offset and length being zero; the idea is that the client will handle this highlighting specially (see D67537

[PATCH] D66990: [clangd] Add distinct highlightings for declarations of functions and methods

nridge added a comment. Herald added a subscriber: usaxena95. In D66990#1656230 , @nridge wrote: > >> I think the way cquery does it > >>

[PATCH] D67901: [clangd] Improve semantic highlighting in dependent contexts (fixes #154)

nridge added inline comments. Comment at: clang-tools-extra/clangd/SemanticHighlighting.cpp:219 + bool VisitDependentNameTypeLoc(DependentNameTypeLoc L) { +addToken(L.getNameLoc(), HighlightingKind::DependentType); +return true; hokein wrote: > nit: we h

[PATCH] D67901: [clangd] Improve semantic highlighting in dependent contexts (fixes #154)

nridge updated this revision to Diff 222725. nridge marked 9 inline comments as done. nridge added a comment. Address review comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67901/new/ https://reviews.llvm.org/D67901 Files: clang-tools-ext

[PATCH] D67901: [clangd] Improve semantic highlighting in dependent contexts (fixes #154)

nridge marked 2 inline comments as done. nridge added inline comments. Comment at: clang-tools-extra/clangd/SemanticHighlighting.cpp:219 + bool VisitDependentNameTypeLoc(DependentNameTypeLoc L) { +addToken(L.getNameLoc(), HighlightingKind::DependentType); +return true; -

[PATCH] D67536: [WIP] [clangd] Add support for an inactive regions notification

nridge marked an inline comment as done. nridge added a comment. In D67536#1691107 , @hokein wrote: > Could you add tests for this? Certainly, I just wanted to discuss the general approach first, as it will affect what the tests look like. ==

[PATCH] D67536: [WIP] [clangd] Add support for an inactive regions notification

nridge added a comment. In D67536#1694098 , @MaskRay wrote: > Why "inactive region", not "skipped ranges"? I got the name from "$cquery/publishInactiveRegions" :) But I don't particularly care what we call it. Repository: rG LLVM Github Monorepo CH

[PATCH] D67536: [WIP] [clangd] Add support for an inactive regions notification

nridge updated this revision to Diff 223577. nridge added a comment. Update to use `PPCallbacks::SourceRangeSkipped` Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67536/new/ https://reviews.llvm.org/D67536 Files: clang-tools-extra/clangd/ParsedA

[PATCH] D67536: [WIP] [clangd] Add support for an inactive regions notification

nridge marked 5 inline comments as done. nridge added inline comments. Comment at: clang-tools-extra/clangd/Compiler.cpp:66 CI->getLangOpts()->CommentOpts.ParseAllComments = true; + CI->getPreprocessorOpts().DetailedRecord = true; return CI; ilya-biryukov

[PATCH] D67536: [WIP] [clangd] Add support for an inactive regions notification

nridge marked 2 inline comments as done. nridge added a comment. How would one even measure the line length? `SourceManager` doesn't sem to have a method like `getLineLength()` or similar. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67536/new/ h

[PATCH] D67536: [WIP] [clangd] Add support for an inactive regions notification

nridge added a comment. One thing that may be worth considering as well, is that if the client prefers to highlight the text of the line only, it can calculate the length of the line itself. In VSCode for instance, the line lengths are readily available; I imagine other editors are similar sinc

[PATCH] D67536: [WIP] [clangd] Add support for an inactive regions notification

nridge planned changes to this revision. nridge marked an inline comment as done. nridge added inline comments. Comment at: clang-tools-extra/clangd/SemanticHighlighting.cpp:152 + // Don't bother computing the offset for the end of the line, just use + // zero.

[PATCH] D67536: [WIP] [clangd] Add support for an inactive regions notification

nridge added a comment. In D67536#1699221 , @ilya-biryukov wrote: > I have actually seen clients that just make the text gray and it looks pretty > nice (ReSharper for Visual Studio and IntelliJ IDEA definitely do that). I don't think there is a confli

[PATCH] D67536: [WIP] [clangd] Add support for an inactive regions notification

nridge added a comment. In D67536#1701038 , @ilya-biryukov wrote: > In D67536#1700872 , @nridge wrote: > > > > It also lets them consistently highlight part of the line (e.g. dead > > > expressions or statements c

[PATCH] D67901: [clangd] Improve semantic highlighting in dependent contexts (fixes #154)

nridge updated this revision to Diff 224241. nridge added a comment. Updated to use WalkUpFromDependentNameTypeLoc Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67901/new/ https://reviews.llvm.org/D67901 Files: clang-tools-extra/clangd/SemanticH

<    1   2   3   4   5   6   7   8   9   10   >