nridge marked 5 inline comments as done.
nridge added inline comments.
================
Comment at: clang-tools-extra/clangd/Compiler.cpp:66
CI->getLangOpts()->CommentOpts.ParseAllComments = true;
+ CI->getPreprocessorOpts().DetailedRecord = true;
return CI;
----------------
ilya-biryukov wrote:
> hokein wrote:
> > I'm not sure how does this flag impact the size of Preamble/AST,
> > @ilya-biryukov any thoughts?
> Have no idea, but why do we need this in the first place?
> `PPCallbacks::SourceRangeSkipped` should allow to record all skipped ranges
> in the main file. Can we use it?
Yes, `PPCallbacks::SourceRangeSkipped` works in place of using
`DetailedRecord`. Thank you for the suggestion.
================
Comment at: clang-tools-extra/clangd/SemanticHighlighting.h:43
Primitive,
+ InactivePreprocessorBranch,
Macro,
----------------
hokein wrote:
> This is a different kind group, I would put it after the Macro, we'd need to
> update the LastKind.
>
> The name seems too specific, how about "UnreachableCode"?
I changed it to "InactiveCode". ("Unreachable" seemed like the wrong word, it
brings to mind control flow.)
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D67536/new/
https://reviews.llvm.org/D67536
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
