nridge added a comment. In D67536#1699221 <https://reviews.llvm.org/D67536#1699221>, @ilya-biryukov wrote:
> I have actually seen clients that just make the text gray and it looks pretty > nice (ReSharper for Visual Studio and IntelliJ IDEA definitely do that). I don't think there is a conflict between this style, and using line highlightings: if the style being applied is a foreground color (gray text) as opposed to a background color, then it will look the same regardless of whether you apply it as a line style, or as a character range style. > It also lets them consistently highlight part of the line (e.g. dead > expressions or statements can be marked in gray even if they are on the same > line). Highlighting part of a line is not applicable to inactive preprocessor branches in C++. If we later introduce highlightings for dead expressions or statements, we can of course use character ranges and not lines for them. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67536/new/ https://reviews.llvm.org/D67536 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
