[PATCH] D51013: [WebAssembly] Revert type of wake count in atomic.wake to i32

aheejin created this revision. aheejin added a reviewer: dschuff. Herald added subscribers: cfe-commits, jfb, sunfish, jgravelle-google, sbc100. We decided to revert this from i64 to i32 in Nov 28 CG meeting. Fixes PR38632. Repository: rC Clang https://reviews.llvm.org/D51013 Files: includ

[PATCH] D51013: [WebAssembly] Revert type of wake count in atomic.wake to i32

This revision was automatically updated to reflect the committed changes. Closed by commit rC340235: [WebAssembly] Revert type of wake count in atomic.wake to i32 (authored by aheejin, committed by ). Changed prior to commit: https://reviews.llvm.org/D51013?vs=161615&id=161620#toc Repository:

[PATCH] D44931: [WebAssembly] Use Windows EH instructions for Wasm EH

aheejin updated this revision to Diff 146076. aheejin added a comment. - getMSVCDispatchBlock -> getFuncletEHDispatchBlock Repository: rC Clang https://reviews.llvm.org/D44931 Files: lib/CodeGen/CGCXXABI.h lib/CodeGen/CGCleanup.cpp lib/CodeGen/CGCleanup.h lib/CodeGen/CGException.cpp

[PATCH] D46906: [clangd] Fix a link failure in unittests

aheejin created this revision. aheejin added a reviewer: sammccall. Herald added subscribers: cfe-commits, jkorous, MaskRay, ioeric, ilya-biryukov, mgorny, klimek. aheejin edited the summary of this revision. https://reviews.llvm.org/D46524 (https://reviews.llvm.org/rL332378) introduced a link f

[PATCH] D46906: [clangd] Fix a link failure in unittests

This revision was automatically updated to reflect the committed changes. Closed by commit rL332438: [clangd] Fix a link failure in unittests (authored by aheejin, committed by ). Herald added a subscriber: llvm-commits. Repository: rL LLVM https://reviews.llvm.org/D46906 Files: clang-tools

[PATCH] D44931: [WebAssembly] Use Windows EH instructions for Wasm EH

aheejin updated this revision to Diff 147287. aheejin marked an inline comment as done. aheejin added a comment. `CatchStartBlock` -> `WasmCatchStartBlock` Repository: rC Clang https://reviews.llvm.org/D44931 Files: lib/CodeGen/CGCXXABI.h lib/CodeGen/CGCleanup.cpp lib/CodeGen/CGCleanup

[PATCH] D44931: [WebAssembly] Use Windows EH instructions for Wasm EH

aheejin added a comment. Thank you for the reviews! Comment at: lib/CodeGen/CGException.cpp:1173 +cast(CatchStartBlock->getFirstNonPHI()); +CurrentFuncletPad = CPI; + } majnemer wrote: > Hmm, why is this done? Won't RestoreCurrentFuncletPad undo th

[PATCH] D44931: [WebAssembly] Use Windows EH instructions for Wasm EH

aheejin added inline comments. Comment at: lib/CodeGen/CGException.cpp:1241-1245 +while (llvm::TerminatorInst *TI = RethrowBlock->getTerminator()) { + llvm::BranchInst *BI = cast(TI); + assert(BI->isConditional()); + RethrowBlock = BI->getSuccessor(1); +} -

[PATCH] D44931: [WebAssembly] Use Windows EH instructions for Wasm EH

aheejin updated this revision to Diff 147695. aheejin added a comment. - Make `wasm.get.exception/selector` intrinsics take a token argument Repository: rC Clang https://reviews.llvm.org/D44931 Files: lib/CodeGen/CGCXXABI.h lib/CodeGen/CGCleanup.cpp lib/CodeGen/CGCleanup.h lib/CodeGe

[PATCH] D44931: [WebAssembly] Use Windows EH instructions for Wasm EH

aheejin updated this revision to Diff 147696. aheejin added a comment. Test case fix was missing in the last commit Repository: rC Clang https://reviews.llvm.org/D44931 Files: lib/CodeGen/CGCXXABI.h lib/CodeGen/CGCleanup.cpp lib/CodeGen/CGCleanup.h lib/CodeGen/CGException.cpp lib/C

[PATCH] D44931: [WebAssembly] Use Windows EH instructions for Wasm EH

aheejin added inline comments. Comment at: lib/CodeGen/CGException.cpp:1241-1245 +while (llvm::TerminatorInst *TI = RethrowBlock->getTerminator()) { + llvm::BranchInst *BI = cast(TI); + assert(BI->isConditional()); + RethrowBlock = BI->getSuccessor(1); +} -

[PATCH] D44931: [WebAssembly] Use Windows EH instructions for Wasm EH

aheejin added a comment. Thanks! No, it does not depend on the other CL chain on the llvm side. Repository: rC Clang https://reviews.llvm.org/D44931 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/lis

[PATCH] D44931: [WebAssembly] Use Windows EH instructions for Wasm EH

aheejin added a comment. Oh no, sorry, it actually depends on https://reviews.llvm.org/D43746; but not others on the chain. I changed the signatures of `wasm.get.exception` and `wasm.get.ehselector` intrinsics to take a token argument, and the intrinsic signature change is added in https://revi

[PATCH] D51448: [WebAssembly] clang-format (NFC)

aheejin created this revision. Herald added subscribers: cfe-commits, jfb, sunfish, jgravelle-google, sbc100, dschuff. This patch runs clang-format on all wasm-only files. Repository: rC Clang https://reviews.llvm.org/D51448 Files: lib/Driver/ToolChains/WebAssembly.cpp lib/Driver/ToolCh

[PATCH] D51448: [WebAssembly] clang-format (NFC)

aheejin added a comment. Ping! Can we land this because this is fairly small? Repository: rC Clang https://reviews.llvm.org/D51448 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D51448: [WebAssembly] clang-format (NFC)

aheejin added a comment. Ping pong Repository: rC Clang https://reviews.llvm.org/D51448 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D51448: [WebAssembly] clang-format (NFC)

This revision was automatically updated to reflect the committed changes. Closed by commit rC341254: [WebAssembly] clang-format (NFC) (authored by aheejin, committed by ). Changed prior to commit: https://reviews.llvm.org/D51448?vs=163152&id=163590#toc Repository: rL LLVM https://reviews.ll

[PATCH] D51448: [WebAssembly] clang-format (NFC)

This revision was automatically updated to reflect the committed changes. Closed by commit rL341254: [WebAssembly] clang-format (NFC) (authored by aheejin, committed by ). Herald added a subscriber: llvm-commits. Repository: rL LLVM https://reviews.llvm.org/D51448 Files: cfe/trunk/lib/Drive

[PATCH] D49629: [CMake] Fix the setting of LIBCXX_HEADER_DIR

aheejin created this revision. aheejin added a reviewer: phosek. Herald added subscribers: cfe-commits, ldionne, christof, mgorny. Repository: rCXX libc++ https://reviews.llvm.org/D49629 Files: CMakeLists.txt Index: CMakeLists.txt ===

[PATCH] D49629: [CMake] Fix the setting of LIBCXX_HEADER_DIR

aheejin added a comment. This line was added in https://reviews.llvm.org/rL335809, and after https://reviews.llvm.org/rL337630 `dst` in this line is set to NULL in our

[PATCH] D49629: [CMake] Fix the setting of LIBCXX_HEADER_DIR

aheejin added a comment. Ping Repository: rCXX libc++ https://reviews.llvm.org/D49629 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D49629: [CMake] Fix the setting of LIBCXX_HEADER_DIR

This revision was automatically updated to reflect the committed changes. Closed by commit rL337727: [CMake] Fix the setting of LIBCXX_HEADER_DIR (authored by aheejin, committed by ). Herald added a subscriber: llvm-commits. Repository: rL LLVM https://reviews.llvm.org/D49629 Files: libcxx/

[PATCH] D49711: [CMake] Fix the setting of LIBCXX_HEADER_DIR in standalone build

aheejin added a comment. This fixes our local waterfall build failure. Thank you! Repository: rCXX libc++ https://reviews.llvm.org/D49711 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-c

[PATCH] D49396: [WebAssembly] Support for atomic.wait / atomic.wake builtins

aheejin updated this revision to Diff 158017. aheejin added a comment. Herald added a subscriber: jfb. - Changed the first argument of wake from i8* to i32* Repository: rC Clang https://reviews.llvm.org/D49396 Files: include/clang/Basic/BuiltinsWebAssembly.def lib/CodeGen/CGBuiltin.cpp

[PATCH] D49396: [WebAssembly] Support for atomic.wait / atomic.wake builtins

aheejin updated this revision to Diff 158434. aheejin marked an inline comment as done. aheejin added a comment. - Changed types Repository: rC Clang https://reviews.llvm.org/D49396 Files: include/clang/Basic/BuiltinsWebAssembly.def lib/CodeGen/CGBuiltin.cpp test/CodeGen/builtins-wasm.

[PATCH] D49396: [WebAssembly] Support for atomic.wait / atomic.wake builtins

aheejin added inline comments. Comment at: include/clang/Basic/BuiltinsWebAssembly.def:38 +// Atomic wait and wake. +BUILTIN(__builtin_wasm_atomic_wait_i32, "Uii*iLLi", "n") +BUILTIN(__builtin_wasm_atomic_wait_i64, "UiLLi*LLiLLi", "n") dschuff wrote: > So this me

[PATCH] D49396: [WebAssembly] Support for atomic.wait / atomic.wake builtins

aheejin updated this revision to Diff 158555. aheejin added a comment. - wake -> notify Repository: rC Clang https://reviews.llvm.org/D49396 Files: include/clang/Basic/BuiltinsWebAssembly.def lib/CodeGen/CGBuiltin.cpp test/CodeGen/builtins-wasm.c Index: test/CodeGen/builtins-wasm.c =

[PATCH] D49396: [WebAssembly] Support for atomic.wait / atomic.wake builtins

This revision was automatically updated to reflect the committed changes. Closed by commit rL338771: [WebAssembly] Support for atomic.wait / atomic.wake builtins (authored by aheejin, committed by ). Herald added a subscriber: llvm-commits. Repository: rL LLVM https://reviews.llvm.org/D49396

[PATCH] D43437: Fix link failures for Preprocessor::addCommentHandler

aheejin created this revision. aheejin added a reviewer: ioeric. Herald added subscribers: cfe-commits, jkorous-apple, ilya-biryukov, mgorny, klimek. https://reviews.llvm.org/D42640 adds calls to `Preprocessor::addCommentHandler` in `unittests/clangd/SymbolCollectorTests.cpp` and `clangd/global-

[PATCH] D43437: [clangd] Fix link failures for Preprocessor::addCommentHandler

This revision was automatically updated to reflect the committed changes. Closed by commit rL325458: [clangd] Fix link failures for Preprocessor::addCommentHandler (authored by aheejin, committed by ). Herald added a subscriber: llvm-commits. Repository: rL LLVM https://reviews.llvm.org/D43437

[PATCH] D43681: [WebAssembly] Add exception handling option

aheejin created this revision. aheejin added a reviewer: dschuff. Herald added subscribers: cfe-commits, sunfish, jgravelle-google, sbc100, jfb. Add exception handling option to clang. Repository: rC Clang https://reviews.llvm.org/D43681 Files: docs/ClangCommandLineReference.rst include/

[PATCH] D43681: [WebAssembly] Add exception handling option

This revision was automatically updated to reflect the committed changes. Closed by commit rL326517: [WebAssembly] Add exception handling option (authored by aheejin, committed by ). Herald added a subscriber: llvm-commits. Repository: rL LLVM https://reviews.llvm.org/D43681 Files: cfe/trun

[PATCH] D44931: [WebAssembly] Use Windows EH instructions for Wasm EH

This revision was automatically updated to reflect the committed changes. Closed by commit rL333703: [WebAssembly] Use Windows EH instructions for Wasm EH (authored by aheejin, committed by ). Herald added a subscriber: llvm-commits. Repository: rL LLVM https://reviews.llvm.org/D44931 Files:

[PATCH] D47614: [WebAssembly] Hide new Wasm EH behind its feature flag

aheejin created this revision. aheejin added reviewers: dschuff, majnemer. Herald added subscribers: cfe-commits, sunfish, jgravelle-google, sbc100. clang's current wasm EH implementation is a non-MVP feature in progress. We had a `-mexception-handling` wasm feature but were not using it. This pat

[PATCH] D47614: [WebAssembly] Hide new Wasm EH behind its feature flag

aheejin updated this revision to Diff 149386. aheejin added a comment. - Add a missing conditional statement. I'll still assume this as accepted Repository: rC Clang https://reviews.llvm.org/D47614 Files: lib/CodeGen/CGException.cpp lib/CodeGen/ItaniumCXXABI.cpp test/CodeGenCXX/wasm-eh

[PATCH] D47614: [WebAssembly] Hide new Wasm EH behind its feature flag

This revision was automatically updated to reflect the committed changes. Closed by commit rC333716: [WebAssembly] Hide new Wasm EH behind its feature flag (authored by aheejin, committed by ). Changed prior to commit: https://reviews.llvm.org/D47614?vs=149386&id=149387#toc Repository: rC Cl

[PATCH] D47620: Remove llvm::Triple argument from get***Personality() functions

aheejin created this revision. aheejin added a reviewer: sbc100. Herald added a subscriber: cfe-commits. Because `llvm::Triple` can be derived from `TargetInfo`, it is simpler to take only `TargetInfo` argument. Repository: rC Clang https://reviews.llvm.org/D47620 Files: lib/CodeGen/CGExce

[PATCH] D47614: [WebAssembly] Hide new Wasm EH behind its feature flag

aheejin marked an inline comment as done. aheejin added inline comments. Comment at: lib/CodeGen/CGException.cpp:322 const EHPersonality &CXX = - getCXXPersonality(getTarget().getTriple(), LangOpts); + getCXXPersonality(getTarget().getTriple(), LangOpts, getTarget())

[PATCH] D47620: Remove llvm::Triple argument from get***Personality() functions. NFC.

aheejin added a comment. @sbc100 ping :) Repository: rC Clang https://reviews.llvm.org/D47620 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D47732: [clang-doc] Add BitReader to LLVM_LINK_COMPONENTS

aheejin created this revision. aheejin added a reviewer: juliehockett. Herald added subscribers: cfe-commits, mgorny, klimek. Without this, build with `-DSHARED_LIB=ON` fails. Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D47732 Files: clang-doc/CMakeLists.txt Index: clang-

[PATCH] D47732: [clang-doc] Add BitReader to LLVM_LINK_COMPONENTS

aheejin abandoned this revision. aheejin added a comment. Oh I see, thanks! Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D47732 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/

[PATCH] D47620: Remove llvm::Triple argument from get***Personality() functions. NFC.

This revision was automatically updated to reflect the committed changes. Closed by commit rC333938: Remove llvm::Triple argument from get***Personality() functions. NFC. (authored by aheejin, committed by ). Changed prior to commit: https://reviews.llvm.org/D47620?vs=149406&id=149814#toc Repo

[PATCH] D48443: [WIP] Add no-prototype attribute to prototype-less C functions

aheejin added inline comments. Comment at: lib/CodeGen/CGCall.cpp:1849 + if (!AttrOnCallSite && !Fn->hasPrototype()) +FuncAttrs.addAttribute("no-prototype"); AddAttributesFromFunctionProtoType( Is there a reason why this is not something like

[PATCH] D53685: [WebAssembly] Bitselect and min/max builtins

aheejin added inline comments. Comment at: include/clang/Basic/BuiltinsWebAssembly.def:85 +BUILTIN(__builtin_wasm_bitselect, "V4iV4iV4iV4i", "nc") + Do you think we need to provide this builtin also for other vector types? Repository: rC Clang https://revi

[PATCH] D53724: [WebAssembly] Fix type names in truncation builtins

aheejin added inline comments. Comment at: lib/CodeGen/CGBuiltin.cpp:12528 + case WebAssembly::BI__builtin_wasm_trunc_saturate_s_f32x4: + case WebAssembly::BI__builtin_wasm_trunc_saturate_s_f64x2: { Value *Src = EmitScalarExpr(E->getArg(0)); But unlike oth

[PATCH] D53724: [WebAssembly] Fix type names in truncation builtins

aheejin added inline comments. Comment at: lib/CodeGen/CGBuiltin.cpp:12528 + case WebAssembly::BI__builtin_wasm_trunc_saturate_s_f32x4: + case WebAssembly::BI__builtin_wasm_trunc_saturate_s_f64x2: { Value *Src = EmitScalarExpr(E->getArg(0)); tlively wrote:

[PATCH] D53675: [WebAssembly] Lower select for vectors

aheejin added a comment. The commit here looks like replaced with that of https://reviews.llvm.org/D53724. Repository: rC Clang https://reviews.llvm.org/D53675 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin

[PATCH] D53675: [WebAssembly] Lower select for vectors

aheejin added a comment. I tried to add `ISD::SELECT` in the expansion list, like for (auto Op : {ISD::VSELECT, ISD::SELECT_CC, ISD::SELECT}) { ... } And the code generation apparently works for current test `simd-select.ll`. I'm not sure if it's optimal though. Could you check again?

[PATCH] D54572: [WebAssembly] Change type of wake count to unsigned int

aheejin created this revision. aheejin added a reviewer: dschuff. Herald added subscribers: cfe-commits, jfb, sunfish, jgravelle-google, sbc100. We discussed this at the Nov 12th CG meeting, and decided to use the unsigned semantics for the wake count. Corresponding spec change: https://github.com

[PATCH] D54572: [WebAssembly] Change type of wake count to unsigned int

This revision was automatically updated to reflect the committed changes. Closed by commit rL347005: [WebAssembly] Change type of wake count to unsigned int (authored by aheejin, committed by ). Herald added a subscriber: llvm-commits. Repository: rL LLVM https://reviews.llvm.org/D54572 Files

[PATCH] D54572: [WebAssembly] Change type of wake count to unsigned int

This revision was automatically updated to reflect the committed changes. Closed by commit rC347005: [WebAssembly] Change type of wake count to unsigned int (authored by aheejin, committed by ). Changed prior to commit: https://reviews.llvm.org/D54572?vs=174169&id=174302#toc Repository: rL L

[PATCH] D58742: [WebAssembly] Remove uses of ThreadModel

aheejin accepted this revision. aheejin added a comment. This looks a nice improvement! Thank you. Comment at: clang/include/clang/Driver/ToolChain.h:456 /// getThreadModel() - Which thread model does this target use? - virtual std::string getThreadModel(const llvm::opt::Ar

[PATCH] D58742: [WebAssembly] Remove uses of ThreadModel

aheejin added inline comments. Comment at: clang/include/clang/Driver/ToolChain.h:456 /// getThreadModel() - Which thread model does this target use? - virtual std::string getThreadModel(const llvm::opt::ArgList &) const { -return "posix"; - } + virtual std::string getT

[PATCH] D59353: [WebAssembly] Use rethrow intrinsic in the rethrow block

aheejin created this revision. aheejin added a reviewer: dschuff. Herald added subscribers: cfe-commits, sunfish, jgravelle-google, sbc100. Herald added a project: clang. Because in wasm we merge all catch clauses into one big catchpad, in case none of the types in catch handlers matches after we

[PATCH] D59353: [WebAssembly] Use rethrow intrinsic in the rethrow block

This revision was automatically updated to reflect the committed changes. Closed by commit rC356317: [WebAssembly] Use rethrow intrinsic in the rethrow block (authored by aheejin, committed by ). Changed prior to commit: https://reviews.llvm.org/D59353?vs=190587&id=190947#toc Repository: rC

[PATCH] D59448: [WebAssembly] Change wasm.throw intrinsic's first argument to immediate

aheejin created this revision. aheejin added a reviewer: dschuff. Herald added subscribers: cfe-commits, sunfish, jgravelle-google, sbc100. Herald added a project: clang. After D57825 (r355981), intrinsic arguments that are marked as `ImmArg` only can take immedi

[PATCH] D59448: [WebAssembly] Change wasm.throw's first argument to an immediate

aheejin added a comment. In D59448#1433607 , @dschuff wrote: > LGTM; I wonder if it makes sense to have predefined macro for the C++ tag (or > perhaps just a regular macro for use in libcxxabi?) The only place the `throw` builtin will be used in within

[PATCH] D59448: [WebAssembly] Change wasm.throw's first argument to an immediate

aheejin added a comment. In D59448#1433622 , @craig.topper wrote: > Shouldn't the definition in BuiltinsWebAssembly.def be updated to include an > 'I' in the type string so that this will be properly diagnosed in the > frontend? Done. Thank you for ch

[PATCH] D59448: [WebAssembly] Change wasm.throw's first argument to an immediate

aheejin updated this revision to Diff 191240. aheejin added a comment. - Add `I` to `wasm.throw` builtin's tag argument Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59448/new/ https://reviews.llvm.org/D59448 Files: include/clang/Basic/BuiltinsWebAssembly.def

[PATCH] D59448: [WebAssembly] Change wasm.throw's first argument to an immediate

This revision was automatically updated to reflect the committed changes. Closed by commit rC356436: [WebAssembly] Change wasm.throw's first argument to an immediate (authored by aheejin, committed by ). Changed prior to commit: https://reviews.llvm.org/D59448?vs=191240&id=191241#toc Repositor

[PATCH] D59827: [slh] x86 impl of ARM instrinsic for SLH

aheejin added inline comments. Comment at: clang/test/Preprocessor/init.c:9678 // WEBASSEMBLY-NEXT:#define __GXX_ABI_VERSION 1002 +// WEBASSEMBLY-NEXT: #define __HAVE_SPECULATION_SAFE_VALUE 1 // WEBASSEMBLY32-NEXT:#define __ILP32__ 1 Nit: Remove the whitespace

[PATCH] D52852: [WebAssembly] __builtin_wasm_extract_lane_* builtins

aheejin added inline comments. Comment at: include/clang/Basic/BuiltinsWebAssembly.def:46 +BUILTIN(__builtin_wasm_extract_lane_s_i16x8, "iV8sIi", "ncV:128:") +BUILTIN(__builtin_wasm_extract_lane_u_i16x8, "iV8sIi", "ncV:128:") +BUILTIN(__builtin_wasm_extract_lane_i32x4, "iV4iIi",

[PATCH] D52856: [WebAssembly] __builtin_wasm_replace_lane_* builtins

aheejin added inline comments. Comment at: include/clang/Basic/BuiltinsWebAssembly.def:55 +BUILTIN(__builtin_wasm_replace_lane_i32x4, "V4iV4iIii", "ncV:128:") +BUILTIN(__builtin_wasm_replace_lane_i64x2, "V2WiV2WiIiWi", "ncV:128:") +BUILTIN(__builtin_wasm_replace_lane_f32x4, "V4fV

[PATCH] D53007: [WebAssembly][NFC] Rename test functions for builtins

aheejin accepted this revision. aheejin added a comment. This revision is now accepted and ready to land. A lot better this way! Thanks. Repository: rC Clang https://reviews.llvm.org/D53007 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D57798: [WebAssembly] Add atomics target option

aheejin created this revision. aheejin added a reviewer: tlively. Herald added subscribers: cfe-commits, jfb, sunfish, jgravelle-google, sbc100, dschuff. Herald added a project: clang. Repository: rC Clang https://reviews.llvm.org/D57798 Files: include/clang/Driver/Options.td lib/Basic/Ta

[PATCH] D57798: [WebAssembly] Add atomics target option

aheejin updated this revision to Diff 185454. aheejin added a comment. - Fix typo Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57798/new/ https://reviews.llvm.org/D57798 Files: include/clang/Driver/Options.td lib/Basic/Targets/WebAssembly.cpp lib/Basic/Ta

[PATCH] D57798: [WebAssembly] Add atomics target option

This revision was automatically updated to reflect the committed changes. Closed by commit rL353260: [WebAssembly] Add atomics target option (authored by aheejin, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Repository: rL LLVM CHANGES SINCE LAST ACTIO

[PATCH] D57798: [WebAssembly] Add atomics target option

aheejin added a comment. In D57798#1386470 , @sbc100 wrote: > How does this relate to the existing ` -mattr=+atomics` of llc? Will it also > result in `attributes #0 = { "target-features"="+atomics" }` in the bitcode? Yes Repository: rL LLVM CHAN

[PATCH] D57874: [WebAssembly] Set '-matomics' when '-pthread' is set

aheejin created this revision. aheejin added a reviewer: dschuff. Herald added subscribers: cfe-commits, jfb, sunfish, jgravelle-google, sbc100. Herald added a project: clang. In wasm, we always use '-matomics' when we use '-pthread'. This will make users type one less option and options will be m

[PATCH] D57874: [WebAssembly] Set '-matomics' when '-pthread' is set

aheejin updated this revision to Diff 185700. aheejin added a comment. - Small fix Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57874/new/ https://reviews.llvm.org/D57874 Files: lib/Frontend/CompilerInvocation.cpp test/Driver/wasm32-unknown-unknown.cpp te

[PATCH] D57874: [WebAssembly] Set '-matomics' when '-pthread' is set

aheejin updated this revision to Diff 185895. aheejin added a comment. Sorry nevermind my previous code. There was not hacky and much cleaner way to do everything in the driver layer. (Before I tried to do everything in the cc1 compilation layer :( ) Anyway, moved all logic to the driver layer

[PATCH] D57874: [WebAssembly] Set '-matomics' when '-pthread' is set

aheejin marked an inline comment as done. aheejin added inline comments. Comment at: lib/Driver/ToolChains/WebAssembly.cpp:66 +if (Args.hasFlag(clang::driver::options::OPT_pthread, + clang::driver::options::OPT_no_pthread), +false)

[PATCH] D57874: [WebAssembly] Make thread-related options consistent

aheejin updated this revision to Diff 186063. aheejin added a comment. - Fix some bugs - Make the driver error out when explicitly given options don't match, such as `-no-pthread` and `-matomics` are given at the same time Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm

[PATCH] D57874: [WebAssembly] Make thread-related options consistent

aheejin marked an inline comment as done. aheejin added inline comments. Comment at: lib/Driver/ToolChains/WebAssembly.cpp:66 +if (Args.hasFlag(clang::driver::options::OPT_pthread, + clang::driver::options::OPT_no_pthread), +false)

[PATCH] D57874: [WebAssembly] Make thread-related options consistent

aheejin updated this revision to Diff 186065. aheejin added a comment. - Small fix Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57874/new/ https://reviews.llvm.org/D57874 Files: include/clang/Driver/ToolChain.h lib/Driver/Driver.cpp lib/Driver/ToolChains/

[PATCH] D57874: [WebAssembly] Make thread-related options consistent

aheejin added a comment. In D57874#1389981 , @sunfish wrote: > > - `-matomics` means `-mthread-model posix` > > The others sound reasonable, though this one seems a little surprising -- a > user might have -matomics enabled because they're targeting a VM

[PATCH] D57874: [WebAssembly] Make thread-related options consistent

aheejin updated this revision to Diff 186068. aheejin added a comment. - Initialized ThreadModel vairables with "" Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57874/new/ https://reviews.llvm.org/D57874 Files: include/clang/Driver/ToolChain.h lib/Driver/Dri

[PATCH] D57874: [WebAssembly] Make thread-related options consistent

aheejin added a comment. I only added those test routines in `wasm-toolchain.c` and not `wasm-toolchain.cpp`, because they are basically the same. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57874/new/ https://reviews.llvm.org/D57874 ___

[PATCH] D57874: [WebAssembly] Make thread-related options consistent

aheejin added a comment. In D57874#1391133 , @tlively wrote: > In D57874#1389953 , @aheejin wrote: > > > Anyway, moved all logic to the driver layer and did this: > > > > - `-matomics` means `-mthread-model posix` >

[PATCH] D57874: [WebAssembly] Make thread-related options consistent

aheejin updated this revision to Diff 186088. aheejin marked 8 inline comments as done. aheejin added a comment. I had an offline discussion with @tlively and @dschuff and decided to remove `-atomics` option in the driver. Instead, `clang -cc1`'s `-target-feature +atomics` will be either of `-pt

[PATCH] D57874: [WebAssembly] Make thread-related options consistent

aheejin added a comment. In D57874#1389981 , @sunfish wrote: > > - `-matomics` means `-mthread-model posix` > > The others sound reasonable, though this one seems a little surprising -- a > user might have -matomics enabled because they're targeting a VM

[PATCH] D57874: [WebAssembly] Make thread-related options consistent

aheejin updated this revision to Diff 186090. aheejin added a comment. - Replace -matomics with -mthread-model posix in preprocessor test Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57874/new/ https://reviews.llvm.org/D57874 Files: include/clang/Driver/Optio

[PATCH] D57874: [WebAssembly] Make thread-related options consistent

aheejin updated this revision to Diff 186093. aheejin added a comment. - Address comments Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57874/new/ https://reviews.llvm.org/D57874 Files: include/clang/Driver/Options.td include/clang/Driver/ToolChain.h lib/D

[PATCH] D57874: [WebAssembly] Make thread-related options consistent

aheejin marked 4 inline comments as done. aheejin added inline comments. Comment at: lib/Driver/ToolChains/WebAssembly.cpp:29 + Pthread = + DriverArgs.hasFlag(options::OPT_pthread, options::OPT_no_pthread, false); + ThreadModel = tlively wrote: > Shouldn't

[PATCH] D57736: [WebAssembly] Bulk memory intrinsics and builtins

aheejin added inline comments. Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Comment at: clang/include/clang/Basic/BuiltinsWebAssembly.def:29 +// Bulk memory builtins +TARGET_BUILTIN(__builtin_wasm_memory_init, "vIiv*ii", "", "bulk-memory") +TARGET_BUILTI

[PATCH] D57874: [WebAssembly] Make thread-related options consistent

aheejin added a comment. If people have opinions on this final version, please let me know. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57874/new/ https://reviews.llvm.org/D57874 ___ cfe-commits mailing list cfe-co

[PATCH] D57874: [WebAssembly] Make thread-related options consistent

This revision was automatically updated to reflect the committed changes. Closed by commit rL353761: [WebAssembly] Make thread-related options consistent (authored by aheejin, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Repository: rL LLVM CHANGES SIN

[PATCH] D57736: [WebAssembly] Bulk memory intrinsics and builtins

aheejin accepted this revision. aheejin added inline comments. This revision is now accepted and ready to land. Comment at: clang/lib/CodeGen/CGBuiltin.cpp:13477 +if (!SegArg->isIntegerConstantExpr(SegConst, getContext())) + llvm_unreachable("Constant arg isn't actually

[PATCH] D62830: [WebAssembly] Support Leak Sanitizer on Emscripten

aheejin added a comment. Oh, can we have a test case? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62830/new/ https://reviews.llvm.org/D62830 ___ cfe-commits mailing list cfe-commits@lists.llvm.org ht

[PATCH] D62830: [WebAssembly] Support Leak Sanitizer on Emscripten

aheejin added a comment. I see. Do you want me to commit this, or you are gonna get a commit access? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62830/new/ https://reviews.llvm.org/D62830 ___ cfe-com

[PATCH] D62915: git-clang-format: Remove trailing whitespace in docstring. NFC.

aheejin accepted this revision. aheejin added a comment. This revision is now accepted and ready to land. I can't find the option of showing whitespace changes in Phabricator so I can't see it, but I'm always in favor of removing trailing whitespaces :D Repository: rG LLVM Github Monorepo CH

[PATCH] D64537: [WebAssembly] Implement thread-local storage (local-exec model)

aheejin added inline comments. Comment at: lld/test/wasm/data-segments.ll:7 ; RUN: wasm-ld -no-gc-sections --no-entry --shared-memory --max-memory=131072 %t.atomics.o -o %t.atomics.wasm -; RUN: obj2yaml %t.atomics.wasm | FileCheck %s --check-prefix ACTIVE +; RUN: obj2yaml %t.at

[PATCH] D64537: [WebAssembly] Implement thread-local storage (local-exec model)

aheejin added inline comments. Comment at: lld/test/wasm/data-segments.ll:7 ; RUN: wasm-ld -no-gc-sections --no-entry --shared-memory --max-memory=131072 %t.atomics.o -o %t.atomics.wasm -; RUN: obj2yaml %t.atomics.wasm | FileCheck %s --check-prefix ACTIVE +; RUN: obj2yaml %t.at

[PATCH] D64537: [WebAssembly] Implement thread-local storage (local-exec model)

aheejin added a comment. Where should we call `__wasm_init_tls`, in case within a library? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64537/new/ https://reviews.llvm.org/D64537 ___ cfe-commits maili

[PATCH] D64900: [WebAssembly] Implement __builtin_wasm_tls_base intrinsic

aheejin accepted this revision. aheejin added a comment. This revision is now accepted and ready to land. What does this return when `__wasm_init_tls` has not been called? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64900/new/ https://reviews.llv

[PATCH] D66035: [WebAssembly] WIP: Add support for reference types

aheejin added a comment. Thank you! We also have been floating some ideas about supporting reference types as types in another address space, but haven't actually started implementing it AFAIK. I like the general direction. Let's wait for other people's comments too. - Are you planning to land

[PATCH] D64015: [WIP][CUDA] Use shared MangleContext for CUDA and CXX CG

aheejin resigned from this revision. aheejin added a comment. Sorry, I don't think I know enough about this code to review this. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64015/new/ https://reviews.llvm.org/D64015 __

[PATCH] D63503: cmake: Add CLANG_LINK_CLANG_DYLIB option

aheejin added a comment. `CLANG_LINK_CLANG_DYLIB=ON` does not seem to work with `LLVM_INSTALL_TOOLCHAIN_ONLY=ON`. I filed a bug report: https://bugs.llvm.org/show_bug.cgi?id=42575 Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63503/new/ https://reviews.llvm.org/

[PATCH] D61909: Add Clang shared library with C++ exports

aheejin added a comment. `CLANG_LINK_CLANG_DYLIB=ON` does not seem to work with `LLVM_INSTALL_TOOLCHAIN_ONLY=ON`. I filed a bug report: https://bugs.llvm.org/show_bug.cgi?id=42575 Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61909/new/ https://reviews.llvm.org

[PATCH] D64537: [WebAssembly] Implement thread-local storage for non-PIC cases

aheejin added a comment. Nice! Then where should we call `__wasm_init_tls`, in case within a library? Comment at: clang/include/clang/Basic/BuiltinsWebAssembly.def:33 +// Thread-local storage +TARGET_BUILTIN(__builtin_wasm_tls_size, "z", "nc", "bulk-memory") +

  1   2   3   >