aheejin added inline comments.
================
Comment at: clang/include/clang/Driver/ToolChain.h:456
/// getThreadModel() - Which thread model does this target use?
- virtual std::string getThreadModel(const llvm::opt::ArgList &) const {
- return "posix";
- }
+ virtual std::string getThreadModel() const { return "posix"; }
----------------
tlively wrote:
> aheejin wrote:
> > I think now we can delete this overridden method, because the default value
> > for this is "posix". See Dan's [[
> > https://github.com/llvm/llvm-project/commit/1384ee936e46816f348bc3756704aeaff92e86fe
> > | commit ]].
> I did delete the overridden method below in
> clang/lib/Driver/ToolChains/WebAssembly.cpp. This is restoring the base class
> implementation to the way it was before your CL added the ArgList argument,
> since we no longer need it.
Oh sorry, I thought this file was WebAssembly.cpp...
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D58742/new/
https://reviews.llvm.org/D58742
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
