aheejin marked an inline comment as done. aheejin added inline comments.
================ Comment at: lib/Driver/ToolChains/WebAssembly.cpp:66 + if (Args.hasFlag(clang::driver::options::OPT_pthread, + clang::driver::options::OPT_no_pthread), + false) ---------------- This code is not strictly related, but `hasFlag` is better than `hasArg` when there are both positive and negative versions of an option exist. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57874/new/ https://reviews.llvm.org/D57874 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits