aheejin created this revision. aheejin added a reviewer: ioeric. Herald added subscribers: cfe-commits, jkorous-apple, ilya-biryukov, mgorny, klimek.
https://reviews.llvm.org/D42640 adds calls to `Preprocessor::addCommentHandler` in `unittests/clangd/SymbolCollectorTests.cpp` and `clangd/global-symbol-builder/GlobalSymbolBuilderMain.cpp` but does not link `clangLex` library. This causes undefined reference errors when built with `-DBUILD_SHARED_LIBS=ON`. Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D43437 Files: clangd/global-symbol-builder/CMakeLists.txt unittests/clangd/CMakeLists.txt Index: unittests/clangd/CMakeLists.txt =================================================================== --- unittests/clangd/CMakeLists.txt +++ unittests/clangd/CMakeLists.txt @@ -38,6 +38,7 @@ clangFormat clangFrontend clangIndex + clangLex clangSema clangTooling clangToolingCore Index: clangd/global-symbol-builder/CMakeLists.txt =================================================================== --- clangd/global-symbol-builder/CMakeLists.txt +++ clangd/global-symbol-builder/CMakeLists.txt @@ -15,5 +15,6 @@ clangDaemon clangBasic clangFrontend + clangLex clangTooling )
Index: unittests/clangd/CMakeLists.txt =================================================================== --- unittests/clangd/CMakeLists.txt +++ unittests/clangd/CMakeLists.txt @@ -38,6 +38,7 @@ clangFormat clangFrontend clangIndex + clangLex clangSema clangTooling clangToolingCore Index: clangd/global-symbol-builder/CMakeLists.txt =================================================================== --- clangd/global-symbol-builder/CMakeLists.txt +++ clangd/global-symbol-builder/CMakeLists.txt @@ -15,5 +15,6 @@ clangDaemon clangBasic clangFrontend + clangLex clangTooling )
_______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
