Author: chandlerc
Date: Wed Apr 12 03:12:30 2017
New Revision: 300035
URL: http://llvm.org/viewvc/llvm-project?rev=300035&view=rev
Log:
Update Clang for an API change to LLVM's switch case iterator (it is now
an actual iterator and so we need to look through it to the case
handle).
Modified:
This appears to break a pretty straightforward use of things like
libstdc++'s __alloctr_rebind (undefined template with a default argument,
specializations, etc):
https://github.com/gcc-mirror/gcc/blob/gcc-4_9-branch/libstdc++-v3/include/bits/alloc_traits.h#L58-L73
At least, I'm getting errors fro
break our modules builds using this version
of libstdc++.
On Tue, Apr 18, 2017 at 8:14 PM Chandler Carruth
wrote:
> This appears to break a pretty straightforward use of things like
> libstdc++'s __alloctr_rebind (undefined template with a default argument,
> specializations, etc):
&g
Author: chandlerc
Date: Wed Apr 19 00:25:13 2017
New Revision: 300659
URL: http://llvm.org/viewvc/llvm-project?rev=300659&view=rev
Log:
Revert r300653 and r300650. The underlying commit fixes one issue with
modules but exposes much more widespread issues. Example and more
information is on the rev
Reverted in r300658.
On Tue, Apr 18, 2017 at 8:30 PM Chandler Carruth
wrote:
> Consider code like the following:
>
> ```
> #include
>
> template
> class MyAllocator : public std::allocator {
> public:
> typedef std::allocator Alloc;
> typedef typename Alloc
Author: chandlerc
Date: Thu Jan 12 16:40:13 2017
New Revision: 291850
URL: http://llvm.org/viewvc/llvm-project?rev=291850&view=rev
Log:
Address review comments on r290392:
- Don't break using '-mllvm -disable-llvm-optzns' (yet).
- Don't add support for '-mllvm -disable-llvm-passes'.
This is impor
Author: chandlerc
Date: Thu Jan 12 16:43:37 2017
New Revision: 291851
URL: http://llvm.org/viewvc/llvm-project?rev=291851&view=rev
Log:
Replace some stray uses of the old spelling of the flag with the new
spelling. NFC.
Modified:
cfe/trunk/test/CodeGen/ms-declspecs.c
cfe/trunk/test/CodeGe
Author: chandlerc
Date: Thu Jan 12 16:48:28 2017
New Revision: 291853
URL: http://llvm.org/viewvc/llvm-project?rev=291853&view=rev
Log:
Fix two test cases I missed updating in r291850. Sorry for the noise.
Modified:
cfe/trunk/test/CodeGen/always_inline.c
cfe/trunk/test/Profile/gcc-flag-co
Author: chandlerc
Date: Thu Jan 12 20:47:34 2017
New Revision: 291881
URL: http://llvm.org/viewvc/llvm-project?rev=291881&view=rev
Log:
Another fix for r291850 because there are apparently targets which add
"-mllvm" flags to the CC1 invocation (notably, Hexagon seems to hit
this).
Modified:
c
Also need to pull in r291881. Sorry about that.
On Thu, Jan 12, 2017 at 3:42 PM Hans Wennborg wrote:
> On Thu, Jan 12, 2017 at 3:01 PM, Chandler Carruth
> wrote:
> >> This isn't quite right, it should either be left as-is or dropped
> >> completely. This path
It's blast from the past time!
On Tue, Sep 18, 2012 at 3:28 PM Hal Finkel wrote:
> Author: hfinkel
> Date: Tue Sep 18 17:25:07 2012
> New Revision: 164177
>
> URL: http://llvm.org/viewvc/llvm-project?rev=164177&view=rev
> Log:
> Add C/C++ header locations for the Freescale SDK.
>
> The Freescale
On Thu, Feb 9, 2017 at 2:46 PM Tobias von Koch
wrote:
> On Wed, Feb 8, 2017 at 7:21 PM, Chandler Carruth
> wrote:
>
>
> +// The Freescale PPC SDK has the gcc libraries in
> +// /usr/lib//x.y.z so have a look there as well.
> +"/" + CandidateTriple.str(
Sorry, email misfire...
On Thu, Jun 29, 2017 at 4:15 PM Chandler Carruth via Phabricator via
llvm-commits wrote:
> chandlerc added a comment.
>
> Already said LGTM, please go ahead and submit. If tehre are further
> requsets, we can always amke follow-up changes.
>
>
> Re
Author: chandlerc
Date: Thu Jun 29 16:20:54 2017
New Revision: 306759
URL: http://llvm.org/viewvc/llvm-project?rev=306759&view=rev
Log:
[clang-format] Switch to case-insensitive header matching and use it to
improve support for LLVM-style include sorting.
This really is a collection of improvemen
Author: chandlerc
Date: Thu Jun 29 22:13:31 2017
New Revision: 306786
URL: http://llvm.org/viewvc/llvm-project?rev=306786&view=rev
Log:
Remove Clang support for '-fvectorize-slp-aggressive' which used LLVM's
basic block vectorizer. This vectorizer has had no known users for many,
many years and is
Author: chandlerc
Date: Tue Jul 25 03:46:07 2017
New Revision: 308967
URL: http://llvm.org/viewvc/llvm-project?rev=308967&view=rev
Log:
[PM] Setup TargetLibraryInfo correctly for the new pass manager.
Without this, -fno-builtin and friends doesn't work. Added the obvious
RUN lines to the test for
Author: chandlerc
Date: Mon Jan 22 14:05:25 2018
New Revision: 323155
URL: http://llvm.org/viewvc/llvm-project?rev=323155&view=rev
Log:
Introduce the "retpoline" x86 mitigation technique for variant #2 of the
speculative execution vulnerabilities disclosed today, specifically identified
by CVE-2
PM Chandler Carruth via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> Author: chandlerc
> Date: Mon Jan 22 14:05:25 2018
> New Revision: 323155
>
> URL: http://llvm.org/viewvc/llvm-project?rev=323155&view=rev
> Log:
> Introduce the "retpoline" x86 m
), r324069 (lld)
>
> > r323288
>
> Merged in r324070.
>
> > r323915
>
> Merged in r324071.
>
> >
> > +Reid Kleckner was going to look at doing the (likely more involved)
> > backport to the 5 branch
> >
> > On Mon, Jan 22, 2018 at 2:06
chandlerc requested changes to this revision.
chandlerc added a comment.
This revision now requires changes to proceed.
Please add a stub tree and tests. You can find similar tests for other Linux
distros in 'tests/Driver'.
https://reviews.llvm.org/D25604
chandlerc added a comment.
In https://reviews.llvm.org/D23754#580277, @mgorny wrote:
> In https://reviews.llvm.org/D23754#580268, @beanz wrote:
>
> > @mgorny, I don't think LLVMgold qualifies as a runtime in the traditional
> > sense. It more closely aligns with the tools vended by LLVM even tho
chandlerc added a comment.
In https://reviews.llvm.org/D23754#580612, @mgorny wrote:
> In https://reviews.llvm.org/D23754#580441, @chandlerc wrote:
>
> > In https://reviews.llvm.org/D23754#580277, @mgorny wrote:
> >
> > > The difference is that LLVMgold.so is not used by LLVM or clang directly
>
chandlerc added a comment.
In https://reviews.llvm.org/D23754#580631, @mgorny wrote:
> In https://reviews.llvm.org/D23754#580620, @chandlerc wrote:
>
> > I'm not sure it really makes sense for the Clang driver to go hunting for
> > an LLVMgold.so from an unrelated build of Clang and LLVM.
> >
>
chandlerc added a comment.
I don't get it.
There is nothing "RUNTIMES" about it. And this variable is actually used to
produce real libraries: libclang, etc.
It's just the LIBDIR_SUFFIX. That's it. The reason it is called
CLANG_LIBDIR_SUFFIX and set from LLVM_LIBDIR_SUFFIX is to support using
chandlerc added a comment.
In https://reviews.llvm.org/D23752#581427, @mgorny wrote:
> In https://reviews.llvm.org/D23752#581416, @chandlerc wrote:
>
> > I don't get it.
> >
> > There is nothing "RUNTIMES" about it. And this variable is actually used to
> > produce real libraries: libclang, etc.
chandlerc added a comment.
In https://reviews.llvm.org/D23752#581436, @mgorny wrote:
> This really doesn't solve the problems we have. We don't want to build and
> install two almost-identical copies of compiler-rt and clang headers, when we
> can just build one and make clang use it.
However
Author: chandlerc
Date: Thu Nov 3 12:42:32 2016
New Revision: 285946
URL: http://llvm.org/viewvc/llvm-project?rev=285946&view=rev
Log:
Using release to free memory is at best confusing -- one would expect
that its result is in fact used. Instead, use reset.
This was pointed out by PVS-Studio.
M
Author: chandlerc
Date: Thu Nov 3 13:03:14 2016
New Revision: 285950
URL: http://llvm.org/viewvc/llvm-project?rev=285950&view=rev
Log:
Instead of resetting the pointer, or releasing it which was the previous
code, let's just assert that the DiagonsticEngine doesn't own the client
because our cons
Author: chandlerc
Date: Fri Nov 4 01:06:50 2016
New Revision: 285980
URL: http://llvm.org/viewvc/llvm-project?rev=285980&view=rev
Log:
Remove no-op checks for a null CodeCompleter. We have already
dereferenced the pointer at this point, and these routines are
exclusively called after the parser e
Author: chandlerc
Date: Fri Nov 4 01:11:54 2016
New Revision: 285982
URL: http://llvm.org/viewvc/llvm-project?rev=285982&view=rev
Log:
Add an assert to further check the invariant that a null pointer
corresponds to another argument being valid.
This makes it clear that the code is correct despit
Author: chandlerc
Date: Fri Nov 4 01:16:09 2016
New Revision: 285983
URL: http://llvm.org/viewvc/llvm-project?rev=285983&view=rev
Log:
Delete a trivially true check for a variable 'S' being null.
The exact same test guards entry into the loop in which this test
occurs, and there is nothing insid
Author: chandlerc
Date: Fri Nov 4 01:32:57 2016
New Revision: 285985
URL: http://llvm.org/viewvc/llvm-project?rev=285985&view=rev
Log:
Add some more asserts to clearly indicate that there are special cases
which guarantee pointers are not null. These all seem to have useful
properties and correla
chandlerc created this revision.
chandlerc added a reviewer: rsmith.
chandlerc added a subscriber: cfe-commits.
Herald added a subscriber: mcrosier.
The latter agrees with most existing diagnostics and the C and C++ standards.
https://reviews.llvm.org/D26530
Files:
include/clang/Basic/Diagnos
chandlerc updated this revision to Diff 77574.
chandlerc added a comment.
Update the tests accordingly.
https://reviews.llvm.org/D26530
Files:
include/clang/Basic/DiagnosticParseKinds.td
include/clang/Basic/DiagnosticSemaKinds.td
test/Parser/objc-property-syntax.m
test/Sema/constant-con
chandlerc added a comment.
I think we want dedicated macros to disable each added [[nodiscard]]. The
reason is that as you add each one, users will have to roll out cleanups for
the new warnings. This may be hard to do quickly and cause problems updating
libc++ for users with -Werror in their b
chandlerc accepted this revision.
chandlerc added a comment.
This revision is now accepted and ready to land.
LGTM i guess...
I'm a tiny bit surprised that you have to handle this here rather than
something else handling this for you... But not a lit surprised...
http://reviews.llvm.org/D12622
None of my performance concerns were relevant to this change FWIW.
I think the reason that this got "fixed" was because people had a tendancy
to *rely* on the name downstream when we made it always present. =/
Personally, I like having *no* names in a no-asserts build because it
ensures that absol
On Thu, Sep 10, 2015 at 7:27 PM John McCall wrote:
> On Sep 10, 2015, at 16:09, Chandler Carruth wrote:
>
>
> On Thu, Sep 10, 2015 at 3:26 PM John McCall wrote:
>
>> On Sep 10, 2015, at 3:22 PM, Chandler Carruth
>> wrote:
>>
>> I've reproduced this
Author: chandlerc
Date: Wed Sep 30 21:21:34 2015
New Revision: 248980
URL: http://llvm.org/viewvc/llvm-project?rev=248980&view=rev
Log:
Patch over a really horrible bug in our vector builtins that showed up
recently when we started using direct conversion to model sign
extension. The __v16qi type
chandlerc created this revision.
chandlerc added a reviewer: rsmith.
chandlerc added a subscriber: cfe-commits.
This further testing uncovered that AVX-2 has a broken cmpgt for 8-bit
elements, and has for a long time. This is fixed in the same way as
SSE4 handles the case.
The other ISA extension
Note that http://reviews.llvm.org/D13324 is the promised improved fix here,
awaiting review. =]
On Wed, Sep 30, 2015 at 7:23 PM Chandler Carruth via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> Author: chandlerc
> Date: Wed Sep 30 21:21:34 2015
> New Revision: 24898
On Wed, Sep 30, 2015 at 8:52 PM Piotr Padlewski via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> Author: prazek
> Date: Wed Sep 30 22:50:41 2015
> New Revision: 248982
>
> URL: http://llvm.org/viewvc/llvm-project?rev=248982&view=rev
> Log:
> Decorating virtual functions load with invariant.l
Author: chandlerc
Date: Thu Oct 1 18:40:12 2015
New Revision: 249097
URL: http://llvm.org/viewvc/llvm-project?rev=249097&view=rev
Log:
Fix the SSE4 byte sign extension in a cleaner way, and more thoroughly
test that our intrinsics behave the same under -fsigned-char and
-funsigned-char.
This fur
This revision was automatically updated to reflect the committed changes.
Closed by commit rL249097: Fix the SSE4 byte sign extension in a cleaner way,
and more thoroughly (authored by chandlerc).
Changed prior to commit:
http://reviews.llvm.org/D13324?vs=36178&id=36321#toc
Repository:
rL LL
Marshall, I think Richard has responded to your concerns. Anything left?
This is blocking some things on our end.
On Wed, Sep 16, 2015 at 2:04 PM Richard Smith via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> On Mon, Sep 14, 2015 at 7:07 AM, Marshall Clow
> wrote:
>
>> mclow.lists added a
chandlerc added a comment.
This isn't necessary. The TC that we assign to is a reference to the pointer in
the map. It should already be caching.
http://reviews.llvm.org/D11983
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.ll
chandlerc added a comment.
I agree with both Marshall and Hal.
However, I'm also not opposed to platforms opting out if this if they want to.
If a particular platform wants to define the behavior of null pointers passed
to these functions, that seems like a reasonable thing to support here. The
chandlerc added a comment.
FYI, we should send an RFC to llvm-dev about the design change of always_inline
and make sure folks generally like the IR-level direction as well. We can point
at this review as an example.
I'm happy to write that up and send it if that's useful?
Repository:
rL LL
Author: chandlerc
Date: Tue Aug 18 12:59:33 2015
New Revision: 245320
URL: http://llvm.org/viewvc/llvm-project?rev=245320&view=rev
Log:
Update to reflect the library set in LLVM changing.
Modified:
cfe/trunk/tools/driver/CMakeLists.txt
Modified: cfe/trunk/tools/driver/CMakeLists.txt
URL:
ht
Author: chandlerc
Date: Sat Aug 29 21:16:36 2015
New Revision: 246368
URL: http://llvm.org/viewvc/llvm-project?rev=246368&view=rev
Log:
Update for API change in LLVM: ARMTargetParser class is just the ARM
namespace.
Modified:
cfe/trunk/lib/Basic/Targets.cpp
cfe/trunk/lib/Driver/ToolChains
Author: chandlerc
Date: Sun Aug 30 02:51:18 2015
New Revision: 246375
URL: http://llvm.org/viewvc/llvm-project?rev=246375&view=rev
Log:
Update for several APIs in LLVM that now use StringRefs rather than
const char pointers. In turn, push this through Clang APIs as well,
simplifying a number of bi
Is it possible to add a unittest that exercises this extension point
in-tree? For example the way I did for AA extension hooks?
On Mon, Oct 19, 2015 at 9:00 PM Michael Gottesman via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> On Oct 19, 2015, at 4:40 PM, Michael Gottesman via cfe-commits <
chandlerc accepted this revision.
chandlerc added a comment.
This revision is now accepted and ready to land.
LGTM to land when http://reviews.llvm.org/D13802 lands. See my comments there.
http://reviews.llvm.org/D13803
___
cfe-commits mailing list
chandlerc added a comment.
Some minor issues below. Also, Hans and Tom should have a glance at the release
bits of this, I don't know any of that stuff.
Also, there are still some bugs with check-libomp. The immediate one I noticed
was that when i run it in a clean build with enough parallelism
chandlerc added a comment.
In http://reviews.llvm.org/D13802#274847, @ABataev wrote:
> Hi Chandler, thanks for the review.
>
> In http://reviews.llvm.org/D13802#272053, @chandlerc wrote:
>
> > I've also had one test fail, and then start passing for me on Linux (after
> > fixing the above). I hav
Note that this is still failing on bots even after the windows fix:
http://lab.llvm.org:8011/builders/clang-x86_64-ubuntu-gdb-75/builds/24169
On Fri, Aug 7, 2015 at 6:50 PM Anna Zaks via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> Author: zaks
> Date: Fri Aug 7 20:49:26 2015
> New Revisi
NP, thanks for the quick fixes!
On Fri, Aug 7, 2015 at 9:56 PM Anna Zaks wrote:
> Sorry about the breakage! I’ve reverted the commit in r244394.
>
> Anna.
>
> On Aug 7, 2015, at 9:08 PM, Chandler Carruth wrote:
>
> Note that this is still failing on bots even after the
Author: chandlerc
Date: Wed Aug 10 02:32:47 2016
New Revision: 278202
URL: http://llvm.org/viewvc/llvm-project?rev=278202&view=rev
Log:
[x86] Fix a really nasty bug introduced in r276417 where alignment
constraints were added to _mm256_broadcast_{pd,ps} intel intrinsics.
The spec for these intrin
On Fri, Jul 22, 2016 at 7:06 AM Simon Pilgrim via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> Author: rksimon
> Date: Fri Jul 22 08:58:56 2016
> New Revision: 276417
>
> URL: http://llvm.org/viewvc/llvm-project?rev=276417&view=rev
> Log:
> [X86][AVX] Added support for lowering to VBROADCAST
Author: chandlerc
Date: Tue Feb 16 20:13:35 2016
New Revision: 261054
URL: http://llvm.org/viewvc/llvm-project?rev=261054&view=rev
Log:
[cmake] Revert r260742 (and r260744) to improve order file support.
This appears to be passing '-Wl,-order_file' to Linux link commands,
which then causes the li
FYI, I had to revert this in r261054 because it caused Linux links to write
the output to 'rder_file' in all cases. See that commit for some details,
and I think several build bots hit this as well. Happy to chat to help
figure out what to do long term.
-Chandler
On Fri, Feb 12, 2016 at 1:41 PM C
Author: chandlerc
Date: Sun May 8 02:59:56 2016
New Revision: 268874
URL: http://llvm.org/viewvc/llvm-project?rev=268874&view=rev
Log:
Teach header search about GCC 4.9 header search paths in Gentoo, they
now use the full GCC version in their weird suffix.
Added:
cfe/trunk/test/Driver/Inputs
Author: chandlerc
Date: Sat May 14 00:39:45 2016
New Revision: 269549
URL: http://llvm.org/viewvc/llvm-project?rev=269549&view=rev
Log:
Revert "Reapply "[ProfileData] (clang) Use Error in InstrProf and Coverage,
NFC""
This reverts commit r269492 as the corresponding LLVM commit was
reverted due
chandlerc accepted this revision.
chandlerc added a comment.
This revision is now accepted and ready to land.
LGTM, nice!
http://reviews.llvm.org/D18648
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/li
chandlerc accepted this revision.
chandlerc added a comment.
This revision is now accepted and ready to land.
Minor tweak, but with that LGTM once the LLVM side is in place.
Comment at: lib/CodeGen/BackendUtil.cpp:347
@@ +346,3 @@
+PassManagerBuilder::EP_EarlyAsPossible,
chandlerc added inline comments.
Comment at: lib/CodeGen/BackendUtil.cpp:347
@@ +346,3 @@
+PassManagerBuilder::EP_EarlyAsPossible,
+[&](const PassManagerBuilder &, legacy::PassManagerBase &PM) {
+ TM->addEarlyAsPossiblePasses(PM);
Wow, C++
On Mon, Mar 7, 2016 at 12:33 AM Michael Zuckerman via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> Author: mzuckerm
> Date: Mon Mar 7 02:29:10 2016
> New Revision: 262817
>
> URL: http://llvm.org/viewvc/llvm-project?rev=262817&view=rev
> Log:
> [CLANG][AVX512][BUILTIN] Adding vpmultishiftqb
This commit is missing a test.
On Fri, Apr 15, 2016 at 5:16 PM Justin Lebar via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> Author: jlebar
> Date: Fri Apr 15 19:11:11 2016
> New Revision: 266496
>
> URL: http://llvm.org/viewvc/llvm-project?rev=266496&view=rev
> Log:
> [CUDA] Raise an error
install is "real". If we changed those heuristics, we'd have to
> change our test.
>
> On Tue, Apr 19, 2016 at 11:21 AM, Chandler Carruth
> wrote:
> > This commit is missing a test.
> >
> >
> > On Fri, Apr 15, 2016 at 5:16 PM Justin Lebar via
w see that we're already biting that cost with existing
> > tests, so adding a test for this shouldn't be a big deal.
> >
> > On Tue, Apr 19, 2016 at 11:33 AM, Chandler Carruth
> wrote:
> >> I don't really understand why having to change the test when we
On Fri, Jun 3, 2016 at 8:21 PM Taewook Oh via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> Author: twoh
> Date: Fri Jun 3 22:14:43 2016
> New Revision: 271761
>
> URL: http://llvm.org/viewvc/llvm-project?rev=271761&view=rev
> Log:
> Revert commit r271708
>
Please actually explain why you a
Author: chandlerc
Date: Fri Jun 10 23:45:38 2016
New Revision: 272453
URL: http://llvm.org/viewvc/llvm-project?rev=272453&view=rev
Log:
Revert "[ASTMatchers] New forEachOverriden matcher."
This reverts commit r272386. It doesn't compile with MSVC and those bots
have been red the entire day as a c
This has broken Windows build bots all day. Here are some recent examples:
http://lab.llvm.org:8011/builders/clang-x86-win2008-selfhost/builds/8506/steps/ninja%20check%201/logs/stdio
http://lab.llvm.org:8011/builders/clang-x64-ninja-win7/builds/12981/steps/ninja%20check%201/logs/stdio
Please pay a
This broke several bots that have now been red most of the day. Here are
recent builds that show the failure:
http://lab.llvm.org:8011/builders/clang-ppc64le-linux/builds/4611
http://lab.llvm.org:8011/builders/clang-ppc64be-linux/builds/6331
http://lab.llvm.org:8011/builders/clang-atom-d525-fedora-
Author: chandlerc
Date: Fri Jun 10 23:57:29 2016
New Revision: 272454
URL: http://llvm.org/viewvc/llvm-project?rev=272454&view=rev
Log:
Revert "Strip Android version when looking up toolchain paths."
This reverts commit r272413. The tests here have been failing on several
different build bots for
Author: chandlerc
Date: Sat Jun 11 01:32:56 2016
New Revision: 272456
URL: http://llvm.org/viewvc/llvm-project?rev=272456&view=rev
Log:
Fix this test to handle NDEBUG builds which don't have a name for the
basic block.
Modified:
cfe/trunk/test/CodeGen/avx512vlbw-builtins.c
Modified: cfe/trun
chandlerc added inline comments.
Comment at: unittests/ASTMatchers/ASTMatchersTest.h:81-83
@@ +80,5 @@
+ //
+ // FIXME: This is a hack to work around the fact that there's no way to do
the
+ // equivalent of runToolOnCodeWithArgs without instantiating a full Driver.
+ // We s
On Wed, Jun 29, 2016 at 12:47 PM Nico Weber via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> On Wed, Jun 29, 2016 at 3:25 PM, Richard Smith
> wrote:
>
>> Note that at this point I'd like to mainly focus on what our policy
>> should be;
>>
>
> Fair enough. I don't have a strong opinion on th
chandlerc accepted this revision.
chandlerc added a comment.
This revision is now accepted and ready to land.
In http://reviews.llvm.org/D21810#471486, @jlebar wrote:
> > But I think this is a reasonable workaround until such an API can be
> > provided.
>
>
> Should I take that as an LG, or are
chandlerc added a reviewer: scanon.
chandlerc added a comment.
I'm fine with this change, but we should also get Steve to comment on it, and
make sure we have a good way of explaining this to users.
In particular, we probably need some documentation around these fast routines
that clearly indic
chandlerc added a comment.
I'd like someone more active on the Clang side to comment about this, but here
is my 2 cents...
It seems like it'd be nice to not populate or run or otherwise build up the
legacy pass managers when using this option. I guess I would expect something
to more split ear
On Sun, Jul 17, 2016 at 1:54 PM Arthur O'Dwyer
wrote:
> Given that this patch is basically Chandler's talk from CppCon 2015 (
> https://www.youtube.com/watch?v=nXaxk27zwlk), I'm surprised that the
> commit message isn't explicitly mentioning that; and surprised that
> Chandler himself isn't weigh
On Mon, Feb 29, 2016 at 11:32 AM Manuel Klimek via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> Author: klimek
> Date: Mon Feb 29 10:27:41 2016
> New Revision: 262232
>
> URL: http://llvm.org/viewvc/llvm-project?rev=262232&view=rev
> Log:
> Implement new interfaces for code-formatting when a
chandlerc added a comment.
In http://reviews.llvm.org/D17784#367601, @kparzysz wrote:
> This seemed fine to me, but at the second thought, the lines 2610-2613 in the
> original should be removed.
I agree. I think using LLVM_PREFIX here in any capacity is incorrect.
http://reviews.llvm.org/D1
chandlerc added a subscriber: chandlerc.
chandlerc added a comment.
If we're not going to fully implement "fdelete-null-pointer-checks" we
shouldn't claim to... I'm really worried about us accepting that flag and not
actually honoring it.
However, I *do* think this should be guarded by a flag,
chandlerc added a comment.
In http://reviews.llvm.org/D17993#371454, @hfinkel wrote:
> In http://reviews.llvm.org/D17993#370793, @chandlerc wrote:
>
> > If we're not going to fully implement "fdelete-null-pointer-checks" we
> > shouldn't claim to... I'm really worried about us accepting that fla
chandlerc added a comment.
FYI, I'd lik eto hold off on submitting here until we're on the same page with
Philip on the original LLVM review (http://reviews.llvm.org/D17946), but some
comments on how this is working are below...
Comment at: lib/CodeGen/CodeGenAction.cpp:660-66
chandlerc added inline comments.
Comment at: lib/CodeGen/CodeGenAction.cpp:660-663
@@ -660,1 +659,6 @@
+ OwnsVMContext(!_VMContext) {
+#ifdef NDEBUG
+ _VMContext.setDiscardValueNames(true);
+#endif
+}
joker.eph wrote:
> chandlerc wrote:
> > I'm surprised t
chandlerc accepted this revision.
chandlerc added a comment.
This revision is now accepted and ready to land.
LGTM
http://reviews.llvm.org/D18024
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/
Author: chandlerc
Date: Fri Mar 11 03:02:43 2016
New Revision: 263210
URL: http://llvm.org/viewvc/llvm-project?rev=263210&view=rev
Log:
Update to include the new header file providing createGVNPass.
Modified:
cfe/trunk/lib/CodeGen/BackendUtil.cpp
Modified: cfe/trunk/lib/CodeGen/BackendUtil.c
chandlerc added a comment.
Change these tests to use %clang_cc1 rather than add all the messy regex to
handle arguments losing names?
Comment at: lib/Driver/Tools.cpp:3715
@@ -3714,1 +3714,3 @@
CmdArgs.push_back("-disable-llvm-verifier");
+ // Disable LLVM value names in -a
chandlerc accepted this revision.
chandlerc added a comment.
This revision is now accepted and ready to land.
Looks good with the two test nits below fixed.
Comment at: test/CodeGen/mips-zero-sized-struct.c:8-10
@@ -7,5 +7,5 @@
-// O32: define void @fn28(%struct.T2* noalias sr
A long time ago I argued that the sanitizers should be using debug info
instead of alloca names for this, and I really thought that they had
implemented this... Is that not the case?
It is really bad that the sanitizers are relying on this stuff...
On Mon, Mar 14, 2016 at 2:28 PM Benjamin Kramer
chandlerc accepted this revision.
chandlerc added a comment.
This revision is now accepted and ready to land.
LGTM with the comments from David addressed and the comment below addressed.
Comment at: lib/Basic/Targets.cpp:6000-6001
@@ +5999,4 @@
+ break;
+default:
+
chandlerc added a comment.
I don't know anything about MIPS and this seems a highly MIPS specific change,
so I can't provide any useful review here. You have someone with MIPS specific
knowledge on the review though, so you seem to have the appropriate people
looped in...
http://reviews.llvm.
Author: chandlerc
Date: Tue Dec 29 20:51:00 2015
New Revision: 256609
URL: http://llvm.org/viewvc/llvm-project?rev=256609&view=rev
Log:
[ptr-traits] Stop using two bogus types as stand-ins for flags
indicating the nature of the default argument in a ParmVarDecl.
Instead, this adds a proper enum s
Author: chandlerc
Date: Tue Dec 29 21:00:23 2015
New Revision: 256610
URL: http://llvm.org/viewvc/llvm-project?rev=256610&view=rev
Log:
[ptr-traits] Switch from a really wasteful SmallDenseMap of
SmallVector<.., 16> (16) objects to a simple SmallVector of pairs.
This no longer de-duplicates t
Author: chandlerc
Date: Tue Dec 29 21:09:25 2015
New Revision: 256611
URL: http://llvm.org/viewvc/llvm-project?rev=256611&view=rev
Log:
[ptr-traits] Switch the Redeclarable template to using a void pointer in
its PointerUnion rather than an ASTContext pointer.
Using pointers with PointerUnion rea
Author: chandlerc
Date: Tue Dec 29 21:24:14 2015
New Revision: 256612
URL: http://llvm.org/viewvc/llvm-project?rev=256612&view=rev
Log:
[ptr-traits] Move methods manipulating PointerUnions, DenseMap pointer
keys, and PointerIntPairs where the pointee types are incomplete
out-of-line to where we ha
Author: chandlerc
Date: Tue Dec 29 21:33:22 2015
New Revision: 256613
URL: http://llvm.org/viewvc/llvm-project?rev=256613&view=rev
Log:
[ptr-traits] Move a class definition up to the top of this header so it
can be referenced as part of a PointerIntPair.
This is part of a series of patches to all
101 - 200 of 566 matches
Mail list logo
