On Mon, Mar 7, 2016 at 12:33 AM Michael Zuckerman via cfe-commits < cfe-commits@lists.llvm.org> wrote:
> Author: mzuckerm > Date: Mon Mar 7 02:29:10 2016 > New Revision: 262817 > > URL: http://llvm.org/viewvc/llvm-project?rev=262817&view=rev > Log: > [CLANG][AVX512][BUILTIN] Adding vpmultishiftqb{128|256|512} > This commit log seems super confusing combined with: +TARGET_BUILTIN(__builtin_ia32_pbroadcastb512_gpr_mask, > "V64ccV64cULLi","","avx512bw") > +TARGET_BUILTIN(__builtin_ia32_pbroadcastb128_gpr_mask, > "V16ccV16cUs","","avx512bw,avx512vl") > +TARGET_BUILTIN(__builtin_ia32_pbroadcastb256_gpr_mask, > "V32ccV32cUi","","avx512bw,avx512vl") > +TARGET_BUILTIN(__builtin_ia32_pbroadcastd128_gpr_mask, > "V4iiV4iUc","","avx512vl") > +TARGET_BUILTIN(__builtin_ia32_pbroadcastd256_gpr_mask, > "V8iiV8iUc","","avx512vl") > +TARGET_BUILTIN(__builtin_ia32_pbroadcastq128_gpr_mask, > "V2LLiULLiV2LLiUc","","avx512vl") > +TARGET_BUILTIN(__builtin_ia32_pbroadcastq256_gpr_mask, > "V4LLiULLiV4LLiUc","","avx512vl") > This is adding *broadcast* intrinsics!!! Not multishift! Please be much more careful with your patch descriptions. I just happened to randomly notice this. Elena, please actually carefully review these patches.
_______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
