r285946 - Using release to free memory is at best confusing -- one would expect

[Chandler Carruth via cfe-commits]

Author: chandlerc
Date: Thu Nov  3 12:42:32 2016
New Revision: 285946

URL: http://llvm.org/viewvc/llvm-project?rev=285946&view=rev
Log:
Using release to free memory is at best confusing -- one would expect
that its result is in fact used. Instead, use reset.

This was pointed out by PVS-Studio.

Modified:
    cfe/trunk/lib/Frontend/VerifyDiagnosticConsumer.cpp

Modified: cfe/trunk/lib/Frontend/VerifyDiagnosticConsumer.cpp
URL: 
http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/Frontend/VerifyDiagnosticConsumer.cpp?rev=285946&r1=285945&r2=285946&view=diff
==============================================================================
--- cfe/trunk/lib/Frontend/VerifyDiagnosticConsumer.cpp (original)
+++ cfe/trunk/lib/Frontend/VerifyDiagnosticConsumer.cpp Thu Nov  3 12:42:32 2016
@@ -43,7 +43,7 @@ VerifyDiagnosticConsumer::~VerifyDiagnos
   assert(!CurrentPreprocessor && "CurrentPreprocessor should be invalid!");
   SrcManager = nullptr;
   CheckDiagnostics();
-  Diags.takeClient().release();
+  Diags.takeClient().reset();
 }
 
 #ifndef NDEBUG


_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits