chandlerc accepted this revision.
chandlerc added a comment.
This revision is now accepted and ready to land.
LGTM with the comments from David addressed and the comment below addressed.
================
Comment at: lib/Basic/Targets.cpp:6000-6001
@@ +5999,4 @@
+ break;
+ default:
+ llvm_unreachable("Unhandled target CPU");
+ }
----------------
Instead of a default, make this a covering switch? We get warnings that way if
someone adds a CPU and doesn't add a case.
http://reviews.llvm.org/D17002
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
