Author: asiri
Date: Thu Jan 26 04:40:17 2017
New Revision: 293167
URL: http://llvm.org/viewvc/llvm-project?rev=293167&view=rev
Log:
Fix chromium build (libcxx)
Remove the reference to pthread_mach_thread_np() in libcxx headers.
Modified:
libcxx/trunk/include/__threading_support
Modified: li
gt;> Nope. But I'm not sure how this got broken on Mac.
>>>>>
>>>>> IIRC, defines mach_port_t type on Mac, which gets included
>>>>> when _LIBCPP_HAS_THREAD_API_PTHREAD is defined (which is what we
>>>>> expect to be the case on
Author: asiri
Date: Thu Feb 2 04:35:18 2017
New Revision: 293877
URL: http://llvm.org/viewvc/llvm-project?rev=293877&view=rev
Log:
Improve docs: Add missing #pragma push directive.
NFC.
Modified:
cfe/trunk/docs/UsersManual.rst
Modified: cfe/trunk/docs/UsersManual.rst
URL:
http://llvm.org/
Author: asiri
Date: Thu Feb 2 05:56:26 2017
New Revision: 293881
URL: http://llvm.org/viewvc/llvm-project?rev=293881&view=rev
Log:
Extend XFAIL to c++98.
NFC.
Modified:
libcxx/trunk/test/std/diagnostics/syserr/syserr.errcode/syserr.errcode.observers/bool.fail.cpp
Modified:
libcxx/trunk/t
Hi Petr,
This is breaking static builds of the libraries, cmake complaints with:
"CMake Error at projects/libcxxabi/src/CMakeLists.txt:134
(target_link_libraries):
Target "unwind" of type UTILITY may not be linked into another target.
One
may link only to STATIC or SHARED libraries, or to exe
Author: asiri
Date: Thu Feb 9 03:31:41 2017
New Revision: 294573
URL: http://llvm.org/viewvc/llvm-project?rev=294573&view=rev
Log:
Threading support: externalize sleep_for() function.
Different platforms implement the wait/sleep functions in difrerent ways.
It makes sense to externalize this int
Ah, ignore me please.
I should've read the patch.
/ Asiri
On Thu, Feb 9, 2017 at 9:13 AM, Asiri Rathnayake wrote:
> Hi Petr,
>
> This is breaking static builds of the libraries, cmake complaints with:
>
> "CMake Error at projects/libcxxabi/src/CMakeLists.txt:134
> (target_link_libraries):
>
Author: asiri
Date: Wed Feb 15 07:43:05 2017
New Revision: 295175
URL: http://llvm.org/viewvc/llvm-project?rev=295175&view=rev
Log:
Fix couple of test failures when using the LIBCXXABI_SILENT_TERMINATE mode.
When libcxxabi is built in LIBCXXABI_SILENT_TERMINATE mode, libcxx test suite
reports
tw
Hi Ed,
I have a feeling that the no-exceptions builders are missing a few
configuration bits.
"No-exceptions" libraries should not require libunwind...
Looking at the cmake configs:
http://lab.llvm.org:8011/builders/libcxx-libcxxabi-libunwind-arm-linux-noexceptions/builds/430/steps/cmake/logs/st
Author: asiri
Date: Mon Feb 27 07:19:25 2017
New Revision: 296338
URL: http://llvm.org/viewvc/llvm-project?rev=296338&view=rev
Log:
Fix cmake dependency for the external-thread-library variant. NFC.
Modified:
libcxx/trunk/test/CMakeLists.txt
Modified: libcxx/trunk/test/CMakeLists.txt
URL:
h
Author: asiri
Date: Mon Feb 27 09:31:34 2017
New Revision: 296344
URL: http://llvm.org/viewvc/llvm-project?rev=296344&view=rev
Log:
Attempt to fix arm-native libcxxabi tests for the no-exceptions variant
These tests embed calls to exceptions-related symbols from the abi library,
which are absent
Author: asiri
Date: Mon Feb 27 09:49:51 2017
New Revision: 296346
URL: http://llvm.org/viewvc/llvm-project?rev=296346&view=rev
Log:
Fix typo in error message. NFC.
Modified:
libcxx/trunk/include/__config
Modified: libcxx/trunk/include/__config
URL:
http://llvm.org/viewvc/llvm-project/libcxx
Author: asiri
Date: Mon Feb 27 10:10:57 2017
New Revision: 296351
URL: http://llvm.org/viewvc/llvm-project?rev=296351&view=rev
Log:
Fix LIBCXX_HAS_EXTERNAL_THREAD_API builds. NFC.
Add the missing check in the __config header.
Modified:
libcxx/trunk/include/__config
Modified: libcxx/trunk/in
Hi Ed,
Could you please always include cfe-commits as a subscriber in you phab
reviews?
We would like to be aware of these changes in advance before they land.
Thanks.
/ Asiri
On 7 Mar 2017 6:27 p.m., "Ed Schouten via cfe-commits" <
cfe-commits@lists.llvm.org> wrote:
> Author: ed
> Date: Tue
@Renato: What's your take on Ed's idea?
We use phab for all sorts of reviews, but it should be possible to figure
out which repository a review is intended to land on and add cfe-commits or
llvm-commits appropriately.
Although, for throw-away reviews, it might generate too much spam.
Cheers,
/
rmaprath added a comment.
In https://reviews.llvm.org/D26458#594069, @EricWF wrote:
> There are cases where it is useful to be able to name `std::nested_exception`
> while exceptions are disabled.
I was thinking about the opposite. That is, we might want to consider disabling
the `` header al
rmaprath added a comment.
On the other hand, disabling `` would mean disabling some parts of
the library as well (in this case, `std::promise::set_exception`). Perhaps
that's a bad path to follow. Not sure.
Repository:
rL LLVM
https://reviews.llvm.org/D26458
_
rmaprath added a comment.
This looks sensible to me. I'll let @EricWF approve.
/ Asiri
https://reviews.llvm.org/D26075
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
rmaprath added inline comments.
Comment at: test/std/strings/basic.string/string.access/at.pass.cpp:41
+const S& cs = s;
+if (pos < cs.size())
+{
For the cases where an exception //should've been// thrown, are we not entering
the **undefined** domain
rmaprath added inline comments.
Comment at: test/std/strings/basic.string/string.access/at.pass.cpp:41
+const S& cs = s;
+if (pos < cs.size())
+{
rogfer01 wrote:
> rmaprath wrote:
> > For the cases where an exception //should've been// thrown, are we
rmaprath added a comment.
Would it be more cleaner to separate out the exceptions-related tests into
their own functions? So, we'd have the two functions `test_withexceptions()`
and `test_noexceptions()`; the former will only be invoked when testing the
normal library variant, the latter will b
rmaprath added a comment.
In https://reviews.llvm.org/D26139#587587, @mclow.lists wrote:
> > I think it might be better to add TEST_TRY and TEST_CATCH(...) macros
> > defined like
>
> @rogfer01 said at the top that he didn't want to add "a magical TEST_TRY
> macro" - and I agree. Someone tri
rmaprath added a comment.
LGTM.
https://reviews.llvm.org/D26457
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
rmaprath added a comment.
Not sure if either of these tests add much value to the no-exceptions variant,
using `std::nested_exception` with such a library seem pointless to me. Perhaps
marking these as `UNSUPPORTED` is a better fix?
https://reviews.llvm.org/D26458
__
rmaprath added a comment.
In https://reviews.llvm.org/D26458#590865, @rmaprath wrote:
> Not sure if either of these tests add much value to the no-exceptions
> variant, using `std::nested_exception` with such a library seem pointless to
> me. Perhaps marking these as `UNSUPPORTED` is a better f
rmaprath created this revision.
rmaprath added a subscriber: cfe-commits.
The ostream header contains an un-guarded reference to uncaught_exception()
which causes it to drag in the exception handling machinery even when not
required (i.e. when compiling with -fno-exceptions). There are no tests
rmaprath updated this revision to Diff 35367.
rmaprath added a comment.
Updated patch with bit more context (-U20).
http://reviews.llvm.org/D13054
Files:
include/ostream
Index: include/ostream
===
--- include/ostream
+++ include
rmaprath added a comment.
Gentle ping.
http://reviews.llvm.org/D13054
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
rmaprath abandoned this revision.
rmaprath added a comment.
Abandoning revision as it seems I cannot add subscribers/reviewers to existing
phab reviews.
http://reviews.llvm.org/D14172
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://l
rmaprath created this revision.
rmaprath added reviewers: rengolin, mclow.lists.
rmaprath added a subscriber: cfe-commits.
Fixes a small omission in libcxx that prevents libcxx being built when
-DLIBCXX_ENABLE_EXCEPTIONS=0 is used.
I will do a follow-up patch to introduce the new libc++ build to
rmaprath created this revision.
rmaprath added reviewers: rengolin, gribozavr, gkistanova, EricWF.
rmaprath added a subscriber: cfe-commits.
This patch adds the necessary builders to zorg to get the -fno-exceptions
libcxx library variant building. I've only used those build-slaves which I have
g
rmaprath added a comment.
PS: I've run a couple of hand-crafted builders on a locally hacked up buildbot
and made sure the above changes are fine.
http://reviews.llvm.org/D14293
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.l
rmaprath added inline comments.
Comment at: buildbot/osuosl/master/config/builders.py:771
@@ +770,3 @@
+ # the -fno-exceptions library build.
+ additional_features={'no-libcxx-tests'}),
+ 'category': 'libcxx'},
jroelofs wrote:
> How
rmaprath added inline comments.
Comment at: buildbot/osuosl/master/config/builders.py:874
@@ -842,1 +873,3 @@
'CMAKE_CXX_FLAGS': '-mcpu=cortex-a15'})},
+
+# Cortex-A15 -fno-exceptions libcxx build (skips libcxx tests)
rengoli
rmaprath added a comment.
In http://reviews.llvm.org/D14293#280982, @rengolin wrote:
> Hi Asiri,
>
> Can I propose a different approach?
>
> We now have a silent buildbot, which will never email people about breakages,
> but can be publicly monitored by you, me and others. I'm assuming you have
rmaprath added a comment.
In http://reviews.llvm.org/D14293#281183, @rengolin wrote:
> In http://reviews.llvm.org/D14293#281176, @jroelofs wrote:
>
> > I think this ^ is a reasonable solution.
>
>
> I'm fine with that, as long as everyone's happy.
>
> 160 XFAILs are ok (as long as you're fixing t
rmaprath updated this revision to Diff 39541.
rmaprath added a comment.
Patch updated to add XFAILS for all those tests that are failing on the new
(-fno-exceptions) library variant. Follow-up patches will progressively
un-XFAIL these tests (i.e. adapt them to cope with the new library variant).
rmaprath closed this revision.
rmaprath added a comment.
Thanks Jon!
Committed as r252598. The current buildbots are happy (except for the ARM one,
which seem to have gone away).
I will update http://reviews.llvm.org/D14293 to include the new runs.
Cheers,
- Asiri
http://reviews.llvm.org/D1
rmaprath updated this revision to Diff 39806.
rmaprath added a comment.
Updated patch to remove the skipping of tests. Now that we have the appropriate
XFAILs in place, these two builders should be green.
I've locally tested the x86 run, I expect the ARM run to be fairly similar.
@Renato: could
rmaprath added inline comments.
Comment at: buildbot/osuosl/master/config/builders.py:880
@@ +879,3 @@
+# See: libcxxabi/test/lit.cfg
+lit_extra_opts={'link_flags': '"-lc++abi -lc -lm -lpthread
-lunwind -ldl -L/opt/llvm/lib/clang/3.6.0/lib/linux -lclang_rt
rmaprath added a comment.
Would it be OK if I commit the x86 buildbot changes (Dmitri approved these
earlier) while the ARM buildbot changes are being reviewed? I suppose the
changes would only take effect once @gkistanova restarts/reconfigs the
build-master ?
Cheers,
- Asiri
http://reviews
Author: asiri
Date: Thu Nov 12 04:41:57 2015
New Revision: 252870
URL: http://llvm.org/viewvc/llvm-project?rev=252870&view=rev
Log:
[libcxx] Fixup a few fumbles in the initial no-exceptions XFAILs list.
The initial buildbot run found a few missing bits in the initial XFAIL list
for the no-excepti
rmaprath created this revision.
rmaprath added reviewers: EricWF, jroelofs, mclow.lists, rengolin.
rmaprath added a subscriber: cfe-commits.
The macro TEST_HAS_NO_EXCEPTIONS seems to be defined very similar to
_LIBCPP_NO_EXCEPTIONS, I'm thinking of getting rid of the former as the latter
is more
Hi Ben,
Looks like there's a typo in this patch that is causing a buildbot failure:
http://lab.llvm.org:8011/builders/libcxx-libcxxabi-singlethreaded-x86_64-linux-debian/builds/1128/steps/build.libcxx/logs/stdio
Also seen in our local builders. I will fix it if I get around to it before
you :)
C
He Petr,
This commit (and #121757) have broken a couple of builders, see:
http://lab.llvm.org:8011/builders/libcxx-libcxxabi-libunwind-x86_64-linux-debian/builds/135
We are also seeing this on our downstream builders.
Cheers,
/ Asiri
On Mon, Aug 8, 2016 at 11:09 PM, Petr Hosek via cfe-commits
rmaprath added a subscriber: rmaprath.
rmaprath added a comment.
I too noticed this very recently (on our non-bare-metal builds), and wondered
why these dependencies are not included by default. Thanks for looking into it.
I'll let someone familiar with the details approve.
https://reviews.llv
rmaprath updated this revision to Diff 68011.
rmaprath added a comment.
Rebased.
https://reviews.llvm.org/D21968
Files:
CMakeLists.txt
include/__config
include/__config_site.in
include/__threading_support
lib/CMakeLists.txt
test/CMakeLists.txt
test/libcxx/test/config.py
test/li
rmaprath added a comment.
Ping?
http://reviews.llvm.org/D16586
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
rmaprath added inline comments.
Comment at: test/CodeGen/aapcs-bitfield.c:312-317
@@ +311,8 @@
+
+ // BE: %[[PTR3:.*]] = bitcast %struct.st5a* %[[PTR2]] to i32*
+ // BE-NEXT: %[[LD:.*]] = load volatile i32, i32* %[[PTR3]], align 4
+ // BE-NEXT: %[[CLR:.*]] = and i32 %[[LD]], -1
rmaprath updated this revision to Diff 55119.
rmaprath added a comment.
Addressing review comments from @bcraig:
In the earlier patch, I tried to keep the `__os_support` header to a minimum by
not exposing the internal pthread dependencies (in library sources) in this
header. This however blew
rmaprath updated this revision to Diff 55127.
rmaprath added a comment.
Addressing review comments from @bcraig:
Adjusted according to the changes of http://reviews.llvm.org/D19412. This patch
is now mostly trivial.
There is a small catch in that, this version of the API takes
pointer-to-point
rmaprath added a comment.
> On a bikeshed note: is `<__os_support>` the right name? Or should it be
> something like `<__thread>` or `<__threading_support>`?
I went with `__os_support` in case if we'd want to group further external
dependencies (like, for example, if some non-c POSIX calls a
rmaprath added inline comments.
Comment at: src/algorithm.cpp:51
@@ -50,3 +50,3 @@
#ifndef _LIBCPP_HAS_NO_THREADS
-static pthread_mutex_t __rs_mut = PTHREAD_MUTEX_INITIALIZER;
+static mutex __rs_mut;
#endif
bcraig wrote:
> rmaprath wrote:
> > mclow.lists wrote:
rmaprath updated this revision to Diff 55425.
rmaprath added a comment.
Addressing review comments by @mclow.lists:
- Switched to `_LIBCPP_ALWAYS_INLINE` from `_LIBCPP_INLINE_VISIBILITY` for all
`__os_xxx` functions.
I've left the remaining points (naming of `__os_support` header and
initializ
rmaprath updated this revision to Diff 55443.
rmaprath added a comment.
Renamed `__os_support` to `__threading_support` as suggested by @mclow.lists
and @bcraig. I've left the namespace name `__libcpp_os_support` untouched, can
change it to `__libcpp_threading_support` if the latter is preferred
rmaprath updated this revision to Diff 55501.
rmaprath added a comment.
Addressing review comments from @EricWF:
- Agree with all the suggested changes, I've applied them all.
Thanks!
/ Asiri
http://reviews.llvm.org/D19412
Files:
include/__config
include/__mutex_base
include/__threadin
rmaprath updated this revision to Diff 55503.
rmaprath added a comment.
Updating to syc-up with http://reviews.llvm.org/D19412. Obviously, this patch
needs more work in terms of setting up the testing story (using a pthreads
based implementation of the threading API).
http://reviews.llvm.org/D
rmaprath updated this revision to Diff 7.
rmaprath added a comment.
In http://reviews.llvm.org/D19412#416183, @EricWF wrote:
> OK. I *think* this is my last round of review comments except for one
> specific issue. I'm still looking into the changes to the static mutex's and
> condition_var
rmaprath updated this revision to Diff 55570.
rmaprath added a comment.
Re-sync with http://reviews.llvm.org/D19412.
http://reviews.llvm.org/D19415
Files:
include/__threading_support
Index: include/__threading_support
===
--- in
rmaprath updated this revision to Diff 55569.
rmaprath added a comment.
Minor tweak: Got rid of the unnecessary template parameters on
`__libcpp_thread_create` and `__libcpp_tl_create`.
http://reviews.llvm.org/D19412
Files:
include/__config
include/__mutex_base
include/__threading_suppor
rmaprath updated this revision to Diff 55571.
rmaprath added a comment.
Missed one: s/_LIBCPP_COND_INITIALIZER/_LIBCPP_CONDVAR_INITIALIZER
http://reviews.llvm.org/D19412
Files:
include/__config
include/__mutex_base
include/__threading_support
include/mutex
include/thread
src/algorit
rmaprath updated this revision to Diff 55573.
rmaprath added a comment.
Minor re-spin on http://reviews.llvm.org/D19412.
http://reviews.llvm.org/D19415
Files:
include/__threading_support
Index: include/__threading_support
===
--
rmaprath updated this revision to Diff 55593.
rmaprath added a comment.
Added missing `__confg` header include.
http://reviews.llvm.org/D19412
Files:
include/__config
include/__mutex_base
include/__threading_support
include/mutex
include/thread
src/algorithm.cpp
src/condition_vari
rmaprath added a comment.
In http://reviews.llvm.org/D19412#417682, @EricWF wrote:
> In http://reviews.llvm.org/D19412#416596, @rmaprath wrote:
>
> > In http://reviews.llvm.org/D19412#416183, @EricWF wrote:
> >
> > > OK. I *think* this is my last round of review comments except for one
> > > spe
rmaprath updated this revision to Diff 55961.
rmaprath added a comment.
As agreed, reverted back to using the native mutex / condition_variable types
within library sources.
@EricWF: Good to go now?
Thanks.
/ Asiri
http://reviews.llvm.org/D19412
Files:
include/__config
include/__mutex_b
rmaprath updated this revision to Diff 55965.
rmaprath added a comment.
Added missing initializer (typo).
http://reviews.llvm.org/D19412
Files:
include/__config
include/__mutex_base
include/__threading_support
include/mutex
include/thread
src/algorithm.cpp
src/condition_variable.c
rmaprath updated this revision to Diff 55967.
rmaprath added a comment.
Re-spun on top of http://reviews.llvm.org/D19412.
http://reviews.llvm.org/D19415
Files:
include/__threading_support
src/algorithm.cpp
src/memory.cpp
src/mutex.cpp
Index: src/mutex.cpp
==
rmaprath created this revision.
rmaprath added reviewers: jroelofs, logan.
rmaprath added subscribers: cfe-commits, logan.
Hi Jon,
Spotted some obviously unused code in `Unwind-EHABI.cpp` while working on
something else. This seem to have been introduced in revision
`9f323e0fca08a0d60c51c4d0927
rmaprath created this revision.
rmaprath added a reviewer: jroelofs.
rmaprath added a subscriber: cfe-commits.
Herald added subscribers: rengolin, aemerson.
Currently, `unw_context_t` and `unw_cursor_t` are sized to allow the virtual
register set of any target supported by libunwind. This does no
rmaprath added a comment.
In http://reviews.llvm.org/D19920#421131, @t.p.northover wrote:
> I think it would be better to use a generic method so the size is minimal
> everywhere rather than making ARM a special case. Possibly move the #define
> bits from libunwind.cpp to __libunwind_config.h a
rmaprath added a comment.
In http://reviews.llvm.org/D19920#421145, @jroelofs wrote:
> Wouldn't this break cross unwinding?
I wasn't aware of cross unwinding, I think you are referring to [1]. Thanks for
the pointer.
Would it make sense to support a libunwind build that only supports native
rmaprath added a comment.
In http://reviews.llvm.org/D19920#421189, @jroelofs wrote:
> In http://reviews.llvm.org/D19920#421173, @rmaprath wrote:
>
> > In http://reviews.llvm.org/D19920#421145, @jroelofs wrote:
> >
> > > Wouldn't this break cross unwinding?
> >
> >
> > I wasn't aware of cross unw
rmaprath added a comment.
In http://reviews.llvm.org/D19920#421230, @bcraig wrote:
> > We could, on the other hand, do this tightening for all the supported
> > architectures (for the new, native-only libunwind build suggested by
> > @jroelofs) with appropriate asserts in place so that we maint
rmaprath added a comment.
@mclow.lists, @EricWF: Gentle ping.
http://reviews.llvm.org/D19412
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: asiri
Date: Fri May 6 09:06:29 2016
New Revision: 268734
URL: http://llvm.org/viewvc/llvm-project?rev=268734&view=rev
Log:
Refactor pthread usage of libcxx.
This patch extracts out all the pthread dependencies of libcxx into the
new header __threading_support. The motivation is to make i
rmaprath closed this revision.
rmaprath added a comment.
@EricWF: Thanks for taking the time to review! :)
Committed as r268734. The bots seem to be happy.
http://reviews.llvm.org/D19412
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http:
rmaprath added a comment.
@espositofulvio: Thanks for the patch! :)
Committed as r268734.
Repository:
rL LLVM
http://reviews.llvm.org/D11781
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/c
rmaprath created this revision.
rmaprath added reviewers: jroelofs, bcraig.
rmaprath added a subscriber: cfe-commits.
Herald added a subscriber: aemerson.
This patch is generalization of D19920.
A new native-only libunwind variant (selectable through the
`-DLIBUNWIND_ENABLE_CROSS_UNWINDING=OFF`
rmaprath abandoned this revision.
rmaprath added a comment.
Superseded by http://reviews.llvm.org/D20119.
http://reviews.llvm.org/D19920
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commi
rmaprath added inline comments.
Comment at: include/libunwind.h:49
@@ -48,1 +48,3 @@
struct unw_context_t {
+#if defined(_LIBUNWIND_NATIVE_I386)
+ uint64_t data[8];
rengolin wrote:
> Wouldn't it be a lot simpler to just define a macro _LIBUNWIND_DATA_SIZE or
>
rmaprath updated this revision to Diff 56779.
rmaprath added a comment.
Address review comments by @rengolin:
- Define and use `_LIBUNWIND_CONTEXT_SIZE` and `_LIBUNWIND_CURSOR_SIZE` macros
http://reviews.llvm.org/D20119
Files:
CMakeLists.txt
include/__libunwind_config.h
include/libunwind
rmaprath marked an inline comment as done.
rmaprath added a comment.
http://reviews.llvm.org/D20119
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
rmaprath added a comment.
Gentle ping.
http://reviews.llvm.org/D20119
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: asiri
Date: Sat May 14 18:58:11 2016
New Revision: 269585
URL: http://llvm.org/viewvc/llvm-project?rev=269585&view=rev
Log:
Disable LIBCXX_ENABLE_ABI_LINKER_SCRIPT for static library builds.
This option is geared towards shared library builds and causes static
library builds to fail if no
rmaprath added a comment.
Ping.
http://reviews.llvm.org/D20119
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
rmaprath created this revision.
rmaprath added reviewers: jroelofs, bcraig.
rmaprath added a subscriber: cfe-commits.
Herald added a subscriber: aemerson.
This is a follow-up to D20119.
`unwind_phase1` and `unwind_phase2` allocate their own copies of `unw_cursor_t`
buffers on the stack. This can
rmaprath created this revision.
rmaprath added reviewers: mclow.lists, EricWF, bcraig.
rmaprath added a subscriber: cfe-commits.
This patch builds on the work done under D19412 where all `pthread`
dependencies were refactored under a separate thread-support API.
The current patch enables buildin
rmaprath abandoned this revision.
rmaprath added a comment.
Superseded by http://reviews.llvm.org/D20328.
http://reviews.llvm.org/D19415
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commi
rmaprath added inline comments.
Comment at: src/UnwindCursor.hpp:580
@@ -579,3 +605,1 @@
_isSignalFrame(false) {
- static_assert(sizeof(UnwindCursor) < sizeof(unw_cursor_t),
-"UnwindCursor<> does not fit in unw_cursor_t");
jroelofs wrote:
>
rmaprath updated this revision to Diff 57487.
rmaprath added a comment.
Addressing review comments from @jroelofs:
- Moved the assertion in `libunwind.cpp` back to `UnwindCursor.cpp` where it
really belogs.
@jroelofs: I just realized that, with this new native-only build of
`libunwind`, users
rmaprath added a subscriber: rmaprath.
rmaprath added a comment.
Hi, could I know the status of this? I'd like to push this forward.
@espositofulvio: Are you working on this? (just checking since this has gone
stale for a while). @EricWF: I can create a separate diff for further review if
this
rmaprath added a comment.
Hi Eric, Thanks for the comments!
I'll wait a bit for @espositofulvio in case if he wants to push this, otherwise
I'll create a new diff with the suggested changes.
For us (ARM), a threads porting layer is important on several RTOSes (where a
full-blown pthreads imple
rmaprath added a comment.
In http://reviews.llvm.org/D11781#403343, @theraven wrote:
> In http://reviews.llvm.org/D11781#403335, @rmaprath wrote:
>
> > For us (ARM), a threads porting layer is important on several RTOSes (where
> > a full-blown pthreads implementations is not available). I will
rmaprath added a comment.
In http://reviews.llvm.org/D11781#403378, @espositofulvio wrote:
> In http://reviews.llvm.org/D11781#400968, @rmaprath wrote:
>
> > Hi, could I know the status of this? I'd like to push this forward.
> >
> > @espositofulvio: Are you working on this? (just checking since
rmaprath added a comment.
In http://reviews.llvm.org/D11781#403349, @rmaprath wrote:
> In http://reviews.llvm.org/D11781#403343, @theraven wrote:
>
> > In http://reviews.llvm.org/D11781#403335, @rmaprath wrote:
> >
> > > For us (ARM), a threads porting layer is important on several RTOSes
> > >
rmaprath added a comment.
In http://reviews.llvm.org/D14293#350570, @rengolin wrote:
> Sorry, this fell out of my radar. I'm ok with the changes. Ping me when you
> commit so I can monitor the bot for a while.
Sorry, I missed your message this time around :)
I'll double-check the patch and co
rmaprath created this revision.
rmaprath added reviewers: EricWF, theraven, mclow.lists, jroelofs.
rmaprath added subscribers: espositofulvio, cfe-commits.
This is mostly D11781 with the final review comments addressed:
- Merged all the headers into a single `__os_support` header
- Moved all inter
rmaprath updated this revision to Diff 54658.
rmaprath added a comment.
Added bit more context to the diff.
http://reviews.llvm.org/D19412
Files:
include/__config
include/__mutex_base
include/__os_support
include/mutex
include/thread
src/algorithm.cpp
src/condition_variable.cpp
rmaprath created this revision.
rmaprath added reviewers: EricWF, mclow.lists, theraven, jroelofs.
rmaprath added a subscriber: cfe-commits.
Herald added a subscriber: aemerson.
This patch builds on D19412.
The motivation here is to allow toolchain vendors to build a version of
`libcxx` with all
rmaprath added a comment.
I forgot to mention that we will need a similar (although much smaller) porting
layer for `libcxxabi` and `libunwind`, as those too currently have a pthread
dependency.
http://reviews.llvm.org/D19415
___
cfe-commits maili
101 - 200 of 336 matches
Mail list logo
