@Renato: What's your take on Ed's idea?

We use phab for all sorts of reviews, but it should be possible to figure
out which repository a review is intended to land on and add cfe-commits or
llvm-commits appropriately.

Although, for throw-away reviews, it might generate too much spam.

Cheers,

/ Asiri


On Wed, Mar 8, 2017 at 3:18 PM, Ed Schouten <e...@nuxi.nl> wrote:

> Hi Asiri,
>
> 2017-03-07 20:42 GMT+01:00 Asiri Rathnayake <asiri.rathnay...@gmail.com>:
> > Could you please always include cfe-commits as a subscriber in you phab
> > reviews?
> >
> > We would like to be aware of these changes in advance before they land.
>
> Sure thing! I'll try to do that from now on.
>
> That said, if the policy is to add cfe-commits@ to all
> Clang/libunwind-related code reviews, would it make sense to configure
> Phabricator's Herald to set this up for us automatically? Looking at
> https://reviews.llvm.org/herald/new/, I suspect that can only be
> configured with admin rights.
>
> Regards,
> --
> Ed Schouten <e...@nuxi.nl>
> Nuxi, 's-Hertogenbosch, the Netherlands
> KvK-nr.: 62051717
>
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to