[PATCH] D151183: [clang][dataflow] Add a `ControlFlowContext::build()` overload taking a `FunctionDecl`.

mboehme marked an inline comment as done. mboehme added inline comments. Comment at: clang/include/clang/Analysis/FlowSensitive/ControlFlowContext.h:39 + /// Builds a ControlFlowContext from an AST node. `D` is the function in which /// `S` resides. `D.isTemplated()` must

[PATCH] D151194: [clang][dataflow] Add support for return values of reference type.

mboehme marked an inline comment as done. mboehme added inline comments. Comment at: clang/include/clang/Analysis/FlowSensitive/DataflowEnvironment.h:196 + void popCall(const CallExpr *Call, const Environment &CalleeEnv); + void popCall(const CXXConstructExpr *Call, const Envir

[PATCH] D151397: [3/N][RISCV] Model vxrm in C intrinsics for RVV fixed-point instruction vaadd

eopXD updated this revision to Diff 525463. eopXD marked 3 inline comments as done. eopXD added a comment. Address comments from Craig. Now the patch includes changes to vaadd/vaaddu/vasub/vasubu. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D15139

[PATCH] D151397: [3/N][RISCV] Model vxrm in C intrinsics for RVV fixed-point instruction vaadd

eopXD marked an inline comment as done. eopXD added inline comments. Comment at: llvm/include/llvm/IR/IntrinsicsRISCV.td:1365 defm vaaddu : RISCVSaturatingBinaryAAX; - defm vaadd : RISCVSaturatingBinaryAAX; - defm vaadd_rm : RISCVSaturatingBinaryAAXRoundingMode; + defm vaad

[clang] 246626a - [clang][dataflow] Add a `ControlFlowContext::build()` overload taking a `FunctionDecl`.

Author: Martin Braenne Date: 2023-05-25T07:19:12Z New Revision: 246626a8cfd3d4f910baadeff4d5aa544b9d4550 URL: https://github.com/llvm/llvm-project/commit/246626a8cfd3d4f910baadeff4d5aa544b9d4550 DIFF: https://github.com/llvm/llvm-project/commit/246626a8cfd3d4f910baadeff4d5aa544b9d4550.diff LOG

[PATCH] D150913: [Clang][BFloat16] Upgrade __bf16 to arithmetic type, change mangling, and extend excess precision support.

pengfei added inline comments. Comment at: clang/docs/LanguageExtensions.rst:852 ``double`` when passed to ``printf``, so the programmer must explicitly cast it to ``double`` before using it with an ``%f`` or similar specifier. rjmccall wrote: > pengfei wrot

[PATCH] D151183: [clang][dataflow] Add a `ControlFlowContext::build()` overload taking a `FunctionDecl`.

This revision was automatically updated to reflect the committed changes. mboehme marked an inline comment as done. Closed by commit rG246626a8cfd3: [clang][dataflow] Add a `ControlFlowContext::build()` overload taking a… (authored by mboehme). Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D148793: [WIP][clang-tidy] Implement an include-cleaner check.

kadircet added inline comments. Comment at: clang-tools-extra/clang-tidy/misc/IncludeCleanerCheck.cpp:61 +void IncludeCleanerCheck::storeOptions(ClangTidyOptions::OptionMap &Opts) { + Options.store(Opts, "Suppress", ""); +} after storing them in the class state

[PATCH] D151397: [3/N][RISCV] Model vxrm in C intrinsics for RVV fixed-point instruction vaadd

eopXD updated this revision to Diff 525473. eopXD added a comment. Bump CI because previous diff failed in patch application. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151397/new/ https://reviews.llvm.org/D151397 Files: clang/include/clang/B

[PATCH] D148793: [WIP][clang-tidy] Implement an include-cleaner check.

sammccall added a comment. Drive-by nit: want add this to the `disableUnusableChecks()` blocklist in `clangd/TidyProvider.cpp`? Since inside clangd we want to use the direct feature instead. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148793/new/

[clang-tools-extra] a2f7352 - [clangd] Dont run raw-lexer for OOB source locations

Author: Kadir Cetinkaya Date: 2023-05-25T09:38:04+02:00 New Revision: a2f7352f3e809cb1b267e769d00ea84e4ef46bf0 URL: https://github.com/llvm/llvm-project/commit/a2f7352f3e809cb1b267e769d00ea84e4ef46bf0 DIFF: https://github.com/llvm/llvm-project/commit/a2f7352f3e809cb1b267e769d00ea84e4ef46bf0.dif

[PATCH] D151321: [clangd] Dont run raw-lexer for OOB source locations

This revision was automatically updated to reflect the committed changes. Closed by commit rGa2f7352f3e80: [clangd] Dont run raw-lexer for OOB source locations (authored by kadircet). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151321/new/ https:/

[PATCH] D151308: -fsanitize=function: fix alignment fault on Arm targets.

simon_tatham added a comment. > `-fsanitize=kcfi` only supports aarch64 and x86-64 now. riscv64 is on the > plan. > > % fclang -fsanitize=kcfi --traget=armv7-linux-gnueabi -c a.c > clang: error: unsupported option '--traget=armv7-linux-gnueabi' Sorry to contradict, but that error message onl

[clang] 20d6dee - -fsanitize=function: fix alignment fault on Arm targets.

Author: Simon Tatham Date: 2023-05-25T09:22:45+01:00 New Revision: 20d6dee40d507d467d3312d5e7dfdf088f106d31 URL: https://github.com/llvm/llvm-project/commit/20d6dee40d507d467d3312d5e7dfdf088f106d31 DIFF: https://github.com/llvm/llvm-project/commit/20d6dee40d507d467d3312d5e7dfdf088f106d31.diff

[PATCH] D151308: -fsanitize=function: fix alignment fault on Arm targets.

This revision was automatically updated to reflect the committed changes. Closed by commit rG20d6dee40d50: -fsanitize=function: fix alignment fault on Arm targets. (authored by simon_tatham). Changed prior to commit: https://reviews.llvm.org/D151308?vs=525111&id=525479#toc Repository: rG LLV

[PATCH] D150635: [clangd] Implement end-definition-comment inlay hints

sammccall accepted this revision. sammccall added a comment. This revision is now accepted and ready to land. > 150ms is more than noticeable Fair enough. I also see we *are* avoiding the quadratic algorithm in other places in inlay hints, and that we can't easily reuse the getHintRange() funct

[clang] 6441358 - [clang][dataflow] Add support for return values of reference type.

Author: Martin Braenne Date: 2023-05-25T08:38:33Z New Revision: 64413584dacba1fccffa345f69043b3509ee1745 URL: https://github.com/llvm/llvm-project/commit/64413584dacba1fccffa345f69043b3509ee1745 DIFF: https://github.com/llvm/llvm-project/commit/64413584dacba1fccffa345f69043b3509ee1745.diff LOG

[PATCH] D151194: [clang][dataflow] Add support for return values of reference type.

This revision was automatically updated to reflect the committed changes. mboehme marked an inline comment as done. Closed by commit rG64413584dacb: [clang][dataflow] Add support for return values of reference type. (authored by mboehme). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[clang] 2e6325c - Revert "[-Wunsafe-buffer-usage] Group variables associated by pointer assignments"

Author: Douglas Yung Date: 2023-05-25T02:10:32-07:00 New Revision: 2e6325c71feb5ab45ef3dbf4362db38602288a4e URL: https://github.com/llvm/llvm-project/commit/2e6325c71feb5ab45ef3dbf4362db38602288a4e DIFF: https://github.com/llvm/llvm-project/commit/2e6325c71feb5ab45ef3dbf4362db38602288a4e.diff

[PATCH] D145739: [-Wunsafe-buffer-usage] Group variables associated by pointer assignments

dyung added a comment. @t-rasmud I am sorry, but I had to revert your change, it is randomly failing on the Windows bots causing a lot of instability. See the revert commit message for examples. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145739

[PATCH] D150253: [RISCV] Add Zvfhmin extension.

jacquesguan updated this revision to Diff 525494. jacquesguan added a comment. Split into 2 revisions and address comment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150253/new/ https://reviews.llvm.org/D150253 Files: clang/include/clang/Basi

[PATCH] D151201: [clang][dataflow] Fix a crash in `getLogicOperatorSubExprValue()`.

mboehme updated this revision to Diff 525501. mboehme added a comment. Add check that the value of the expression is true. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151201/new/ https://reviews.llvm.org/D151201 Files: clang/lib/Analysis/FlowS

[PATCH] D151201: [clang][dataflow] Fix a crash in `getLogicOperatorSubExprValue()`.

mboehme marked an inline comment as done. mboehme added inline comments. Comment at: clang/unittests/Analysis/FlowSensitive/TransferTest.cpp:5064 +bool target() { + return true || false || false || false; +} xazax.hun wrote: > Should we also test tha

[PATCH] D151344: Reland "[CMake] Bumps minimum version to 3.20.0.

hans added a comment. This looks right to me. (I'm out of office at the moment, but this looks like what I tested in https://github.com/llvm/llvm-project/issues/62719 so it should work.) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151344/new/ h

[PATCH] D150902: [ARM][Driver] Warn if -mhard-float is incompatible

simon_tatham added inline comments. Comment at: clang/lib/Driver/ToolChains/Arch/ARM.cpp:151 + const std::vector &Features) { + if (llvm::find(Features, "-fpregs") == Features.end()) +return; This whole patch hinges on the unspoke

[PATCH] D145265: [Pipeline] Remove GlobalCleanupPM

nikic added a comment. Unfortunately I'm seeing a number of Rust optimization regressions with this change. I'll try to reduce those to some PhaseOrdering tests. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145265/new/ https://reviews.llvm.org/D1

[PATCH] D151308: -fsanitize=function: fix alignment fault on Arm targets.

peter.smith added a comment. In D151308#4369828 , @MaskRay wrote: > In D151308#4367704 , @peter.smith > wrote: > >> This looks good to me. Will be worth waiting for a day to give the US time >> zone time to leav

[PATCH] D151081: [Clang][SVE2.1] Add svpext builtins

CarolineConcatto updated this revision to Diff 525508. CarolineConcatto marked 2 inline comments as done. CarolineConcatto added a comment. Add doxygen comments to FormSVEBuiltinResult function Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151081/ne

[PATCH] D145265: [Pipeline] Remove GlobalCleanupPM

nikic added a comment. Here are two inputs that currently fold down to constants and no longer do so with this patch: https://gist.github.com/nikic/4a714ea550bf2252543570585f642af2 These need further reduction for PhaseOrdering tests, but should be a good starting point for analysis... Reposi

[PATCH] D151253: [clangd] Move completion signatures and labelDetails

sammccall updated this revision to Diff 525517. sammccall retitled this revision from "[clangd] Move completion signatures and insertion markers into labelDetails" to "[clangd] Move completion signatures and labelDetails". sammccall edited the summary of this revision. sammccall added a comment.

[PATCH] D148700: [clang] Add support for “regular” keyword attributes

rsandifo-arm added a comment. Thanks @aaron.ballman and @erichkeane for your patience in reviewing the patch and steering me in the right direction. What do you think about the other two patches in the series: - https://reviews.llvm.org/D148699 (comes before this one) - https://reviews.llvm.org

[PATCH] D150253: [RISCV] Add Zvfhmin extension for clang.

jacquesguan marked 8 inline comments as done. jacquesguan added a comment. https://reviews.llvm.org/D151414 this is the backend part. Comment at: clang/include/clang/Basic/riscv_vector.td:1856 def vfwcvt_f_x_v : RVVConvBuiltin<"Fw", "Fwv", "csi", "vfwcvt_f">; - def vfwcvt_f

[PATCH] D151047: [clang-format] Fix indentation for selective formatting.

HazardyKnusperkeks added a comment. In D151047#4369742 , @Sedeniono wrote: > To create a new fix, do I understand the guide > correctly that > I basically execute `arc diff --verbatim` and m

[PATCH] D151183: [clang][dataflow] Add a `ControlFlowContext::build()` overload taking a `FunctionDecl`.

chapuni added inline comments. Comment at: clang/unittests/Analysis/FlowSensitive/TypeErasedDataflowAnalysisTest.cpp:71 - auto CFCtx = llvm::cantFail( - ControlFlowContext::build(*Func, *Body, AST->getASTContext())); This was the only user of Body in -As

[clang] 0123deb - [Lex] Warn when defining or undefining any builtin macro

Author: John Brawn Date: 2023-05-25T11:55:44+01:00 New Revision: 0123deb3a6f0a83095287f51b07c77b7b43ab847 URL: https://github.com/llvm/llvm-project/commit/0123deb3a6f0a83095287f51b07c77b7b43ab847 DIFF: https://github.com/llvm/llvm-project/commit/0123deb3a6f0a83095287f51b07c77b7b43ab847.diff LO

[PATCH] D146418: Support for OpenMP 5.0 sec 2.12.7 - Declare Target initializer expressions

RitanyaB updated this revision to Diff 525531. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146418/new/ https://reviews.llvm.org/D146418 Files: clang/include/clang/Sema/Sema.h clang/lib/Sema/SemaDecl.cpp clang/lib/Sema/SemaOpenMP.cpp clang/test/OpenMP/declare_target_messages.cpp

[PATCH] D144654: [Lex] Warn when defining or undefining any builtin macro

john.brawn added a comment. D150966 should fix the failure that was seen in buildbots, so I've now re-committed this. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144654/new/ https://reviews.llvm.org/D144654 __

[PATCH] D151047: [clang-format] Fix indentation for selective formatting.

barannikov88 added a comment. In D151047#4369742 , @Sedeniono wrote: > To create a new fix, do I understand the guide > correctly that > I basically execute `arc diff --verbatim` and mention

[PATCH] D103930: [clang][HeaderSearch] Fix implicit module when using header maps

ivanmurashko added a comment. > Still looking at issues and not sure whether these are blockers or not. Friendly reminder: @benlangmuir, do you need any assistance from my side with it? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103930/new/ htt

[PATCH] D151383: [clang-tidy] Check for specific return types on all functions

PiotrZSL requested changes to this revision. PiotrZSL added a comment. This revision now requires changes to proceed. - Missing tests - Missing release notes - Missing check documentation update Comment at: clang-tools-extra/clang-tidy/bugprone/UnusedReturnValueCheck.cpp:159

[PATCH] D151426: [Clang][NFC] Prepare C++ DR suite for better test isolation

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. The changes LGTM (verified off-list that the regenerated HTML is identical before and after this change), but let's not land this until we've gotten farther along the review proc

[PATCH] D151429: print user provide value in tabstop diagnostic

csmoe created this revision. csmoe added a reviewer: clang. csmoe added a project: clang. Herald added a project: All. csmoe requested review of this revision. Herald added a subscriber: cfe-commits. github issue: https://github.com/llvm/llvm-project/issues/62912 Repository: rG LLVM Github Mon

[PATCH] D148699: [clang] Mark keywords that have their own parsing rules

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148699/new/ https://reviews.llvm.org/D148699

[PATCH] D151308: -fsanitize=function: fix alignment fault on Arm targets.

simon_tatham added a comment. In D151308#4367704 , @peter.smith wrote: > I note that this is also broken in -fsanitize=kcfi [*] > (https://reviews.llvm.org/D135411) although fixing that is a separate patch. > Would you be able to raise a github issue t

[PATCH] D151426: [Clang][NFC] Prepare C++ DR suite for better test isolation

Endill added a comment. In D151426#4371730 , @aaron.ballman wrote: > The changes LGTM (verified off-list that the regenerated HTML is identical > before and after this change), I've run `make_cxx_dr_status` on top of this patch, and learned that the pa

[PATCH] D148700: [clang] Add support for “regular” keyword attributes

aaron.ballman added a comment. In D148700#4371518 , @rsandifo-arm wrote: > Thanks @aaron.ballman and @erichkeane for your patience in reviewing the > patch and steering me in the right direction. > > What do you think about the other two patches in the

[PATCH] D151430: [clang][dataflow][NFC] Remove unused variable.

mboehme created this revision. Herald added subscribers: martong, xazax.hun. Herald added a project: All. mboehme requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Thanks to chapuni to pointing this out on https://reviews.llvm.org/D151183.

[clang] 49946df - [clang][dataflow][NFC] Remove unused variable.

Author: Martin Braenne Date: 2023-05-25T12:09:52Z New Revision: 49946df8211e9d36f0b3755e64b55bc28c0a4247 URL: https://github.com/llvm/llvm-project/commit/49946df8211e9d36f0b3755e64b55bc28c0a4247 DIFF: https://github.com/llvm/llvm-project/commit/49946df8211e9d36f0b3755e64b55bc28c0a4247.diff LOG

[PATCH] D151430: [clang][dataflow][NFC] Remove unused variable.

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG49946df8211e: [clang][dataflow][NFC] Remove unused variable. (auth

[PATCH] D151183: [clang][dataflow] Add a `ControlFlowContext::build()` overload taking a `FunctionDecl`.

mboehme marked an inline comment as done. mboehme added inline comments. Comment at: clang/unittests/Analysis/FlowSensitive/TypeErasedDataflowAnalysisTest.cpp:71 - auto CFCtx = llvm::cantFail( - ControlFlowContext::build(*Func, *Body, AST->getASTContext()));

[PATCH] D151162: Add -Wpacked-non-pod to -Wall

aaron.ballman added a comment. In D151162#4369717 , @SlaterLatiao wrote: > In D151162#4369584 , @aaron.ballman > wrote: > >> Please be sure to add a release note for the change, and it'd probably be >> good to

[PATCH] D151431: [clang-tidy] Add check bugprone-unique-ptr-array-mismatch.

balazske created this revision. Herald added subscribers: PiotrZSL, carlosgalvezp, steakhal, martong, gamesh411, Szelethus, dkrupp, xazax.hun. Herald added a reviewer: njames93. Herald added a project: All. balazske requested review of this revision. Herald added a project: clang-tools-extra. Hera

[PATCH] D150803: [WebAssembly] Add a new `wasm_async` clang attribute for marking async functions.

aaron.ballman added a reviewer: erichkeane. aaron.ballman added a comment. This is missing all the usual Sema tests that the attribute only applies to functions, takes no arguments, only works in web assembly targets, etc. Also, the changes should come with a release note so users know about the

[PATCH] D103930: [clang][HeaderSearch] Fix implicit module when using header maps

ivanmurashko updated this revision to Diff 525557. ivanmurashko added a comment. rebase to latest LLVM main branch Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103930/new/ https://reviews.llvm.org/D103930 Files: clang/lib/Lex/HeaderSearch.cpp

[PATCH] D145302: [clangd] Add library for clangd main function

ivanmurashko updated this revision to Diff 525558. ivanmurashko added a comment. rebased to the latest LLVM main Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145302/new/ https://reviews.llvm.org/D145302 Files: clang-tools-extra/clangd/CMakeList

[PATCH] D151087: [Clang] Permit address space casts with 'reinterpret_cast' in C++

aaron.ballman added a comment. In D151087#4363503 , @ebevhan wrote: > In D151087#4362059 , @aaron.ballman > wrote: > >> Based on all this, I think we should go with `__addrspace_cast` as a named >> cast and not

[PATCH] D151398: [clang] Make `FileEntryRef::getDir()` return the as-requested `DirectoryEntryRef`

rmaz accepted this revision. rmaz added a comment. This revision is now accepted and ready to land. LGTM Comment at: clang/include/clang/Basic/FileEntry.h:124 +/// Directory the file was found in. OptionalDirectoryEntryRef Dir; If this is always set

[PATCH] D151060: [Clang][Sema] Generate vector vs scalar builtin overloads

aaron.ballman added a comment. Thanks for the fix! The changes should come with a release note. Comment at: clang/lib/Sema/SemaOverload.cpp:9041-9044 + // (allowing splatting the scalar to a vector). + for (unsigned Candidate = 0; Candidate < 2; ++Candidate) { +

[PATCH] D151437: [NFC][Driver] Change MultilibBuilder interface

michaelplatings created this revision. michaelplatings added a reviewer: phosek. Herald added a subscriber: abrachet. Herald added a project: All. michaelplatings requested review of this revision. Herald added subscribers: cfe-commits, MaskRay. Herald added a project: clang. Decouple the interfac

[PATCH] D139010: [clang][WebAssembly] Implement support for table types and builtins

aaron.ballman added inline comments. Comment at: clang/docs/LanguageExtensions.rst:2288 +argument is the index to which to store the value into, and the +third argument is a value of reference type to store in the table. +It returns nothing. pmatos wrote: > aaron

[PATCH] D145302: [clangd] Add library for clangd main function

ivanmurashko updated this revision to Diff 525570. ivanmurashko added a comment. removed header install, only lib install has been left after the change CC: @kadircet Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145302/new/ https://reviews.llvm.o

[PATCH] D151438: [NFC][Driver] Change Multilib flag representation

michaelplatings created this revision. michaelplatings added a reviewer: phosek. Herald added a project: All. michaelplatings requested review of this revision. Herald added subscribers: cfe-commits, MaskRay. Herald added a project: clang. This new representation means that if a string is a valid

[PATCH] D151215: [clang][Diagnostics] Split source ranges into line ranges before...

aaron.ballman added reviewers: tahonermann, cor3ntin. aaron.ballman added subscribers: cor3ntin, tahonermann. aaron.ballman added a comment. This looks correct to me, but because it involves things like characters, lines, and output, I'd appreciate if @tahonermann or @cor3ntin could do the final

[PATCH] D146389: [clang-repl][CUDA] Initial interactive CUDA support for clang-repl

argentite updated this revision to Diff 525572. argentite added a comment. Workaround for depending on NVPTX symbols: initialize all available targets instead. If NVPTX is not available, it will complain when we try to actually execute anything in CUDA mode. Rebased and fixed conflicts on recent

[PATCH] D146757: [Driver] Enable defining multilib flags verbatim

michaelplatings abandoned this revision. michaelplatings added a comment. Abandoning this in favour of D151437 & D151438 . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146757/new

[PATCH] D149872: [OpenMP][OMPIRBuilder] Migrate emitOffloadingArrays and EmitNonContiguousDescriptor from Clang

TIFitis added a comment. Ping for review :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149872/new/ https://reviews.llvm.org/D149872 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://list

[PATCH] D150860: [OpenMP] Change clang emitTargetDataCalls to use OMPIRBuilder

TIFitis marked 2 inline comments as not done. TIFitis added a comment. Ping for reviews :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150860/new/ https://reviews.llvm.org/D150860 ___ cfe-commits maili

[PATCH] D150185: [include-cleaner] Allow multiple strategies for spelling includes.

VitaNuo created this revision. Herald added subscribers: kadircet, arphaman. Herald added a project: All. VitaNuo updated this revision to Diff 525477. VitaNuo added a comment. VitaNuo updated this revision to Diff 525560. VitaNuo updated this revision to Diff 525566. VitaNuo updated this revision

[PATCH] D147321: [RFC][Flang][OMPIRBuilder] Add nounwind attribute to the LLVM IR

domada added inline comments. Comment at: llvm/lib/Frontend/OpenMP/OMPIRBuilder.cpp:5063 + } +} + jdoerfert wrote: > jdoerfert wrote: > > Style `F` > Why does this belong here? We should do it like clang, one function at a > time, or in a generic place. This is

[PATCH] D151439: [Clang][SVE2.1] Add builtins for 2-way svdot (vectors, indexed)

CarolineConcatto created this revision. Herald added subscribers: arphaman, kristof.beyls, tschuett. Herald added a project: All. CarolineConcatto requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. As described in: https://github.com/ARM-softw

[PATCH] D150253: [RISCV] Add Zvfhmin extension for clang.

michaelmaitland added inline comments. Comment at: llvm/lib/Target/RISCV/RISCVSubtarget.h:162 + bool hasVInstructionsF16Mininal() const { +return HasStdExtZvfhmin || HasStdExtZvfh; + } jacquesguan wrote: > craig.topper wrote: > > Doesn't HasStdExtZvfh alrea

[PATCH] D150185: [include-cleaner] Allow multiple strategies for spelling includes.

VitaNuo updated this revision to Diff 525581. VitaNuo added a comment. Move the speller out of the loop. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150185/new/ https://reviews.llvm.org/D150185 Files: clang-tools-extra/clangd/Hover.cpp clang

[PATCH] D150528: [Clang][Attribute] Improve the AST/diagnoses fidelity of alignas and _Alignas

yronglin added a comment. ping～ @erichkeane Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150528/new/ https://reviews.llvm.org/D150528 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://list

[PATCH] D150253: [RISCV] Add Zvfhmin extension for clang.

michaelmaitland added inline comments. Comment at: llvm/lib/Target/RISCV/RISCVSubtarget.h:162 + bool hasVInstructionsF16Mininal() const { +return HasStdExtZvfhmin || HasStdExtZvfh; + } michaelmaitland wrote: > jacquesguan wrote: > > craig.topper wrote: > >

[PATCH] D151294: [clangd] Remove inline Specifier for DefineOutline Tweak

kadircet accepted this revision. kadircet added a comment. This revision is now accepted and ready to land. thanks, LGTM! Comment at: clang-tools-extra/clangd/refactor/tweaks/DefineOutline.cpp:136 +// Removes matching instances of given token preceeding the function defition. +

[PATCH] D151365: [Sema] cast to CXXRecordDecl correctly when diag a default comparison method

erichkeane added inline comments. Comment at: clang/lib/Sema/SemaTemplateInstantiate.cpp:969 << (int)DFK.asComparison() -<< Context.getTagDeclType( - cast(FD->getLexicalDeclContext())); +<< Context.getRecordType(RecordType->g

[PATCH] D151194: [clang][dataflow] Add support for return values of reference type.

xazax.hun added inline comments. Comment at: clang/include/clang/Analysis/FlowSensitive/DataflowEnvironment.h:196 + void popCall(const CallExpr *Call, const Environment &CalleeEnv); + void popCall(const CXXConstructExpr *Call, const Environment &CalleeEnv); m

[PATCH] D151445: [Flang] Add main-file-name flag to flang -fc1

domada created this revision. domada added reviewers: awarzynski, kiranchandramohan, jsjodin, kiranktp, agozillon, skatrak, TIFitis, RogerV-AMD, NimishMishra, raghavendhra, dpalermo. domada added a project: Flang. Herald added subscribers: bviyer, sunshaoce, Moerafaat, zero9178, bzcheeseman, sdas

[PATCH] D150528: [Clang][Attribute] Improve the AST/diagnoses fidelity of alignas and _Alignas

erichkeane added a comment. Just 1 change I'd like, but otherwise this LGTM. Comment at: clang/lib/AST/AttrImpl.cpp:244 + assert(!isAlignmentDependent()); + auto getAlignmentImpl = [&]() -> unsigned { +if (isAlignmentExpr()) { I don't think it makes sense

[PATCH] D148702: [clang] Add Parse and Sema support for RegularKeyword attributes

erichkeane added a comment. So I have 1 issue that is throughout the patch, but I'm ok with the patch otherwise. This'll get a LGTM after that is fixed. Comment at: clang/lib/Sema/SemaDeclAttr.cpp:2902 S.Diag(AL.getRange().getBegin(), diag::err_attribute_wrong_decl_type)

[PATCH] D151438: [NFC][Driver] Change Multilib flag representation

michaelplatings added a comment. @phosek you made some alternative suggestions: 1. Have two separate lists of include and exclude flags. 2. Store flags as a tuple (or a struct?) of string and a tag (that is include or exclude). The reason for not doing that is to keep multilib selection method

[clang] 7f6c3a9 - [clang][dataflow] Fix a crash in `getLogicOperatorSubExprValue()`.

Author: Martin Braenne Date: 2023-05-25T14:47:03Z New Revision: 7f6c3a9033b6409ada46609f5f4b650e8556f56d URL: https://github.com/llvm/llvm-project/commit/7f6c3a9033b6409ada46609f5f4b650e8556f56d DIFF: https://github.com/llvm/llvm-project/commit/7f6c3a9033b6409ada46609f5f4b650e8556f56d.diff LOG

[PATCH] D151201: [clang][dataflow] Fix a crash in `getLogicOperatorSubExprValue()`.

This revision was automatically updated to reflect the committed changes. mboehme marked an inline comment as done. Closed by commit rG7f6c3a9033b6: [clang][dataflow] Fix a crash in `getLogicOperatorSubExprValue()`. (authored by mboehme). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D150528: [Clang][Attribute] Improve the AST/diagnoses fidelity of alignas and _Alignas

yronglin updated this revision to Diff 525614. yronglin added a comment. Address comment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150528/new/ https://reviews.llvm.org/D150528 Files: clang/docs/ReleaseNotes.rst clang/include/clang/Parse/P

[PATCH] D150528: [Clang][Attribute] Improve the AST/diagnoses fidelity of alignas and _Alignas

yronglin marked an inline comment as done. yronglin added a comment. Thanks for your comments, @erichkeane ! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150528/new/ https://reviews.llvm.org/D150528 ___

[PATCH] D150528: [Clang][Attribute] Improve the AST/diagnoses fidelity of alignas and _Alignas

erichkeane accepted this revision. erichkeane added a comment. This revision is now accepted and ready to land. 1 nit I don't care either way about, 1 suggestion. Comment at: clang/lib/AST/AttrImpl.cpp:247 + + if (isAlignmentExpr()) { +return alignmentExpr

[PATCH] D150253: [RISCV] Add Zvfhmin extension for clang.

craig.topper added inline comments. Comment at: llvm/lib/Target/RISCV/RISCVSubtarget.h:162 + bool hasVInstructionsF16Mininal() const { +return HasStdExtZvfhmin || HasStdExtZvfh; + } michaelmaitland wrote: > michaelmaitland wrote: > > jacquesguan wrote: > >

[PATCH] D141627: [Clang][OpenMP] Fix the issue that list items in `has_device_addr` are still mapped to the target device

tianshilei1992 updated this revision to Diff 525627. tianshilei1992 added a comment. add a test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141627/new/ https://reviews.llvm.org/D141627 Files: clang/lib/CodeGen/CGOpenMPRuntime.cpp clang/test/

[PATCH] D141627: [Clang][OpenMP] Fix the issue that list items in `has_device_addr` are still mapped to the target device

jyu2 accepted this revision. jyu2 added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141627/new/ https://reviews.llvm.org/D141627 ___ cfe

[PATCH] D151145: Add disabled unittest reproducing TextProto formatting issue.

Icantjuddle added a comment. In D151145#4369406 , @MyDeveloperDay wrote: > We don't normally land broken tests, even if they are disabled, its better > for us if we get a fix at the same time ;-) In D151145#4367495

[PATCH] D151060: [Clang][Sema] Generate vector vs scalar builtin overloads

porglezomp added inline comments. Comment at: clang/lib/Sema/SemaOverload.cpp:9041-9044 + // (allowing splatting the scalar to a vector). + for (unsigned Candidate = 0; Candidate < 2; ++Candidate) { +for (QualType Vec1Ty : CandidateTypes[Candidate].vector_types(

[PATCH] D150114: [Headers][doc] Add "add/sub/mul" intrinsic descriptions to avx2intrin.h

probinson updated this revision to Diff 525632. probinson added a comment. Correct order of horizontal operands CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150114/new/ https://reviews.llvm.org/D150114 Files: clang/lib/Headers/avx2intrin.h Index: clang/lib/Headers/avx2intrin.h

[PATCH] D150114: [Headers][doc] Add "add/sub/mul" intrinsic descriptions to avx2intrin.h

probinson added inline comments. Comment at: clang/lib/Headers/avx2intrin.h:456 +/// j := i*128 +/// result[j+31:j] := __a[j+63:j+32] - __a[j+31:j] +/// result[j+63:j+32] := __a[j+127:j+96] - __a[j+95:j+64] craig.topper wrote: > Intel intrinsics guide says

[PATCH] D148216: Add support for annotations in UpdateTestChecks (NFC)

hnrklssn added inline comments. Comment at: clang/test/utils/update_cc_test_checks/Inputs/annotations.c.expected:12 +// CHECK-NEXT:[[TMP1:%.*]] = load i32, ptr [[X]], align 4 +// CHECK-NEXT:ret i32 [[TMP1]] +// nikic wrote: > hnrklssn wrote: > > nikic wr

[PATCH] D149800: [WIP][PGO] Add ability to mark cold functions as optsize/minsize/optnone

davidxl added a comment. Sorry I missed the question. What I meant is that a lot of the profile guided size optimization (PGSO) done by Hiroshi can be adapted to use the attribute based method proposed in the patch as we don't need two different mechanisms. Repository: rG LLVM Github Monorep

[PATCH] D150528: [Clang][Attribute] Improve the AST/diagnoses fidelity of alignas and _Alignas

yronglin updated this revision to Diff 525636. yronglin added a comment. Address comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150528/new/ https://reviews.llvm.org/D150528 Files: clang/docs/ReleaseNotes.rst clang/include/clang/Parse/P

[PATCH] D151349: [HIP] emit macro `__HIP_NO_IMAGE_SUPPORT`

yaxunl updated this revision to Diff 525637. yaxunl added a comment. Herald added a subscriber: jdoerfert. Herald added a reviewer: kiranchandramohan. update tests CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151349/new/ https://reviews.llvm.org/D151349 Files: clang/include/clang/Ba

[PATCH] D150528: [Clang][Attribute] Improve the AST/diagnoses fidelity of alignas and _Alignas

yronglin marked 2 inline comments as done. yronglin added inline comments. Comment at: clang/lib/AST/AttrImpl.cpp:247 + + if (isAlignmentExpr()) { +return alignmentExpr erichkeane wrote: > Typically we don't do curleys on a single-statement... but I am on th

[PATCH] D143675: Discussion: Darwin Sanitizers Stable ABI

rsundahl updated this revision to Diff 525644. rsundahl added a comment. Apply proper backticks quotes to options. Remove redundant ellipses. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143675/new/ https://reviews.llvm.org/D143675 Files: clang

[PATCH] D143675: Discussion: Darwin Sanitizers Stable ABI

rsundahl marked 2 inline comments as done. rsundahl added a comment. Thanks for your time and guidance getting this landed. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143675/new/ https://reviews.llvm.org/D143675

  1   2   3   >