rmaz accepted this revision. rmaz added a comment. This revision is now accepted and ready to land.
LGTM ================ Comment at: clang/include/clang/Basic/FileEntry.h:124 + /// Directory the file was found in. OptionalDirectoryEntryRef Dir; ---------------- If this is always set now, should it be a non optional `DirectoryEntryRef`? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151398/new/ https://reviews.llvm.org/D151398 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits