michaelplatings added a comment. @phosek you made some alternative suggestions:
1. Have two separate lists of include and exclude flags. 2. Store flags as a tuple (or a struct?) of string and a tag (that is include or exclude). The reason for not doing that is to keep multilib selection method conceptually simple: a multilib is a match if its flags are a subset of flags generated from command line arguments. Although historically the Multilib class has had the concept of flags being indicated or contraindicated, I've found that's not needed for the proposed configurable multilib scheme. Therefore I'd prefer not to codify that concept within the Multilib class any more than it already is. Over time I expect "contraindicated" flags like `!fexceptions` to be used less and less, in favour of real flags like `-fno-exceptions`. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151438/new/ https://reviews.llvm.org/D151438 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
