michaelmaitland added inline comments.
================
Comment at: llvm/lib/Target/RISCV/RISCVSubtarget.h:162
+ bool hasVInstructionsF16Mininal() const {
+ return HasStdExtZvfhmin || HasStdExtZvfh;
+ }
----------------
michaelmaitland wrote:
> jacquesguan wrote:
> > craig.topper wrote:
> > > Doesn't HasStdExtZvfh already imply HasStdExtZvfhmin?
> > The v spec doesn't metion this.
> I think the spec conveys this when it says `The Zvfhmin extension depends on
> the Zve32f extension.`
My mistake, that says `Zve32f`, not `Zvfh`. However, the spec does say:
`When the Zvfhmin extension is implemented, the vfwcvt.f.f.v and vfncvt.f.f.w
instructions become defined when SEW=16` and also says `When the Zvfh extension
is implemented, all instructions in Sections Vector Floating-Point
Instructions.` Since `vfwcvt.f.f.v and vfncvt.f.f.w` are part of `Vector
Floating-Point Instructions` section, this is how it is implied.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D150253/new/
https://reviews.llvm.org/D150253
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
