xazax.hun added inline comments.
================ Comment at: clang/include/clang/Analysis/FlowSensitive/DataflowEnvironment.h:196 + void popCall(const CallExpr *Call, const Environment &CalleeEnv); + void popCall(const CXXConstructExpr *Call, const Environment &CalleeEnv); ---------------- mboehme wrote: > xazax.hun wrote: > > I know that Obj-C is a non-goal, but it might worth a comment to support > > `ObjCMessageExpr` just in case someone wants to work on this. > > > > Btw, this is one of my biggest pet peeves about the Clang AST. We should > > have a common abstraction for all the callables, instead of having to > > bifurcate many of the APIs. > Agreed! > > I'm a bit hesitant to add a FIXME here though, as that might make it sound as > if there's a plan to add Objective-C support or at least imply that that's a > goal. Also, I think Objective-C support would entail quite a bit more than > adding the right overloads here -- so I'm not sure how helpful the comment > here would be. I think once someone goes down the road of seriously working > on Objective-C support, they'll quickly discover that they need a new > overload here. > > I hope this makes sense? Happy to add something in a followup patch if you > feel we should add some Objective-C "breadcrumbs" here. Yup, makes sense! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151194/new/ https://reviews.llvm.org/D151194 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
