[PATCH] D148094: [clang][CodeGen] Break up TargetInfo.cpp [7/7]

barannikov88 updated this revision to Diff 520611. barannikov88 retitled this revision from "[clang][CodeGen] Break up TargetInfo.cpp [6/6]" to "[clang][CodeGen] Break up TargetInfo.cpp [7/7]". barannikov88 edited the summary of this revision. barannikov88 added a comment. Rebase Repository:

[PATCH] D148094: [clang][CodeGen] Break up TargetInfo.cpp [7/7]

barannikov88 updated this revision to Diff 520613. barannikov88 added a comment. Remove introduced duplicate functions Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148094/new/ https://reviews.llvm.org/D148094 Files: clang/docs/UsersManual.rst

[PATCH] D148457: [clangd] Support macro evaluation on hover

nridge accepted this revision. nridge added a comment. This revision is now accepted and ready to land. Thanks! LGTM with one final nit (the other comment is just food for future thought) Comment at: clang-tools-extra/clangd/Hover.cpp:503 + +std::optional printExprValue(const

cfe-commits@lists.llvm.org

Author: Martin Braenne Date: 2023-05-09T07:42:20Z New Revision: 0c852dc88e9276b74532fd7d233dd23ec1bbed6f URL: https://github.com/llvm/llvm-project/commit/0c852dc88e9276b74532fd7d233dd23ec1bbed6f DIFF: https://github.com/llvm/llvm-project/commit/0c852dc88e9276b74532fd7d233dd23ec1bbed6f.diff LOG

cfe-commits@lists.llvm.org

This revision was automatically updated to reflect the committed changes. Closed by commit rG0c852dc88e92: [clang][dataflow][NFC] Remove `SkipPast` param from `getValue(const ValueDecl… (authored by mboehme). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.

[clang] cac4d7f - [CodeGen] Only consider innermost cast for !heapallocsite

Author: Nikita Popov Date: 2023-05-09T09:49:42+02:00 New Revision: cac4d7ff4652815e12132c990a62d68873ba4b9e URL: https://github.com/llvm/llvm-project/commit/cac4d7ff4652815e12132c990a62d68873ba4b9e DIFF: https://github.com/llvm/llvm-project/commit/cac4d7ff4652815e12132c990a62d68873ba4b9e.diff

[PATCH] D145788: [CodeGen] Only consider innermost cast for !heapallocsite

This revision was automatically updated to reflect the committed changes. Closed by commit rGcac4d7ff4652: [CodeGen] Only consider innermost cast for !heapallocsite (authored by nikic). Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo C

[PATCH] D150181: [XCOFF][DWARF] XCOFF64 should be able to select the dwarf version under intergrated-as mode.

Esme created this revision. Esme added reviewers: shchenz, lkail, PowerPC, DiggerLin. Herald added a subscriber: hiraditya. Herald added a project: All. Esme requested review of this revision. Herald added subscribers: llvm-commits, cfe-commits, MaskRay. Herald added projects: clang, LLVM. DWARF32

[PATCH] D143260: [clangd] Add semantic token for labels

kadircet added a comment. (sorry for taking so long to get back to this) In D143260#4270807 , @nridge wrote: > In the case of labels (and angle brackets (D139926 > ) and operators (D136594 >

[PATCH] D150140: [NFC][CLANG] Fix Static Code Analysis Concerns

sdesmalen added inline comments. Comment at: clang/utils/TableGen/SveEmitter.cpp:302 unsigned Shift = llvm::countr_zero(Mask); + assert(Shift >= 64 && "Shift is out of encodable range"); return (V << Shift) & Mask; erichkeane wrote: > Shouldn't

[PATCH] D146389: [clang-repl][CUDA] Initial interactive CUDA support for clang-repl

Hahnfeld added a comment. Some comments, but otherwise LGTM Comment at: clang/include/clang/Interpreter/Interpreter.h:43 public: + IncrementalCompilerBuilder(){}; + and this should probably be run through `clang-format`... Comment at: clang

[clang] 74fd474 - [clang] Evaluate non-type default template argument when it is required

Author: Mariya Podchishchaeva Date: 2023-05-09T04:21:46-04:00 New Revision: 74fd474eea53e85fc8f64422f565fd2bd50fd7e4 URL: https://github.com/llvm/llvm-project/commit/74fd474eea53e85fc8f64422f565fd2bd50fd7e4 DIFF: https://github.com/llvm/llvm-project/commit/74fd474eea53e85fc8f64422f565fd2bd50fd7

[PATCH] D150108: [clang] Evaluate non-type default template argument when it is required

This revision was automatically updated to reflect the committed changes. Closed by commit rG74fd474eea53: [clang] Evaluate non-type default template argument when it is required (authored by Fznamznon). Changed prior to commit: https://reviews.llvm.org/D150108?vs=520325&id=520622#toc Reposito

[PATCH] D143260: [clangd] Add semantic token for labels

nridge added a comment. In D143260#4328948 , @kadircet wrote: > Considering that we have added a bunch of token kinds, let me ask you another > question then, how many more new token kinds do we expect to have? e.g. if > label is the last one sure, but

[PATCH] D143260: [clangd] Add semantic token for labels

ckandeler added a comment. In D143260#4328948 , @kadircet wrote: > Considering that we have added a bunch of token kinds, let me ask you another > question then, how many more new token kinds do we expect to have? e.g. if > label is the last one sure, b

[PATCH] D150183: [Clang][clang-cl] Implement `__builtin_FUNCSIG`

JMazurkiewicz created this revision. JMazurkiewicz added a reviewer: clang. Herald added a project: All. JMazurkiewicz requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This patch implements `__builtin_FUNCSIG` intrinsic which returns the sam

[PATCH] D148802: [Sema] Lambdas are not part of immediate context for deduction

ilya-biryukov updated this revision to Diff 520628. ilya-biryukov added a comment. - Moved the relase note to 'C++20 feature support', fixed typos Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148802/new/ https://reviews.llvm.org/D148802 Files:

[PATCH] D150178: [clang][CodeGen] Break up TargetInfo.cpp [6/7]

barannikov88 created this revision. Herald added a project: All. barannikov88 published this revision for review. barannikov88 added reviewers: rjmccall, aaron.ballman, erichkeane, jdoerfert, efriedma. Herald added a project: clang. Herald added a subscriber: cfe-commits. Make `qualifyWindowsLibr

[PATCH] D148802: [Sema] Lambdas are not part of immediate context for deduction

ilya-biryukov updated this revision to Diff 520630. ilya-biryukov added a comment. - Fix a typo (forgot to commit last time) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148802/new/ https://reviews.llvm.org/D148802 Files: clang/docs/ReleaseNote

[PATCH] D146389: [clang-repl][CUDA] Initial interactive CUDA support for clang-repl

v.g.vassilev added inline comments. Comment at: clang/lib/Interpreter/Interpreter.cpp:144-146 ClangArgv.insert(ClangArgv.end(), "-Xclang"); ClangArgv.insert(ClangArgv.end(), "-fincremental-extensions"); ClangArgv.insert(ClangArgv.end(), "-c"); Hahnfeld w

[PATCH] D150187: [tidy][IdentifierNaming] Fix crashes on non-identifiers

kadircet created this revision. kadircet added a reviewer: VitaNuo. Herald added subscribers: PiotrZSL, carlosgalvezp. Herald added a reviewer: njames93. Herald added a project: All. kadircet requested review of this revision. Herald added a project: clang-tools-extra. Herald added a subscriber: cf

[PATCH] D146389: [clang-repl][CUDA] Initial interactive CUDA support for clang-repl

argentite updated this revision to Diff 520636. argentite marked 3 inline comments as done. argentite added a comment. Added a check to run CUDA tests only on systems with CUDA. We need some ideas for the actual tests. Rename Offload.cpp to DeviceOffload.cpp Other syntax/style fixes Repository:

[PATCH] D148457: [clangd] Support macro evaluation on hover

zyounan updated this revision to Diff 520638. zyounan added a comment. Final update Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148457/new/ https://reviews.llvm.org/D148457 Files: clang-tools-extra/clangd/Hover.cpp clang-tools-extra/clangd/u

[PATCH] D150187: [tidy][IdentifierNaming] Fix crashes on non-identifiers

PiotrZSL accepted this revision. PiotrZSL added a comment. This revision is now accepted and ready to land. LGTM, fell free to deliver (to quickly fix crash). Any improvements could be done later. Comment at: clang-tools-extra/clang-tidy/utils/RenamerClangTidyCheck.cpp:457 + /

[PATCH] D150187: [tidy][IdentifierNaming] Fix crashes on non-identifiers

PiotrZSL added inline comments. Comment at: clang-tools-extra/test/clang-tidy/checkers/readability/identifier-naming-nocrash.cpp:3-5 +struct Foo { + operator bool(); +}; PiotrZSL wrote: > i would merge this with some existing test file... yep, tests fails due t

[PATCH] D150124: [index][clangd] Consider labels when indexing function bodies

ilya-biryukov added a comment. Thanks! This looks like a useful addition. Could you add a test into `libIndex` for this too? Just for the sake of having better coverage, some folks probably don't run `clang-tools-extra` tests. Also, could we add a test that a label does not get indexed if local

[PATCH] D150124: [index][clangd] Consider labels when indexing function bodies

ilya-biryukov added a reviewer: kadircet. ilya-biryukov added a comment. In `clangd` we also have `findExplicitReferences` and `targetDecl` functions that seem to handle the `GoToStmt`. In fact, I believe they are used in `findDocumentHighlights`, so I'm not sure why your test did not work befor

[PATCH] D150116: clang-format: [JS] support import/export type

krasimir accepted this revision. krasimir added a comment. This revision is now accepted and ready to land. Looks good! Thank you! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150116/new/ https://reviews.llvm.org/D150116 _

[clang] 629170f - [Sema] Lambdas are not part of immediate context for deduction

Author: Ilya Biryukov Date: 2023-05-09T12:06:33+02:00 New Revision: 629170fe452f4849c89fc289d6e2cf5f08534342 URL: https://github.com/llvm/llvm-project/commit/629170fe452f4849c89fc289d6e2cf5f08534342 DIFF: https://github.com/llvm/llvm-project/commit/629170fe452f4849c89fc289d6e2cf5f08534342.diff

[PATCH] D148802: [Sema] Lambdas are not part of immediate context for deduction

This revision was automatically updated to reflect the committed changes. Closed by commit rG629170fe452f: [Sema] Lambdas are not part of immediate context for deduction (authored by ilya-biryukov). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D14880

[clang] 60a3784 - [C++20] [Modules] Handle modules visible relationship properly

Author: Chuanqi Xu Date: 2023-05-09T18:36:37+08:00 New Revision: 60a3784b3e1f0e65e2a0e6daf070bbc7cd4bbab5 URL: https://github.com/llvm/llvm-project/commit/60a3784b3e1f0e65e2a0e6daf070bbc7cd4bbab5 DIFF: https://github.com/llvm/llvm-project/commit/60a3784b3e1f0e65e2a0e6daf070bbc7cd4bbab5.diff LO

[PATCH] D150187: [tidy][IdentifierNaming] Fix crashes on non-identifiers

kadircet updated this revision to Diff 520648. kadircet marked 3 inline comments as done. kadircet added a comment. Merge with existing tests Perform check earlier Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150187/new/ https://reviews.llvm.org/D

[clang-tools-extra] 7385cc3 - [clangd] Support macro evaluation on hover

Author: Younan Zhang Date: 2023-05-09T18:50:27+08:00 New Revision: 7385cc389abad29eb9044d260b23dd483d674718 URL: https://github.com/llvm/llvm-project/commit/7385cc389abad29eb9044d260b23dd483d674718 DIFF: https://github.com/llvm/llvm-project/commit/7385cc389abad29eb9044d260b23dd483d674718.diff

[PATCH] D148457: [clangd] Support macro evaluation on hover

This revision was automatically updated to reflect the committed changes. Closed by commit rG7385cc389aba: [clangd] Support macro evaluation on hover (authored by zyounan). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148457/new/ https://reviews.ll

[clang-tools-extra] b36a2e7 - [tidy][IdentifierNaming] Fix crashes on non-identifiers

Author: Kadir Cetinkaya Date: 2023-05-09T12:50:57+02:00 New Revision: b36a2e7828befcf948f461b72c78a8d2386db2e7 URL: https://github.com/llvm/llvm-project/commit/b36a2e7828befcf948f461b72c78a8d2386db2e7 DIFF: https://github.com/llvm/llvm-project/commit/b36a2e7828befcf948f461b72c78a8d2386db2e7.dif

[PATCH] D150187: [tidy][IdentifierNaming] Fix crashes on non-identifiers

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGb36a2e7828be: [tidy][IdentifierNaming] Fix crashes on non-identifiers (authored by kadircet). Repository: rG LLVM Github Monorepo CHANGES SINCE L

[PATCH] D146389: [clang-repl][CUDA] Initial interactive CUDA support for clang-repl

v.g.vassilev added a comment. Generally lgtm, let's extend the test coverage. Comment at: clang/lib/Interpreter/DeviceOffload.cpp:1 +//===-- Offload.cpp - CUDA Offloading ---*- C++ -*-===// +// Likewise. Comment at: c

[PATCH] D150187: [tidy][IdentifierNaming] Fix crashes on non-identifiers

VitaNuo added inline comments. Comment at: clang-tools-extra/clang-tidy/utils/RenamerClangTidyCheck.cpp:457 + // Don't keep track for non-identifier names. + if (auto *II = Decl->getIdentifier()) { +return addUsage(RenamerClangTidyCheck::NamingCheckId(Decl->getLocation(), -

[PATCH] D150191: [clang][Diagnostics] Provide a source range for 'use of undeclared identifier' diagnostics

tbaeder created this revision. tbaeder added reviewers: cjdb, aaron.ballman, shafik. Herald added a project: All. tbaeder requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Just a small improvement. Before: array.cpp:1279:9: error: use of

[PATCH] D150192: Allow clang to emit inrange metadata when generating code for array subscripts

simeon-imgtec created this revision. simeon-imgtec added reviewers: pcc, eli.friedman. simeon-imgtec created this object with visibility "All Users". Herald added subscribers: mattd, asavonic, jdoerfert, pengfei, hiraditya, jvesely. Herald added a project: All. simeon-imgtec requested review of th

[PATCH] D149119: [CMake] Use LLVM own tools in extract_symbols.py

tmatheson accepted this revision. tmatheson added a comment. This revision is now accepted and ready to land. LGTM, thank you for doing this. Please give it a couple of days in case others have comments. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149119/new/ https://reviews.llvm.org

[PATCH] D149119: [CMake] Use LLVM own tools in extract_symbols.py

jhenderson added a comment. I've not really looked into this patch significantly, so this may well be addressed in the patch, given I see you have modified stuff to do with the NATIVE build, but in the past I have seen LLVM using its own tools to build other parts of its system. I believe it wa

[PATCH] D139837: [Clang] Implements CTAD for aggregates P1816R0 and P2082R1

aaron.ballman added a comment. In D139837#4326501 , @cor3ntin wrote: > @erichkeane @aaron.ballman I think we should determine how much works remains > there and if the author is not responsive maybe one of us can push this up > the finishing line. That

[PATCH] D149982: AMDGPU: Add basic gfx941 target

arsenm accepted this revision. arsenm added inline comments. This revision is now accepted and ready to land. Comment at: llvm/lib/Target/AMDGPU/AMDGPU.td:1231-1261 + [FeatureGFX9, + FeatureGFX90AInsts, + FeatureGFX940Insts, + FeatureFmaMixInsts, + FeatureLDSBankCount32,

[PATCH] D149986: AMDGPU: Force sc0 and sc1 on stores for gfx940 and gfx941

arsenm added a comment. Should this be a feature set by default in the subtarget constructor instead? Should you be able to turn this off? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149986/new/ https://reviews.llvm.org/D149986

[PATCH] D150191: [clang][Diagnostics] Provide a source range for 'use of undeclared identifier' diagnostics

aaron.ballman added a comment. The changes are reasonable but should have test coverage. We test source ranges with `-fdiagnostics-print-source-range-info` as in https://github.com/llvm/llvm-project/blob/929a8c9f72dc405779a8aaf82304efdb7f1ab5e4/clang/test/Misc/diag-greatergreater.cpp#L4 Reposi

[PATCH] D150191: [clang][Diagnostics] Provide a source range for 'use of undeclared identifier' diagnostics

tbaeder added a comment. Right, I expect (hope?) precommit CI to fail, but I'm stuck at an airport right now so I'll leave tests for when I'm back home. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150191/new/ https://reviews.llvm.org/D150191 __

[PATCH] D150043: [InferAddressSpaces] Handle vector of pointers type & Support intrinsic masked gather/scatter

CaprYang updated this revision to Diff 520660. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150043/new/ https://reviews.llvm.org/D150043 Files: llvm/lib/Transforms/Scalar/InferAddressSpaces.cpp llvm/test/Transforms/InferAddressSpaces/AMDGPU/icmp.ll llvm/test/Transforms/InferAddres

[PATCH] D150139: [clang-repl] Enable basic multiline support.

aaron.ballman added inline comments. Comment at: clang/test/Interpreter/multiline.cpp:12-17 +void f(int x) \ +{ \ + printf("x=\ + %d", x); \ +} +f(i); Another fun test case: ``` // Requires -ftrigraphs but

[PATCH] D150043: [InferAddressSpaces] Handle vector of pointers type & Support intrinsic masked gather/scatter

CaprYang added inline comments. Comment at: llvm/test/Transforms/InferAddressSpaces/AMDGPU/icmp.ll:151 ; CHECK-LABEL: @icmp_flat_flat_from_group_vector( -; CHECK: %cmp = icmp eq <2 x ptr> %cast0, %cast1 +; CHECK: %cmp = icmp eq <2 x ptr addrspace(3)> %group.ptr.0, %group.ptr.1

[PATCH] D150122: [Clang] Fix status of P0960

aaron.ballman added a reviewer: ayzhao. aaron.ballman added subscribers: ayzhao, tstellar. aaron.ballman added a comment. I believe we are having another release of Clang 16, but @tstellar can confirm or deny that. AIUI, there were a few issues holding us back from claiming complete support (ad

[PATCH] D150043: [InferAddressSpaces] Handle vector of pointers type & Support intrinsic masked gather/scatter

arsenm added inline comments. Comment at: llvm/lib/Transforms/Scalar/InferAddressSpaces.cpp:289 + +static bool hasSameElementOfPtrOrVecPtrs(Type *Ty1, Type *Ty2) { + assert(isPtrOrVecOfPtrsType(Ty1) && isPtrOrVecOfPtrsType(Ty2)); arsenm wrote: > Ditto, only opaq

[clang-tools-extra] 28bdff1 - [clangd][NFX][FIX] Fix conflicting symbol name `Expr`

Author: Joseph Huber Date: 2023-05-09T07:58:36-05:00 New Revision: 28bdff19e3ad981ef83e372e8c301f1407b82135 URL: https://github.com/llvm/llvm-project/commit/28bdff19e3ad981ef83e372e8c301f1407b82135 DIFF: https://github.com/llvm/llvm-project/commit/28bdff19e3ad981ef83e372e8c301f1407b82135.diff

[PATCH] D148700: [clang] Add support for “regular” keyword attributes

aaron.ballman added inline comments. Comment at: clang/include/clang/Basic/Attr.td:2427-2430 +def ArmStreaming : TypeAttr, TargetSpecificAttr { + let Spellings = [RegularKeyword<"__arm_streaming">]; + let Documentation = [Undocumented]; +} I'd feel more comfort

[PATCH] D147844: [clang][Sema]Print diagnostic warning about precedence when integer expression is used without parentheses in an conditional operator expression

aaron.ballman added a comment. In general, I think this is incremental progress on the diagnostic behavior. However, it's clear that there is room for interpretation on what is or is not a false positive diagnostic for this, so we should pay close attention to user feedback during the 17.x rele

[PATCH] D150043: [InferAddressSpaces] Handle vector of pointers type & Support intrinsic masked gather/scatter

CaprYang added inline comments. Comment at: llvm/lib/Transforms/Scalar/InferAddressSpaces.cpp:289 + +static bool hasSameElementOfPtrOrVecPtrs(Type *Ty1, Type *Ty2) { + assert(isPtrOrVecOfPtrsType(Ty1) && isPtrOrVecOfPtrsType(Ty2)); arsenm wrote: > arsenm wrote:

[PATCH] D150140: [NFC][CLANG] Fix Static Code Analysis Concerns

erichkeane added inline comments. Comment at: clang/utils/TableGen/SveEmitter.cpp:302 unsigned Shift = llvm::countr_zero(Mask); + assert(Shift >= 64 && "Shift is out of encodable range"); return (V << Shift) & Mask; sdesmalen wrote: > erichkean

[PATCH] D150140: [NFC][CLANG] Fix Static Code Analysis Concerns

sdesmalen added inline comments. Comment at: clang/utils/TableGen/SveEmitter.cpp:302 unsigned Shift = llvm::countr_zero(Mask); + assert(Shift >= 64 && "Shift is out of encodable range"); return (V << Shift) & Mask; erichkeane wrote: > sdesmalen

[PATCH] D149612: [Sema] avoid merge error type

erichkeane added inline comments. Comment at: clang/lib/Sema/SemaType.cpp:2583 +if (ArraySize->containsErrors()) { + RecoveryExpr *RE = RecoveryExpr::Create( + Context, ArraySize->getType(), ArraySize->getBeginLoc(), HerrCai0907 wrote: > erichke

[PATCH] D140996: [c++20] P1907R1: Support for generalized non-type template arguments of scalar type.

bolshakov-a updated this revision to Diff 520678. bolshakov-a added a comment. Fix MS compatibility mangling algorithm. Tested with MSVC ver. 19.35 (toolset ver. 143). CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140996/new/ https://reviews.llvm.org/D140996 Files: clang-tools-extra

[PATCH] D149119: [CMake] Use LLVM own tools in extract_symbols.py

beanz added a comment. One potential area of concern here: If `llvm-driver` is ever extended to work as a plugin loader (thus exporting its symbols), removing support for the pre-installed host tools could cause a cyclic dependency. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149119/

[PATCH] D150140: [NFC][CLANG] Fix Static Code Analysis Concerns

Manna updated this revision to Diff 520681. Manna edited the summary of this revision. Manna added a comment. Thank you for reviews and comments @erichkeane and @sdesmalen! I have updated patch. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150140/new/ https://reviews.llvm.org/D150140

[PATCH] D150140: [NFC][CLANG] Fix Static Code Analysis Concerns

Manna marked 4 inline comments as done. Manna added inline comments. Comment at: clang/utils/TableGen/SveEmitter.cpp:302 unsigned Shift = llvm::countr_zero(Mask); + assert(Shift >= 64 && "Shift is out of encodable range"); return (V << Shift) & Mask; --

[PATCH] D150043: [InferAddressSpaces] Handle vector of pointers type & Support intrinsic masked gather/scatter

CaprYang updated this revision to Diff 520692. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150043/new/ https://reviews.llvm.org/D150043 Files: llvm/lib/Transforms/Scalar/InferAddressSpaces.cpp llvm/test/Transforms/InferAddressSpaces/AMDGPU/icmp.ll llvm/test/Transforms/InferAddres

[PATCH] D150140: [NFC][CLANG] Fix Static Code Analysis Concerns

Manna updated this revision to Diff 520693. Manna marked an inline comment as done. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150140/new/ https://reviews.llvm.org/D150140 Files: clang/utils/TableGen/SveEmitter.cpp Index: clang/utils/TableGen/SveEmitter.cpp ===

[PATCH] D150043: [InferAddressSpaces] Handle vector of pointers type & Support intrinsic masked gather/scatter

CaprYang added inline comments. Comment at: llvm/test/Transforms/InferAddressSpaces/masked-gather-scatter.ll:3 + +; CHECK-LABEL: @masked_gather_inferas( +; CHECK: tail call <4 x i32> @llvm.masked.gather.v4i32.v4p1 arsenm wrote: > Generate full checks updated C

[PATCH] D149162: [Clang][OpenMP][IRBuilder] Move registerTargetGlobalVariable & getAddrOfDeclareTargetVar into the OMPIRBuilder

jsjodin added inline comments. Comment at: llvm/include/llvm/Frontend/OpenMP/OMPIRBuilder.h:865 + TargetRegionEntryInfo EntryInfo, StringRef MangledName, + Module *LlvmModule, std::vector &GeneratedRefs, + bool OpenMPSIMD, std::vector TargetTriple,

[PATCH] D149495: [RISCV] Add support for V extension in SiFive7

reames accepted this revision. reames added a comment. This revision is now accepted and ready to land. LGTM, thought please wait for other review feedback to settle. I am very very happy to have this upstream, thank you! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https:

[clang] f859835 - [HIP] Detect HIP for Ubuntu, Mint, Gentoo, etc.

Author: Cordell Bloor Date: 2023-05-09T11:31:57-04:00 New Revision: f8598357662dc8dd0f4400bcaeb48e8befe43ecc URL: https://github.com/llvm/llvm-project/commit/f8598357662dc8dd0f4400bcaeb48e8befe43ecc DIFF: https://github.com/llvm/llvm-project/commit/f8598357662dc8dd0f4400bcaeb48e8befe43ecc.diff

[PATCH] D149110: [HIP] Detect HIP for Ubuntu, Mint, Gentoo, etc.

This revision was automatically updated to reflect the committed changes. Closed by commit rGf8598357662d: [HIP] Detect HIP for Ubuntu, Mint, Gentoo, etc. (authored by cgmb, committed by yaxunl). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149110/n

[PATCH] D140996: [c++20] P1907R1: Support for generalized non-type template arguments of scalar type.

bolshakov-a updated this revision to Diff 520716. bolshakov-a added a comment. Rebased. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140996/new/ https://reviews.llvm.org/D140996 Files: clang-tools-extra/clangd/DumpAST.cpp clang-tools-extra/clangd/FindTarget.cpp clang/docs/Releas

[libclc] 21508fa - libclc: clspv: fix fma, add vstore and fix inlining issues

Author: Kévin Petit Date: 2023-05-09T16:52:13+01:00 New Revision: 21508fa76914a5e4281dc5bc77cac7f2e8bc3aef URL: https://github.com/llvm/llvm-project/commit/21508fa76914a5e4281dc5bc77cac7f2e8bc3aef DIFF: https://github.com/llvm/llvm-project/commit/21508fa76914a5e4281dc5bc77cac7f2e8bc3aef.diff L

[PATCH] D147844: [clang][Sema]Print diagnostic warning about precedence when integer expression is used without parentheses in an conditional operator expression

chaitanyav updated this revision to Diff 520725. chaitanyav added a comment. Rebase with upstream and remove duplicate line from ReleaseNotes Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147844/new/ https://reviews.llvm.org/D147844 Files: clang

[PATCH] D146418: Support for OpenMP 5.0 sec 2.12.7 - Declare Target initializer expressions

RitanyaB updated this revision to Diff 520729. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146418/new/ https://reviews.llvm.org/D146418 Files: clang/include/clang/Sema/Sema.h clang/lib/Sema/SemaDecl.cpp clang/lib/Sema/SemaOpenMP.cpp clang/test/OpenMP/declare_target_messages.cpp

[PATCH] D146418: Support for OpenMP 5.0 sec 2.12.7 - Declare Target initializer expressions

ABataev added inline comments. Comment at: clang/lib/Sema/SemaDecl.cpp:14473 + // directive and has static storage duration. + if (auto *VD = dyn_cast_or_null(D); + LangOpts.OpenMP && VD && VD->hasAttr() && В is already checked that is not null

[PATCH] D149872: [OpenMP][OMPIRBuilder] Migrate emitOffloadingArrays and EmitNonContiguousDescriptor from Clang

TIFitis updated this revision to Diff 520730. TIFitis added a comment. Addressed reviewer comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149872/new/ https://reviews.llvm.org/D149872 Files: clang/lib/CodeGen/CGOpenMPRuntime.cpp llvm/in

[clang-tools-extra] 0d6d8a8 - [clang-tidy] Fix bugprone-assert-side-effect to actually give warnings

Author: Carlos Galvez Date: 2023-05-09T16:45:02Z New Revision: 0d6d8a853a6ea29b5f461a475a8f8eb7e7ba18e2 URL: https://github.com/llvm/llvm-project/commit/0d6d8a853a6ea29b5f461a475a8f8eb7e7ba18e2 DIFF: https://github.com/llvm/llvm-project/commit/0d6d8a853a6ea29b5f461a475a8f8eb7e7ba18e2.diff LOG:

[PATCH] D150071: [clang-tidy] Fix bugprone-assert-side-effect to actually give warnings

This revision was automatically updated to reflect the committed changes. carlosgalvezp marked 2 inline comments as done. Closed by commit rG0d6d8a853a6e: [clang-tidy] Fix bugprone-assert-side-effect to actually give warnings (authored by carlosgalvezp). Changed prior to commit: https://reviews

[PATCH] D150071: [clang-tidy] Fix bugprone-assert-side-effect to actually give warnings

carlosgalvezp added a comment. Thanks for the review! Fixed your comments before landing. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150071/new/ https://reviews.llvm.org/D150071 ___ cfe-commits mailin

[PATCH] D150122: [Clang] Fix status of P0960

ayzhao added a comment. In D150122#4329401 , @aaron.ballman wrote: > I believe we are having another release of Clang 16, but @tstellar can > confirm or deny that. > > AIUI, there were a few issues holding us back from claiming complete support > (adde

[PATCH] D146764: [clang] Make predefined expressions string literals under -fms-extensions

aeubanks reopened this revision. aeubanks added a comment. This revision is now accepted and ready to land. the following crashes with this patch: struct StringRef { StringRef(const char *); }; template StringRef getTypeName() { StringRef s = __func__; } `clang -cc1 -fms-exten

[clang] ee8ed0b - [clang][deps] Teach dep directive scanner about _Pragma

Author: Ben Langmuir Date: 2023-05-09T10:05:12-07:00 New Revision: ee8ed0b3099e63ba0a18cca42b9cfdf098bc6201 URL: https://github.com/llvm/llvm-project/commit/ee8ed0b3099e63ba0a18cca42b9cfdf098bc6201 DIFF: https://github.com/llvm/llvm-project/commit/ee8ed0b3099e63ba0a18cca42b9cfdf098bc6201.diff

[PATCH] D150001: [clang] Fix initializer_list matching failures with modules

ayzhao updated this revision to Diff 520744. ayzhao added a comment. rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150001/new/ https://reviews.llvm.org/D150001 Files: clang/include/clang/AST/DeclBase.h clang/lib/Sema/SemaDeclCXX.cpp c

[PATCH] D149884: [clang][deps] Teach dep directive scanner about _Pragma

This revision was automatically updated to reflect the committed changes. Closed by commit rGee8ed0b3099e: [clang][deps] Teach dep directive scanner about _Pragma (authored by benlangmuir). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149884/new/ h

[clang] d1d35f0 - [clang] Fix initializer_list matching failures with modules

Author: Alan Zhao Date: 2023-05-09T10:31:43-07:00 New Revision: d1d35f04c6cb2e3d5b0fbc6101d5425a33f8fc63 URL: https://github.com/llvm/llvm-project/commit/d1d35f04c6cb2e3d5b0fbc6101d5425a33f8fc63 DIFF: https://github.com/llvm/llvm-project/commit/d1d35f04c6cb2e3d5b0fbc6101d5425a33f8fc63.diff LOG

[PATCH] D150001: [clang] Fix initializer_list matching failures with modules

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGd1d35f04c6cb: [clang] Fix initializer_list matching failures with modules (authored by ayzhao). Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D150013: [Clang] Respect `-L` options when compiling directly for AMDGPU

MaskRay added inline comments. Comment at: clang/lib/Driver/ToolChains/AMDGPU.cpp:546 addLinkerCompressDebugSectionsOption(getToolChain(), Args, CmdArgs); AddLinkerInputs(getToolChain(), Inputs, Args, CmdArgs, JA); + Args.AddAllArgs(CmdArgs, options::OPT_L); --

[PATCH] D150013: [Clang] Respect `-L` options when compiling directly for AMDGPU

jhuber6 added inline comments. Comment at: clang/lib/Driver/ToolChains/AMDGPU.cpp:546 addLinkerCompressDebugSectionsOption(getToolChain(), Args, CmdArgs); AddLinkerInputs(getToolChain(), Inputs, Args, CmdArgs, JA); + Args.AddAllArgs(CmdArgs, options::OPT_L); --

[PATCH] D150209: [clang][Interp] Add more shift error checking

tbaeder created this revision. tbaeder added reviewers: aaron.ballman, erichkeane, tahonermann, shafik. Herald added a project: All. tbaeder requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://revi

[PATCH] D133289: [C2X] N3007 Type inference for object definitions

aaron.ballman added a comment. Thank you for the continued work on this! In general, I think the test coverage should verify the deduced type information more often. e.g., if we accept the code, there should probably be a `static_assert` nearby that ensures the deduced type is what we'd expect.

[PATCH] D150212: [clang][Sema] Improve diagnostics for auto return type

yaxunl created this revision. yaxunl added reviewers: tra, rjmccall, rsmith. Herald added a project: All. yaxunl requested review of this revision. Currently when clang fails to deduce auto return type of a function, it does not emit any notes about why it fails. This causes difficulty for users t

[PATCH] D150192: Allow clang to emit inrange metadata when generating code for array subscripts

efriedma added a comment. From what I recall, "inrange" is actually more restrictive than the normal C/C++ array indexing rules. Specifically, the bits regarding comparisons. "inrange" was designed to allow splitting globals indexed using inrange. That isn't to say that functionality like this

[clang] 6db007a - [Clang][Sema] Fix comparison of constraint expressions

Author: Alexander Shaposhnikov Date: 2023-05-09T18:14:39Z New Revision: 6db007a0654ed7a6ed5c3aa3b61a937c19a6bc6b URL: https://github.com/llvm/llvm-project/commit/6db007a0654ed7a6ed5c3aa3b61a937c19a6bc6b DIFF: https://github.com/llvm/llvm-project/commit/6db007a0654ed7a6ed5c3aa3b61a937c19a6bc6b.d

[PATCH] D149986: AMDGPU: Force sc0 and sc1 on stores for gfx940 and gfx941

kzhuravl added a comment. In D149986#4329302 , @arsenm wrote: > Should this be a feature set by default in the subtarget constructor instead? > Should you be able to turn this off? Users should not be able to turn this off. If user wants it off, user ca

[PATCH] D148094: [clang][CodeGen] Break up TargetInfo.cpp [8/8]

barannikov88 updated this revision to Diff 520772. barannikov88 retitled this revision from "[clang][CodeGen] Break up TargetInfo.cpp [7/7]" to "[clang][CodeGen] Break up TargetInfo.cpp [8/8]". barannikov88 edited the summary of this revision. barannikov88 added a comment. Rebase on top of the co

[PATCH] D150215: [clang][CodeGen] Break up TargetInfo.cpp [7/8]

barannikov88 created this revision. Herald added subscribers: s.egerton, simoncook, asb, fedor.sergeev, dschuff. Herald added a project: All. barannikov88 published this revision for review. barannikov88 added reviewers: rjmccall, aaron.ballman, erichkeane, jdoerfert, efriedma. Herald added subscr

[PATCH] D148094: [clang][CodeGen] Break up TargetInfo.cpp [8/8]

barannikov88 updated this revision to Diff 520774. barannikov88 added a comment. Squash commits Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148094/new/ https://reviews.llvm.org/D148094 Files: clang/docs/UsersManual.rst clang/docs/tools/clang

[PATCH] D148094: [clang][CodeGen] Break up TargetInfo.cpp [8/8]

barannikov88 updated this revision to Diff 520777. barannikov88 added a comment. Undo file renaming so that it does not look like the file was replaced Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148094/new/ https://reviews.llvm.org/D148094 File

[PATCH] D148094: [clang][CodeGen] Break up TargetInfo.cpp [8/8]

barannikov88 updated this revision to Diff 520781. barannikov88 added a comment. Undo unintended formatting changes Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148094/new/ https://reviews.llvm.org/D148094 Files: clang/docs/UsersManual.rst cl

[PATCH] D149193: [Driver] Add -dumpdir and change -gsplit-dwarf .dwo names for linking

scott.linder added a comment. In D149193#4316293 , @dblaikie wrote: > I guess my main question is: What's the motivation for implementing this? Do > you have a need/use for this? (it doesn't seem to be motivated by GCC > compatibility - as discussed, lo

  1   2   >