jsjodin added inline comments.
================ Comment at: llvm/include/llvm/Frontend/OpenMP/OMPIRBuilder.h:865 + TargetRegionEntryInfo EntryInfo, StringRef MangledName, + Module *LlvmModule, std::vector<GlobalVariable *> &GeneratedRefs, + bool OpenMPSIMD, std::vector<Triple> TargetTriple, ---------------- Instead of passing in the Module, we should be able to use M in the OpenMPIRBuilder. ================ Comment at: llvm/lib/Frontend/OpenMP/OMPIRBuilder.cpp:5225 + std::function<llvm::GlobalValue::LinkageTypes()> VariableLinkage, + llvm::Type *LlvmPtrTy, llvm::Constant *Addr) { + if (DeviceClause != OffloadEntriesInfoManager::OMPTargetDeviceClauseAny || ---------------- no llvm::prefix (look for more occurrences) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149162/new/ https://reviews.llvm.org/D149162 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits