VitaNuo added inline comments.
================
Comment at: clang-tools-extra/clang-tidy/utils/RenamerClangTidyCheck.cpp:457
+ // Don't keep track for non-identifier names.
+ if (auto *II = Decl->getIdentifier()) {
+ return addUsage(RenamerClangTidyCheck::NamingCheckId(Decl->getLocation(),
----------------
PiotrZSL wrote:
> Most probably this could be done before for, as overridden/cannonical decl
> should have same naming.
> And looks we get here from VisitMemberExpr.
Could you do an early return instead? I believe it's clearer.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D150187/new/
https://reviews.llvm.org/D150187
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
