[PATCH] D149160: [clang][analyzer] Handle special value AT_FDCWD in affected standard functions

steakhal added inline comments. Comment at: clang/lib/StaticAnalyzer/Checkers/StdLibraryFunctionsChecker.cpp:1988 + return std::make_shared( + ArgN, WithinRange, Range({AT_FDCWDv, AT_FDCWDv}, {0, IntMax}), ""); +}; Should we define a specific c

[PATCH] D147875: [clang][Diagnostics] Show line numbers when printing code snippets

tbaeder updated this revision to Diff 517463. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147875/new/ https://reviews.llvm.org/D147875 Files: clang-tools-extra/test/clang-tidy/checkers/cert/uppercase-literal-suffix-integer.cpp clang-tools-extra/test/clang-tidy/checkers/readabilit

[PATCH] D147875: [clang][Diagnostics] Show line numbers when printing code snippets

PiotrZSL added inline comments. Comment at: clang-tools-extra/test/clang-tidy/checkers/cert/uppercase-literal-suffix-integer.cpp:34 // CHECK-MESSAGES-NEXT: ^~ - // CHECK-MESSAGES-NEXT: {{^ *}}L{{$}} + // CHECK-MESSAGES-NEXT: {{^ *| *}}L{{$}} // CHECK-FIXES: static conste

[PATCH] D147875: [clang][Diagnostics] Show line numbers when printing code snippets

tbaeder added inline comments. Comment at: clang-tools-extra/test/clang-tidy/checkers/cert/uppercase-literal-suffix-integer.cpp:34 // CHECK-MESSAGES-NEXT: ^~ - // CHECK-MESSAGES-NEXT: {{^ *}}L{{$}} + // CHECK-MESSAGES-NEXT: {{^ *| *}}L{{$}} // CHECK-FIXES: static constex

[PATCH] D149280: [clang-tidy] Add modernize-printf-to-std-print check

PiotrZSL added inline comments. Comment at: clang-tools-extra/clang-tidy/modernize/PrintfToStdPrintCheck.cpp:28 + ReplacementPrintFunction(Options.get("PrintFunction", "std::print")) { + PrintfLikeFunctions.push_back("printf"); + PrintfLikeFunctions.push_back("absl::PrintF

[PATCH] D136515: [builtins] Add __builtin_assume_separate_storage.

OfekShilon added subscribers: kosarev, OfekShilon. OfekShilon added inline comments. Comment at: clang/docs/LanguageExtensions.rst:2393 +particular object (so for example, it's never correct to call this function +passing the addresses of fields in the same struct, elements of th

[PATCH] D149160: [clang][analyzer] Handle special value AT_FDCWD in affected standard functions

balazske updated this revision to Diff 517470. balazske marked an inline comment as done. balazske added a comment. using short way for getting macro value added constraint description Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149160/new/ https

[PATCH] D149160: [clang][analyzer] Handle special value AT_FDCWD in affected standard functions

balazske marked 2 inline comments as done. balazske added inline comments. Comment at: clang/lib/StaticAnalyzer/Checkers/StdLibraryFunctionsChecker.cpp:1988 + return std::make_shared( + ArgN, WithinRange, Range({AT_FDCWDv, AT_FDCWDv}, {0, IntMax}), ""); +}; ---

[PATCH] D149321: [clang][analyzer] Display buffer sizes in StdCLibraryFunctionArgs checker

balazske created this revision. Herald added subscribers: steakhal, manas, ASDenysPetrov, martong, gamesh411, dkrupp, donat.nagy, Szelethus, mikhail.ramalho, a.sidorin, szepet, baloghadamsoftware, xazax.hun. Herald added a reviewer: Szelethus. Herald added a reviewer: NoQ. Herald added a project:

[PATCH] D149321: [clang][analyzer] Display buffer sizes in StdCLibraryFunctionArgs checker

Szelethus added reviewers: steakhal, gamesh411. Szelethus accepted this revision. Szelethus added a comment. This revision is now accepted and ready to land. I am Szelethus, and I approve this warning message! Now, on another issue, if we can output such a thorough message, we should start to co

[PATCH] D139010: [clang][WebAssembly] Implement support for table types and builtins

pmatos updated this revision to Diff 517478. pmatos marked 6 inline comments as done. pmatos added a comment. Complete fixing tests. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139010/new/ https://reviews.llvm.org/D139010 Files: clang/docs/Lan

[PATCH] D149321: [clang][analyzer] Display buffer sizes in StdCLibraryFunctionArgs checker

Szelethus added inline comments. Comment at: clang/lib/StaticAnalyzer/Checkers/StdLibraryFunctionsChecker.cpp:889 + State, getArgSVal(Call, ArgN))) +Out << " (that is " << *Val << ")"; +} I think this would be correct. Repository: rG LLVM Git

[PATCH] D149276: [Clang] Fix parsing of `(auto(x))`.

cor3ntin updated this revision to Diff 517488. cor3ntin marked 8 inline comments as done. cor3ntin added a comment. - Fix tests - Address aaron's comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149276/new/ https://reviews.llvm.org/D149276 F

cfe-commits@lists.llvm.org

massberg updated this revision to Diff 517489. massberg added a comment. Updated errort messages, code and tests. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148924/new/ https://reviews.llvm.org/D148924 Files: clang/include/clang/Basic/

[PATCH] D149276: [Clang] Fix parsing of `(auto(x))`.

cor3ntin updated this revision to Diff 517491. cor3ntin added a comment. Do not parse auto( as an expression before C++23 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149276/new/ https://reviews.llvm.org/D149276 Files: clang/docs/ReleaseNotes.r

[PATCH] D149276: [Clang] Fix parsing of `(auto(x))`.

tbaeder added inline comments. Comment at: clang/lib/Parse/ParseTentative.cpp:1067 +bool mayHaveDirectInit, +bool mayHaveTrailingReturnType) { // declarator: Not part of th

cfe-commits@lists.llvm.org

massberg marked 5 inline comments as done. massberg added inline comments. Comment at: clang/lib/Sema/SemaDeclCXX.cpp:8593 +const FunctionProtoType *FnType = FD->getType()->castAs(); +if (FnType->isVolatile()) { aaron.ballman wrote: > aaron.ballman wro

[PATCH] D149276: [Clang] Fix parsing of `(auto(x))`.

cor3ntin added inline comments. Comment at: clang/lib/Parse/ParseTentative.cpp:237 ConsumeAnnotationToken(); -if (Tok.is(tok::identifier)) +if (Tok.isOneOf(tok::identifier, tok::kw_auto)) ConsumeToken(); aaron.ballman wrote: > This smells a

[PATCH] D132819: [RISCV] Add MC support of RISCV zcmp Extension

VincentWu updated this revision to Diff 517494. VincentWu marked 3 inline comments as done. VincentWu added a comment. address comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132819/new/ https://reviews.llvm.org/D132819 Files: clang/test/

[PATCH] D149246: [RISCV] Relax rules for ordering s/z/x prefixed extensions in ISA naming strings

kito-cheng accepted this revision. kito-cheng added a comment. I am really happy to see this happen, binutils has relaxed for a while in more relaxed way[1] - only require must start with `rv[32|64][e|i|g]`, personally I would like to relax the order at all like binutils did for GCC, but I don't

[clang] 7c97dc2 - [clang] Do not crash on undefined template partial specialization

Author: Mariya Podchishchaeva Date: 2023-04-27T05:38:41-04:00 New Revision: 7c97dc20ab6148289f2cc01b2999130e32a19eb3 URL: https://github.com/llvm/llvm-project/commit/7c97dc20ab6148289f2cc01b2999130e32a19eb3 DIFF: https://github.com/llvm/llvm-project/commit/7c97dc20ab6148289f2cc01b2999130e32a19e

[PATCH] D148330: [clang] Do not crash on undefined template partial specialization

This revision was automatically updated to reflect the committed changes. Closed by commit rG7c97dc20ab61: [clang] Do not crash on undefined template partial specialization (authored by Fznamznon). Changed prior to commit: https://reviews.llvm.org/D148330?vs=513581&id=517496#toc Repository:

[PATCH] D148712: [clang] Diagnose shadowing of lambda's template parameter by a capture

Fznamznon updated this revision to Diff 517502. Fznamznon added a comment. Rebase to double check that pre-commit fail is unrelated, add a release note Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148712/new/ https://reviews.llvm.org/D148712 File

[clang] 6cf14a7 - [clang][Interp] Check Neg ops for errors

Author: Timm Bäder Date: 2023-04-27T12:05:23+02:00 New Revision: 6cf14a72390f0914b18f30f2f357b783ff84533c URL: https://github.com/llvm/llvm-project/commit/6cf14a72390f0914b18f30f2f357b783ff84533c DIFF: https://github.com/llvm/llvm-project/commit/6cf14a72390f0914b18f30f2f357b783ff84533c.diff LO

[PATCH] D148987: [clang][Interp] Check Neg ops for errors

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG6cf14a72390f: [clang][Interp] Check Neg ops for errors (authored by tbaeder). Changed prior to commit: https://reviews.llvm.org/D148987?vs=517054&

[clang-tools-extra] 4b1cec0 - [clangd] Add batch fixes for include-cleaner diagnostics

Author: Haojian Wu Date: 2023-04-27T12:08:59+02:00 New Revision: 4b1cec065227db64f870a179a2d45cffa314641a URL: https://github.com/llvm/llvm-project/commit/4b1cec065227db64f870a179a2d45cffa314641a DIFF: https://github.com/llvm/llvm-project/commit/4b1cec065227db64f870a179a2d45cffa314641a.diff LO

[PATCH] D147684: [clangd] Add batch fixes for include-cleaner diagnostics

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG4b1cec065227: [clangd] Add batch fixes for include-cleaner diagnostics (authored by hokein). Changed prior to commit: https://reviews.llvm.org/D14

[clang] f8a9c55 - [clang][Interp] Emit diagnostic when comparing function pointers

Author: Timm Bäder Date: 2023-04-27T12:33:28+02:00 New Revision: f8a9c55bef380a592c4588025f8b6ca4dfc94c47 URL: https://github.com/llvm/llvm-project/commit/f8a9c55bef380a592c4588025f8b6ca4dfc94c47 DIFF: https://github.com/llvm/llvm-project/commit/f8a9c55bef380a592c4588025f8b6ca4dfc94c47.diff LO

[PATCH] D149154: [clang][Interp] Emit diagnostic when comparing function pointers

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGf8a9c55bef38: [clang][Interp] Emit diagnostic when comparing function pointers (authored by tbaeder). Changed prior to commit: https://reviews.llv

[PATCH] D148663: [RFC][clangd] Use interpolation for CDB pushed via LSP protocol

DmitryPolukhin added a comment. In D148663#4298496 , @ilya-biryukov wrote: > I wanted to chime in and provide a bit of context. > This was a long time ago, so I might misremember, so take this with a grain > of salt. > > Idea behind pushing the CDB over

[PATCH] D137414: [TySan] Fix Type Sanitizer build on Linux

Enna1 created this revision. Herald added a project: All. Enna1 updated this revision to Diff 474450. Enna1 added a comment. Enna1 added a reviewer: fhahn. Enna1 added a subscriber: MTC. Enna1 published this revision for review. Herald added subscribers: Sanitizers, cfe-commits, StephenFan. Herald

[PATCH] D149172: [clang][Interp] Emit proper diagnostic when comparing unrelated pointers

tbaeder added a comment. Meh, turns out `(void*)&s.a;` is a bitcast, so can't push this yet. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149172/new/ https://reviews.llvm.org/D149172 ___ cfe-commits mai

[PATCH] D143347: [lldb][DWARF] Infer no_unique_address attribute

Michael137 added a comment. In D143347#4298613 , @kpdev42 wrote: > So what are next steps? Are we going for implementation of > `DW_AT_no_unique_address` (which is going to be a non-standard extension) ? > @dblaikie @aprantl @Michael137 in my opinion t

[PATCH] D146178: [Clang][Sema] Fix comparison of constraint expressions

alexander-shaposhnikov updated this revision to Diff 517513. alexander-shaposhnikov added a comment. Add more tests Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146178/new/ https://reviews.llvm.org/D146178 Files: clang/include/clang/AST/DeclTem

[PATCH] D139010: [clang][WebAssembly] Implement support for table types and builtins

aaron.ballman added inline comments. Comment at: clang/test/Sema/wasm-refs-and-tables.c:17 +static __externref_t t6[] = {0}; // expected-error {{only zero-length WebAssembly tables are currently supported}} +__externref_t t7[0]; // expected-error {{WebAssembly table

[PATCH] D149334: [RISCV] Enable strict fp for RISC-V in clang.

fakepaper56 created this revision. fakepaper56 added reviewers: craig.topper, reames, frasercrmck, rogfer01. Herald added subscribers: jobnoorman, luke, VincentWu, vkmr, evandro, luismarques, apazos, sameer.abuasal, s.egerton, Jim, benna, psnobl, jocewei, PkmX, the_o, brucehoult, MartinMosbeck, e

[clang] a3e56a8 - [KMSAN] Enable on SystemZ

Author: Ilya Leoshkevich Date: 2023-04-27T13:44:54+02:00 New Revision: a3e56a8792ffaf3a3d3538736e1042b8db45ab89 URL: https://github.com/llvm/llvm-project/commit/a3e56a8792ffaf3a3d3538736e1042b8db45ab89 DIFF: https://github.com/llvm/llvm-project/commit/a3e56a8792ffaf3a3d3538736e1042b8db45ab89.di

[PATCH] D148596: [KMSAN] Enable on SystemZ

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGa3e56a8792ff: [KMSAN] Enable on SystemZ (authored by iii). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.or

[PATCH] D134821: [flang][driver] Allow main program to be in an archive

sunshaoce added a comment. Any further suggestions? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134821/new/ https://reviews.llvm.org/D134821 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http

[PATCH] D141451: [clang] report inlining decisions with -Wattribute-{warning|error}

aaron.ballman added inline comments. Comment at: clang/test/Frontend/backend-attribute-error-warning-optimize.c:12 foo(); // expected-error {{call to 'foo' declared with 'error' attribute: oh no foo}} + // expected-note@* {{In function 'baz'}} if (x())

[PATCH] D139010: [clang][WebAssembly] Implement support for table types and builtins

pmatos marked 2 inline comments as done. pmatos added inline comments. Comment at: clang/include/clang/Basic/BuiltinsWebAssembly.def:205-210 +TARGET_BUILTIN(__builtin_wasm_table_set, "viii", "t", "reference-types") +TARGET_BUILTIN(__builtin_wasm_table_get, "iii", "t", "referenc

[PATCH] D139010: [clang][WebAssembly] Implement support for table types and builtins

pmatos updated this revision to Diff 517521. pmatos marked 2 inline comments as done. pmatos added a comment. Update a few more tests. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139010/new/ https://reviews.llvm.org/D139010 Files: clang/docs/L

[PATCH] D139010: [clang][WebAssembly] Implement support for table types and builtins

pmatos marked an inline comment as done. pmatos added inline comments. Comment at: clang/test/Sema/wasm-refs-and-tables.c:17 +static __externref_t t6[] = {0}; // expected-error {{only zero-length WebAssembly tables are currently supported}} +__externref_t t7[0]; // e

[PATCH] D139010: [clang][WebAssembly] Implement support for table types and builtins

pmatos updated this revision to Diff 517525. pmatos marked an inline comment as done. pmatos added a comment. Quick fixup of test. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139010/new/ https://reviews.llvm.org/D139010 Files: clang/docs/Langu

[PATCH] D139010: [clang][WebAssembly] Implement support for table types and builtins

pmatos added inline comments. Comment at: clang/test/SemaCXX/wasm-refs-and-tables.cpp:35 +task<__externref_t[]> g() { + co_return table; +} @aaron.ballman I tried and failed to create a good testcase for co_return. However creating coroutines seems to be an std

[PATCH] D149276: [Clang] Fix parsing of `(auto(x))`.

aaron.ballman added inline comments. Comment at: clang/lib/Parse/ParseTentative.cpp:1067 +bool mayHaveDirectInit, +bool mayHaveTrailingReturnType) { // declarator: tbaeder

[PATCH] D149206: [clang][driver] Enable MisExpect diagnostics flag outside of CC1

hans accepted this revision. hans added a comment. lgtm Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149206/new/ https://reviews.llvm.org/D149206 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D134821: [flang][driver] Allow main program to be in an archive

awarzynski accepted this revision. awarzynski added a comment. In D134821#4301701 , @sunshaoce wrote: > Any further suggestions? I am happy for you to land this, thanks! LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://re

cfe-commits@lists.llvm.org

aaron.ballman added a comment. Basically looking good to me now, but the changes need a release note and I does this mean we can change cxx_status.html to claim full support for P2002R1 now or is there more left to be done for that? (If there's more left to do, adding those details to the cxx_s

[clang-tools-extra] 6cfcf02 - [clangd] Fix the include-cleaner-batch-fix.test failure on some

Author: Haojian Wu Date: 2023-04-27T14:59:37+02:00 New Revision: 6cfcf0242f3260a3a90bac68e9f271548caa8372 URL: https://github.com/llvm/llvm-project/commit/6cfcf0242f3260a3a90bac68e9f271548caa8372 DIFF: https://github.com/llvm/llvm-project/commit/6cfcf0242f3260a3a90bac68e9f271548caa8372.diff LO

[PATCH] D139010: [clang][WebAssembly] Implement support for table types and builtins

pmatos updated this revision to Diff 517535. pmatos added a comment. Add documentation for table builtins. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139010/new/ https://reviews.llvm.org/D139010 Files: clang/docs/LanguageExtensions.rst clan

[PATCH] D139010: [clang][WebAssembly] Implement support for table types and builtins

pmatos marked an inline comment as done. pmatos added a comment. I think we are almost there. @aaron.ballman what do you think? Comment at: clang/test/Sema/wasm-refs-and-tables.c:81 + + funcref_t func = __builtin_wasm_ref_null_func(0); // expected-error {{too many arguments t

[PATCH] D149276: [Clang] Fix parsing of `(auto(x))`.

cor3ntin updated this revision to Diff 517536. cor3ntin added a comment. Fix tests Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149276/new/ https://reviews.llvm.org/D149276 Files: clang/docs/ReleaseNotes.rst clang/include/clang/Parse/Parser.h

[PATCH] D149264: GH62362: Handle constraints on "Using" inherited constructors

erichkeane added a comment. Confirmed this is all fixed by your patch. Thanks! Comment at: clang/lib/Sema/SemaTemplateInstantiate.cpp:138-144 +bool SkipForSpecialization, +bool ForConstraintInstantiation) { if (!ClassTemplSpec

[clang] f539b6f - [NFC] Add tests from my fix for GH62362.

Author: Erich Keane Date: 2023-04-27T06:33:34-07:00 New Revision: f539b6ffc25144703498176558035c499825dc48 URL: https://github.com/llvm/llvm-project/commit/f539b6ffc25144703498176558035c499825dc48 DIFF: https://github.com/llvm/llvm-project/commit/f539b6ffc25144703498176558035c499825dc48.diff L

[PATCH] D149264: GH62362: Handle constraints on "Using" inherited constructors

erichkeane abandoned this revision. erichkeane added a comment. Fixed by Richard! Tests and release note added in f539bffc CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149264/new/ https://reviews.llvm.org/D149264 ___ cfe-commits mailing lis

[PATCH] D149210: [IR] Change shufflevector undef mask to poison

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG8b56da5e9f3b: [IR] Change shufflevector undef mask to poison (authored by ManuelJBrito). Changed prior to commit: https://reviews.llvm.org/D149210

[PATCH] D149272: [clang] Call printName to get name of Decl

aaron.ballman added inline comments. Comment at: clang/lib/AST/DeclarationName.cpp:119-125 if (const RecordType *ClassRec = ClassType->getAs()) { -OS << *ClassRec->getDecl(); +ClassRec->getDecl()->printName(OS, Policy); return; } if (Policy.SuppressTemplateA

[PATCH] D146557: [MLIR][OpenMP] Refactoring how map clause is processed

TIFitis added a comment. In D146557#4295550 , @kiranchandramohan wrote: > In D146557#4292223 , @TIFitis wrote: > >> Cleaned up how IsBegin argument is passed for createTargetData call. > > Please submit this dire

[PATCH] D148601: [Clang] Handle Error message to output proper Prefix

aaron.ballman requested changes to this revision. aaron.ballman added a comment. This revision now requires changes to proceed. Thank you for working on this! These changes should come with test coverage (we have a handful of verifier tests in `clang/test/Frontend` -- you can add a new test file

[PATCH] D146557: [MLIR][OpenMP] Refactoring how map clause is processed

TIFitis updated this revision to Diff 517548. TIFitis added a comment. Rebased Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146557/new/ https://reviews.llvm.org/D146557 Files: clang/lib/CodeGen/CGOpenMPRuntime.cpp llvm/include/llvm/Frontend/O

[clang] 843450b - [clang] Try to fix check-clang after f539b6ffc251

Author: Nico Weber Date: 2023-04-27T10:12:39-04:00 New Revision: 843450b9a67c57f134913a2b90dcb5ba95114e0f URL: https://github.com/llvm/llvm-project/commit/843450b9a67c57f134913a2b90dcb5ba95114e0f DIFF: https://github.com/llvm/llvm-project/commit/843450b9a67c57f134913a2b90dcb5ba95114e0f.diff LO

[PATCH] D148802: [Sema] Lambdas are not part of immediate context for deduction

ilya-biryukov updated this revision to Diff 517550. ilya-biryukov marked 5 inline comments as done. ilya-biryukov added a comment. - Add a note when substituting into a lambda - Quote the standard and add explanation for the test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D148802: [Sema] Lambdas are not part of immediate context for deduction

ilya-biryukov added a comment. In D148802#4283566 , @erichkeane wrote: > My one concern is that this is going to expose our incorrect instantiation of > lambdas further and more painfully (see > https://github.com/llvm/llvm-project/issues/58872). Else

[PATCH] D141627: [Clang][OpenMP] Fix the issue that list items in `has_device_addr` are still mapped to the target device

tianshilei1992 added a comment. ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141627/new/ https://reviews.llvm.org/D141627 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.

[PATCH] D149321: [clang][analyzer] Display buffer sizes in StdCLibraryFunctionArgs checker

balazske updated this revision to Diff 517554. balazske added a comment. using "wihch" at argument values Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149321/new/ https://reviews.llvm.org/D149321 Files: clang/lib/StaticAnalyzer/Checkers/StdLibr

[PATCH] D149280: [clang-tidy] Add modernize-printf-to-std-print check

Eugene.Zelenko added inline comments. Comment at: clang-tools-extra/clang-tidy/modernize/PrintfToStdPrintCheck.cpp:66 + if (Converter.canApply()) { +const auto *PrintfCall = Printf->getCallee(); +DiagnosticBuilder Diag = Please don't use `auto` unless ty

[PATCH] D148088: [RFC][clangd] Move preamble index task to a seperate task

ilya-biryukov added a comment. > We would like to move the preamble index out of the critical path Could you provide motivation why you need to do it? What is the underlying problem that this change is trying to solve? We rely on preamble being indexed at that particular time for correct results

[PATCH] D148088: [RFC][clangd] Move preamble index task to a seperate task

kuganv added a comment. In D148088#4302092 , @ilya-biryukov wrote: >> We would like to move the preamble index out of the critical path > > Could you provide motivation why you need to do it? What is the underlying > problem that this change is trying t

[clang] 05d0cae - [RISCV] Remove support for attribute interrupt("user").

Author: Craig Topper Date: 2023-04-27T08:21:36-07:00 New Revision: 05d0caef6081e1a6cb23a5a5afe43dc82e8ca558 URL: https://github.com/llvm/llvm-project/commit/05d0caef6081e1a6cb23a5a5afe43dc82e8ca558 DIFF: https://github.com/llvm/llvm-project/commit/05d0caef6081e1a6cb23a5a5afe43dc82e8ca558.diff

[PATCH] D149314: [RISCV] Remove support for attribute interrupt("user").

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG05d0caef6081: [RISCV] Remove support for attribute interrupt("user"). (authored by craig.topper). Repository: rG LLVM Github Monorepo CHANGES SIN

[PATCH] D149314: [RISCV] Remove support for attribute interrupt("user").

aaron.ballman added a comment. Is this a potentially breaking change that we need to call out for users to be aware of? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149314/new/ https://reviews.llvm.org/D149314 ___

[PATCH] D149352: [clang-format] Recognize Verilog type dimension in module header

sstwcw created this revision. sstwcw added a reviewer: curdeius. Herald added projects: All, clang, clang-format. Herald added a subscriber: cfe-commits. Herald added reviewers: rymiel, HazardyKnusperkeks, owenpan, MyDeveloperDay. sstwcw requested review of this revision. We had the function `veri

[PATCH] D141627: [Clang][OpenMP] Fix the issue that list items in `has_device_addr` are still mapped to the target device

jyu2 added a comment. If it is okay with is_divece_ptr. I am okay with it. Please add a lit test for this? Thanks. Jennifer Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141627/new/ https://reviews.llvm.org/D141627 __

[PATCH] D149314: [RISCV] Remove support for attribute interrupt("user").

asb added a comment. In D149314#4302203 , @aaron.ballman wrote: > Is this a potentially breaking change that we need to call out for users to > be aware of? We should mention this in the Clang release notes I think. Repository: rG LLVM Github Monor

[PATCH] D148088: [RFC][clangd] Move preamble index task to a seperate task

ilya-biryukov added a comment. In D148088#4302182 , @kuganv wrote: > 1. We see preamble indexing taking as much as 18% of the time for some files. > Moving preamble indexing out of the critical path helps there. Which operation are you measuring? 18%

[PATCH] D149272: [clang] Call printName to get name of Decl

dankm added inline comments. Comment at: clang/test/CodeGen/debug-prefix-map.cpp:1 +// RUN: %clang++ -g -fdebug-prefix-map=%p=./UNLIKELY_PATH/empty -S -c %s -emit-llvm -o - | FileCheck %s --check-prefix=CHECK-REL + aaron.ballman wrote: > I'm taking a guess at co

[PATCH] D146557: [MLIR][OpenMP] Refactoring how map clause is processed

kiranchandramohan added a comment. In D146557#4301955 , @TIFitis wrote: > In D146557#4295550 , > @kiranchandramohan wrote: > >> In D146557#4292223 , @TIFitis >> wrote: >

[PATCH] D149314: [RISCV] Remove support for attribute interrupt("user").

aaron.ballman added a reviewer: erichkeane. aaron.ballman added a comment. In D149314#4302266 , @asb wrote: > In D149314#4302203 , @aaron.ballman > wrote: > >> Is this a potentially breaking change that we need t

[PATCH] D149314: [RISCV] Remove support for attribute interrupt("user").

reames added a comment. In D149314#4302300 , @aaron.ballman wrote: > In D149314#4302266 , @asb wrote: > >> In D149314#4302203 , >> @aaron.ballman wrote: >> >>> Is this a

[PATCH] D149314: [RISCV] Remove support for attribute interrupt("user").

aaron.ballman added a comment. In D149314#4302312 , @reames wrote: > In D149314#4302300 , @aaron.ballman > wrote: > >> In D149314#4302266 , @asb wrote: >> >>> In D149314#

[PATCH] D149272: [clang] Call printName to get name of Decl

dankm added inline comments. Comment at: clang/test/CodeGen/debug-prefix-map.cpp:1 +// RUN: %clang++ -g -fdebug-prefix-map=%p=./UNLIKELY_PATH/empty -S -c %s -emit-llvm -o - | FileCheck %s --check-prefix=CHECK-REL + dankm wrote: > aaron.ballman wrote: > > I'm tak

[PATCH] D149193: [Driver] Add -dumpdir and change -gsplit-dwarf .dwo names for linking

scott.linder added a comment. In D149193#4300885 , @MaskRay wrote: > I think the patch as-is implements all the useful parts of GCC's complex > rules and in the absence of `-dumpbase` (we deliberately don't implement), > the rule almost exactly matches

[PATCH] D149272: [clang] Call printName to get name of Decl

dankm updated this revision to Diff 517595. dankm added a comment. Correct test case Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149272/new/ https://reviews.llvm.org/D149272 Files: clang/lib/AST/Decl.cpp clang/lib/AST/DeclarationName.cpp c

[PATCH] D149314: [RISCV] Remove support for attribute interrupt("user").

asb added a comment. In D149314#4302312 , @reames wrote: > In D149314#4302300 , @aaron.ballman > wrote: > >> In D149314#4302266 , @asb wrote: >> >>> In D149314#4302203

[PATCH] D148601: [Clang] Handle Error message to output proper Prefix

Unique_Usman added a comment. In D148601#4301977 , @aaron.ballman wrote: > Thank you for working on this! These changes should come with test coverage > (we have a handful of verifier tests in `clang/test/Frontend` -- you can add > a new test file ther

[clang] 4ab76b7 - [AArch64][InlineAsm]Add Clang support for flag output constraints

Author: Mingming Liu Date: 2023-04-27T09:39:08-07:00 New Revision: 4ab76b77cee0e27510d5d5cb3072ee7e92d96eec URL: https://github.com/llvm/llvm-project/commit/4ab76b77cee0e27510d5d5cb3072ee7e92d96eec DIFF: https://github.com/llvm/llvm-project/commit/4ab76b77cee0e27510d5d5cb3072ee7e92d96eec.diff

[PATCH] D149123: [AArch64][InlineAsm]Add Clang support for flag output constraints

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG4ab76b77cee0: [AArch64][InlineAsm]Add Clang support for flag output constraints (authored by mingmingl). Repository: rG LLVM Github Monorepo CHAN

[PATCH] D147218: [OpenMP][Flang][MLIR] Lowering of OpenMP requires directive from parse tree to MLIR

skatrak updated this revision to Diff 517616. skatrak added a comment. Remove checks from lowering that belong in semantic analysis Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147218/new/ https://reviews.llvm.org/D147218 Files: flang/include/f

[PATCH] D132819: [RISCV] Add MC support of RISCV zcmp Extension

craig.topper added inline comments. Comment at: llvm/lib/Target/RISCV/AsmParser/RISCVAsmParser.cpp:3150 + SMLoc Loc = Operands[1]->getStartLoc(); + return Error(Loc, "'rs1' and 'rs2' mast be different."); +} mast -> must Repository: rG LLVM Gith

[PATCH] D149314: [RISCV] Remove support for attribute interrupt("user").

aaron.ballman added a comment. In D149314#4302342 , @asb wrote: > In D149314#4302312 , @reames wrote: > >> In D149314#4302300 , >> @aaron.ballman wrote: >> >>> In D149314

[PATCH] D149301: [clang] Fix a crash with parenthesized aggregate initialization and base classes

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM, good catch! I think you should add a release note for this when landing, and this seems pretty reasonable to consider backporting to 16.x, WDYT? Repository: rG LLVM Gith

[PATCH] D141451: [clang] report inlining decisions with -Wattribute-{warning|error}

cjdb added inline comments. Comment at: clang/test/Frontend/backend-attribute-error-warning-optimize.c:12 foo(); // expected-error {{call to 'foo' declared with 'error' attribute: oh no foo}} + // expected-note@* {{In function 'baz'}} if (x()) aaro

[PATCH] D149193: [Driver] Add -dumpdir and change -gsplit-dwarf .dwo names for linking

MaskRay marked an inline comment as done. MaskRay added a comment. In D149193#4302337 , @scott.linder wrote: > In D149193#4300885 , @MaskRay wrote: > >> I think the patch as-is implements all the useful parts of

[PATCH] D149301: [clang] Fix a crash with parenthesized aggregate initialization and base classes

ayzhao updated this revision to Diff 517636. ayzhao added a comment. add release note Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149301/new/ https://reviews.llvm.org/D149301 Files: clang/docs/ReleaseNotes.rst clang/lib/Sema/SemaInit.cpp c

[PATCH] D149301: [clang] Fix a crash with parenthesized aggregate initialization and base classes

ayzhao added a comment. In D149301#4302621 , @aaron.ballman wrote: > I think you should add a release note for this when landing, Done > and this seems pretty reasonable to consider backporting to 16.x, WDYT? Agreed, given that this is a crash. Repo

[clang] 7417e9d - [clang] Fix a crash with parenthesized aggregate initialization and base classes

Author: Alan Zhao Date: 2023-04-27T10:43:16-07:00 New Revision: 7417e9d75c9af7dd0d3dad12eebdee84b10b56d7 URL: https://github.com/llvm/llvm-project/commit/7417e9d75c9af7dd0d3dad12eebdee84b10b56d7 DIFF: https://github.com/llvm/llvm-project/commit/7417e9d75c9af7dd0d3dad12eebdee84b10b56d7.diff LOG

[PATCH] D149301: [clang] Fix a crash with parenthesized aggregate initialization and base classes

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG7417e9d75c9a: [clang] Fix a crash with parenthesized aggregate initialization and base classes (authored by ayzhao). Repository: rG LLVM Github Mo

[clang] d7354fb - Keep multiple-include optimization for null directives

Author: Elliot Goodrich Date: 2023-04-27T13:44:11-04:00 New Revision: d7354fb63471a7a38993280c8264fd8d57432dc7 URL: https://github.com/llvm/llvm-project/commit/d7354fb63471a7a38993280c8264fd8d57432dc7 DIFF: https://github.com/llvm/llvm-project/commit/d7354fb63471a7a38993280c8264fd8d57432dc7.dif

[PATCH] D147928: [clang] Keep multiple-include optimization for null directives

This revision was automatically updated to reflect the committed changes. Closed by commit rGd7354fb63471: Keep multiple-include optimization for null directives (authored by IncludeGuardian, committed by aaron.ballman). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://r

  1   2   >