kiranchandramohan added a comment. In D146557#4301955 <https://reviews.llvm.org/D146557#4301955>, @TIFitis wrote:
> In D146557#4295550 <https://reviews.llvm.org/D146557#4295550>, > @kiranchandramohan wrote: > >> In D146557#4292223 <https://reviews.llvm.org/D146557#4292223>, @TIFitis >> wrote: >> >>> Cleaned up how IsBegin argument is passed for createTargetData call. >> >> Please submit this directly as an NFC patch. > > I have merged it separately. > >> We should always work towards simple patches that are easy to review. >> Sometimes a big patch is required to give the full context. But it can then >> be broken up into small patches for faster review. I have created D149153 >> <https://reviews.llvm.org/D149153> for the `inlineConvertOmpRegions` change. > > Thanks for creating your patch. I'll try to make my patches shorter in the > future. > > Once D149153 <https://reviews.llvm.org/D149153> is merged I'll rebase this > patch. I have submitted D149153 <https://reviews.llvm.org/D149153>. https://github.com/llvm/llvm-project/commit/1ed522623d95ce7dcf95e711b0f2e3844d2e6be1 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146557/new/ https://reviews.llvm.org/D146557 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
