aaron.ballman added a reviewer: erichkeane.
aaron.ballman added a comment.

In D149314#4302266 <https://reviews.llvm.org/D149314#4302266>, @asb wrote:
> In D149314#4302203 <https://reviews.llvm.org/D149314#4302203>, @aaron.ballman 
> wrote:
>
>> Is this a potentially breaking change that we need to call out for users to 
>> be aware of?
>
> We should mention this in the Clang release notes I think.

Beyond that, we've got a process for what to do when considering potentially 
breaking changes, we should be following that: 
https://llvm.org/docs/DeveloperPolicy.html#making-potentially-breaking-changes 
Also, if we're all agreed this is potentially breaking, it really should have 
more review time and buy-in from the code owner.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D149314/new/

https://reviews.llvm.org/D149314

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to