aaron.ballman requested changes to this revision.
aaron.ballman added a comment.
This revision now requires changes to proceed.
Thank you for working on this! These changes should come with test coverage (we
have a handful of verifier tests in `clang/test/Frontend` -- you can add a new
test file there), but I don't think a release note is required because this is
a fix for internal functionality. The test should cover the simple case of
`-verify=something` as well as a more complex test with `-verify=something,
something_else`.
================
Comment at: clang/include/clang/Basic/DiagnosticFrontendKinds.td:175-176
def err_verify_invalid_no_diags : Error<
"%select{expected|'expected-no-diagnostics'}0 directive cannot follow "
"%select{'expected-no-diagnostics' directive|other expected directives}0">;
def err_verify_no_directives : Error<
----------------
Should we be handling this situation at the same time, as it's effectively the
same concern? e.g., https://godbolt.org/z/4Mn1rW9oa
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D148601/new/
https://reviews.llvm.org/D148601
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
