[PATCH] D131678: hicpp-signed-bitwise - Return location of the operand (and not of the operator beginning)

njames93 added inline comments. Comment at: clang-tools-extra/clang-tidy/hicpp/SignedBitwiseCheck.cpp:100 "%select{binary|unary}0 bitwise operator") - << IsUnary << SignedOperand->getSourceRange(); + << IsUnary << Location; } Seems pr

[PATCH] D130181: [clang-tidy] Add readability-use-early-exits check

njames93 updated this revision to Diff 451856. njames93 added a comment. Refactor some of the impl. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130181/new/ https://reviews.llvm.org/D130181 Files: clang-tools-extra/clang-tidy/readability/CMakeL

[PATCH] D131469: [Clang] change default storing path of `-ftime-trace`

dongjunduo updated this revision to Diff 451857. dongjunduo added a comment. format code Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131469/new/ https://reviews.llvm.org/D131469 Files: clang/lib/Driver/Driver.cpp clang/test/Driver/check-time

[PATCH] D131683: "Diagnosing the Future Keywords"

Codesbyusman created this revision. Herald added a project: All. Codesbyusman requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D131683 Files: clang/include/clang/Basic/Diagno

[PATCH] D131678: hicpp-signed-bitwise - Return location of the operand (and not of the operator beginning)

carlosgalvezp added a comment. Hi @vladimir.plyashkun ! I looked at the screenshot in the link you posted. What is the type of `value`? Consider that if `value` is an `uint8_t`, as per the integer promotion rules, it will be promoted to (signed) `int` before running the bitwise operation. Ther

[PATCH] D131683: "Diagnosing the Future Keywords"

xbolva00 added inline comments. Comment at: clang/include/clang/Basic/TokenKinds.def:395 CXX11_KEYWORD(noexcept , 0) CXX11_KEYWORD(nullptr , 0) +CXX11_KEYWORD(static_assert , KEYMSCOMPAT|KEYC23) nullptr is now in C23, right?

[PATCH] D131678: hicpp-signed-bitwise - Return location of the operand (and not of the operator beginning)

carlosgalvezp added a comment. On the other hand, if the `0xFF` becomes `0xFFu`, then Clang performs an integer promotion to `unsigned int` instead of `int`, and that's why clang-tidy no longer complains. I'm not sure that's correct behavior, however: If int can represent the entire range of

[PATCH] D131683: Diagnosing the Future Keywords

erichkeane added a comment. I believe you need tests here desperately. I also believe the `define` logic that you have here isn't going to be sufficient for the C future flags thanks to it getting some C keywords. Comment at: clang/include/clang/Basic/TokenKinds.def:387 //

[clang] 6e19e6c - [clang][X86] Add RDPRU predefined macro tests for znver2/znver3 targets

Author: Simon Pilgrim Date: 2022-08-11T15:48:39+01:00 New Revision: 6e19e6ce36e44554ac9fbf8b2780de05e922c849 URL: https://github.com/llvm/llvm-project/commit/6e19e6ce36e44554ac9fbf8b2780de05e922c849 DIFF: https://github.com/llvm/llvm-project/commit/6e19e6ce36e44554ac9fbf8b2780de05e922c849.diff

[PATCH] D131646: [clang][dataflow] Restructure loops to call widen on back edges

li.zhe.hua updated this revision to Diff 451861. li.zhe.hua marked 2 inline comments as done. li.zhe.hua added a comment. Address comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131646/new/ https://reviews.llvm.org/D131646 Files: clang/li

[PATCH] D131646: [clang][dataflow] Restructure loops to call widen on back edges

li.zhe.hua added inline comments. Comment at: clang/lib/Analysis/FlowSensitive/TypeErasedDataflowAnalysis.cpp:180 + assert(Block->pred_size() == 2); + BackEdge = Pred; +} ymandel wrote: > Might it be worth simply returning the backedge when you find

[PATCH] D131645: [clang][dataflow] Allow user-provided lattices to provide a widen operator

li.zhe.hua marked an inline comment as done. li.zhe.hua added inline comments. Comment at: clang/unittests/Analysis/FlowSensitive/TypeErasedDataflowAnalysisTest.cpp:119 + std::unique_ptr AST = + tooling::buildASTFromCodeWithArgs("int x = 0;", {"-std=c++11"}); + HasWidenAn

[PATCH] D131683: Diagnosing the Future Keywords

aaron.ballman added inline comments. Comment at: clang/include/clang/Basic/TokenKinds.def:395 CXX11_KEYWORD(noexcept , 0) CXX11_KEYWORD(nullptr , 0) +CXX11_KEYWORD(static_assert , KEYMSCOMPAT|KEYC23) xbolva00 wrote: > nullptr

[PATCH] D131678: hicpp-signed-bitwise - Return location of the operand (and not of the operator beginning)

vladimir.plyashkun added a comment. Hi @carlosgalvezp Yes, sorry, maybe screenshot and example from issue in our bugtracker is not the best one. You can check it on this sample from clang-tidy tests: The "hicpp-signed-bitwise" will point to URes = UValue & -

[PATCH] D131683: Diagnosing the Future Keywords

Codesbyusman added inline comments. Comment at: clang/include/clang/Basic/TokenKinds.def:387 // C++11 keywords -CXX11_KEYWORD(alignas , 0) +CXX11_KEYWORD(alignas , KEYC23) // alignof and _Alignof return the required ABI alignment eri

[PATCH] D128934: [X86] Add RDPRU instruction

probinson added a comment. In D128934#3630800 , @probinson wrote: > In D128934#3629653 , @pengfei wrote: > >> > > Done, thanks for the reminder! > >>> 2. Update `clang/lib/Headers/cpuid.h` and `llvm/lib/Support/H

[PATCH] D131623: [clang-tidy] Improve modernize-use-emplace check

njames93 added a comment. Just a general drive by comment here and doesn't affect this patch. This specifying containers logic is a little verbose, There may be a case to deprecate most of these options and just detect containers with an equivalent emplace* method at runtime. ===

[PATCH] D131683: Diagnosing the Future Keywords

erichkeane added inline comments. Comment at: clang/include/clang/Basic/TokenKinds.def:387 // C++11 keywords -CXX11_KEYWORD(alignas , 0) +CXX11_KEYWORD(alignas , KEYC23) // alignof and _Alignof return the required ABI alignment Codes

[PATCH] D131623: [clang-tidy] Improve modernize-use-emplace check

joeywatts added a comment. In D131623#3716227 , @njames93 wrote: > Just a general drive by comment here and doesn't affect this patch. > This specifying containers logic is a little verbose, There may be a case to > deprecate most of these options and j

[PATCH] D131469: [Clang] change default storing path of `-ftime-trace`

dongjunduo updated this revision to Diff 451865. dongjunduo added a comment. Restyle codes Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131469/new/ https://reviews.llvm.org/D131469 Files: clang/lib/Driver/Driver.cpp clang/test/Driver/check-ti

[clang] 08a8805 - [X86] Add RDPRU instruction CPUID bit masks

Author: Simon Pilgrim Date: 2022-08-11T16:07:36+01:00 New Revision: 08a880509e4f7ca8d346dce42fe7528c3a33f22c URL: https://github.com/llvm/llvm-project/commit/08a880509e4f7ca8d346dce42fe7528c3a33f22c DIFF: https://github.com/llvm/llvm-project/commit/08a880509e4f7ca8d346dce42fe7528c3a33f22c.diff

[PATCH] D131469: [Clang] change default storing path of `-ftime-trace`

dongjunduo marked 3 inline comments as done. dongjunduo added inline comments. Comment at: clang/lib/Driver/Driver.cpp:4786 +const std::string::size_type size = arg.size(); +char *buffer = new char[size + 1]; +memcpy(buffer, arg.c_str(), size + 1); ---

[PATCH] D129570: [clang-tidy] Add new clang-tidy check to find implicit conversions from enum to integer.

pfultz2 added a comment. Anymore feedback? Can this be merged now? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129570/new/ https://reviews.llvm.org/D129570 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-b

[PATCH] D111283: [clang] template / auto deduction deduces common sugar

mizvekov added a comment. In D111283#3716104 , @davrec wrote: > The first paragraph says X and Y must have the same canonical type, the > second suggests they need not. The first paragraph is talking about canonical equality, or if you take it that typ

[PATCH] D90275: [clang][IR] Add support for leaf attribute

jdoerfert added a comment. In D90275#3715563 , @xbolva00 wrote: > Was there any follow up? It seems that this hint (attribute) is currently not > used by LLVM passes. It is, also in our runtime, see https://reviews.llvm.org/D131628#3716252 Repository:

[PATCH] D131464: [test] Make tests pass regardless of gnu++14/gnu++17 default

aaron.ballman added a comment. In D131464#3713705 , @MaskRay wrote: > It will take some time to fix all tests properly. Let's have a guideline how > to fix them properly. I tried fixing some using several patterns in the last > revision. I didn't fix al

[PATCH] D131685: [clang][AST] RecursiveASTVisitor should visit owned TagDecl of friend type.

balazske created this revision. Herald added subscribers: steakhal, martong, gamesh411, Szelethus, dkrupp. Herald added a project: All. balazske requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. A FriendDecl node can have a friend record type

[PATCH] D131479: Handle explicitly defaulted consteval special members.

aaron.ballman accepted this revision. aaron.ballman added a comment. Thanks, this LGTM! Please be sure to add a release note for the fix before landing. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131479/new/ https://reviews.llvm.org/D131479 __

[PATCH] D129608: [Clang][OpenMP] Fix segmentation fault when data field is used in is_device_pt.

ABataev added inline comments. Comment at: clang/lib/CodeGen/CGOpenMPRuntime.cpp:9073 SmallVector DeclComponentLists; +if (DevPointersMap.count(VD)) { + // For member fields list in is_device_ptr, store it in If VD is nullptr, why do we need this ch

[PATCH] D131084: Add support for specifying the severity of a SARIF Result.

aaron.ballman added inline comments. Comment at: clang/include/clang/Basic/Sarif.h:157 +/// 1. https://docs.oasis-open.org/sarif/sarif/v2.1.0/os/sarif-v2.1.0-os.html#_Toc34317648";>level property +enum class SarifResultLevel { Note, Warning, Error }; + Should th

[PATCH] D131686: [clang-tidy] Add test to cert-dcl58-cpp.

balazske created this revision. Herald added subscribers: steakhal, martong, gamesh411, Szelethus, dkrupp, xazax.hun. Herald added a project: All. balazske requested review of this revision. Herald added a project: clang-tools-extra. Herald added a subscriber: cfe-commits. Add a test to cert-dcl5

[PATCH] D131590: Fixed page title for abseil-no-internal-dependencies check documentation

njames93 added a comment. In D131590#3713824 , @vladimir.plyashkun wrote: > In D131590#3713731 , @njames93 > wrote: > >> Can this be backported as well. > > I guess someone needs to do it, because i haven't got

[PATCH] D131423: [clang] fix frontend crash when evaluating type trait

aaron.ballman added a comment. In D131423#3714318 , @shafik wrote: > In D131423#3712083 , @inclyc wrote: > >> @aaron.ballman @shafik (Help wanted). These type traits will not cause >> clang to crash if current p

[PATCH] D131469: [Clang] change default storing path of `-ftime-trace`

dongjunduo updated this revision to Diff 451874. dongjunduo added a comment. format cc1_main.cpp Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131469/new/ https://reviews.llvm.org/D131469 Files: clang/lib/Driver/Driver.cpp clang/test/Driver/ch

[PATCH] D131685: [clang][AST] RecursiveASTVisitor should visit owned TagDecl of friend type.

balazske added reviewers: sammccall, martong, davrec. balazske added a comment. Herald added a subscriber: rnkovacs. I really do not know why parent of the node for the owned `TagDecl` node is the `FriendDecl` and not a `TypeLoc` node, but it is working. The code `struct A { friend struct Fr; };`

[PATCH] D131590: Fixed page title for abseil-no-internal-dependencies check documentation

vladimir.plyashkun added a comment. In D131590#3716317 , @njames93 wrote: > In D131590#3713824 , > @vladimir.plyashkun wrote: > >> In D131590#3713731 , @njames93 >> wrot

[PATCH] D131678: hicpp-signed-bitwise - Return location of the operand (and not of the operator beginning)

vladimir.plyashkun added inline comments. Comment at: clang-tools-extra/clang-tidy/hicpp/SignedBitwiseCheck.cpp:100 "%select{binary|unary}0 bitwise operator") - << IsUnary << SignedOperand->getSourceRange(); + << IsUnary << Location; } ---

[PATCH] D129231: [Builtins] Do not claim all libfuncs are readnone with trapping math.

scanon added a comment. >> Looking at implementations of these functions, it looks like GNU libm >> doesn't raise inexact, but the bionic libm does. I think I'm leaning towards >> marking all of them as "fng" as it's the more cautious of the two. > > Hmm, bionic's behavior sounds a bit surprisin

[PATCH] D129231: [Builtins] Do not claim all libfuncs are readnone with trapping math.

scanon added a comment. In any event, from the standpoint of the C(23) language, these operations do not set inexact, so I believe that it is appropriate to optimize them as if they do not set inexact. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/

[PATCH] D131469: [Clang] change default storing path of `-ftime-trace`

Whitney added inline comments. Comment at: clang/lib/Driver/Driver.cpp:4786 +const std::string::size_type size = arg.size(); +char *buffer = new char[size + 1]; +memcpy(buffer, arg.c_str(), size + 1); dongjunduo wrote: > Whitney wrote: > >

[PATCH] D131203: [HLSL] Initial codegen for SV_GroupIndex

python3kgae added inline comments. Comment at: clang/lib/CodeGen/CGHLSLRuntime.cpp:119 + auto *EntryTy = llvm::FunctionType::get(llvm::Type::getVoidTy(Ctx), false); + Function *EntryFn = + Function::Create(EntryTy, Function::ExternalLinkage, FD->getName(), &M); ---

[PATCH] D131639: [OpenMP] Remove 'stdbool.h' from OpenMP header wrappers

jhuber6 updated this revision to Diff 451875. jhuber6 added a comment. Changing bool usage to use `_Bool` if compiling for C so we don't need to include the extra header for this single declaration. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131

[PATCH] D131688: [clang][dataflow][NFC] Remove LatticeJoinEffect from framework interfaces

li.zhe.hua created this revision. li.zhe.hua added a reviewer: ymandel. Herald added subscribers: martong, xazax.hun. Herald added a reviewer: NoQ. Herald added a project: All. li.zhe.hua requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Thou

[PATCH] D131298: [clang-doc] Read docstrings for record members

brettw added inline comments. Comment at: clang-tools-extra/unittests/clang-doc/SerializeTest.cpp:166 + ExpectedE.Members.emplace_back("int", "value", AccessSpecifier::AS_public); + //ExpectedE.Members.back().Description.push_back(MakeOneLineCommentInfo(" Some docs")); Chec

[PATCH] D131691: [clang][dataflow] Remove references of LatticeJoinEffect from dataflow

li.zhe.hua created this revision. li.zhe.hua added a reviewer: ymandel. Herald added subscribers: martong, xazax.hun. Herald added a reviewer: NoQ. Herald added a project: All. li.zhe.hua requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. A fo

[PATCH] D131645: [clang][dataflow] Allow user-provided lattices to provide a widen operator

xazax.hun accepted this revision. xazax.hun added a comment. Very cool! Thanks for investing into fixing the soundness issues! A couple of ideas for the future (probably you are already aware of most of this, but open communication can help other members of the community to jump in): - Some fr

[PATCH] D131688: [clang][dataflow][NFC] Remove LatticeJoinEffect from framework interfaces

xazax.hun accepted this revision. xazax.hun added a comment. This revision is now accepted and ready to land. Herald added a subscriber: rnkovacs. Returning whether the lattice was changed can be a nice optimization when comparing lattice elements is expensive. On the other hand, it can be one mo

[PATCH] D131590: Fixed page title for abseil-no-internal-dependencies check documentation

njames93 added a comment. In D131590#3716358 , @vladimir.plyashkun wrote: > Sure it's up to you, it's my github > account , but i don't think it's linked to JetBrains... Which email address would you like me to us

[PATCH] D131298: [clang-doc] Read docstrings for record members

brettw updated this revision to Diff 451882. brettw marked 2 inline comments as done. brettw added a comment. New patch up with requested changes. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131298/new/ https://reviews.llvm.org/D131298 Files: clang-tools-extra/clang-doc/BitcodeRead

[PATCH] D131645: [clang][dataflow] Allow user-provided lattices to provide a widen operator

li.zhe.hua updated this revision to Diff 451887. li.zhe.hua marked an inline comment as done. li.zhe.hua added a comment. Add FIXME Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131645/new/ https://reviews.llvm.org/D131645 Files: clang/include/c

[PATCH] D131645: [clang][dataflow] Allow user-provided lattices to provide a widen operator

li.zhe.hua added a comment. In D131645#3716464 , @xazax.hun wrote: > probably you are already aware of most of this Actually, more likely than not I don't! I don't have a strong background in PL (or, really any background), so I'm really just learning a

[clang] dd4c838 - [OpenMP] Allow data members in interop init/use/destroy clauses

Author: Mike Rice Date: 2022-08-11T09:39:12-07:00 New Revision: dd4c838da30ad4b6d5dc0f700df0a6629469f719 URL: https://github.com/llvm/llvm-project/commit/dd4c838da30ad4b6d5dc0f700df0a6629469f719 DIFF: https://github.com/llvm/llvm-project/commit/dd4c838da30ad4b6d5dc0f700df0a6629469f719.diff LOG

[PATCH] D131222: [OpenMP] Allow data members in interop init/use/destroy clauses

This revision was automatically updated to reflect the committed changes. Closed by commit rGdd4c838da30a: [OpenMP] Allow data members in interop init/use/destroy clauses (authored by mikerice). Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Mo

[PATCH] D129231: [Builtins] Do not claim all libfuncs are readnone with trapping math.

fhahn added a comment. In D129231#3716363 , @scanon wrote: >>> Looking at implementations of these functions, it looks like GNU libm >>> doesn't raise inexact, but the bionic libm does. I think I'm leaning >>> towards marking all of them as "fng" as it'

[PATCH] D131307: [Clang] Allow downgrading to a warning the diagnostic for setting a non fixed enum to a value outside the range of the enumeration values

ayermolo added a comment. In D131307#3714629 , @shafik wrote: > In D131307#3713011 , @sberg wrote: > >> With this commit, >> >> $ cat test.cc >> #include "boost/numeric/conversion/cast.hpp" >> int main() { r

[PATCH] D131645: [clang][dataflow] Allow user-provided lattices to provide a widen operator

xazax.hun added a comment. In D131645#3716508 , @li.zhe.hua wrote: > In D131645#3716464 , @xazax.hun > wrote: > >> probably you are already aware of most of this > > Actually, more likely than not I don't! I don

[clang] dacbddf - [RISCV] Move isValidCPUName to RISCVTargetInfo. NFC

Author: Craig Topper Date: 2022-08-11T10:01:56-07:00 New Revision: dacbddf56205f90e33d39575fc9d8455458d851e URL: https://github.com/llvm/llvm-project/commit/dacbddf56205f90e33d39575fc9d8455458d851e DIFF: https://github.com/llvm/llvm-project/commit/dacbddf56205f90e33d39575fc9d8455458d851e.diff

[PATCH] D129160: libclang.so: Make SONAME the same as LLVM version

MaskRay added a comment. In D129160#3716016 , @isuruf wrote: > As a downstream packager of libclang, I really like the SONAME not changing > in libclang. It makes it possible for us to package things like qt that > depend on libclang, but not have to re

[PATCH] D131194: [C++20] Fix crash-on-valid with consteval temporary construction through list initialization

efriedma accepted this revision as: efriedma. efriedma added a comment. This revision is now accepted and ready to land. LGTM Comment at: clang/lib/CodeGen/CGExprConstant.cpp:1402 +RetType = CGM.getContext().getLValueReferenceType(RetType); + assert(!RetType.isNull() && "N

[clang-tools-extra] 99baa10 - [clang-doc] Read docstrings for record members

Author: Brett Wilson Date: 2022-08-11T17:14:15Z New Revision: 99baa10f8f01f5c054d259182b24ae04ae57101d URL: https://github.com/llvm/llvm-project/commit/99baa10f8f01f5c054d259182b24ae04ae57101d DIFF: https://github.com/llvm/llvm-project/commit/99baa10f8f01f5c054d259182b24ae04ae57101d.diff LOG:

[PATCH] D131298: [clang-doc] Read docstrings for record members

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG99baa10f8f01: [clang-doc] Read docstrings for record members (authored by brettw, committed by paulkirth). Repository: rG LLVM Github Monorepo CH

[PATCH] D131532: [Sema] Avoid isNullPointerConstant invocation

justinstitt updated this revision to Diff 451902. justinstitt edited the summary of this revision. justinstitt added a comment. add more descriptive names, add more detail to revision summary. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131532/new

[PATCH] D131696: [clangd] Fix an inlay-hint crash on a broken designator.

hokein created this revision. hokein added a reviewer: kadircet. Herald added subscribers: usaxena95, arphaman. Herald added a project: All. hokein requested review of this revision. Herald added subscribers: MaskRay, ilya-biryukov. Herald added a project: clang-tools-extra. Repository: rG LLVM

[PATCH] D131698: [Sema] Fix `ExtVectorElementExpr` tree transform for the `isArrow` case.

michele.scandale created this revision. michele.scandale added reviewers: rsmith, doug.gregor, rjmccall. Herald added a project: All. michele.scandale requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Make sure we propagate the value for `IsA

[PATCH] D131698: [Sema] Fix `ExtVectorElementExpr` tree transform for the `isArrow` case.

michele.scandale updated this revision to Diff 451911. michele.scandale added a comment. Clang-format fixes Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131698/new/ https://reviews.llvm.org/D131698 Files: clang/lib/Sema/TreeTransform.h clang/

[clang] b48fb85 - Fix crash-on-valid with consteval temporary construction through list initialization

Author: Aaron Ballman Date: 2022-08-11T13:44:24-04:00 New Revision: b48fb85fe60b339b31b0381dde481b284e0fb93e URL: https://github.com/llvm/llvm-project/commit/b48fb85fe60b339b31b0381dde481b284e0fb93e DIFF: https://github.com/llvm/llvm-project/commit/b48fb85fe60b339b31b0381dde481b284e0fb93e.diff

[PATCH] D131194: [C++20] Fix crash-on-valid with consteval temporary construction through list initialization

This revision was automatically updated to reflect the committed changes. Closed by commit rGb48fb85fe60b: Fix crash-on-valid with consteval temporary construction through list… (authored by aaron.ballman). Changed prior to commit: https://reviews.llvm.org/D131194?vs=450271&id=451913#toc Repos

[PATCH] D131194: [C++20] Fix crash-on-valid with consteval temporary construction through list initialization

aaron.ballman added inline comments. Comment at: clang/lib/CodeGen/CGExprConstant.cpp:1402 +RetType = CGM.getContext().getLValueReferenceType(RetType); + assert(!RetType.isNull() && "Not certain of the constant expression's type"); + efriedma wrote: > Not su

[PATCH] D131701: [CodeGen][ObjC] Call synthesized copy constructor/assignment operator functions in getter/setter functions of non-trivial C struct properties

ahatanak created this revision. ahatanak added a reviewer: rjmccall. ahatanak added a project: clang. Herald added a project: All. ahatanak requested review of this revision. This fixes a bug where the getter/setter functions were doing a trivial copy instead of calling the synthesized functions

[clang] d17de54 - [clang][RISCV][test] Add test that shows incorrect ABI lowering

Author: Alex Bradbury Date: 2022-08-11T18:51:37+01:00 New Revision: d17de5479c6234f9e37fb4deca9e537bf8d3932e URL: https://github.com/llvm/llvm-project/commit/d17de5479c6234f9e37fb4deca9e537bf8d3932e DIFF: https://github.com/llvm/llvm-project/commit/d17de5479c6234f9e37fb4deca9e537bf8d3932e.diff

[PATCH] D130033: [HLSL] Add resource binding attribute for HLSL.

python3kgae updated this revision to Diff 451917. python3kgae marked 14 inline comments as done. python3kgae added a comment. Remove optional flag for Slot. Update error messages and doc. Add test for empty resource attribute and space only resource attribute. Repository: rG LLVM Github Monore

[PATCH] D130033: [HLSL] Add resource binding attribute for HLSL.

python3kgae added inline comments. Comment at: clang/include/clang/Basic/Attr.td:4022 + let LangOpts = [HLSL]; + let Args = [StringArgument<"Slot", 1>, StringArgument<"Space", 1>]; + let Documentation = [HLSLResourceBindingDocs]; aaron.ballman wrote: > Do you

[PATCH] D131677: [clang][RISCV][WIP] Fix incorrect ABI lowering for inherited structs with hard-float ABIs

asb updated this revision to Diff 451915. asb added reviewers: kito-cheng, craig.topper, reames. asb added a comment. Herald added subscribers: frasercrmck, apazos, jocewei, PkmX, the_o, brucehoult, MartinMosbeck, edward-jones, zzheng, MaskRay, jrtc27, niosHD, sabuasal, johnrusso, rbar. Add test

[PATCH] D131701: [CodeGen][ObjC] Call synthesized copy constructor/assignment operator functions in getter/setter functions of non-trivial C struct properties

ahatanak added a comment. There is another bug where an object isn't destructed when a non-trivial C struct property is set. I plan to send a patch that fixes the bug after this. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131701/new/ https://re

[PATCH] D129160: libclang.so: Make SONAME the same as LLVM version

isuruf added a comment. Maybe this should be a cmake option that is off by default and I can turn it for my builds? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129160/new/ https://reviews.llvm.org/D129160 ___

[PATCH] D116203: [clang] adds unary type transformations as compiler built-ins

cjdb added a comment. Thanks for patiently reviewing! I'll do the libc++ stuff and a pilot run in some code. Hopefully can get it merged tomorrow :-) Comment at: clang/lib/Parse/ParseDeclCXX.cpp:1149-1150 + default: +assert(false && "passed in an unhandled type transforma

[PATCH] D131084: Add support for specifying the severity of a SARIF Result.

vaibhav.y marked an inline comment as not done. vaibhav.y added inline comments. Comment at: clang/include/clang/Basic/Sarif.h:157 +/// 1. https://docs.oasis-open.org/sarif/sarif/v2.1.0/os/sarif-v2.1.0-os.html#_Toc34317648";>level property +enum class SarifResultLevel { Note, Wa

[PATCH] D131704: [Clang] Tighten restrictions on enum out of range diagnostic

shafik created this revision. shafik added reviewers: erichkeane, aaron.ballman, thakis. Herald added a project: All. shafik requested review of this revision. In D131528 using `Info.EvalMode == EvalInfo::EM_ConstantExpression` is not strict enough to restrict t

[PATCH] D131528: [Clang] Restrict non fixed enum to a value outside the range of the enumeration values warning to context requiring a constant expression

shafik added a comment. In D131528#3715841 , @thakis wrote: > We're also still seeing the diag fire after this: > https://ci.chromium.org/p/chromium/builders/ci/ToTLinux > > (And we cleaned up our codebase back when it was still an error.) > > Our bots h

[PATCH] D131677: [clang][RISCV] Fix incorrect ABI lowering for inherited structs under hard-float ABIs

jrtc27 added inline comments. Comment at: clang/lib/CodeGen/TargetInfo.cpp:10986 +bool Ret = detectFPCCEligibleStructHelper( +B.getType(), CurOff, Field1Ty, Field1Off, Field2Ty, Field2Off); +if (!Ret) With multiple inheritance this off

[PATCH] D131677: [clang][RISCV] Fix incorrect ABI lowering for inherited structs under hard-float ABIs

craig.topper added a comment. Remove the WIP note from the end of the description? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131677/new/ https://reviews.llvm.org/D131677 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://list

[PATCH] D131646: [clang][dataflow] Restructure loops to call widen on back edges

xazax.hun added inline comments. Comment at: clang/lib/Analysis/FlowSensitive/TypeErasedDataflowAnalysis.cpp:168-169 +// back edge block. (That is, all paths from the entry block to the back edge +// block must go through `Block`.) It also means that there are only two +// prede

[PATCH] D131464: [test] Make tests pass regardless of gnu++14/gnu++17 default

MaskRay added a comment. Sorry, my previous main comment had been written before I introduced `LIT_CLANG_STD_GROUP` in `llvm/utils/lit/lit/llvm/config.py`. The multiple `%clang_cc1` approach actually looks like the following. Note the use of `%stdcxx_17-` to make the test future-proof. (It is no

[PATCH] D129160: libclang.so: Make SONAME the same as LLVM version

h-vetinari added a comment. In D129160#3716826 , @isuruf wrote: > Maybe this should be a cmake option that is off by default and I can turn it > for my builds? I proposed something along those lines in https://discourse.llvm.org/t/rationale-for-removin

[PATCH] D131646: [clang][dataflow] Restructure loops to call widen on back edges

li.zhe.hua updated this revision to Diff 451926. li.zhe.hua added a comment. Fix incorrect assumption that back edge blocks have an empty body. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131646/new/ https://reviews.llvm.org/D131646 Files: cla

[PATCH] D131677: [clang][RISCV] Fix incorrect ABI lowering for inherited structs under hard-float ABIs

jrtc27 added inline comments. Comment at: clang/lib/CodeGen/TargetInfo.cpp:10986 +bool Ret = detectFPCCEligibleStructHelper( +B.getType(), CurOff, Field1Ty, Field1Off, Field2Ty, Field2Off); +if (!Ret) jrtc27 wrote: > With multiple inhe

[PATCH] D131706: [clangd][unittests][IncludeCleaner] Don't call findReferencedFiles() if the result is not used

ArcsinX created this revision. ArcsinX added reviewers: kbobyrev, sammccall, kadircet. Herald added subscribers: usaxena95, arphaman. Herald added a project: All. ArcsinX requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang-

[PATCH] D131423: [clang] fix frontend crash when evaluating type trait

inclyc updated this revision to Diff 451931. inclyc added a comment. address comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131423/new/ https://reviews.llvm.org/D131423 Files: clang/include/clang/Basic/TypeTraits.h clang/include/clang/

[PATCH] D112374: [clang] Implement ElaboratedType sugaring for types written bare

alexfh added a comment. One more problem related to this patch: it changes the behavior of __PRETTY_FUNCTION__: https://gcc.godbolt.org/z/Mvnj9j74E. There may be dependencies upon the specific format of expansions of this macro: tests, log processing tools, libraries like ctti, and probably oth

[clang] adcd4b1 - [analyzer] [NFC] Fix comments into more regular form.

Author: Denys Petrov Date: 2022-08-11T21:28:23+03:00 New Revision: adcd4b1c0bd43c89e579bf07daff7ffb02848012 URL: https://github.com/llvm/llvm-project/commit/adcd4b1c0bd43c89e579bf07daff7ffb02848012 DIFF: https://github.com/llvm/llvm-project/commit/adcd4b1c0bd43c89e579bf07daff7ffb02848012.diff

[PATCH] D131423: [clang] fix frontend crash when evaluating type trait

inclyc updated this revision to Diff 451932. inclyc added a comment. rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131423/new/ https://reviews.llvm.org/D131423 Files: clang/include/clang/Basic/TypeTraits.h clang/include/clang/Sema/Sema.

[PATCH] D131677: [clang][RISCV] Fix incorrect ABI lowering for inherited structs under hard-float ABIs

craig.topper added inline comments. Comment at: clang/lib/CodeGen/TargetInfo.cpp:10986 +bool Ret = detectFPCCEligibleStructHelper( +B.getType(), CurOff, Field1Ty, Field1Off, Field2Ty, Field2Off); +if (!Ret) jrtc27 wrote: > jrtc27 wrote

[PATCH] D131423: [clang] fix frontend crash when evaluating type trait

inclyc added inline comments. Comment at: clang/lib/Parse/ParseExprCXX.cpp:3783 - if (Arity && Args.size() != Arity) { -Diag(EndLoc, diag::err_type_trait_arity) Before this patch, we check the `Arity` here, so using type traits with unexpected number of a

[PATCH] D131590: Fixed page title for abseil-no-internal-dependencies check documentation

vladimir.plyashkun added a comment. In D131590#3716471 , @njames93 wrote: > In D131590#3716358 , > @vladimir.plyashkun wrote: > >> Sure it's up to you, it's my github >> ac

[PATCH] D131677: [clang][RISCV] Fix incorrect ABI lowering for inherited structs under hard-float ABIs

jrtc27 added inline comments. Comment at: clang/lib/CodeGen/TargetInfo.cpp:10986 +bool Ret = detectFPCCEligibleStructHelper( +B.getType(), CurOff, Field1Ty, Field1Off, Field2Ty, Field2Off); +if (!Ret) craig.topper wrote: > jrtc27 wrote

[PATCH] D131707: [analyzer]{NFC} Cache the result of getLocationType in TypedValueRegion

ASDenysPetrov created this revision. ASDenysPetrov added reviewers: steakhal, martong, NoQ, xazax.hun, isuckatcs. ASDenysPetrov added a project: clang. Herald added subscribers: manas, dkrupp, donat.nagy, Szelethus, mikhail.ramalho, a.sidorin, rnkovacs, szepet, baloghadamsoftware. Herald added a p

[PATCH] D112374: [clang] Implement ElaboratedType sugaring for types written bare

mizvekov marked an inline comment as done. mizvekov added a comment. In D112374#3716944 , @alexfh wrote: > One more problem related to this patch: it changes the behavior of > __PRETTY_FUNCTION__: https://gcc.godbolt.org/z/Mvnj9j74E. There may be > depe

[PATCH] D129608: [Clang][OpenMP] Fix segmentation fault when data field is used in is_device_pt.

jyu2 updated this revision to Diff 451939. jyu2 added a comment. Thanks Alexey! Address the comment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129608/new/ https://reviews.llvm.org/D129608 Files: clang/lib/CodeGen/CGOpenMPRuntime.cpp clang

[PATCH] D129608: [Clang][OpenMP] Fix segmentation fault when data field is used in is_device_pt.

jyu2 added inline comments. Comment at: clang/lib/CodeGen/CGOpenMPRuntime.cpp:9073 SmallVector DeclComponentLists; +if (DevPointersMap.count(VD)) { + // For member fields list in is_device_ptr, store it in ABataev wrote: > If VD is nullptr, why do w

[PATCH] D131708: [RISCV] Change how mtune aliases are implemented.

craig.topper created this revision. craig.topper added reviewers: jrtc27, asb, luismarques, kito-cheng. Herald added subscribers: sunshaoce, VincentWu, luke957, jeroen.dobbelaere, StephenFan, vkmr, frasercrmck, evandro, apazos, sameer.abuasal, s.egerton, Jim, benna, psnobl, jocewei, PkmX, the_o,

<    1   2   3   >