joeywatts added a comment. In D131623#3716227 <https://reviews.llvm.org/D131623#3716227>, @njames93 wrote:
> Just a general drive by comment here and doesn't affect this patch. > This specifying containers logic is a little verbose, There may be a case to > deprecate most of these options and just detect containers with an equivalent > emplace* method at runtime. I thought the same thing, but wasn't sure what the stance is on breaking changes here: would it be a problem if the existing "ContainersWithPush" option were removed in favor of a more generic option for a list of containers? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131623/new/ https://reviews.llvm.org/D131623 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
