python3kgae added inline comments.
================ Comment at: clang/lib/CodeGen/CGHLSLRuntime.cpp:119 + auto *EntryTy = llvm::FunctionType::get(llvm::Type::getVoidTy(Ctx), false); + Function *EntryFn = + Function::Create(EntryTy, Function::ExternalLinkage, FD->getName(), &M); ---------------- beanz wrote: > python3kgae wrote: > > Need to move all attributes from Fn to EntryFn. > > And make Fn a normal function. > Yes on the function attributes. > > What do you mean by "normal function" as written it is an external linkage > function, which matches what we expect in DXIL. By "normal function" I mean remove the special attribute like HLSLEntry, numofthreads. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131203/new/ https://reviews.llvm.org/D131203 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
