li.zhe.hua marked an inline comment as done.
li.zhe.hua added inline comments.


================
Comment at: 
clang/unittests/Analysis/FlowSensitive/TypeErasedDataflowAnalysisTest.cpp:119
+  std::unique_ptr<ASTUnit> AST =
+      tooling::buildASTFromCodeWithArgs("int x = 0;", {"-std=c++11"});
+  HasWidenAnalysis Analysis(AST->getASTContext(),
----------------
ymandel wrote:
> nit: why c++11 (vs something later)?
Consistency with `runAnalysis` defined above. FWIW, I don't think `int x = 0;` 
is materially different in any standard, and all I really want out of this is 
an `ASTContext` to pass to `TypeErasedDataflowAnalysis` to satisfy its 
constructor.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D131645/new/

https://reviews.llvm.org/D131645

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to