[PATCH] D128833: [clang][dataflow] Handle `for` statements without conditions

This revision was automatically updated to reflect the committed changes. Closed by commit rG8207c2a66030: [clang][dataflow] Handle `for` statements without conditions (authored by sgatev). Herald added a reviewer: NoQ. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://re

[clang] 8207c2a - [clang][dataflow] Handle `for` statements without conditions

Author: Stanislav Gatev Date: 2022-06-30T07:00:35Z New Revision: 8207c2a660303272ad8ecb1807407f029466ff49 URL: https://github.com/llvm/llvm-project/commit/8207c2a660303272ad8ecb1807407f029466ff49 DIFF: https://github.com/llvm/llvm-project/commit/8207c2a660303272ad8ecb1807407f029466ff49.diff LO

[PATCH] D128704: [clang-extdef-mapping] Directly process .ast files

thieta updated this revision to Diff 441279. thieta added a comment. Clean-ups and error handling. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128704/new/ https://reviews.llvm.org/D128704 Files: clang/test/Analysis/func-mapping-test.cpp clan

[PATCH] D124750: [MLIR] Add a utility to sort the operands of commutative ops

Mogball added a comment. I'm glad the `DenseSet`s are gone, but my three-ish biggest gripes are: - The algorithm is conceptually simple, but there is way more code than is necessary to achieve it. - More comments (excluding "doc" comments) than code is generally not a good sign - The implementa

[PATCH] D124750: [MLIR] Add a utility to sort the operands of commutative ops

Mogball added inline comments. Comment at: mlir/lib/Transforms/Utils/CommutativityUtils.cpp:523 + shiftTheSmallestUnsortedOperandsToTheSmallestUnsortedPositions( + bfsOfOperands, smallestUnsortedPosition); + And then you'll never need to check `isSo

[PATCH] D124750: [MLIR] Add a utility to sort the operands of commutative ops

srishti-pm marked 4 inline comments as done. srishti-pm added inline comments. Comment at: mlir/lib/Transforms/Utils/CommutativityUtils.cpp:76 + // `CONSTANT_OP` and `opName` remains "". + type = CONSTANT_OP; +} Mogball wrote: > Constant ops could b

[PATCH] D128887: [clang][transformer] Fix crash on replacement-less ASTEdit.

courbet created this revision. courbet added a reviewer: ymandel. Herald added a project: All. courbet requested review of this revision. Herald added projects: clang, clang-tools-extra. Given that we provide an EditGenerator edit(ASTEdit), we can't ever be sure that the user won't give us an empt

[PATCH] D128807: [clang][transformer] Finish plumbing `Note` all the way to the output.

courbet added inline comments. Comment at: clang/lib/Tooling/Transformer/RewriteRule.cpp:56 T.Range = *EditRange; -T.Replacement = std::move(*Replacement); -T.Metadata = std::move(*Metadata); +if (E.Replacement) { + auto Replacement = E.Replacement->eval(Res

[clang] f595003 - [NFC] [Modules] Add test for inherit default arguments

Author: Chuanqi Xu Date: 2022-06-30T15:48:22+08:00 New Revision: f595003e8e86bcb9531c2439f6a3771e669a3f3e URL: https://github.com/llvm/llvm-project/commit/f595003e8e86bcb9531c2439f6a3771e669a3f3e DIFF: https://github.com/llvm/llvm-project/commit/f595003e8e86bcb9531c2439f6a3771e669a3f3e.diff LO

[PATCH] D127189: [clang][AIX] Add option to control quadword lock free atomics ABI on AIX

lkail updated this revision to Diff 441293. lkail added a comment. Option name changed to `-mabi=quadword-atomics` as nemanja suggested. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127189/new/ https://reviews.llvm.org/D127189 Files: clang/incl

[PATCH] D126956: [tbaa] Handle base classes in struct tbaa

brunodf updated this revision to Diff 441294. brunodf added a comment. Adding comment regarding empty subobjects. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126956/new/ https://reviews.llvm.org/D126956 Files: clang/lib/CodeGen/CodeGenTBAA.cpp

[PATCH] D128402: [clang-tidy] Don't treat invalid branches as identical

njames93 added a comment. In D128402#3621002 , @ishaangandhi wrote: > Once you see it, can you either confirm `-fix-errors` was correct originally, > or instruct me on how to fix this test failure? `-expect-clang-tidy-error` is the technically correct

[PATCH] D125788: [flang][driver] Rename `flang-new` as `flang`

clementval added a comment. Overall the patch looks ok from a technical point. Shouldn't we just wait until we can make the permanent renaming so we do not add unnecessary cmake option? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125788/new/ htt

[PATCH] D128892: [clangd] Also mark output arguments of array subscript expressions

ckandeler created this revision. Herald added subscribers: usaxena95, kadircet, arphaman. Herald added a project: All. ckandeler requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang-tools-extra. ... with the "usedAsMutableR

[PATCH] D128783: [test] Check for more -fsanitize=array-bounds regressions

sberg updated this revision to Diff 441313. sberg added a comment. Updated the prospective git commit message as follow: [test] Check for more -fsanitize=array-bounds behavior ...that had temporarily regressed with (since reverted)

[PATCH] D128625: [RISCV][Driver] Fix baremetal `GCCInstallation` paths

anton-afanasyev added a comment. In D128625#3621030 , @MaskRay wrote: > The description seems unclear to me. Is a `riscv64-unknown-linux-gnu` GCC > installation selected while the requested target triple is > `riscv64-unknown-elf`? Yes, exactly (see pr

[clang] abeeae5 - [X86] Support `_Float16` on SSE2 and up

Author: Phoebe Wang Date: 2022-06-30T17:21:37+08:00 New Revision: abeeae570efff38dceccf68f5352809c58ffdda2 URL: https://github.com/llvm/llvm-project/commit/abeeae570efff38dceccf68f5352809c58ffdda2 DIFF: https://github.com/llvm/llvm-project/commit/abeeae570efff38dceccf68f5352809c58ffdda2.diff L

[PATCH] D128571: [X86] Support `_Float16` on SSE2 and up

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGabeeae570eff: [X86] Support `_Float16` on SSE2 and up (authored by pengfei). Changed prior to commit: https://reviews.llvm.org/D128571?vs=441272&i

[PATCH] D125788: [flang][driver] Rename `flang-new` as `flang`

awarzynski added a comment. Thank your for reviewing @clementval ! In D125788#3621585 , @clementval wrote: > Shouldn't we just wait until we can make the permanent renaming so we do not > add unnecessary cmake option? This was discussed in one of our

[PATCH] D111617: [RISCV] Lazily add RVV C intrinsics.

kito-cheng updated this revision to Diff 441320. kito-cheng added a comment. Changes: - Rebase - Address @khchen's comment Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111617/new/ https://reviews.llvm.org/D111617 Files: clang/include/clang/Bas

[PATCH] D125788: [flang][driver] Rename `flang-new` as `flang`

clementval requested changes to this revision. clementval added inline comments. This revision now requires changes to proceed. Comment at: clang/lib/Driver/ToolChain.cpp:185 {"flang", "--driver-mode=flang"}, + {"flang-new", "--driver-mode=flang"}, {"clang-dxc"

[PATCH] D113107: Support of expression granularity for _Float16.

pengfei added a comment. > Am I understanding correctly? @pengfei you are interested in the > -fexcess-precision=16 part of this right? @rjmccall what do yo think? I agree with @rjmccall , we just need to disable what we do here for `-fexcess-precision=16`. CHANGES SINCE LAST ACTION https:/

[clang] 1d421e6 - [OpenCL] Remove half scalar vload/vstore builtins

Author: Sven van Haastregt Date: 2022-06-30T11:01:19+01:00 New Revision: 1d421e6e3b789ede2f61756a72e2b27456f868e3 URL: https://github.com/llvm/llvm-project/commit/1d421e6e3b789ede2f61756a72e2b27456f868e3 DIFF: https://github.com/llvm/llvm-project/commit/1d421e6e3b789ede2f61756a72e2b27456f868e3.

[PATCH] D128434: [OpenCL] Remove half scalar vload/vstore builtins

This revision was automatically updated to reflect the committed changes. Closed by commit rG1d421e6e3b78: [OpenCL] Remove half scalar vload/vstore builtins (authored by svenvh). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128434/new/ https://revi

[PATCH] D128625: [RISCV][Driver] Fix baremetal `GCCInstallation` paths

arichardson added inline comments. Comment at: clang/lib/Driver/ToolChains/RISCVToolchain.cpp:54 + + // Set alias for "riscv{64|32}-unknown-unknown-elf" + SmallVector TripleAliases; This seems like the wrong place to add this workaround, shouldn't the change be

[PATCH] D125788: [flang][driver] Rename `flang-new` as `flang`

richard.barton.arm added inline comments. Comment at: clang/lib/Driver/ToolChain.cpp:185 {"flang", "--driver-mode=flang"}, + {"flang-new", "--driver-mode=flang"}, {"clang-dxc", "--driver-mode=dxc"}, clementval wrote: > This is counter intuitive

[PATCH] D125788: [flang][driver] Rename `flang-new` as `flang`

awarzynski added inline comments. Comment at: clang/lib/Driver/ToolChain.cpp:185 {"flang", "--driver-mode=flang"}, + {"flang-new", "--driver-mode=flang"}, {"clang-dxc", "--driver-mode=dxc"}, richard.barton.arm wrote: > clementval wrote: > > Thi

[PATCH] D128550: [OpenMP] Change OpenMP code generation for target region entries

ABataev accepted this revision. ABataev added a comment. This revision is now accepted and ready to land. LG Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128550/new/ https://reviews.llvm.org/D128550 ___

[PATCH] D128248: [clang] Avoid an assertion in APValue::hasArrayFiller()

tbaeder updated this revision to Diff 441344. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128248/new/ https://reviews.llvm.org/D128248 Files: clang/lib/AST/ExprConstant.cpp clang/test/SemaCXX/constexpr-array-init.cpp Index: clang/test/SemaCXX/constexpr-array-init.cpp

[PATCH] D128248: [clang] Avoid an assertion in APValue::hasArrayFiller()

tbaeder added a comment. I added the `isArray()` check in both places now, but the first one is not necessary for the test case (at least). CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128248/new/ https://reviews.llvm.org/D128248 ___ cfe-co

[PATCH] D127803: Generate the capture for field when the field is used in openmp region with implicit default in the member function.

ABataev added inline comments. Comment at: clang/lib/Sema/SemaOpenMP.cpp:199 UsesAllocatorsDecls; +/// Data is needed on creating capture fields for implicit +/// defualt first|private clause. Data required? Comment at: clang/l

[PATCH] D128379: [clangd] Change the url for clang-tidy check documentation

njames93 updated this revision to Diff 441351. njames93 added a comment. Herald added subscribers: ormris, mgorny. Emit documentation links for the version of clangd built. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128379/new/ https://reviews.l

[PATCH] D128379: [clangd] Change the url for clang-tidy check documentation

njames93 updated this revision to Diff 441352. njames93 added a comment. Fix lit cfg typo Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128379/new/ https://reviews.llvm.org/D128379 Files: clang-tools-extra/clangd/CMakeLists.txt clang-tools-ext

[PATCH] D128379: [clangd] Change the url for clang-tidy check documentation

njames93 requested review of this revision. njames93 added a comment. Any issues with this now for getting correct version? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128379/new/ https://reviews.llvm.org/D128379

[PATCH] D127313: [libc++] Implement P0618R0 (Deprecating )

philnik updated this revision to Diff 441353. philnik added a comment. - Try to fix CI Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127313/new/ https://reviews.llvm.org/D127313 Files: libcxx/docs/ReleaseNotes.rst libcxx/docs/Status/Cxx17Paper

[PATCH] D128855: [HLSL] Change WaveActiveCountBits to wrapper of __builtin_hlsl_wave_active_count_bits

python3kgae updated this revision to Diff 441358. python3kgae added a comment. Rebase to fix test fail. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128855/new/ https://reviews.llvm.org/D128855 Files: clang/include/clang/Basic/Builtins.def cl

[PATCH] D95588: [RISCV] Implement the MC layer support of P extension

sunshaoce added a comment. Hello @Jim! We are developing the P extension, are you still maintaining this patch? Or would you mind co-development together? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95588/new/ https://reviews.llvm.org/D95588 __

[PATCH] D128774: [libTooling] Add a comment about comment parsing to getAssociatedRange.

ymandel added a comment. sure Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128774/new/ https://reviews.llvm.org/D128774 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi

[PATCH] D128248: [clang] Avoid an assertion in APValue::hasArrayFiller()

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. Basically LGTM -- can you also add a release note about the assertion fix? Comment at: clang/test/SemaCXX/constexpr-array-init.cpp:1 + +// RUN: %clang_cc1 -std=

[PATCH] D127807: [clang-tidy] Properly forward clang-tidy output when running tests

aaron.ballman added a comment. FWIW, I'm also a tentative LG on these changes. I'm not certain if there's a reason why we did things this way in the first place, but I think the new output is more readable. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm

[PATCH] D128379: [clangd] Change the url for clang-tidy check documentation

sammccall added a comment. Hmm, this version looks complicated to me. And also fragile: downstream we have CLANG_VERSION_STRINGs that don't match upstream, Apple has their own versioning scheme, linux distros tend to do things like `6.0.1~ubuntu3`... Let me sync with @kadircet Repository: rG

[clang] 0079343 - [libTooling][NFC] Add a comment about comment parsing to getAssociatedRange.

Author: Aaron Jacobs Date: 2022-06-30T12:46:57Z New Revision: 007934343c4c18102b2b3e4195d356dbcdf9a3fc URL: https://github.com/llvm/llvm-project/commit/007934343c4c18102b2b3e4195d356dbcdf9a3fc DIFF: https://github.com/llvm/llvm-project/commit/007934343c4c18102b2b3e4195d356dbcdf9a3fc.diff LOG:

[PATCH] D128774: [libTooling] Add a comment about comment parsing to getAssociatedRange.

This revision was automatically updated to reflect the committed changes. Closed by commit rG007934343c4c: [libTooling][NFC] Add a comment about comment parsing to getAssociatedRange. (authored by jacobsa, committed by ymandel). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION h

[PATCH] D128048: Add a new clang option "-ftime-trace-path"

dongjunduo updated this revision to Diff 441368. dongjunduo added a comment. [Clang] change "-ftime-trace-path" to "-ftime-trace" Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128048/new/ https://reviews.llvm.org/D128048 Files: clang/include/cla

[PATCH] D128907: [Clang] Disable noundef attribute for languages which allow uninitialized function arguments

skc7 created this revision. skc7 added reviewers: arsenm, sameerds, cdevadas, ronlieb, yaxunl, b-sumner, bcahoon. Herald added subscribers: kosarev, mattd, asavonic, ThomasRaoux, jdoerfert, kerbowa, kbarton, jvesely, nemanjai. Herald added a project: All. skc7 requested review of this revision. H

[PATCH] D128700: [AMDGPU][Clang] Skip adding noundef attribute to AMDGPU HIP device functions

skc7 added inline comments. Comment at: clang/lib/CodeGen/CGCall.cpp:2309 + bool EnableNoundefAttrs = CodeGenOpts.EnableNoundefAttrs && +!(getLangOpts().HIP && getLangOpts().CUDAIsDevice); + arsenm wrote: > Shouldn't be limited to HIP

[PATCH] D128048: Add a new clang option "-ftime-trace-path"

dongjunduo added a comment. Hi @jamieschmeiser @Whitney @MaskRay, I have changed "-ftime-trace-path" to "-ftime-trace". It is a well-spelling option name. The user can turn on the time-trace by: - specifying "**-ftime-trace**" only and output it to the default directory (the same as the "-o" o

[PATCH] D128652: [PowerPC] Finished kill_canary implementation and debugging

pscoro updated this revision to Diff 441374. pscoro added a comment. fixed XOR usage, added linux tests and other small fixes Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128652/new/ https://reviews.llvm.org/D128652 Files: clang/include/clang/B

[clang] cde1df4 - Correct -Winfinite-recursion warning on potentially-unevaluated operand

Author: Prathit Aswar Date: 2022-06-30T09:09:28-04:00 New Revision: cde1df4ca4f233f1069041ed1646779e9ff1ad7d URL: https://github.com/llvm/llvm-project/commit/cde1df4ca4f233f1069041ed1646779e9ff1ad7d DIFF: https://github.com/llvm/llvm-project/commit/cde1df4ca4f233f1069041ed1646779e9ff1ad7d.diff

[PATCH] D128747: ISSUE - incorrect -Winfinite-recursion warning on potentially-unevaluated operand #21668

This revision was automatically updated to reflect the committed changes. Closed by commit rGcde1df4ca4f2: Correct -Winfinite-recursion warning on potentially-unevaluated operand (authored by appmonster007, committed by aaron.ballman). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST AC

[PATCH] D128064: [Static Analyzer] Small array binding policy

Szelethus added a comment. Herald added a subscriber: steakhal. No need for post commit fixes, just general observations since I noticed them. Comment at: clang/lib/StaticAnalyzer/Core/RegionStore.cpp:2427 + uint64_t ArrSize = CAT->getSize().getLimitedValue(); + if (ArrSize >

[PATCH] D126907: Deferred Concept Instantiation Implementation Take 2

erichkeane added inline comments. Comment at: clang/include/clang/AST/Decl.h:1944-1948 + /// For non-templates this value will be NULL, unless this non-template + /// function declaration was declared directly inside of a function template, + /// in which case this will have a

[clang] a591c7c - [HLSL] Change WaveActiveCountBits to wrapper of __builtin_hlsl_wave_active_count_bits

Author: Xiang Li Date: 2022-06-30T06:16:51-07:00 New Revision: a591c7ca0d9fe47223127ee13df60689f36ba112 URL: https://github.com/llvm/llvm-project/commit/a591c7ca0d9fe47223127ee13df60689f36ba112 DIFF: https://github.com/llvm/llvm-project/commit/a591c7ca0d9fe47223127ee13df60689f36ba112.diff LOG:

[PATCH] D128855: [HLSL] Change WaveActiveCountBits to wrapper of __builtin_hlsl_wave_active_count_bits

This revision was automatically updated to reflect the committed changes. Closed by commit rGa591c7ca0d9f: [HLSL] Change WaveActiveCountBits to wrapper of… (authored by python3kgae). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128855/new/ https://

[PATCH] D128844: Improve the formatting of static_assert messages

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. I agree with the changes in principle, but it looks like the libc++ precommit CI builder is failing with a bunch of failures... but those failures look like the precommit CI isn'

[PATCH] D128103: Adds AST Matcher for ObjCStringLiteral

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM! Do you need me to commit on your behalf? If so, what name and email address would you like me to use for patch attribution? CHANGES SINCE LAST ACTION https://reviews.llv

[PATCH] D128625: [RISCV][Driver] Fix baremetal `GCCInstallation` paths

anton-afanasyev marked an inline comment as done. anton-afanasyev added inline comments. Comment at: clang/lib/Driver/ToolChains/RISCVToolchain.cpp:54 + + // Set alias for "riscv{64|32}-unknown-unknown-elf" + SmallVector TripleAliases; arichardson wrote: > This

[PATCH] D128652: [PowerPC] Finished kill_canary implementation and debugging

lkail added a comment. Summary should be updated as @nemanjai has said. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128652/new/ https://reviews.llvm.org/D128652 ___ cfe-commits mailing list cfe-commits

[PATCH] D128844: Improve the formatting of static_assert messages

philnik requested changes to this revision. philnik added a comment. This revision now requires changes to proceed. Sorry I missed that. You have to changes the libc++ tests to regex checks to allow both error-styles. This can then be removed once we drop support for LLVM 14 (so after the releas

[PATCH] D128048: Add a new clang option "-ftime-trace-path"

Whitney added inline comments. Comment at: clang/test/Driver/check-time-trace.cpp:9 +// RUN: | FileCheck %s +// RUN: %clangxx -S -ftime-trace=%T -ftime-trace-granularity=0 -o %T/check-time-trace %s +// RUN: cat %T/check-time-trace.json \ By default, the JSON f

[PATCH] D128248: [clang] Avoid an assertion in APValue::hasArrayFiller()

tbaeder updated this revision to Diff 441379. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128248/new/ https://reviews.llvm.org/D128248 Files: clang/docs/ReleaseNotes.rst clang/lib/AST/ExprConstant.cpp clang/test/SemaCXX/constexpr-array-init.cpp Index: clang/test/SemaCXX/constex

[clang] 2f20743 - Deferred Concept Instantiation Implementation

Author: Erich Keane Date: 2022-06-30T06:47:11-07:00 New Revision: 2f207439521d62d9551b2884158368e8b34084e5 URL: https://github.com/llvm/llvm-project/commit/2f207439521d62d9551b2884158368e8b34084e5 DIFF: https://github.com/llvm/llvm-project/commit/2f207439521d62d9551b2884158368e8b34084e5.diff L

[PATCH] D126907: Deferred Concept Instantiation Implementation Take 2

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG2f207439521d: Deferred Concept Instantiation Implementation (authored by erichkeane). Herald added a project: clang. Repository: rG LLVM Github Mo

[PATCH] D125788: [flang][driver] Rename `flang-new` as `flang`

clementval added inline comments. Comment at: clang/lib/Driver/ToolChain.cpp:185 {"flang", "--driver-mode=flang"}, + {"flang-new", "--driver-mode=flang"}, {"clang-dxc", "--driver-mode=dxc"}, awarzynski wrote: > richard.barton.arm wrote: > > cle

[PATCH] D125788: [flang][driver] Rename `flang-new` as `flang`

clementval added a comment. In D125788#3621744 , @awarzynski wrote: > We discussed this in our call on Monday and agreed to go ahead provided that > this change is technically sound. IIUC, this has now been confirmed: > >> Overall the patch looks ok fro

[PATCH] D128379: [clangd] Change the url for clang-tidy check documentation

sammccall added a comment. In D128379#3622128 , @sammccall wrote: > Hmm, this version looks complicated to me. > And also fragile: downstream we have CLANG_VERSION_STRINGs that don't match > upstream, Apple has their own versioning scheme, linux distros

[PATCH] D128907: [Clang] Disable noundef attribute for languages which allow uninitialized function arguments

arsenm added inline comments. Comment at: clang/include/clang/Basic/LangOptions.h:534 + bool allowUninitializedFunctionsArgs() const { +return ConvergentFunctions; + } Should add a comment explaining it here Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D121141: [Clang] Add `-funstable` flag to enable unstable and experimental features: follow-up fixes

ldionne commandeered this revision. ldionne edited reviewers, added: egorzhdan; removed: ldionne. ldionne added a comment. Herald added a subscriber: MaskRay. Thanks a lot for the fixes @egorzhdan! I think this looks pretty good. Since LLVM 15 is coming up and we'd like to have this in its final

[PATCH] D128652: [PowerPC] Finished kill_canary implementation and debugging

shchenz added a comment. Please make sure the patch is able to compile first. I fixed two build failures, it still fails : ( Comment at: llvm/include/llvm/IR/IntrinsicsPowerPC.td:221 + def int_ppc_kill_canary + : GCCBuiltin<"__builtin_ppc_kill_canary">, +Intrins

[PATCH] D128914: [HIP] Add support for handling HIP in the linker wrapper

jhuber6 created this revision. jhuber6 added reviewers: jdoerfert, JonChesterfield, yaxunl, tra. Herald added a project: All. jhuber6 requested review of this revision. Herald added subscribers: cfe-commits, sstefan1. Herald added a project: clang. This patch adds the necessary changes required to

[PATCH] D124750: [MLIR] Add a utility to sort the operands of commutative ops

Mogball added inline comments. Comment at: mlir/lib/Transforms/Utils/CommutativityUtils.cpp:76 + // `CONSTANT_OP` and `opName` remains "". + type = CONSTANT_OP; +} srishti-pm wrote: > Mogball wrote: > > Constant ops could be sorted by name as well.

[PATCH] D127313: [libc++] Implement P0618R0 (Deprecating )

This revision was automatically updated to reflect the committed changes. Closed by commit rG3ee9a50a146c: [libc++] Implement P0618R0 (Deprecating ) (authored by philnik). Changed prior to commit: https://reviews.llvm.org/D127313?vs=441353&id=441398#toc Repository: rG LLVM Github Mo

[clang-tools-extra] 8b04c33 - [pseudo] Forest dump ascii art isn't broken by large indices

Author: Sam McCall Date: 2022-06-30T16:53:51+02:00 New Revision: 8b04c331b51811fc6ddcfc8207b1ccdcea02108e URL: https://github.com/llvm/llvm-project/commit/8b04c331b51811fc6ddcfc8207b1ccdcea02108e DIFF: https://github.com/llvm/llvm-project/commit/8b04c331b51811fc6ddcfc8207b1ccdcea02108e.diff LO

[PATCH] D124750: [MLIR] Add a utility to sort the operands of commutative ops

srishti-pm marked 4 inline comments as done. srishti-pm added inline comments. Comment at: mlir/lib/Transforms/Utils/CommutativityUtils.cpp:329-353 + assert(frontPosition >= 0 && frontPosition < bfsOfOperands.size() && + "`frontPosition` should be valid"); + unsigned po

[PATCH] D128921: [Sema] Merge C++20 concept definitions from different modules in same TU

ilya-biryukov created this revision. ilya-biryukov added a reviewer: erichkeane. Herald added a project: All. ilya-biryukov requested review of this revision. Herald added a project: clang. Currently the C++20 concepts are only merged in `ASTReader`, i.e. when coming from different TU. This can ca

[PATCH] D128612: RISC-V big-endian support implementation

gbenyei marked 3 inline comments as done. gbenyei added inline comments. Comment at: llvm/lib/ExecutionEngine/JITLink/ELF_riscv.cpp:554 .buildGraph(); - } else { -assert((*ELFObj)->getArch() == Triple::riscv32 && - "Invalid triple for RISCV ELF object file

[PATCH] D128907: [Clang] Disable noundef attribute for languages which allow uninitialized function arguments

skc7 updated this revision to Diff 441409. skc7 added a comment. Add description for allowUninitializedFunctionsArgs Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128907/new/ https://reviews.llvm.org/D128907 Files: clang/include/clang/Basic/Lang

[PATCH] D128921: [Sema] Merge C++20 concept definitions from different modules in same TU

erichkeane added subscribers: ChuanqiXu, iains. erichkeane added a comment. I don't see anything to be concerned about here, but I'd like a modules person to take a look. @ChuanqiXu any chance you can confirm here? (or @iains ?) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D124750: [MLIR] Add a utility to sort the operands of commutative ops

Mogball added inline comments. Comment at: mlir/lib/Transforms/Utils/CommutativityUtils.cpp:329-353 + assert(frontPosition >= 0 && frontPosition < bfsOfOperands.size() && + "`frontPosition` should be valid"); + unsigned positionOfOperandToShift; + bool foundOperandToSh

[PATCH] D128921: [Sema] Merge C++20 concept definitions from different modules in same TU

erichkeane added a comment. I don't see anything to be concerned about here, but I'd like a modules person to take a look. @ChuanqiXu any chance you can confirm here? (or @iains ?) Also, would like to see a release note on this too! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST AC

[PATCH] D128612: RISC-V big-endian support implementation

gbenyei updated this revision to Diff 441410. gbenyei added a comment. Removed LLD and JIT related parts - JIT is out of my scope, and LLD will be in an additional patch. Fixed additional remarks. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D12861

[PATCH] D128921: [Sema] Merge C++20 concept definitions from different modules in same TU

ilya-biryukov added a comment. @erichkeane please let me know if you're the right person to review this. Comment at: clang/lib/Sema/SemaTemplate.cpp:8674 auto *Old = Previous.getRepresentativeDecl(); Diag(NameLoc, isa(Old) ? diag::err_redefinition : diag::er

[PATCH] D128379: [clangd] Change the url for clang-tidy check documentation

njames93 added a comment. In D128379#3622286 , @sammccall wrote: > In D128379#3622128 , @sammccall > wrote: > >> Hmm, this version looks complicated to me. >> And also fragile: downstream we have CLANG_VERSION_ST

[PATCH] D124750: [MLIR] Add a utility to sort the operands of commutative ops

mehdi_amini added a comment. For this to be a usable canonicalization, it is really the case where the operands are already sorted (no-op) that needs to be heavily optimized (that is no complex data structure to populate, etc.) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D128923: [LinkerWrapper] Add AMDGPU specific options to the LLD invocation

jhuber6 created this revision. jhuber6 added reviewers: arsenm, JonChesterfield, saiislam, yaxunl. Herald added subscribers: kosarev, t-tye, tpr, dstuttard, kzhuravl. Herald added a project: All. jhuber6 requested review of this revision. Herald added subscribers: cfe-commits, wdng. Herald added a

[PATCH] D111617: [RISCV] Lazily add RVV C intrinsics.

khchen accepted this revision. khchen added a comment. This revision is now accepted and ready to land. LGTM. Other than that last comments. Comment at: clang/utils/TableGen/RISCVVEmitter.cpp:77 + // Create compressed hsignature table from SemaRecords. + void init(const std::

[PATCH] D128924: [clang][dataflow] Replace TEST_F with TEST where possible

samestep created this revision. Herald added subscribers: martong, tschuett, xazax.hun. Herald added a project: All. samestep requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D1

[PATCH] D111617: [RISCV] Lazily add RVV C intrinsics.

khchen added a comment. @craig.topper @rogfer01 - do you have other comments? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111617/new/ https://reviews.llvm.org/D111617 ___ cfe-commits mailing list cfe-c

[PATCH] D128924: [clang][dataflow] Replace TEST_F with TEST where possible

ymandel accepted this revision. ymandel added a comment. This revision is now accepted and ready to land. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128924/new/ https://reviews.llvm.org/D128924 __

[PATCH] D128807: [clang][transformer] Finish plumbing `Note` all the way to the output.

li.zhe.hua added a comment. In D128807#3620573 , @ymandel wrote: > Eric -- what do you think? You've thought a lot more about metadata recently. (Apologies for the delay. Still struggling to figure out a good workflow for reviewing patches...) Can you

[PATCH] D128924: [clang][dataflow] Replace TEST_F with TEST where possible

sgatev accepted this revision. sgatev added a comment. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128924/new/ https://reviews.llvm.org/D128924 ___ cfe-commits mailing list cfe-commits@lists.ll

[clang] 1d83a16 - [clang][dataflow] Replace TEST_F with TEST where possible

Author: Sam Estep Date: 2022-06-30T16:03:33Z New Revision: 1d83a16bd3faa1dfb6e8ed40c53d018dc03e2c81 URL: https://github.com/llvm/llvm-project/commit/1d83a16bd3faa1dfb6e8ed40c53d018dc03e2c81 DIFF: https://github.com/llvm/llvm-project/commit/1d83a16bd3faa1dfb6e8ed40c53d018dc03e2c81.diff LOG: [cl

[PATCH] D128924: [clang][dataflow] Replace TEST_F with TEST where possible

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG1d83a16bd3fa: [clang][dataflow] Replace TEST_F with TEST where possible (authored by samestep). Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D127803: Generate the capture for field when the field is used in openmp region with implicit default in the member function.

jyu2 added inline comments. Comment at: clang/lib/Sema/SemaOpenMP.cpp:17480 DeclRefExpr *Ref = nullptr; -if (!VD && !CurContext->isDependentContext()) - Ref = buildCapture(*this, D, SimpleRefExpr, /*WithInit=*/false); -DSAStack->addDSA(D, RefExpr->IgnoreParens()

[PATCH] D128927: [libc++] Always build c++experimental.a

ldionne created this revision. ldionne added a reviewer: Mordante. Herald added subscribers: Enna1, abrachet, arichardson, mgorny. Herald added a project: All. ldionne requested review of this revision. Herald added projects: clang, Sanitizers, libc++. Herald added subscribers: libcxx-commits, Sani

[PATCH] D128248: [clang] Avoid an assertion in APValue::hasArrayFiller()

shafik accepted this revision. shafik added a comment. LGTM after addressing all of Aaron's comments. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128248/new/ https://reviews.llvm.org/D128248 ___ cfe-commits mailing list cfe-commits@lists.ll

[PATCH] D128807: [clang][transformer] Finish plumbing `Note` all the way to the output.

ymandel added a comment. In D128807#3622727 , @li.zhe.hua wrote: > - A note being a part of an edit seems weird at best. An `ASTEdit` and `Edit` > are fragments of a greater, logical change. That a note should semantically > be associated with the inse

[PATCH] D128927: [libc++] Always build c++experimental.a

ldionne added a subscriber: mstorsjo. ldionne added a comment. @mstorsjo I might need some assistance figuring out what to do with the Windows parts of this change. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128927/new/ https://reviews.llvm.org

[PATCH] D111617: [RISCV] Lazily add RVV C intrinsics.

craig.topper added inline comments. Comment at: clang/include/clang/Basic/TokenKinds.def:911 +// Annotation for the riscv pragma directives - #pragma clang riscv intrinsic .. +PRAGMA_ANNOTATION(pragma_riscv) Why only 2 periods at the end. Should be 3 like on l

[PATCH] D128927: [libc++] Always build c++experimental.a

Mordante accepted this revision. Mordante added a comment. This revision is now accepted and ready to land. Thanks for working on this! LGTM with some suggestions. Comment at: libcxx/docs/ReleaseNotes.rst:226 + experimental features provided by it. Note that vendors are encour

  1   2   >