clementval added a comment.

In D125788#3621744 <https://reviews.llvm.org/D125788#3621744>, @awarzynski 
wrote:
> We discussed this in our call on Monday and agreed to go ahead provided that 
> this change is technically sound. IIUC, this has now been confirmed:
>
>> Overall the patch looks ok from a technical point.
>
> As always, please correct me if I missed or misinterpreted something!

I still have reserved on this patch so please do not take my "Overall the patch 
looks ok from a technical point." as an approval. There are open discussion so 
wait for other to confirm or not.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D125788/new/

https://reviews.llvm.org/D125788

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to