arichardson added inline comments.
================ Comment at: clang/lib/Driver/ToolChains/RISCVToolchain.cpp:54 + + // Set alias for "riscv{64|32}-unknown-unknown-elf" + SmallVector<std::string, 1> TripleAliases; ---------------- This seems like the wrong place to add this workaround, shouldn't the change be in `GCCInstallation::init`? That way targets other than RISC-V also benefit from this fix. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128625/new/ https://reviews.llvm.org/D128625 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits