[PATCH] D126192: [Driver] Improve linking options for target AVR

benshi001 updated this revision to Diff 433300. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126192/new/ https://reviews.llvm.org/D126192 Files: clang/include/clang/Basic/DiagnosticDriverKinds.td clang/lib/Driver/ToolChains/AVR.cpp clang/test/Driver/avr-toolchain.c Index: clang/t

[PATCH] D126672: [Driver] Add multiarch path for RISC-V

Hahnfeld added a comment. In D126672#3546782 , @Hahnfeld wrote: > In D126672#3546773 , @MaskRay wrote: > >> This needs a test. > > There are no tests for any of the other architectures. @MaskRay is this ok to lan

[PATCH] D126192: [Driver] Improve linking options for target AVR

benshi001 added a comment. In D126192#3549238 , @MaskRay wrote: > I am still uncomfortable with such a change. Trying to be smart sometimes may > get in the way. I have removed the guess of default linker script. Currently my patch only does 1. Support

[PATCH] D126757: Fix clang RecursiveASTVisitor for definition of XXXTemplateSpecializationDecl

nridge added a comment. Thanks for the patch! Could you add a semantic highlighting test case to SemanticHighlighting.GetsCorrectTokens as well please?

[PATCH] D124753: [HLSL] Set main as default entry.

python3kgae updated this revision to Diff 433301. python3kgae added a comment. Cleanup test. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124753/new/ https://reviews.llvm.org/D124753 Files: clang/include/clang/Driver/Options.td clang/test/Cod

[PATCH] D126560: [analyzer][NFC] SimpleSValBuilder simplification: Remove superfluous workaround code and track Assume call stack rather

steakhal added a comment. This isn't an NFC change. It's more than a refactor/cosmetic change. Please run some benchmarks to validate the assumed performance characteristics. Comment at: clang/include/clang/StaticAnalyzer/Core/PathSensitive/ConstraintManager.h:156 + private:

[PATCH] D126725: [pseudo] rename pseudo-gen -> clang-pseudo-gen. NFC

hokein accepted this revision. hokein added inline comments. This revision is now accepted and ready to land. Comment at: llvm/utils/gn/secondary/clang-tools-extra/pseudo/gen/BUILD.gn:1 -executable("pseudo-gen") { +executable("clang-pseudo-gen") { configs += [ "//llvm/utils/gn

[PATCH] D126498: [clangd] Fix hover crashing on integral or enumeral casts

gkll updated this revision to Diff 433304. gkll added a comment. Avoid double negation. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126498/new/ https://reviews.llvm.org/D126498 Files: clang-tools-extra/clangd/Hover.cpp clang-tools-extra/clangd/unittests/HoverTests.cpp clang-too

[PATCH] D36423: [libc++] Introsort based sorting function

philnik commandeered this revision. philnik added a reviewer: DIVYA. philnik added a comment. Herald added a subscriber: mgrang. Herald added a project: All. This has been superseded by D113413 . CHANGES SINCE LAST ACTION https://reviews.llvm.org/D36423/new/

[PATCH] D126731: [pseudo] Eliminate dependencies from clang-pseudo-gen. NFC

hokein accepted this revision. hokein added a comment. This revision is now accepted and ready to land. Nice. > ninja clean; ninja pseudo-gen runs 169 actions only I think previous version was ~400 actions. Comment at: clang-tools-extra/pseudo/lib/grammar/Grammar.cpp:10 #inc

[PATCH] D126192: [Driver] Improve linking options for target AVR

benshi001 added a comment. I have a bit confused, why `clang --target=x86_64 -fuse-ld=lld` needs not to be explicitly specified with a linker script and produces a runnable x86_64 ELF? How does lld arrange code/data addresses for x86_64 by default ? My original will is `clang --target=avr -fuse

[PATCH] D126498: [clangd] Fix hover crashing on integral or enumeral casts

gkll marked 2 inline comments as done. gkll added a comment. Thank you, and sorry for the chaos, this is my first submission to llvm :D Comment at: clang-tools-extra/clangd/unittests/HoverTests.cpp:3221 + TestTU TU = TestTU::withCode(T.code()); + TU.OmitPredefinedMacros = fal

[clang] d597a46 - [clang][ASTImporter] Add support for import of UsingPackDecl.

Author: Balázs Kéri Date: 2022-06-01T09:58:08+02:00 New Revision: d597a461e0f5b1d7508983878bc5a38326cffd14 URL: https://github.com/llvm/llvm-project/commit/d597a461e0f5b1d7508983878bc5a38326cffd14 DIFF: https://github.com/llvm/llvm-project/commit/d597a461e0f5b1d7508983878bc5a38326cffd14.diff L

[PATCH] D125986: [clang][ASTImporter] Add support for import of UsingPackDecl.

This revision was automatically updated to reflect the committed changes. Closed by commit rGd597a461e0f5: [clang][ASTImporter] Add support for import of UsingPackDecl. (authored by balazske). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125986/new/

[PATCH] D126299: [Driver] Support linking to compiler-rt for target AVR

benshi001 added a comment. It seems that the expected path should be `$resource_dir/lib/avr5/libclang_rt.builtins.a`, other than `libclang_rt.builtins-avr5.a`. I will fix that. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126299/new/ https://reviews.llvm.org/D126299

[PATCH] D120201: [Clang] Extend -gen-reproducer flag

vitalybuka added subscribers: browneee, vitalybuka. vitalybuka added a comment. This patch breaks msan bots: https://lab.llvm.org/buildbot/#/builders/5/builds/24307 and https://lab.llvm.org/buildbot/#/builders/74 https://lab.llvm.org/buildbot/#/builders/5/builds/24335 is (last green build http

[PATCH] D126758: [clang-format] Handle do-while loops for RemoveBracesLLVM

owenpan created this revision. owenpan added reviewers: curdeius, HazardyKnusperkeks, MyDeveloperDay. owenpan added a project: clang-format. Herald added a project: All. owenpan requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. If a do-while

[PATCH] D126066: [clang] [WIP] Don't plumb access specifier attributes through Parser unnecessarily.

mboehme added a comment. I erroneously stated in the description that all tests pass, but as the CI shows, this is actually not true. Marking this as "WIP" until I figure out whether this change can be salvaged or should be abandoned. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST A

[PATCH] D126291: [flang][Driver] Update link job on windows

rovka added a comment. In D126291#3547142 , @awarzynski wrote: > In D126291#3547023 , @rovka wrote: > >> With this patch in place, we still need to add `-Xlinker -subsystem:console' >> in order to compile a simp

[PATCH] D126291: [flang][Driver] Update link job on windows

rovka updated this revision to Diff 433318. rovka added a comment. Updated comment in `linker-flags.f90` test CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126291/new/ https://reviews.llvm.org/D126291 Files: clang/lib/Driver/ToolChains/CommonArgs.cpp clang/lib/Driver/ToolChains/Com

[PATCH] D126299: [Driver] Support linking to compiler-rt for target AVR

benshi001 added inline comments. Comment at: clang/lib/Driver/ToolChains/AVR.cpp:463 +std::string +AVRToolChain::buildCompilerRTBasename(const llvm::opt::ArgList &Args, + StringRef Component, FileType Type, benshi001 wrote: >

[PATCH] D126759: [clang][dataflow] Model calls returning optionals

sgatev created this revision. sgatev added reviewers: ymandel, xazax.hun, gribozavr2. Herald added subscribers: tschuett, steakhal, rnkovacs. Herald added a project: All. sgatev requested review of this revision. Herald added a project: clang. Model calls returning optionals Repository: rG LLV

[PATCH] D126560: [analyzer][NFC] SimpleSValBuilder simplification: Remove superfluous workaround code and track Assume call stack rather

martong marked 2 inline comments as done. martong added inline comments. Comment at: clang/include/clang/StaticAnalyzer/Core/PathSensitive/ConstraintManager.h:156 + private: +llvm::SmallSet Aux; + }; steakhal wrote: > Have you considered [[ > https://www.

[PATCH] D126560: [analyzer][NFC] SimpleSValBuilder simplification: Remove superfluous workaround code and track Assume call stack rather

martong marked 2 inline comments as done. martong added a comment. In D126560#3549408 , @steakhal wrote: > This isn't an NFC change. It's more than a refactor/cosmetic change. Still, there is no visible change in the behavior, at least that is intended.

[clang] b1b86b6 - [Clang][Driver] More explicit message when failing to find sanitizer resource file

Author: serge-sans-paille Date: 2022-06-01T10:54:20+02:00 New Revision: b1b86b63943305f71e5fb522da168c9dbac1d39d URL: https://github.com/llvm/llvm-project/commit/b1b86b63943305f71e5fb522da168c9dbac1d39d DIFF: https://github.com/llvm/llvm-project/commit/b1b86b63943305f71e5fb522da168c9dbac1d39d.d

[PATCH] D120484: More explicit message when failing to find a mandatory cfi ressource file

This revision was automatically updated to reflect the committed changes. Closed by commit rGb1b86b639433: [Clang][Driver] More explicit message when failing to find sanitizer resource… (authored by serge-sans-paille). Changed prior to commit: https://reviews.llvm.org/D120484?vs=433063&id=43332

[PATCH] D126723: [pseudo] GC GSS nodes, reuse them with a freelist

hokein added a comment. Nice! I really like the form it goes now. Comment at: clang-tools-extra/pseudo/include/clang-pseudo/GLR.h:82 // FIXME: Most nodes live a fairly short time, and are simply discarded. // Is it worth refcounting them (we have empty padding) and

[PATCH] D126560: [analyzer][NFC] SimpleSValBuilder simplification: Remove superfluous workaround code and track Assume call stack rather

martong updated this revision to Diff 433324. martong edited the summary of this revision. martong added a comment. - Use SmallVector in AssumeStack Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126560/new/ https://reviews.llvm.org/D126560 Files:

[PATCH] D126560: [analyzer][NFC] SimpleSValBuilder simplification: Remove superfluous workaround code and track Assume call stack rather

steakhal added a comment. In D126560#3549570 , @martong wrote: > In D126560#3549408 , @steakhal > wrote: > >> This isn't an NFC change. It's more than a refactor/cosmetic change. > > Still, there is no visible ch

[PATCH] D107960: [clang][analyzer] Make ReturnPtrRange checker warn at negative index.

balazske abandoned this revision. balazske added a comment. Herald added a project: All. With the current main branch the new test passes. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107960/new/ https://reviews.llvm.org/D107960 _

[PATCH] D126723: [pseudo] GC GSS nodes, reuse them with a freelist

sammccall added inline comments. Comment at: clang-tools-extra/pseudo/lib/GLR.cpp:15 #include "llvm/ADT/STLExtras.h" +#include "llvm/ADT/ScopeExit.h" #include "llvm/ADT/StringExtras.h" hokein wrote: > an off-topic comment: we only use the function in debug bran

[PATCH] D126707: [analyzer][NFC] Move overconstrained check from reAssume to assumeDualImpl

steakhal added a comment. LGTM; measure performance implications. Comment at: clang/include/clang/StaticAnalyzer/Core/PathSensitive/ProgramState.h:117-120 // Make internal constraint solver entities friends so they can access the // overconstrained-related functions. We

[PATCH] D126764: [clang] [ARM] Add __builtin_sponentry like on aarch64

mstorsjo created this revision. mstorsjo added reviewers: efriedma, zzheng. Herald added a subscriber: kristof.beyls. Herald added a project: All. mstorsjo requested review of this revision. Herald added a project: clang. This is used for calling the SEH aware setjmp on MinGW. Repository: rG L

[PATCH] D126723: [pseudo] GC GSS nodes, reuse them with a freelist

hokein added inline comments. Comment at: clang-tools-extra/pseudo/lib/GLR.cpp:87 NewHeads.clear(); +MaybeGC(); glrReduce(PendingReduce, Params, sammccall wrote: > hokein wrote: > > I would just call it before the `NewHeads.clear()`, and run the `gc

[PATCH] D126758: [clang-format] Handle do-while loops for RemoveBracesLLVM

curdeius accepted this revision. curdeius added inline comments. This revision is now accepted and ready to land. Comment at: clang/unittests/Format/FormatTest.cpp:25103 - // The following eight test cases are fully-braced versions of the examples at + // The following nine

[clang] 3ec78d9 - [Clang] NFCI: Add a new bit HasExtraBitfields to FunctionType.

Author: Sander de Smalen Date: 2022-06-01T12:40:33+02:00 New Revision: 3ec78d9ff1b3f430dab27434fe8f9a3790d08808 URL: https://github.com/llvm/llvm-project/commit/3ec78d9ff1b3f430dab27434fe8f9a3790d08808 DIFF: https://github.com/llvm/llvm-project/commit/3ec78d9ff1b3f430dab27434fe8f9a3790d08808.di

[PATCH] D126642: [Clang] NFCI: Add a new bit HasExtraBitfields to FunctionType.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG3ec78d9ff1b3: [Clang] NFCI: Add a new bit HasExtraBitfields to FunctionType. (authored by sdesmalen). Changed prior to commit: https://reviews.llv

[PATCH] D126642: [Clang] NFCI: Add a new bit HasExtraBitfields to FunctionType.

sdesmalen added a comment. Thanks for the review and comments @erichkeane and @aaron.ballman! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126642/new/ https://reviews.llvm.org/D126642 ___ cfe-commits ma

[PATCH] D126198: [analyzer][NFCi] Annotate major nonnull returning functions

uabelho added a comment. Hi, I see crashes like this with this patch: clang: ../../clang/include/clang/StaticAnalyzer/Core/PathSensitive/BasicValueFactory.h:94: clang::ento::PointerToMemberData::PointerToMemberData(const clang::NamedDecl *, llvm::ImmutableList): Assertion `D' failed. Anyht

[PATCH] D125323: [RISCV] Add the passthru operand for RVV unmasked segment load IR intrinsics.

pcwang-thead added a comment. Is there an easy way to update tests? Or we need to add passthru operands manually? I will appreciate it if you can tell me. :-) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125323/new/ https://reviews.llvm.org/D1253

[PATCH] D126536: [pseudo] Add grammar annotations support.

hokein updated this revision to Diff 433351. hokein marked 3 inline comments as done and an inline comment as not done. hokein added a comment. [pseudo] Support annotations in the grammar. This patch adds annotations in the bnf grammar. Annotations (which has a form of `[key1=value;key2=value]`)

[PATCH] D126066: [clang] [WIP] Don't plumb access specifier attributes through Parser unnecessarily.

mboehme abandoned this revision. mboehme added a comment. Apologies, I had thoroughly misunderstood how this works. Specifically, what wasn't clear to me is that attributes added to the access specifier are added to every member below it until the next access specifier. With that, all of this c

[PATCH] D126560: [analyzer][NFC] SimpleSValBuilder simplification: Remove superfluous workaround code and track Assume call stack rather

martong updated this revision to Diff 433353. martong added a comment. - Remove FIXME comment Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126560/new/ https://reviews.llvm.org/D126560 Files: clang/include/clang/StaticAnalyzer/Core/PathSensitive

[PATCH] D126536: [pseudo] Add grammar annotations support.

hokein added a comment. I addressed comments on the grammar part, (the remaining GLR, pseudo_gen parts are not covered yet), I think it would be better them into different patches, so that we can land the grammar bit first, then start doing the error recovery and guard implementation in paralle

[PATCH] D126536: [pseudo] Add grammar annotations support.

hokein updated this revision to Diff 433354. hokein marked 2 inline comments as done. hokein added a comment. remove a left-out change. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126536/new/ https://reviews.llvm.org/D126536 Files: clang-tools

[PATCH] D126198: [analyzer][NFCi] Annotate major nonnull returning functions

uabelho added a comment. In D126198#3549790 , @uabelho wrote: > Hi, > > I see crashes like this with this patch: > > clang: > ../../clang/include/clang/StaticAnalyzer/Core/PathSensitive/BasicValueFactory.h:94: > clang::ento::PointerToMemberData::Point

[clang-tools-extra] 94552f0 - [pseudo] Build inc files when cxx.bnf changes.

Author: Haojian Wu Date: 2022-06-01T13:48:09+02:00 New Revision: 94552f02163a348d7b5a4001e0e719b1e617a5d2 URL: https://github.com/llvm/llvm-project/commit/94552f02163a348d7b5a4001e0e719b1e617a5d2 DIFF: https://github.com/llvm/llvm-project/commit/94552f02163a348d7b5a4001e0e719b1e617a5d2.diff LO

[PATCH] D126560: [analyzer][NFC] SimpleSValBuilder simplification: Remove superfluous workaround code and track Assume call stack rather

martong added inline comments. Comment at: clang/include/clang/StaticAnalyzer/Core/PathSensitive/ConstraintManager.h:140-146 /// A flag to indicate that clients should be notified of assumptions. /// By default this is the case, but sometimes this needs to be restricted

[PATCH] D126758: [clang-format] Handle do-while loops for RemoveBracesLLVM

MyDeveloperDay accepted this revision. MyDeveloperDay added a comment. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126758/new/ https://reviews.llvm.org/D126758 ___ cfe-commits mailing list cfe-com

[PATCH] D116638: [clang-format] Fix ignoring JavaScriptWrapImport when ColumnWidth: 0

MyDeveloperDay added a comment. @stasm thank you for taking it on, "Commandeer" the revision via the Revision actions. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116638/new/ https://reviews.llvm.org/D116638 ___ cfe-commits mailing list cf

[PATCH] D126183: Implement soft reset of the diagnostics engine.

tapaswenipathak updated this revision to Diff 433362. tapaswenipathak added a comment. this should be green. :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126183/new/ https://reviews.llvm.org/D126183 Files: clang/include/clang/Basic/Diagnosti

[PATCH] D126759: [clang][dataflow] Model calls returning optionals

ymandel accepted this revision. ymandel added a comment. This revision is now accepted and ready to land. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126759/new/ https://reviews.llvm.org/D126759 __

[PATCH] D126707: [analyzer][NFC] Move overconstrained check from reAssume to assumeDualImpl

martong marked an inline comment as done. martong added inline comments. Comment at: clang/include/clang/StaticAnalyzer/Core/PathSensitive/ProgramState.h:117-120 // Make internal constraint solver entities friends so they can access the // overconstrained-related functions

[PATCH] D126365: [git-clang-format] Stop ignoring changes for files with space in path

curdeius accepted this revision. curdeius added a comment. Ok, I'm not blocking this patch. I'll take a look to see whether we can add some tests. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126365/new/ https://reviews.llvm.org/D126365

[PATCH] D126534: [analyzer] Deadstore static analysis: Fix false positive on C++17 assignments

frederic-tingaud-sonarsource added a comment. Thanks @NoQ! The change in behavior is indeed what I was mentioning in the summary. After discussing it with a colleague, it seemed to us that pointing to a more precise range where the object is allocated was an improvement. I understand your point

[clang] f951a6b - Fix potentially uninitialized memory

Author: Mikhail Goncharov Date: 2022-06-01T15:31:37+02:00 New Revision: f951a6b2f37baf6ae832318fcca9ba4121c29529 URL: https://github.com/llvm/llvm-project/commit/f951a6b2f37baf6ae832318fcca9ba4121c29529 DIFF: https://github.com/llvm/llvm-project/commit/f951a6b2f37baf6ae832318fcca9ba4121c29529.d

[PATCH] D126651: [clang-diff] Fix getStmtValue when dealing with wide chars

PRESIDENT810 updated this revision to Diff 433375. PRESIDENT810 added a comment. Refactored some code and add support of U16 & U32 characters, as well as tests for them. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126651/new/ https://reviews.llvm.org/D126651 Files: clang/lib/Tooli

[PATCH] D126364: Fix interaction of pragma FENV_ACCESS with other pragmas

kpn added a comment. >> On targets that support static rounding mode (like RISCV) dynamic and >> constant rounding modes may be different and the behavior changes if default >> mode is replaced by dynamic. > > Whether a target supports static rounding modes on floating-point > instructions is c

[PATCH] D62574: Add support for target-configurable address spaces.

ebevhan added a comment. I've been away from LLVM development for a while, and sadly this patch has languished a bit. I don't think there were any strong objections to its inclusion, though. If there is still interest in reviewing this, I could try to rebase the patch (or something resembling

[PATCH] D75277: [WebAssembly] Remove restriction on main name mangling

sbc100 updated this revision to Diff 433386. sbc100 added a comment. - feedback Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75277/new/ https://reviews.llvm.org/D75277 Files: clang/lib/AST/Mangle.cpp clang/lib/CodeGen/CodeGenModule.cpp Inde

[PATCH] D126560: [analyzer][NFC] SimpleSValBuilder simplification: Remove superfluous workaround code and track Assume call stack rather

steakhal accepted this revision. steakhal added inline comments. This revision is now accepted and ready to land. Comment at: clang/include/clang/StaticAnalyzer/Core/PathSensitive/ConstraintManager.h:21 #include "llvm/ADT/Optional.h" +#include "llvm/ADT/SmallSet.h" #include "l

[clang] 3a07280 - [analyzer] Fix wrong annotation of PointerToMemberData

Author: Balazs Benics Date: 2022-06-01T16:12:54+02:00 New Revision: 3a07280290564e294c957c94c918a6680714b417 URL: https://github.com/llvm/llvm-project/commit/3a07280290564e294c957c94c918a6680714b417 DIFF: https://github.com/llvm/llvm-project/commit/3a07280290564e294c957c94c918a6680714b417.diff

[PATCH] D126719: [clang-cl] Add support for /kernel

steplong updated this revision to Diff 433389. steplong added a comment. Herald added a subscriber: ormris. - Reject /kernel and /arch combinations for x64 and x86 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126719/new/ https://reviews.llvm.org/D

[PATCH] D126779: [analyzer] Fix assertion in simplifySymbolCast

martong created this revision. martong added reviewers: ASDenysPetrov, steakhal, NoQ, vabridgers. Herald added subscribers: manas, gamesh411, dkrupp, donat.nagy, Szelethus, mikhail.ramalho, a.sidorin, rnkovacs, szepet, baloghadamsoftware, xazax.hun. Herald added a reviewer: Szelethus. Herald added

[PATCH] D126664: Expand definition deprecation warning to include constexpr statements.

luken-google updated this revision to Diff 433395. luken-google added a comment. Add release note. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126664/new/ https://reviews.llvm.org/D126664 Files: clang/docs/ReleaseNotes.rst Index: clang/docs/

[PATCH] D126664: Expand definition deprecation warning to include constexpr statements.

luken-google added a comment. Thanks for the review! I do need someone to commit on my behalf. Please commit with name "Luke Nihlen" and email address "lu...@google.com". Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126664/new/ https://reviews.ll

[PATCH] D126707: [analyzer][NFC] Move overconstrained check from reAssume to assumeDualImpl

martong marked an inline comment as done. martong added a comment. In D126707#3549677 , @steakhal wrote: > LGTM; measure performance implications. Seems like there are no implications (or within the error margin). F23278565: image.png

[PATCH] D126780: [clang-tidy] `bugprone-use-after-move`: Fix handling of moves in lambda captures

mboehme created this revision. Herald added subscribers: carlosgalvezp, xazax.hun. Herald added a project: All. mboehme requested review of this revision. Herald added a project: clang-tools-extra. Herald added a subscriber: cfe-commits. Previously, we were treating a move in the lambda capture as

[PATCH] D119165: [clang-tidy] Add processing lambda captures at bugprone-use-after-move check

mboehme added inline comments. Herald added a project: All. Comment at: clang-tools-extra/clang-tidy/bugprone/UseAfterMoveCheck.cpp:403 hasArgument(0, declRefExpr().bind("arg")), - anyOf(hasAncestor(lambdaExpr().bind("containing-lambda")), -

[PATCH] D126781: [CodeGen] Correctly handle weak symbols in the codegen

junaire created this revision. junaire added reviewers: v.g.vassilev, rjmccall. Herald added a project: All. junaire requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This used to be several downstream patches of Cling, it aims to fix errors

[PATCH] D124525: [OpenMP][ClangLinkerWrapper] Extending linker wrapper to embed metadata for multi-arch fat binaries

saiislam updated this revision to Diff 433401. saiislam added a comment. Added the multi-entry logic in libomptarget. Yet to move the image compatibility testing to plugin. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124525/new/ https://reviews.

[PATCH] D126664: Expand definition deprecation warning to include constexpr statements.

luken-google updated this revision to Diff 433404. luken-google added a comment. Squash commit to include original changes. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126664/new/ https://reviews.llvm.org/D126664 Files: clang/docs/ReleaseNotes

[PATCH] D125323: [RISCV] Add the passthru operand for RVV unmasked segment load IR intrinsics.

khchen added a comment. In D125323#3549794 , @pcwang-thead wrote: > Is there an easy way to update tests? Or we need to add passthru operands > manually? I will appreciate it if you can tell me. :-) use sed to do replacement. ex. #!/bin/bash set -

[PATCH] D124753: [HLSL] Set main as default entry.

Anastasia added a comment. In D124753#3546608 , @python3kgae wrote: > In D124753#3545779 , @Anastasia > wrote: > >> From the current change it seems to me that what you need to be testing is a >> just that the

[PATCH] D122150: [clang][analyzer] Add checker for bad use of 'errno'.

martong added inline comments. Comment at: clang/include/clang/StaticAnalyzer/Checkers/Checkers.td:554 +CmdLineOptionhttps://reviews.llvm.org/D122150/new/ https://reviews.llvm.org/D122150 ___ cfe-commits mailing list cfe-commits@l

[PATCH] D124752: [HLSL] clang codeGen for HLSLShaderAttr.

Anastasia accepted this revision. Anastasia added a comment. This revision is now accepted and ready to land. LGTM! Thanks Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124752/new/ https://reviews.llvm.org/D124752 _

[clang] 1f6ea2a - Expand definition deprecation warning to include constexpr statements.

Author: Luke Nihlen Date: 2022-06-01T11:31:07-04:00 New Revision: 1f6ea2a37c4393a2147cb82c8fe7966a2f690e24 URL: https://github.com/llvm/llvm-project/commit/1f6ea2a37c4393a2147cb82c8fe7966a2f690e24 DIFF: https://github.com/llvm/llvm-project/commit/1f6ea2a37c4393a2147cb82c8fe7966a2f690e24.diff L

[PATCH] D126664: Expand definition deprecation warning to include constexpr statements.

This revision was automatically updated to reflect the committed changes. Closed by commit rG1f6ea2a37c43: Expand definition deprecation warning to include constexpr statements. (authored by luken-google, committed by aaron.ballman). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTI

[PATCH] D126660: [OpenCL] Reword unknown extension pragma diagnostic

Anastasia accepted this revision. Anastasia added a comment. This revision is now accepted and ready to land. Ok, makes sense! Thanks! Btw I was thinking we should provide some way for developers to know what extensions are being supported either through documentation or by querying clang someh

[clang] 872f744 - Fix std::has_unique_object_representations for _BitInt types with padding bits

Author: Mital Ashok Date: 2022-06-01T11:34:40-04:00 New Revision: 872f74440f3c8b749d90384a23caa894068504f9 URL: https://github.com/llvm/llvm-project/commit/872f74440f3c8b749d90384a23caa894068504f9 DIFF: https://github.com/llvm/llvm-project/commit/872f74440f3c8b749d90384a23caa894068504f9.diff L

[PATCH] D125802: Fix std::has_unique_object_representations for _BitInt types with padding bits

This revision was automatically updated to reflect the committed changes. Closed by commit rG872f74440f3c: Fix std::has_unique_object_representations for _BitInt types with padding bits (authored by MitalAshok, committed by aaron.ballman). Repository: rG LLVM Github Monorepo CHANGES SINCE LAS

[PATCH] D126660: [OpenCL] Reword unknown extension pragma diagnostic

svenvh added a comment. In D126660#3550356 , @Anastasia wrote: > Ok, makes sense! Thanks! > > Btw I was thinking we should provide some way for developers to know what > extensions are being supported either through documentation or by querying > clang

[PATCH] D125400: [clang][Analyzer] Add errno state to standard functions modeling.

martong accepted this revision. martong added a comment. This revision is now accepted and ready to land. LGTM! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125400/new/ https://reviews.llvm.org/D125400

[PATCH] D119646: [clang] Allow consteval functions in default arguments

aaron.ballman accepted this revision. aaron.ballman added a comment. LGTM as well, but please add a release note about the bug fix (and reference the issue it closes). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119646/new/ https://reviews.llvm.

[PATCH] D126559: [MSVC] Fix pragma alloc_text failing for C files

aaron.ballman accepted this revision. aaron.ballman added a comment. LGTM! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126559/new/ https://reviews.llvm.org/D126559 ___ cfe-commits mailing list cfe-comm

[PATCH] D120290: [Clang][OpenMP] Add the codegen support for `atomic compare capture`

ABataev accepted this revision. ABataev added a comment. This revision is now accepted and ready to land. LG Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120290/new/ https://reviews.llvm.org/D120290 ___

[PATCH] D126578: [clang] Add tests for (const) weak variables

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126578/new/ https://reviews.llvm.org/D126578

[PATCH] D126758: [clang-format] Handle do-while loops for RemoveBracesLLVM

owenpan added inline comments. Comment at: clang/unittests/Format/FormatTest.cpp:25103 - // The following eight test cases are fully-braced versions of the examples at + // The following nine test cases are fully-braced versions of the examples at // "llvm.org/docs/Coding

[PATCH] D126758: [clang-format] Handle do-while loops for RemoveBracesLLVM

owenpan updated this revision to Diff 433432. owenpan added a comment. Removed the numbering of the examples from the coding standards. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126758/new/ https://reviews.llvm.org/D126758 Files: clang/lib/Format/UnwrappedLineParser.cpp clang/l

[PATCH] D126291: [flang][Driver] Update link job on windows

Meinersbur added a comment. While the test passes now, I still get `LINK : fatal error LNK1561: entry point must be defined` when trying to actually link. Isn't it expected to not work yet? Linking with `lld-link.exe` does work. objdump says there is a `_QQmain` symbol, why does lld consider t

[clang] a5b056f - [MSVC] Fix pragma alloc_text failing for C files

Author: Stephen Long Date: 2022-06-01T09:39:46-07:00 New Revision: a5b056fe49a991c65e665468f1a681965f41b137 URL: https://github.com/llvm/llvm-project/commit/a5b056fe49a991c65e665468f1a681965f41b137 DIFF: https://github.com/llvm/llvm-project/commit/a5b056fe49a991c65e665468f1a681965f41b137.diff

[PATCH] D126559: [MSVC] Fix pragma alloc_text failing for C files

This revision was automatically updated to reflect the committed changes. Closed by commit rGa5b056fe49a9: [MSVC] Fix pragma alloc_text failing for C files (authored by steplong). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126559/new/ https://rev

[clang] e5ece11 - [analyzer][NFC] Add test for 3a07280290564e294c957c94c918a6680714b417

Author: Balazs Benics Date: 2022-06-01T18:53:19+02:00 New Revision: e5ece11e761a8b31b700249e46cf05590330ebc7 URL: https://github.com/llvm/llvm-project/commit/e5ece11e761a8b31b700249e46cf05590330ebc7 DIFF: https://github.com/llvm/llvm-project/commit/e5ece11e761a8b31b700249e46cf05590330ebc7.diff

[PATCH] D102122: Support warn_unused_result on typedefs

aaron.ballman added a comment. In D102122#3544655 , @dblaikie wrote: > How's this look now, then? I think it's heading in the right direction. > One drawback is the built-in attribute warnings that mention which entities > the attribute is valid on wil

[PATCH] D126324: [clang] Allow const variables with weak attribute to be overridden

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM! Please wait a day or two before landing in case @jyknight has additional comments, though. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https

[PATCH] D126364: Fix interaction of pragma FENV_ACCESS with other pragmas

efriedma added a comment. > Constrained intrinsics don't change the rounding mode. The standard text for FENV_ROUND requires that when we see a floating point operation, we have to perform it using the specified rounding mode. "floating-point operators [...] shall be evaluated according to the

[PATCH] D120540: [Driver] Enable to use C++20 modules standalone by -fcxx-modules

aprantl added a comment. This patch broke a whole bunch tests in the LLDB testsuite. I'm trying to figure out what exactly the semantics of the change are, particularly on Darwin, where `-fmodules` doesn't imply `-fcxx-modules`. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D120540: [Driver] Enable to use C++20 modules standalone by -fcxx-modules

aprantl added a comment. https://green.lab.llvm.org/green/view/LLDB/job/lldb-cmake/44167/ Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120540/new/ https://reviews.llvm.org/D120540 ___ cfe-commits mailin

[PATCH] D119051: Extend the C++03 definition of POD to include defaulted functions

probinson added a comment. I'm in the middle of upstreaming PS5 support and I still didn't think of this... doh! Comment at: clang/lib/Driver/ToolChains/Clang.cpp:5588 + bool DefaultedSMFArePOD = !RawTriple.isPS4() && !RawTriple.isOSDarwin(); + `isPS4()` =>

[PATCH] D124753: [HLSL] Set main as default entry.

python3kgae added a comment. In D124753#3550337 , @Anastasia wrote: > In D124753#3546608 , @python3kgae > wrote: > >> In D124753#3545779 , @Anastasia >> wrote: >> >>> Fr

  1   2   3   >