martong created this revision.
martong added reviewers: ASDenysPetrov, steakhal, NoQ, vabridgers.
Herald added subscribers: manas, gamesh411, dkrupp, donat.nagy, Szelethus,
mikhail.ramalho, a.sidorin, rnkovacs, szepet, baloghadamsoftware, xazax.hun.
Herald added a reviewer: Szelethus.
Herald added a project: All.
martong requested review of this revision.
Herald added a project: clang.
Herald added a subscriber: cfe-commits.
Added a new test code that fails an assertion in the baseline.
That is because `getAPSIntType` works only with integral types.
Repository:
rG LLVM Github Monorepo
https://reviews.llvm.org/D126779
Files:
clang/lib/StaticAnalyzer/Core/SValBuilder.cpp
clang/test/Analysis/produce-symbolcast_x86.cpp
Index: clang/test/Analysis/produce-symbolcast_x86.cpp
===================================================================
--- clang/test/Analysis/produce-symbolcast_x86.cpp
+++ clang/test/Analysis/produce-symbolcast_x86.cpp
@@ -11,6 +11,15 @@
template <typename T>
void clang_analyzer_dump(T);
+void test_double(int n) {
+ double D = n / 30;
+ clang_analyzer_dump(D); // expected-warning{{(double) ((double) ((reg_$0<int
n>) / 30))}}
+ char C = D;
+ clang_analyzer_dump(C); // expected-warning{{(char) ((double) ((double)
((reg_$0<int n>) / 30)))}}
+ int I = C; // assertion should not fail here!
+ clang_analyzer_dump(I); // expected-warning{{(int) ((char) ((double)
((double) ((reg_$0<int n>) / 30))))}}
+}
+
void test_schar(schar x) {
clang_analyzer_dump(x); // expected-warning{{reg_$0<schar x>}}
Index: clang/lib/StaticAnalyzer/Core/SValBuilder.cpp
===================================================================
--- clang/lib/StaticAnalyzer/Core/SValBuilder.cpp
+++ clang/lib/StaticAnalyzer/Core/SValBuilder.cpp
@@ -1078,6 +1078,11 @@
SymbolRef RootSym = cast<SymbolCast>(SE)->getOperand();
QualType RT = RootSym->getType().getCanonicalType();
+ // FIXME support cast from non-integers.
+ // E.g (char)(double)(double x) -> (char)(double x)
+ if (!RT->isIntegralOrEnumerationType())
+ return makeNonLoc(SE, T, CastTy);
+
BasicValueFactory &BVF = getBasicValueFactory();
APSIntType CTy = BVF.getAPSIntType(CastTy);
APSIntType TTy = BVF.getAPSIntType(T);
Index: clang/test/Analysis/produce-symbolcast_x86.cpp
===================================================================
--- clang/test/Analysis/produce-symbolcast_x86.cpp
+++ clang/test/Analysis/produce-symbolcast_x86.cpp
@@ -11,6 +11,15 @@
template <typename T>
void clang_analyzer_dump(T);
+void test_double(int n) {
+ double D = n / 30;
+ clang_analyzer_dump(D); // expected-warning{{(double) ((double) ((reg_$0<int n>) / 30))}}
+ char C = D;
+ clang_analyzer_dump(C); // expected-warning{{(char) ((double) ((double) ((reg_$0<int n>) / 30)))}}
+ int I = C; // assertion should not fail here!
+ clang_analyzer_dump(I); // expected-warning{{(int) ((char) ((double) ((double) ((reg_$0<int n>) / 30))))}}
+}
+
void test_schar(schar x) {
clang_analyzer_dump(x); // expected-warning{{reg_$0<schar x>}}
Index: clang/lib/StaticAnalyzer/Core/SValBuilder.cpp
===================================================================
--- clang/lib/StaticAnalyzer/Core/SValBuilder.cpp
+++ clang/lib/StaticAnalyzer/Core/SValBuilder.cpp
@@ -1078,6 +1078,11 @@
SymbolRef RootSym = cast<SymbolCast>(SE)->getOperand();
QualType RT = RootSym->getType().getCanonicalType();
+ // FIXME support cast from non-integers.
+ // E.g (char)(double)(double x) -> (char)(double x)
+ if (!RT->isIntegralOrEnumerationType())
+ return makeNonLoc(SE, T, CastTy);
+
BasicValueFactory &BVF = getBasicValueFactory();
APSIntType CTy = BVF.getAPSIntType(CastTy);
APSIntType TTy = BVF.getAPSIntType(T);
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
