Hahnfeld added a comment. In D126672#3546782 <https://reviews.llvm.org/D126672#3546782>, @Hahnfeld wrote:
> In D126672#3546773 <https://reviews.llvm.org/D126672#3546773>, @MaskRay wrote: > >> This needs a test. > > There are no tests for any of the other architectures. @MaskRay is this ok to land without the test? IMHO, if this part of the driver is to be tested, it should happen for all architectures and requires mock directories because the paths are only added to the list of include / library directories if they exist. This goes far beyond this patch, only adding a `case` to the existing method. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126672/new/ https://reviews.llvm.org/D126672 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
