martong marked an inline comment as done. martong added inline comments.
================ Comment at: clang/include/clang/StaticAnalyzer/Core/PathSensitive/ProgramState.h:117-120 // Make internal constraint solver entities friends so they can access the // overconstrained-related functions. We want to keep this API inaccessible // for Checkers. friend class ConstraintManager; ---------------- steakhal wrote: > Shouldn't you remove this as well? Check the friends. No, it is the `ConstraintManager` which checks the overconstrained property (in `assumeDualImpl`). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126707/new/ https://reviews.llvm.org/D126707 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
