[PATCH] D115620: [AArch64] Lowering and legalization of strict FP16

dmgreen added a comment. I might have misunderstood which this patch was. Can you move the clang test into D118259 with the other? It seems like the same problem, and it looks like there should be enough llc tests to cover all the cases. Co

[PATCH] D123574: [clang] NFCI: Use FileEntryRef in PPCallbacks::InclusionDirective

jansvoboda11 created this revision. jansvoboda11 added reviewers: dexonsmith, bnbarham. Herald added subscribers: carlosgalvezp, usaxena95, shchenz, kadircet, arphaman, kbarton, nemanjai. Herald added a project: All. jansvoboda11 requested review of this revision. Herald added projects: clang, cla

[PATCH] D123300: [Clang] Enable opaque pointers by default

vitalybuka added a comment. In D123300#3443603 , @vitalybuka wrote: > https://lab.llvm.org/buildbot/#/builders/74/builds/10288/steps/14/logs/stdio This looks like a false report. Probably opaque pointers somehow break Msan. Repository: rG LLVM Githu

[PATCH] D123300: [Clang] Enable opaque pointers by default

mstorsjo added a comment. This triggered (or exposed) assertion failures: $ cat inlinecost.cpp typedef char a; typedef unsigned b; typedef int c; typedef struct { b d[]; } e; e f(void *) {} typedef void *fptr; fptr g; template void h(fptr i) { int (*j)(const void *) =

[PATCH] D123127: [AST] Add a new TemplateName for templates found via a using declaration.

hokein updated this revision to Diff 422134. hokein marked an inline comment as done. hokein edited the summary of this revision. hokein added a comment. Fix a use-after-free in the unittest, TemplateArgumentLoc is a local storage of MatchCallback. Repository: rG LLVM Github Monorepo CHANGES

[clang] 2b6e5fa - [clang][ASTImporter] Add import of attribute 'enable_if'.

Author: Balázs Kéri Date: 2022-04-12T10:02:51+02:00 New Revision: 2b6e5fa62b80f4c0ca540e2fc0ebe3b15e50b78a URL: https://github.com/llvm/llvm-project/commit/2b6e5fa62b80f4c0ca540e2fc0ebe3b15e50b78a DIFF: https://github.com/llvm/llvm-project/commit/2b6e5fa62b80f4c0ca540e2fc0ebe3b15e50b78a.diff L

[PATCH] D123397: [clang][ASTImporter] Add import of attribute 'enable_if'.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG2b6e5fa62b80: [clang][ASTImporter] Add import of attribute 'enable_if'. (authored by balazske). Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D121556: [randstruct] Add randomize structure layout support

void added a comment. In D121556#334 , @MaskRay wrote: > In D121556#3444260 , @void wrote: > >> In D121556#3444221 , @MaskRay >> wrote: >> >>> In D121556#3444131

[PATCH] D122525: [clang][ASTImporter] Fix an import error handling related bug.

balazske updated this revision to Diff 422139. balazske added a comment. Created a common place for the `DeclContext` child error handling code. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122525/new/ https://reviews.llvm.org/D122525 Files: cl

[PATCH] D123297: [flang][driver] Add support for -mmlir

rovka added inline comments. Comment at: flang/test/Driver/mllvm_vs_mmlir.f90:17 +! MLLVM: flang (LLVM option parsing) [options] +! MLLVM: --print-ir-after-all +! MLLVM-NOT: --mlir-{{.*}} awarzynski wrote: > awarzynski wrote: > > rriddle wrote: > > > awarzynski w

[clang] 5a5be40 - [AST] Add a new TemplateKind for template decls found via a using decl.

Author: Haojian Wu Date: 2022-04-12T10:48:23+02:00 New Revision: 5a5be4044f0bceb71bb6a81f6955704691b389ed URL: https://github.com/llvm/llvm-project/commit/5a5be4044f0bceb71bb6a81f6955704691b389ed DIFF: https://github.com/llvm/llvm-project/commit/5a5be4044f0bceb71bb6a81f6955704691b389ed.diff LO

[PATCH] D123127: [AST] Add a new TemplateName for templates found via a using declaration.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG5a5be4044f0b: [AST] Add a new TemplateKind for template decls found via a using decl. (authored by hokein). Repository: rG LLVM Github Monorepo C

[PATCH] D122008: [flang][driver] Add support for generating executables

awarzynski updated this revision to Diff 422143. awarzynski added a comment. Updates required after https://reviews.llvm.org/D122444 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122008/new/ https://reviews.llvm.org/D122008 Files: clang/lib/Driv

[PATCH] D123488: [clangd] IncludeCleaner: Add filtering mechanism

dsanders11 added a comment. Cool stuff! Chiming in randomly here, but I've been keeping a loose eye on the progress of IncludeCleaner. I've been using IncludeCleaner to power include cleanup in the Chromium code base for the past few months, and have built Python scripts around it so I can mor

[PATCH] D123300: [Clang] Enable opaque pointers by default

nikic added a comment. @mstorsjo Thanks for the report, the issue should be fixed by https://github.com/llvm/llvm-project/commit/8d5c8d57c637d898094af323d1888ea5a3364f8c. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123300/new/ https://reviews.ll

[PATCH] D123297: [flang][driver] Add support for -mmlir

awarzynski added inline comments. Comment at: flang/test/Driver/mllvm_vs_mmlir.f90:17 +! MLLVM: flang (LLVM option parsing) [options] +! MLLVM: --print-ir-after-all +! MLLVM-NOT: --mlir-{{.*}} rovka wrote: > awarzynski wrote: > > awarzynski wrote: > > > rriddle w

[PATCH] D123300: [Clang] Enable opaque pointers by default

nikic added a comment. @vitalybuka Are there any instructions on how to reproduce failures from this buildbot? It seems like this needs more than a simple bootstrap build due to the need for instrumented libcxx? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews

[clang] 95f0f69 - Revert "[AST] Add a new TemplateKind for template decls found via a using decl."

Author: Haojian Wu Date: 2022-04-12T11:51:00+02:00 New Revision: 95f0f69f1ff8eff34a00a47a236c2f91a2392c70 URL: https://github.com/llvm/llvm-project/commit/95f0f69f1ff8eff34a00a47a236c2f91a2392c70 DIFF: https://github.com/llvm/llvm-project/commit/95f0f69f1ff8eff34a00a47a236c2f91a2392c70.diff LO

[PATCH] D123533: [clang][extract-api] Add support for true anonymous enums

dang updated this revision to Diff 422160. dang added a comment. Address code review feedback: - Normalize test file URIs - Key RecordMaps by USR instead of by Name Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123533/new/ https://reviews.llvm.org

[PATCH] D123533: [clang][extract-api] Add support for true anonymous enums

dang marked 3 inline comments as done. dang added inline comments. Comment at: clang/test/ExtractAPI/enum.c:693 +], +"title": "(anonymous)" + }, zixuw wrote: > So the `Name` of the record is literally `(anonymous)`? I think this might > crea

[PATCH] D123297: [flang][driver] Add support for -mmlir

awarzynski added a comment. I did a bit of digging and realised that MLIR llvm::cl options are lazily constructed on demand (see the definition of options

[PATCH] D123297: [flang][driver] Add support for -mmlir

awarzynski updated this revision to Diff 422163. awarzynski added a comment. Rebase on top of `main`, re-fine the test Make sure that the test file correctly takes into account that `-mmlir -help` is a superset of `-mllvm -help`. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

Re: [PATCH] D123345: Treat `std::move`, `forward`, and `move_if_noexcept` as builtins.

On Mon, Apr 11, 2022 at 12:14 PM Aaron Ballman via cfe-commits < cfe-commits@lists.llvm.org> wrote: > On Mon, Apr 11, 2022 at 10:50 AM Joerg Sonnenberger via Phabricator < > revi...@reviews.llvm.org> wrote: > > > > joerg added a comment. > > > > The patch contains at least one user visible change

[PATCH] D121556: [randstruct] Add randomize structure layout support

aaron.ballman added a comment. In D121556#3444837 , @void wrote: > In D121556#334 , @MaskRay wrote: > >> In D121556#3444260 , @void wrote: >> >>> In D121556#3444221

[PATCH] D123298: [NFC] [AST] Reduce the size of TemplateParmPosition

aaron.ballman added a comment. Still LG to me, but please watch the build bots and issues list closely for any new template instantiation depth/position related issues over the next short while given that we're making a best guess at the bit widths here. Comment at: clang/inc

[PATCH] D123586: [clang][dataflow] Weaken abstract comparison to enable loop termination.

ymandel created this revision. ymandel added reviewers: xazax.hun, sgatev. Herald added subscribers: tschuett, steakhal, rnkovacs. Herald added a project: All. ymandel requested review of this revision. Herald added a project: clang. Currently, when the framework is used with an analysis that does

[PATCH] D123544: [randstruct] Automatically randomize a structure of function pointers

aaron.ballman requested changes to this revision. aaron.ballman added a comment. This revision now requires changes to proceed. While I agree with the security aspects of this in principle, it is not a conforming behavior in C and it runs significant risk of breaking existing code such that it i

[PATCH] D123447: [Clang] Fix unknown type attributes diagnosed twice with [[]] spelling

aaron.ballman accepted this revision. aaron.ballman added a comment. I did some minor changes to the release note, but otherwise LGTM! Comment at: clang/docs/ReleaseNotes.rst:116-117 This fixes Issue `Issue 53488 `_. +- Unk

[PATCH] D123598: Clean the code, formated and add basic tests for the patch.

abidmalikwaterloo created this revision. Herald added subscribers: mgrang, hiraditya. Herald added a project: All. abidmalikwaterloo requested review of this revision. Herald added a reviewer: jdoerfert. Herald added subscribers: llvm-commits, cfe-commits, sstefan1. Herald added projects: clang, LL

[PATCH] D123544: [randstruct] Automatically randomize a structure of function pointers

xbolva00 added a comment. >> While I agree with the security aspects of this in principle, it is not a >> conforming behavior in C and it runs significant risk of breaking existing >> code such that it introduces new security issues. I agree strongly. This could happily can do more harm than go

[PATCH] D123300: [Clang] Enable opaque pointers by default

nikic added a comment. Okay, I managed to reproduce this using the instructions from https://github.com/google/sanitizers/wiki/MemorySanitizerBootstrappingClang. Reduced to these two variants for `-passes=msan`: target triple = "x86_64-unknown-linux-gnu" define void @test(i8* %p, i32* by

[PATCH] D123601: [clang][AArch64] Split neon tests into 2 files

DavidSpickett created this revision. Herald added a subscriber: kristof.beyls. Herald added a project: All. DavidSpickett requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This should reduce the per test execution time and prevent timeouts in

[PATCH] D123601: [clang][AArch64] Split neon tests into 2 files

DavidSpickett added a comment. For https://github.com/llvm/llvm-project/issues/54821. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123601/new/ https://reviews.llvm.org/D123601 ___ cfe-commits mailing li

[clang] f9c2f82 - [Clang] Fix unknown type attributes diagnosed twice with [[]] spelling

Author: Jun Zhang Date: 2022-04-12T21:11:51+08:00 New Revision: f9c2f821d71b7bbb2544a489b7798bd173ea8907 URL: https://github.com/llvm/llvm-project/commit/f9c2f821d71b7bbb2544a489b7798bd173ea8907 DIFF: https://github.com/llvm/llvm-project/commit/f9c2f821d71b7bbb2544a489b7798bd173ea8907.diff LOG

[PATCH] D123447: [Clang] Fix unknown type attributes diagnosed twice with [[]] spelling

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGf9c2f821d71b: [Clang] Fix unknown type attributes diagnosed twice with [[]] spelling (authored by junaire). Changed prior to commit: https://revie

[PATCH] D123456: [C89/C2x] Diagnose calls to a function without a prototype but passes arguments

erichkeane added inline comments. Comment at: clang/docs/ReleaseNotes.rst:126 + a prototype will change behavior in C2x. Additionally, it will diagnose calls + to a function without a prototype but arguments are provided, only so long as + the ``-Wdeprecated-non-prototype`` op

[PATCH] D123300: [Clang] Enable opaque pointers by default

nikic added a comment. I've put up https://reviews.llvm.org/D123602 to fix the msan issue. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123300/new/ https://reviews.llvm.org/D123300 ___ cfe-commits maili

[PATCH] D119136: [clang] Implement Change scope of lambda trailing-return-type

aaron.ballman added inline comments. Comment at: clang/include/clang/Basic/DiagnosticSemaKinds.td:7702 + def err_lambda_used_before_capture: Error< +"captured variable %0 cannot appear before the end of the lambda's parameter list">; def note_lambda_variable_capture_fixi

[PATCH] D123605: Work in progress: [Sema][SVE] Move sema testing for SVE2-AES ACLE builtins

RosieSumpter created this revision. RosieSumpter added reviewers: sdesmalen, paulwalker-arm. Herald added subscribers: ctetreau, psnobl, tschuett. Herald added a reviewer: efriedma. Herald added a project: All. RosieSumpter requested review of this revision. Herald added a project: clang. Herald ad

[PATCH] D119136: [clang] Implement Change scope of lambda trailing-return-type

cor3ntin added inline comments. Comment at: clang/include/clang/Basic/DiagnosticSemaKinds.td:7702 + def err_lambda_used_before_capture: Error< +"captured variable %0 cannot appear before the end of the lambda's parameter list">; def note_lambda_variable_capture_fixit : N

[PATCH] D123182: [Concepts] Fix overload resolution bug with constrained candidates

erichkeane added inline comments. Comment at: clang/lib/Sema/SemaOverload.cpp:2967 + "parameters!"); + for (FunctionProtoType::param_type_iterator + O = OldType->param_type_begin(), Thanks for the clarification on 'Reversed'. The comment makes

[PATCH] D123605: Work in progress: [Sema][SVE] Move sema testing for SVE2-AES ACLE builtins

paulwalker-arm added inline comments. Comment at: clang/test/Sema/aarch64-acle-sve2-aes.c:1 +// RUN: %clang_cc1 -triple aarch64-none-linux-gnu -target-feature +sve2 -fallow-half-arguments-and-returns -fsyntax-only -std=c99 -verify -verify-ignore-unexpected=error %s + --

[PATCH] D122525: [clang][ASTImporter] Fix an import error handling related bug.

martong accepted this revision. martong added a comment. This revision is now accepted and ready to land. Very good! Thanks for the update! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122525/new/ https://reviews.llvm.org/D122525

[PATCH] D122895: [C89/C2x] Improve diagnostics around strict prototypes in C

jyknight added inline comments. Comment at: clang/test/CodeGen/2009-06-01-addrofknr.c:8 -static int func(f) +static int func(f) // expected-warning {{this function declaration without a prototype is deprecated in all versions of C and changes behavior in C2x}} void *f;

[PATCH] D123547: [docs] Mention that we are in the process of removing the legacy PM for the optimization pipeline

nikic accepted this revision. nikic added a comment. This revision is now accepted and ready to land. LG Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123547/new/ https://reviews.llvm.org/D123547 ___ cfe

[PATCH] D122243: [analyzer][NFC] Introduce the checker package separator character

steakhal added a comment. In D122243#3443109 , @ASDenysPetrov wrote: > LGTM Oh I completely forgot about this stack. Thanks. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122243/new/ https://reviews.llvm

[PATCH] D123601: [clang][AArch64] Split neon tests into 2 files

tstellar added a comment. Can't we add a timeout exception for this test in buildkite? Splitting the file in two actually increases the runtime, due to the overhead of setting up each test. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123601/new

[PATCH] D122535: [clang-tidy] Never consider assignments as equivalent in `misc-redundant-expression` check

This revision was automatically updated to reflect the committed changes. Closed by commit rGa18634b74fc0: [clang-tidy] Never consider assignments as equivalent in `misc-redundant… (authored by fwolff). Changed prior to commit: https://reviews.llvm.org/D122535?vs=418420&id=42#toc Repositor

[clang-tools-extra] a18634b - [clang-tidy] Never consider assignments as equivalent in `misc-redundant-expression` check

Author: Fabian Wolff Date: 2022-04-12T16:03:14+02:00 New Revision: a18634b74fc0ee1ca0d580cb5b71cd6807d18ce9 URL: https://github.com/llvm/llvm-project/commit/a18634b74fc0ee1ca0d580cb5b71cd6807d18ce9 DIFF: https://github.com/llvm/llvm-project/commit/a18634b74fc0ee1ca0d580cb5b71cd6807d18ce9.diff

[clang-tools-extra] 60502ed - [pseudo] Remove unused clangTesting dep. NFC

Author: Sam McCall Date: 2022-04-12T16:17:43+02:00 New Revision: 60502ed11a0c3b4c757a9cf526c27999c0029485 URL: https://github.com/llvm/llvm-project/commit/60502ed11a0c3b4c757a9cf526c27999c0029485 DIFF: https://github.com/llvm/llvm-project/commit/60502ed11a0c3b4c757a9cf526c27999c0029485.diff LO

[PATCH] D119290: [Clang] Add support for -fcx-limited-range, -fcx-fortran-rules options.

zahiraam added inline comments. Herald added a subscriber: MaskRay. Herald added a project: All. Comment at: clang/include/clang/Driver/Options.td:1853 +def fcx_fortran_rules : Flag<["-"], "fcx-fortran-rules">, Group; +def fnocx_fortran_rules : Flag<["-"], "fnocx-fortran-rules">,

[PATCH] D123235: atomic compare fail : Parser & AST support

tianshilei1992 added a comment. In D123235#3444644 , @koops wrote: > Can I please have the detailed log for the build failures? I do not have the > necessary setup to test those builds. You can find it https://buildkite.com/llvm-project/premerge-checks

[PATCH] D122895: [C89/C2x] Improve diagnostics around strict prototypes in C

aaron.ballman added inline comments. Comment at: clang/test/CodeGen/2009-06-01-addrofknr.c:8 -static int func(f) +static int func(f) // expected-warning {{this function declaration without a prototype is deprecated in all versions of C and changes behavior in C2x}} void *f;

[PATCH] D123610: [Testing] Drop clangTesting from clang's public library interface

sammccall created this revision. sammccall added a reviewer: hokein. Herald added a subscriber: mgorny. Herald added a project: All. sammccall requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This was probably not particularly intended to be

[PATCH] D123488: [clangd] IncludeCleaner: Add filtering mechanism

kbobyrev updated this revision to Diff 47. kbobyrev marked 7 inline comments as done. kbobyrev added a comment. Resolve comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123488/new/ https://reviews.llvm.org/D123488 Files: clang-tools-e

[PATCH] D123488: [clangd] IncludeCleaner: Add filtering mechanism

kbobyrev updated this revision to Diff 48. kbobyrev added a comment. Fix the comment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123488/new/ https://reviews.llvm.org/D123488 Files: clang-tools-extra/clangd/Config.h clang-tools-extra/cla

[PATCH] D123488: [clangd] IncludeCleaner: Add filtering mechanism

kbobyrev added a comment. In D123488#3444900 , @dsanders11 wrote: > Cool stuff! Chiming in randomly here, but I've been keeping a loose eye on > the progress of IncludeCleaner. > > I've been using IncludeCleaner to power include cleanup in the Chromium

[PATCH] D123488: [clangd] IncludeCleaner: Add filtering mechanism

kbobyrev added a comment. Oops, sorry, I linked the wrong revision; here's the prototype: we plan to start rolling it out gradually https://reviews.llvm.org/D122677 and then have a common library that we could share between both clangd and Clang-Tidy (and potentially other tools). Repository:

[PATCH] D123456: [C89/C2x] Diagnose calls to a function without a prototype but passes arguments

aaron.ballman updated this revision to Diff 422231. aaron.ballman marked 3 inline comments as done. aaron.ballman added a comment. Updated based on review feedback (reworded diagnostic and release note). CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123456/new/ https://reviews.llvm.org/

[PATCH] D123456: [C89/C2x] Diagnose calls to a function without a prototype but passes arguments

aaron.ballman added inline comments. Comment at: clang/docs/ReleaseNotes.rst:126 + a prototype will change behavior in C2x. Additionally, it will diagnose calls + to a function without a prototype but arguments are provided, only so long as + the ``-Wdeprecated-non-prototype``

[PATCH] D122150: [clang][analyzer] Add checker for bad use of 'errno'.

martong added a comment. In D122150#3408156 , @balazske wrote: > This errno check will work if a state split is added at every standard > function that may set `errno` at failure. (The success and failure branches > have different //errno check state//,

[PATCH] D119136: [clang] Implement Change scope of lambda trailing-return-type

aaron.ballman added inline comments. Comment at: clang/include/clang/Basic/DiagnosticSemaKinds.td:7702 + def err_lambda_used_before_capture: Error< +"captured variable %0 cannot appear before the end of the lambda's parameter list">; def note_lambda_variable_capture_fixi

[PATCH] D119136: [clang] Implement Change scope of lambda trailing-return-type

aaron.ballman added inline comments. Comment at: clang/lib/Parse/ParseExprCXX.cpp:1259 Actions.PushLambdaScope(); + Actions.ActOnLambdaIntroducer(Intro, getCurScope()); aaron.ballman wrote: > cor3ntin wrote: > > aaron.ballman wrote: > > > This call surprise

[PATCH] D123612: [Driver] Support linking to compiler-rt on AVR

benshi001 created this revision. benshi001 added reviewers: aykevl, MaskRay, dylanmckay. Herald added subscribers: StephenFan, Jim, dberris. Herald added a project: All. benshi001 requested review of this revision. Herald added subscribers: cfe-commits, jacquesguan. Herald added a project: clang.

[PATCH] D123612: [Driver] Support linking to compiler-rt on AVR

benshi001 added a comment. As changes in https://reviews.llvm.org/D123200, it whould be better to support "--rtlib=compiler-rt" on AVR first. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123612/new/ https://reviews.llvm.org/D123612 _

[PATCH] D123605: Work in progress: [Sema][SVE] Move sema testing for SVE2-AES ACLE builtins

RosieSumpter added inline comments. Comment at: clang/test/Sema/aarch64-acle-sve2-aes.c:1 +// RUN: %clang_cc1 -triple aarch64-none-linux-gnu -target-feature +sve2 -fallow-half-arguments-and-returns -fsyntax-only -std=c99 -verify -verify-ignore-unexpected=error %s +

[PATCH] D122895: [C89/C2x] Improve diagnostics around strict prototypes in C

jyknight added inline comments. Comment at: clang/test/Sema/knr-def-call.c:15 +void f2(float); // expected-note{{previous declaration is here}} \ + expected-warning {{this function declaration with a prototype changes behavior in C2x because it is followed by a

[PATCH] D122895: [C89/C2x] Improve diagnostics around strict prototypes in C

aaron.ballman added inline comments. Comment at: clang/test/Sema/knr-def-call.c:15 +void f2(float); // expected-note{{previous declaration is here}} \ + expected-warning {{this function declaration with a prototype changes behavior in C2x because it is followed

[PATCH] D123300: [Clang] Enable opaque pointers by default

mstorsjo added a comment. In D123300#3444903 , @nikic wrote: > @mstorsjo Thanks for the report, the issue should be fixed by > https://github.com/llvm/llvm-project/commit/8d5c8d57c637d898094af323d1888ea5a3364f8c. Awesome, thanks! Unfortunately, there se

[PATCH] D123300: [Clang] Enable opaque pointers by default

vitalybuka added a comment. In D123300#3444988 , @nikic wrote: > @vitalybuka Are there any instructions on how to reproduce failures from this > buildbot? It seems like this needs more than a simple bootstrap build due to > the need for instrumented lib

[PATCH] D123533: [clang][extract-api] Add support for true anonymous enums

zixuw added inline comments. Comment at: clang/test/ExtractAPI/enum.c:693 +], +"title": "(anonymous)" + }, dang wrote: > zixuw wrote: > > So the `Name` of the record is literally `(anonymous)`? I think this might > > create problems (well I

[PATCH] D122895: [C89/C2x] Improve diagnostics around strict prototypes in C

aaron.ballman added inline comments. Comment at: clang/test/CodeGen/2009-06-01-addrofknr.c:8 -static int func(f) +static int func(f) // expected-warning {{this function declaration without a prototype is deprecated in all versions of C and changes behavior in C2x}} void *f;

[PATCH] D115620: [AArch64] Lowering and legalization of strict FP16

john.brawn updated this revision to Diff 422257. john.brawn added a comment. Removed clang test changes. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115620/new/ https://reviews.llvm.org/D115620 Files: llvm/lib/CodeGen/SelectionDAG/LegalizeDAG.cpp llvm/lib/Target/AArch64/AArch64IS

[PATCH] D123211: [flang][driver] Add support for generating LLVM bytecode files

awarzynski added a comment. In D123211#3435421 , @rovka wrote: > Is there actually a significant difference, besides the naming (which is easy > to change)? AFAICT the BackendAction isn't initializing anything > backend-related except very close to wher

[PATCH] D115620: [AArch64] Lowering and legalization of strict FP16

john.brawn added inline comments. Comment at: llvm/lib/Target/AArch64/AArch64ISelLowering.cpp:1386 + + IsStrictFPEnabled = true; } dmgreen wrote: > What are the ramifications of setting this to true? The behaviour with IsStrictFPEnabled = false is that strict f

[PATCH] D121387: [analyzer] ClangSA should tablegen doc urls refering to the main doc page

ASDenysPetrov accepted this revision. ASDenysPetrov added a comment. Thanks! LGTM. Comment at: clang/utils/TableGen/ClangSACheckersEmitter.cpp:87-90 + std::string CheckerFullName = StringRef(getCheckerFullName(&R, "-")).lower(); + return (llvm::Twine("https://clang.llvm.org/d

[PATCH] D123300: [Clang] Enable opaque pointers by default

nikic added a comment. @mstorsjo Thanks! I've reduced this to a crash in `-argpromotion`: efine void @caller() { call i32 @callee(ptr null) ret void } define internal void @callee(ptr %p) { ret void } Similar issue with function type mismatch. Repository: rG LLVM Githu

[PATCH] D122865: [HLSL][clang][Driver] Support target profile command line option.

python3kgae updated this revision to Diff 422272. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122865/new/ https://reviews.llvm.org/D122865 Files: clang/include/clang/Basic/DiagnosticDriverKinds.td clang/include/clang/Driver/Driver.h clang/in

[clang] e08c435 - [clang][ExtractAPI][NFC] Fix sed delimiter in test

Author: Zixu Wang Date: 2022-04-12T10:00:15-07:00 New Revision: e08c435401bc335c687b693591feafd7dbca1455 URL: https://github.com/llvm/llvm-project/commit/e08c435401bc335c687b693591feafd7dbca1455 DIFF: https://github.com/llvm/llvm-project/commit/e08c435401bc335c687b693591feafd7dbca1455.diff LOG

[PATCH] D123526: [clang][ExtractAPI][NFC] Fix sed delimiter in test

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGe08c435401bc: [clang][ExtractAPI][NFC] Fix sed delimiter in test (authored by zixuw). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTI

[PATCH] D119136: [clang] Implement Change scope of lambda trailing-return-type

cor3ntin updated this revision to Diff 422282. cor3ntin added a comment. After offline discussion with Aaron, we decided that "can not appear here" was a sufficient diagnostic, so I have implemented that. A better solution would be to track which captures fail, and collect the diagnostics to emit

[PATCH] D118259: [AArch64] Adjust aarch64 constrained intrinsics tests and un-XFAIL

john.brawn updated this revision to Diff 422285. john.brawn retitled this revision from "[AArch64] Adjust aarch64-neon-intrinsics-constrained test and un-XFAIL" to "[AArch64] Adjust aarch64 constrained intrinsics tests and un-XFAIL". john.brawn edited the summary of this revision. john.brawn adde

[PATCH] D118259: [AArch64] Adjust aarch64 constrained intrinsics tests and un-XFAIL

kpn accepted this revision. kpn added a comment. This revision is now accepted and ready to land. I trust you on the instruction set changes. LGTM. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118259/new/ https://reviews.llvm.org/D118259 ___

[clang] 9faab43 - [docs] Mention that we are in the process of removing the legacy PM for the optimization pipeline

Author: Arthur Eubanks Date: 2022-04-12T10:47:58-07:00 New Revision: 9faab435a35720fd7c6b3aeafe22c5dfb29f36e0 URL: https://github.com/llvm/llvm-project/commit/9faab435a35720fd7c6b3aeafe22c5dfb29f36e0 DIFF: https://github.com/llvm/llvm-project/commit/9faab435a35720fd7c6b3aeafe22c5dfb29f36e0.diff

[PATCH] D123547: [docs] Mention that we are in the process of removing the legacy PM for the optimization pipeline

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG9faab435a357: [docs] Mention that we are in the process of removing the legacy PM for the… (authored by aeubanks). Repository: rG LLVM Github Mono

[PATCH] D123533: [clang][extract-api] Add support for true anonymous enums

dang updated this revision to Diff 422296. dang marked an inline comment as done. dang added a comment. Add a second anonymous enum to the test case to make sure that distinct symbols are generated for both of them. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://revie

[PATCH] D123544: [randstruct] Automatically randomize a structure of function pointers

void added a comment. In D123544#3445425 , @xbolva00 wrote: >>> While I agree with the security aspects of this in principle, it is not a >>> conforming behavior in C and it runs significant risk of breaking existing >>> code such that it introduces new

[PATCH] D123533: [clang][extract-api] Add support for true anonymous enums

zixuw accepted this revision. zixuw added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123533/new/ https://reviews.llvm.org/D123533 ___ c

[PATCH] D121556: [randstruct] Add randomize structure layout support

void added a comment. In D121556#3445124 , @aaron.ballman wrote: > In D121556#3444837 , @void wrote: > >> In D121556#334 , @MaskRay >> wrote: >> >>> In D121556#34442

[PATCH] D123544: [randstruct] Automatically randomize a structure of function pointers

MaskRay added a comment. The Linux kernel already uses some options which deviate from standard C: `__attribute__((__gnu_inline__))`, `-ftrivial-auto-var-init=zero -enable-trivial-auto-var-init-zero-knowing-it-will-be-removed-from-clang`. If the feature is to emulate `GCC_PLUGIN_STRUCTLEAK` in

[PATCH] D123544: [randstruct] Automatically randomize a structure of function pointers

lebedev.ri added a comment. Does this not lead to non-deterministic/non-reproducible builds? I do not understand why this feature must be inflicted onto everyone. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123544/new/ https://reviews.llvm.org/D1

[PATCH] D123544: [randstruct] Automatically randomize a structure of function pointers

MaskRay added a comment. In D123544#3446285 , @lebedev.ri wrote: > Does this not lead to non-deterministic/non-reproducible builds? > I do not understand why this feature must be inflicted onto everyone. It seems that the feature fixes the randomization

[PATCH] D123345: Treat `std::move`, `forward`, and `move_if_noexcept` as builtins.

rsmith updated this revision to Diff 422305. rsmith added a comment. - Add support for -fno-builtin, -ffreestanding, -fno-builtin-std-move. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123345/new/ https://reviews.llvm.org/D123345 Files: clang/d

[PATCH] D123352: [analyzer] Add FixItHint to `nullability.NullReturnedFromNonnull` and `nullability.NullableReturnedFromNonnull`

MosheBerman added a comment. Hey, bumping for feedback, please. :D Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123352/new/ https://reviews.llvm.org/D123352 ___ cfe-commits mailing list cfe-commits@list

[PATCH] D123544: [randstruct] Automatically randomize a structure of function pointers

void added a comment. In D123544#3446285 , @lebedev.ri wrote: > Does this not lead to non-deterministic/non-reproducible builds? It's deterministic based on the randomization seed. > I do not understand why this feature must be inflicted onto everyone.

[PATCH] D123574: [clang] NFCI: Use FileEntryRef in PPCallbacks::InclusionDirective

dexonsmith accepted this revision. dexonsmith added a comment. This revision is now accepted and ready to land. LGTM, with a couple of nitpicks. If you'd rather not improve the tests that's probably fine, since the patch doesn't make them any worse. Comment at: clang-tools-ext

[PATCH] D121637: [PowerPC] Fix EmitPPCBuiltinExpr to emit arguments once

quinnp reopened this revision. quinnp added a comment. This revision is now accepted and ready to land. Re-opening the revision so that I can update it with a fix. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121637/new/ https://reviews.llvm.org/D

[PATCH] D123574: [clang] NFCI: Use FileEntryRef in PPCallbacks::InclusionDirective

bnbarham accepted this revision. bnbarham added a comment. Thanks Jan :)! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123574/new/ https://reviews.llvm.org/D123574 ___ cfe-commits mailing list cfe-commi

[PATCH] D123127: [AST] Add a new TemplateName for templates found via a using declaration.

hokein reopened this revision. hokein added a comment. This revision is now accepted and ready to land. reopening it for the reland version. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123127/new/ https://reviews.llvm.org/D123127 ___

[PATCH] D123127: [AST] Add a new TemplateName for templates found via a using declaration.

hokein updated this revision to Diff 422310. hokein added a comment. reland version: there is no freebit in the TemplateName's PointerUnion to store 5 different pointer types in 32-bit build, instead we change the TemplateDecl to NamedDecl, which can be used to hold the TemplateDecl and UsingShado

  1   2   >