sammccall created this revision. sammccall added a reviewer: hokein. Herald added a subscriber: mgorny. Herald added a project: All. sammccall requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits.
This was probably not particularly intended to be public, and disallows deps on gtest which are useful in test helpers. https://discourse.llvm.org/t/stop-exporting-clangtesting-library/61672 Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D123610 Files: clang/lib/CMakeLists.txt clang/lib/Testing/CMakeLists.txt clang/unittests/AST/CMakeLists.txt clang/unittests/ASTMatchers/CMakeLists.txt clang/unittests/ASTMatchers/Dynamic/CMakeLists.txt clang/unittests/Analysis/CMakeLists.txt clang/unittests/Analysis/FlowSensitive/CMakeLists.txt clang/unittests/Sema/CMakeLists.txt clang/unittests/StaticAnalyzer/CMakeLists.txt clang/unittests/Tooling/Syntax/CMakeLists.txt
Index: clang/unittests/Tooling/Syntax/CMakeLists.txt =================================================================== --- clang/unittests/Tooling/Syntax/CMakeLists.txt +++ clang/unittests/Tooling/Syntax/CMakeLists.txt @@ -18,7 +18,6 @@ clangFrontend clangLex clangSerialization - clangTesting clangTooling clangToolingCore clangToolingSyntax @@ -26,5 +25,6 @@ target_link_libraries(SyntaxTests PRIVATE + clangTesting LLVMTestingSupport ) Index: clang/unittests/StaticAnalyzer/CMakeLists.txt =================================================================== --- clang/unittests/StaticAnalyzer/CMakeLists.txt +++ clang/unittests/StaticAnalyzer/CMakeLists.txt @@ -31,6 +31,10 @@ clangSerialization clangStaticAnalyzerCore clangStaticAnalyzerFrontend - clangTesting clangTooling ) + +target_link_libraries(StaticAnalysisTests + PRIVATE + clangTesting + ) Index: clang/unittests/Sema/CMakeLists.txt =================================================================== --- clang/unittests/Sema/CMakeLists.txt +++ clang/unittests/Sema/CMakeLists.txt @@ -18,11 +18,11 @@ clangParse clangSema clangSerialization - clangTesting clangTooling ) target_link_libraries(SemaTests PRIVATE + clangTesting LLVMTestingSupport ) Index: clang/unittests/Analysis/FlowSensitive/CMakeLists.txt =================================================================== --- clang/unittests/Analysis/FlowSensitive/CMakeLists.txt +++ clang/unittests/Analysis/FlowSensitive/CMakeLists.txt @@ -31,11 +31,11 @@ clangFrontend clangLex clangSerialization - clangTesting clangTooling ) target_link_libraries(ClangAnalysisFlowSensitiveTests PRIVATE + clangTesting LLVMTestingSupport ) Index: clang/unittests/Analysis/CMakeLists.txt =================================================================== --- clang/unittests/Analysis/CMakeLists.txt +++ clang/unittests/Analysis/CMakeLists.txt @@ -20,12 +20,12 @@ clangFrontend clangLex clangSerialization - clangTesting clangTooling ) target_link_libraries(ClangAnalysisTests PRIVATE + clangTesting LLVMTestingSupport ) Index: clang/unittests/ASTMatchers/Dynamic/CMakeLists.txt =================================================================== --- clang/unittests/ASTMatchers/Dynamic/CMakeLists.txt +++ clang/unittests/ASTMatchers/Dynamic/CMakeLists.txt @@ -17,6 +17,10 @@ clangDynamicASTMatchers clangFrontend clangSerialization - clangTesting clangTooling ) + +target_link_libraries(DynamicASTMatchersTests + PRIVATE + clangTesting + ) Index: clang/unittests/ASTMatchers/CMakeLists.txt =================================================================== --- clang/unittests/ASTMatchers/CMakeLists.txt +++ clang/unittests/ASTMatchers/CMakeLists.txt @@ -18,12 +18,12 @@ clangBasic clangFrontend clangSerialization - clangTesting clangTooling ) target_link_libraries(ASTMatchersTests PRIVATE + clangTesting LLVMTestingSupport ) Index: clang/unittests/AST/CMakeLists.txt =================================================================== --- clang/unittests/AST/CMakeLists.txt +++ clang/unittests/AST/CMakeLists.txt @@ -42,11 +42,11 @@ clangFrontend clangLex clangSerialization - clangTesting clangTooling ) target_link_libraries(ASTTests PRIVATE + clangTesting LLVMTestingSupport ) Index: clang/lib/Testing/CMakeLists.txt =================================================================== --- clang/lib/Testing/CMakeLists.txt +++ clang/lib/Testing/CMakeLists.txt @@ -2,6 +2,12 @@ Support ) -add_clang_library(clangTesting +# Not add_clang_library: this is not part of clang's public library interface. +# Unit tests should depend on this with target_link_libraries, not clang_TLL. +add_llvm_library(clangTesting CommandLineArgs.cpp + BUILDTREE_ONLY + + LINK_COMPONENTS + Support ) Index: clang/lib/CMakeLists.txt =================================================================== --- clang/lib/CMakeLists.txt +++ clang/lib/CMakeLists.txt @@ -25,5 +25,7 @@ add_subdirectory(IndexSerialization) add_subdirectory(StaticAnalyzer) add_subdirectory(Format) -add_subdirectory(Testing) +if(CLANG_INCLUDE_TESTS) + add_subdirectory(Testing) +endif() add_subdirectory(Interpreter)
_______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
