MaskRay added a comment.

In D123544#3446285 <https://reviews.llvm.org/D123544#3446285>, @lebedev.ri 
wrote:

> Does this not lead to non-deterministic/non-reproducible builds?
> I do not understand why this feature must be inflicted onto everyone.

It seems that the feature fixes the randomization seed in the option 
`-frandomize-layout-seed=`, so it is deterministic, but it currently has a 
possible Windows vs non-Windows host difference, probably related to MSVC's 
`std::mt19937`.
My concern is related to the lack of `-frandomize-layout-seed-file=` testing in 
the base patch.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D123544/new/

https://reviews.llvm.org/D123544

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to