paulwalker-arm added inline comments.
================
Comment at: clang/test/Sema/aarch64-acle-sve2-aes.c:1
+// RUN: %clang_cc1 -triple aarch64-none-linux-gnu -target-feature +sve2
-fallow-half-arguments-and-returns -fsyntax-only -std=c99 -verify
-verify-ignore-unexpected=error %s
+
----------------
Relying on the `implicit declaration...` warning is potentially problematic and
what triggered this work in the first place. Can you make the new Sema tests
c++ ones instead. Doing this means we can catch errors like `error: use of
undeclared identifier 'svaesd_u8'` instead of a c99 warning.
================
Comment at: clang/test/Sema/aarch64-acle-sve2-aes.c:5-9
+svuint8_t test_svaesd_u8(svuint8_t op1, svuint8_t op2)
+{
+ // expected-warning@+1 {{implicit declaration of function 'svaesd_u8'}}
+ return svaesd_u8(op1, op2);
+}
----------------
The original versions of these tests used the `SVE_ACLE_FUNC` macro so that the
overloaded builtin names are also protected. Can you do likewise for the new
tests?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D123605/new/
https://reviews.llvm.org/D123605
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
